Sagar Vora
|
40c7d27e4f
|
fix!: disallow setting link values not matching filters
|
2026-01-10 13:25:35 +05:30 |
|
barredterra
|
68b18d8a93
|
test: don't wait for cached request
|
2025-12-13 17:43:07 +01:00 |
|
Raffael Meyer
|
a9c4bac950
|
fix: speed up link field (#34689)
|
2025-12-01 19:31:27 +01:00 |
|
Sagar Vora
|
aab68012d0
|
perf: ignore link validation if no fetch and value in awesomplete list
|
2025-12-01 20:59:51 +05:30 |
|
sokumon
|
c8f499ab2f
|
fix: ui tests
|
2025-11-14 23:05:14 +05:30 |
|
sokumon
|
fa4e826411
|
chore: rename app to desk in ui tests
|
2025-11-14 23:05:13 +05:30 |
|
Ejaaz Khan
|
51f17a6726
|
Merge pull request #34395 from iamejaaz/fix-flacky-test
test: fix flaky test of setting default value
|
2025-10-14 16:56:40 +05:30 |
|
Ejaaz Khan
|
e1d522ad4e
|
test: fix flacky test of setting default value
|
2025-10-14 16:27:43 +05:30 |
|
Sagar Vora
|
5bb51a294f
|
test: use permitted user for link field test
|
2025-10-14 14:49:03 +05:30 |
|
Ankush Menat
|
266b510c88
|
test: skip HTTP caching in tests
|
2025-01-24 19:53:30 +05:30 |
|
Ankush Menat
|
6328421fde
|
fix: only cache if called directly
|
2025-01-24 19:08:04 +05:30 |
|
Raffael Meyer
|
bba05d869f
|
perf: reduce klicks for changing link value (#28988)
|
2025-01-03 20:06:23 +01:00 |
|
Ankush Menat
|
c1e8d8e791
|
test: flaky link field test (#26246)
|
2024-04-30 11:12:49 +00:00 |
|
Shariq Ansari
|
b2f8c11330
|
test: flaky control_link
|
2023-12-01 15:01:54 +05:30 |
|
Suraj Shetty
|
49d7f132da
|
test: Fix control link flaky test
|
2023-06-16 11:32:55 +05:30 |
|
Shariq Ansari
|
177ca618eb
|
test: fix flaky control_link UI test
|
2023-01-26 17:05:24 +05:30 |
|
Ankush Menat
|
a6b341bd59
|
test: fix tests using admin account
|
2022-09-10 12:48:33 +05:30 |
|
hrwx
|
42a3fe0fa2
|
chore: remove untranslated matching
|
2022-08-12 17:04:37 +01:00 |
|
Himanshu
|
c6e2ce3e42
|
Merge branch 'develop' into merge_translated_doctypes
|
2022-08-09 09:50:31 +01:00 |
|
Himanshu
|
1aa3f75d4c
|
feat: custom __link_options (#17699)
* feat: custom __link_optins
* chore: linter fixes
* test: add ui test for custom link option
|
2022-08-09 11:20:13 +05:30 |
|
hrwx
|
db2e898397
|
chore: linter fixes
|
2022-08-06 10:52:59 +01:00 |
|
hrwx
|
b01929405d
|
refactor: translatable doctypes
|
2022-08-05 21:38:10 +01:00 |
|
Ankush Menat
|
40f27f908a
|
style: format JS files with prettier
|
2022-08-04 14:51:01 +05:30 |
|
Himanshu
|
70409a3c7b
|
fix: set translated text to link field (#15451)
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324)
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.
Todo:
- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour
### Behaviour
- Link field loses focus: show the translated name.
- Link field is focused
- If old value is present
- If options **are** one of [Role, DocType]: show the translated name
- Else: show the name (untranslated) to enable search in untranslated values
- Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus
## Demo
### Link to UOM in a custom Item DocType
The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.
#### Before
https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov
#### After
https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov
### Link to DocType in Customize Form
The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.
#### Before
https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov
#### After
https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov
https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
|
2022-05-16 13:21:42 +00:00 |
|
Saqib Ansari
|
8a882cf09a
|
chore: add missing semicolon
|
2022-02-14 15:11:09 +05:30 |
|
Saqib Ansari
|
cd3a6261fb
|
chore: remove property setter after test
|
2022-02-12 13:42:44 +05:30 |
|
Saqib Ansari
|
bbbeb342df
|
fix: test for show title field in link fields
|
2022-02-09 13:05:35 +05:30 |
|
Suraj Shetty
|
68d934ae0f
|
Merge branch 'develop' into link_title_refactor
|
2022-02-04 14:53:26 +05:30 |
|
Suraj Shetty
|
ebd756c1e5
|
test: Update test case for default value in link field
|
2022-02-01 13:30:48 +05:30 |
|
Suraj Shetty
|
5f64dac3c1
|
test: Update UI test for link field
|
2022-01-31 15:23:08 +05:30 |
|
Saqib Ansari
|
74276ef69b
|
chore: undo changes to link ui test
|
2022-01-07 16:22:15 +05:30 |
|
Saqib Ansari
|
ab9700d947
|
Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor
|
2021-12-15 19:32:16 +05:30 |
|
Sagar Vora
|
0b0f896258
|
fix: cleaner implementation for link validation
|
2021-11-12 10:36:21 +05:30 |
|
Sagar Vora
|
1fd53c4306
|
test: intercept validate_link instead of get_value
|
2021-11-11 12:30:30 +05:30 |
|
Sagar Vora
|
7aa8059b57
|
test: add UI test to ensure fetch_from works
|
2021-10-21 19:11:17 +05:30 |
|
Sagar Vora
|
f2b319920c
|
refactor: improved design for fetching values using add_fetch
|
2021-10-21 19:00:30 +05:30 |
|
MitulDavid
|
93198b7123
|
test: Replace existing queries with Testing-Library queries
|
2021-08-18 19:11:01 +05:30 |
|
MitulDavid
|
b417218f1d
|
test: Add support for Testing-Library queries within Cypress tests
|
2021-08-17 19:06:01 +05:30 |
|
hrwx
|
d056beb0ef
|
feat: show title links in Link Fields
|
2021-08-03 15:55:32 +05:30 |
|
Suraj Shetty
|
1f96f3d83c
|
style: Fix indentation
|
2021-01-31 23:21:42 +05:30 |
|
Suraj Shetty
|
d18751db07
|
test: Make tests Cypress v6 compatible
|
2021-01-31 23:19:01 +05:30 |
|
Rushabh Mehta
|
b2686e0623
|
fix(routing): removed /space from routing
|
2021-01-01 12:30:35 +05:30 |
|
prssanna
|
841c1b9852
|
fix: cypress tests
|
2020-12-29 17:00:30 +05:30 |
|
Rushabh Mehta
|
54cee87826
|
fix(minor): tests + routing
|
2020-12-24 14:48:40 +05:30 |
|
Shivam Mishra
|
b97c0e24a1
|
test: rename workspace to space
|
2020-12-16 14:28:52 +05:30 |
|
Rushabh Mehta
|
06355968f8
|
fix(routes): move /app#route to /app/route
|
2020-11-11 16:35:02 +05:30 |
|
Rushabh Mehta
|
75fe8a615a
|
feat(app): move /desk to /app
|
2020-11-11 16:31:47 +05:30 |
|
Shivam Mishra
|
e33bcfa6bd
|
style: fix linting issue
|
2020-05-21 00:03:46 +05:30 |
|
Shivam Mishra
|
5d5cb26143
|
fix: add delay in typing
|
2020-05-20 23:28:40 +05:30 |
|
Shivam Mishra
|
7a1cb7fa00
|
refactor: don't login before each test
|
2020-05-20 23:28:26 +05:30 |
|