Commit graph

1308 commits

Author SHA1 Message Date
Faris Ansari
becef09e06 fix(xlsx): Fix for handle failed html parse 2019-04-11 14:53:48 +05:30
Faris Ansari
56f94700e2 fix: Get all ancestors
When a file is uploaded by Guest, the folder size needs to be updated,
which breaks because get_ancestors uses `get_list`
2019-04-10 15:58:10 +05:30
Faris Ansari
70246946b2 fix: Dont escape tracebacks in errprint 2019-03-28 15:05:23 +05:30
Suraj Shetty
73c1f531e8 fix: Set default only if the dependent field is set (#7130)
Client side fix
https://github.com/frappe/frappe/pull/7004
2019-03-28 11:46:51 +05:30
Shivam Mishra
efa8263d2b
Merge pull request #7102 from scmmishra/hotfix
fix: Proxied `validate_email_add`
2019-03-22 15:18:56 +05:30
scmmishra
349132f392 fix: Proxied validate_email_add 2019-03-22 15:00:16 +05:30
Himanshu Mishra
d0eb066fa4
Variable bleed in response 2019-03-21 16:49:35 +05:30
Saurabh
4ae92edfb9 fix: do not check password strength while creating system manager 2019-03-19 14:40:29 +05:30
FinByz Tech Pvt. Ltd
245a8186af fix: Allowed guest to attach files to web forms (#7017)
Created the fix for the issue [#6774](https://github.com/frappe/frappe/issues/6774), in which guest can attach files in web forms like job application.
2019-03-06 22:48:11 +05:30
Rushabh Mehta
9df07891ff fix(xmlx): handle unparseable HTML 2019-03-06 16:11:06 +05:30
Rohit Waghchaure
ae67ced14d fix: errprint not working 2019-02-28 20:23:06 +05:30
Aditya Hase
4b4d59026f fix: Jinja template error (#6957)
Errors in Custom Print Format are not framework errors and should not have a "Report Issue" button
2019-02-19 14:19:51 +05:30
Rushabh Mehta
e850721d05
Merge pull request #6843 from Zlash65/enh-treeview
feat: Minor additional enhancements to Treeview
2019-02-15 14:30:38 +05:30
Aditya Hase
683be9e096 feat(error-report): Collect frame locals in error report (#6938)
* feat(error-report): Collect frame locals in error report

* style: Linting fixes
2019-02-15 14:24:08 +05:30
Saif
1bb4c6275f fix: Don't send attachment/download header with PDF files (#6881) 2019-02-06 12:48:41 +05:30
Chinmay Pai
6377bdf6db fix(data_import): use absolute url (#6875)
there is no need to prepend the sitename to the url, since browsers/html are/is smart enough to handle absolute urls.

Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
2019-02-05 10:53:31 +05:30
Saurabh
96bff3cd9e fix: jinja local.conf data leak (#6884) 2019-02-05 10:52:00 +05:30
Zlash65
1d8f35ce97 fix: use orm instead of query 2019-02-01 15:53:01 +05:30
Zlash65
04b3a5cabc feat: added a utility method to get all the descendants of a node 2019-02-01 12:14:45 +05:30
Zlash65
a7e127e498 fix: get ancestors for a node with more filters 2019-02-01 12:14:45 +05:30
Chinmay Pai
9873c04231 fix(sync_global_search): decode json object as str (#6867) 2019-01-31 15:16:47 +05:30
Aditya Hase
57196a8bbe fix(website): Enable socketio on website (for file upload) (#6866) 2019-01-31 13:54:42 +05:30
Rushabh Mehta
0704928fd8 fix(global search): fallback if redis is not yet started 2019-01-30 11:26:07 +05:30
Rushabh Mehta
d09792c606 fix: refactor global search to not insert after every commit (#6845)
* fix: refactor global search to not insert after every commit

* feat: configuration to disable_global_search
2019-01-30 11:13:51 +05:30
Sagar Vora
fe3fe0a4b8 Merge branch 'master' into staging-fixes 2019-01-29 17:08:58 +05:30
Shivam Mishra
dad1c04aae feat: Deprecate In App Help (#6801)
* [feat] Removed help from toolbar.js

* [feat] Removed help from global search

* [feat] redirected search in help to docs website

[] Url needs to be configurable from hooks

* [Feat] Removed search functions for help

* [fix] Help links not redirecting

* [feat] Modified "Help" menu on desk toolbar

* [feat] Removed docs search from desk toolbar

* Removed Search from toolbar.js

* Removed /search_docs from website

* Removed help from migrate

* Deprecated help from command utils

* Removed help.py

* Removed help setup from travis.yml

* [fix] Fixed formatting issues

* [fix] Deleted commented code from toolbar.js

* [fix] Minor link fix

* [Fix] Fixed a small typo

* Removed docs_app dependency from pathces

* [fix] Removed commented code

* [fix] Typo in function name

* fix: remove commented code

* [fix] Changed 'Deprecated' message to 'Removed'

Removed will be the correct term instead of deprecated
2019-01-29 14:59:39 +05:30
Suraj Shetty
5af8d4d1bb
Merge pull request #6824 from netchampfaris/feat-is-set-is-not-set
feat: New filter type "Is Set", "Is Not Set"
2019-01-29 07:27:57 +05:30
Aditya Hase
36bc812c94 fix(security): Make server-side PDF rendering tighter 2019-01-28 12:41:21 +05:30
Aditya Hase
837bfc0995 fix(unicode): Import unicode_literals in every file (#6805)
* fix(unicode): Import unicode_literals in every file

* fix(unicode): Test if safe_json_loads return unicode instead of bytes
2019-01-25 11:56:27 +05:30
Faris Ansari
5ffdeb19fc feat: New filter type "Is Set", "Is Not Set" 2019-01-24 14:26:27 +05:30
Zarrar
8bdb0dc5f8 feat: Download json file (#6793)
* feat: download file as json type

* fix: make raw type files downloadable
2019-01-23 16:51:02 +05:30
Aditya Hase
6b72faf44f style: Linting fixes (#6809)
* style: Remove unused imports

* style: Remove unused local variables
2019-01-23 16:39:55 +05:30
Faris Ansari
987a604749 fix: Use ImportError instead of ModuleNotFoundError (#6797)
- ModuleNotFoundError is available in python 3.6
2019-01-21 17:57:38 +05:30
Saurabh
2fbf59522e Merge branch 'master' into staging-fixes 2019-01-15 19:05:42 +05:30
Nabin Hait
1d686e470b
fix(comp_dashboard): Company dashboard if goal is zero. (#6719) 2019-01-08 14:16:04 +05:30
Nabin Hait
5590193c8d fix(version): getting version update (#6717)
* fix(version): getting version update

* fix(version): getting version update
2019-01-07 08:57:04 +05:30
Faris Ansari
ae57e75b0e fix(is_html): Return false if text is not string 2018-12-30 22:43:21 +05:30
rohitwaghchaure
22fe10148a [Fix] Translation not working for the html data (#6647)
* [Fix] Translation not working for the html data

* Test cases

* Fixed codacy

* Fixed is html method

* Fixed test cases
2018-12-24 15:17:38 +05:30
Zarrar
863c54b0fa [Fix] Json data for Report Builder based reports (#6624)
* replace doctype name if already present

* patch to update json data for report builder based reports

* minor fix for auto email
2018-12-18 08:56:10 +05:30
Prateeksha Singh
31c9e5a078 [setup] check skip_setup_wizard from common_site_comfig 2018-12-11 16:10:02 +05:30
Prateeksha Singh
1f1e70d335 [fix] Better multiple root node message 2018-12-11 16:10:02 +05:30
Prateeksha Singh
0ccb159c6f Add make_records() 2018-12-11 16:10:02 +05:30
Saurabh
5dceb7fb42 provision to setup password while adding system manager 2018-12-11 16:10:02 +05:30
Rushabh Mehta
dad0b84847
fix(patch): check if table exists for old prepared reports (#6605)
* debug(test): test_scheduler_events

* fix(patch): check if table exists for old prepared reports

* debug(tests): add comments for debug
2018-12-11 11:08:50 +05:30
Aditya Hase
fc48597694 fix(prepared-report): Python 2 compatibility fix
gzip.compress and gzip.decompress were introduced in Python 3.2

Added gzip_compress and gzip_decompress to frappe.utils to add this functionality
to both Python 2 and 3
2018-12-06 16:01:41 +05:30
Ameya Shenoy
79bd1ed9d6 fix: identify production mode for PDF generation (#6559)
In regards to PDF generation, if developer_mode was set to true, the PDF
generated used to lack css styling. This was because the URL to the CSS
assets used to contain the webserver port number, but given the system
was running in production, the URL was invalid, thereby not being able
to load CSS assets. This fix does not rely on the value of
developer_mode to identify if the system is running in production,
rather, it uses the value of restart_superviosor or systemd_on_update,
to check for the same.
2018-11-29 10:31:53 +05:30
Ameya Shenoy
3669203acf fix(get_version): from hooks.py instaed of git (#6534) 2018-11-26 12:16:12 +01:00
Ameya Shenoy
d1d0edc636
Merge branch 'master' into staging-fixes 2018-11-23 08:07:36 +00:00
Juan Carlos Espinoza Zurita
7319853d58 [MINOR FEATURE] Export file to TXT #6737 (#6489) 2018-11-21 18:17:34 +05:30
Aditya Hase
fc085a2b39 fix(redis-wrapper): Do not assume existence of superclass of redis.Redis
RedisWrapper inherits from Redis which inherits from StrictRedis

In redis-py 3.0.0 StrictRedis was renamed to Redis.

This seems like a harmless change, but, instead of using
`self(RedisWrapper ...`, all methods use `self(Redis ...`
which assumes previous hierarchy (i.e. RedisWrapper <- Redis <- StrictRedis)
2018-11-15 20:06:03 +05:30