Commit graph

2842 commits

Author SHA1 Message Date
Ankush Menat
7a3faf23e1
Merge pull request #18664 from barredterra/csv-params
feat: configurable CSV delimiter and quoting
2022-11-29 13:27:24 +05:30
HarryPaulo
f25358ad63
fix: "_dict" is an invalid attribute name because it starts with "_" (#19010)
* fix: "_dict" is an invalid attribute name because it starts with "_"

* chore: move to frappe namespace
2022-11-29 11:43:23 +05:30
Raffael Meyer
83e2f524e2
Merge branch 'develop' into csv-params 2022-11-26 20:10:51 +01:00
barredterra
433b285b92 refactor: use provide_binary_file 2022-11-26 20:08:50 +01:00
Ankush Menat
d00b98f460 chore: typo 2022-11-25 13:10:43 +05:30
Ankush Menat
ed28626021 refactor: simpler deque strat selection
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-11-25 12:14:37 +05:30
Ankush Menat
a8bf86ef75 feat: support dequeuing strategies for worker 2022-11-25 12:14:37 +05:30
Ankush Menat
aece93fbc5 feat: burst mode in workers
https://python-rq.org/docs/workers/#burst-mode
2022-11-25 12:14:33 +05:30
Ankush Menat
0ebd3945ff refactor: consider multi-queue consumption 2022-11-25 12:03:34 +05:30
Ankush Menat
40b2929c0d feat(workers): allow consuming multiple queues 2022-11-25 12:03:34 +05:30
Ankush Menat
b7cef3ae71 fix: prioritize short queue when using all queues 2022-11-25 12:03:34 +05:30
Raffael Meyer
920606f10e
fix: handle "No Letterhead" in new print format builder (#18990)
[skip ci]
2022-11-24 10:54:46 +05:30
Faris Ansari
5695346668
fix: allow mark tag in texteditor (#18871) 2022-11-14 17:33:28 +05:30
Ritwik Puri
518b7e1c66
Merge pull request #18251 from Aradhya-Tripathi/bg-submissions
feat: Background submissions for submittable doctypes
2022-11-12 20:06:57 +05:30
Ankush Menat
6c01d1d417 refactor: hmac generation
Reduce code duplication
2022-11-12 13:05:57 +05:30
Aradhya Tripathi
07bd958dfd
Merge branch 'develop' into bg-submissions 2022-11-12 08:37:55 +05:30
Ankush Menat
ba27434d81
refactor: Use safer hashing algorithm for verified_command (#18848) 2022-11-11 21:42:51 +05:30
Ankush Menat
668a730788 fix: avoid patching QB if already patched 2022-11-11 16:38:05 +05:30
Anand Baburajan
bc0abd9cfd
feat(util): add is_last_day_of_the_month (#18835)
* feat: add is_last_day_of_the_month
2022-11-10 15:18:49 +05:30
Ankush Menat
f34f7030a3 refactor: remove txt param from generate_hash use 2022-11-10 11:56:48 +05:30
Ankush Menat
66f5f4dd46 refactor(db): deprecated unused functions 2022-11-09 16:10:09 +05:30
Ankush Menat
ce360b6fce feat: Set default SQL statement timeouts 2022-11-08 14:51:43 +05:30
Daizy Modi
62c4a3c020
fix: check permission before print or download document (#18757) 2022-11-06 19:59:59 +05:30
Ankush Menat
44a5bdc3f1
fix: ignore internal methods (#18784) 2022-11-06 19:18:30 +05:30
Ankush Menat
e02b90cd5b
fix: dont allow reading attributes of unsafe objects (#18706) 2022-11-06 17:33:02 +05:30
Aradhya
f587140f6f Merge branch 'develop' of https://github.com/Aradhya-Tripathi/frappe into bg-submissions 2022-11-04 18:34:41 +05:30
Ankush Menat
0ed7600604
build: py3.11 support (#18550)
* chore: bump RestrictedPython

* ci: use py3.11 on development version

* fix: py311 compat changes

* chore: bump to final versions
2022-11-03 20:49:05 +05:30
Ankush Menat
56640a0723 fix: support symlinked and /files directory
Easiest way to move site/files or site/private directories is to symlink
them, the validation for file path was failing because it resolves only
until site path.

Resolving real path doesn't seem to be _REALLY_ required here.
2022-11-01 13:25:21 +05:30
Ankush Menat
f0ab6cb488
Revert "fix: use is_file_path_valid instead of is_safe_path (#18316)" (#18688)
This reverts commit d35aa6c545.
2022-11-01 12:40:54 +05:30
Sagar Vora
d35aa6c545
fix: use is_file_path_valid instead of is_safe_path (#18316)
* fix: use `validate_file_path` instead of `is_safe_path`

* test: specify `is_private` for file with private URL
2022-10-28 13:56:24 +05:30
Ankush Menat
1c613179bb
fix: correct stacklevel for warnings (#18633)
Stacklevel=2 just points to frame that called warning and not frame
where it originated. This frame is useless in most cases as you can just
`grep` for it instead of looking at log.

stacklevel=3 gives frame which is calling the code with warnings.

[skip ci]
2022-10-28 12:22:24 +05:30
Aradhya
7cefc240ac fix: merge conflicts 2022-10-21 14:22:51 +05:30
Daizy Modi
fce9ccedaa
fix: only execute generator if value is not found in redis cache (#18472)
* fix: use of generator in

* fix: improve docstring

* fix: improve docstring

* fix: directly assign value to flags

Co-authored-by: Daizy <DaizyModi>
2022-10-20 16:48:03 +05:30
Faris Ansari
4f650854b8
fix(dx): resolve_class (#18417)
* fix(resolve_class): ignore False values

* fix: allow multiple arguments

* fix: remove unnecessary condition

* test: resolve_class
2022-10-15 17:40:22 +05:30
Aradhya
3852eaea74 feat: Added on_success and on_failure to enqueue 2022-10-15 14:41:08 +05:30
Ankush Menat
eebf7e1fff
chore: dead code removal (#18410)
* chore!: Drop dead code related to configs/moduelview

* chore!: Drop dead boilerplate

* chore: drop desktop.py boilerplate

* chore!: Remove report dump
2022-10-13 15:55:40 +05:30
Ankush Menat
45645c3f73 feat: consistent, translatable timeline messages (#17526)
reapply accidentally reverted commit

[skip ci]
2022-10-12 22:27:04 +05:30
Ankush Menat
ab3f706948 Revert "feat: consistent, translatable timeline messages (#17526)"
This reverts commit 112c492f3e.
2022-10-12 18:03:57 +05:30
Ankush Menat
c3b547f897
refactor!: scheduler without external libraries (#18331) 2022-10-10 13:09:34 +05:30
Raffael Meyer
112c492f3e
feat: consistent, translatable timeline messages (#17526)
* feat: consistent, translatable timeline messages

* fix: save only filename for attachment comments

The rest of the comment will be added and translated ad-hoc by form_timeline.js

* patch: clean up Comments of type "Attachment"

* feat: further message types

* style: format with prettier

* test: cypress timeline

Timeline now correctly displays "You ..." instead of "{User} ..."

* feat: german transations for timeline comments

* fix: enable auto_commit_on_many_writes

* fix: don't update modified timestamp in patch
2022-10-06 16:05:34 +05:30
mergify[bot]
939d926b91
feat: Added Subscription Banner for remotely logging into FrappeCloud dashboard from site (backport #18263) (#18281)
* feat: Added Subscription Banner for remotely logging into FrappeCloud dashboard from site (#18263)

* feat: added Subscription Banner and Manage Subscription button

* feat[patch]: added a patch for adding `Manage Subscription` button in
navbar_settings

* chore: removed console ;)

* refactor: make the `Manage Subscription` navbar item optional

* keep it hidden by default, only show when the site configs are present

* style: prettier, isort and stuff

* chore: handling null responses, translation and refactored patch

* fix: correct index reset

* perf: reduce network/db calls

If not sys manager then why make a request?

* fix: removed network call and added subscription_expiry to boot process

* chore: added enable_manage_susbcriptions as daily background job and refactored patch

* chore: added hook to hooks.py

* this looks clean enough, also don't have insert for child tables ;)

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 68f315d372cc8c6e41f2aabda61eba0d42dcf6e4)

# Conflicts:
#	frappe/patches.txt

* chore: conflicts

* style: format

[skip ci]

Co-authored-by: Rutwik Hiwalkar <50401596+rutwikhdev@users.noreply.github.com>
2022-10-03 16:41:12 +05:30
Ankush Menat
35ba00a54e
fix: handle isatty correctly (#18277)
sys.stdin can be `None`

[skip ci]
2022-10-03 12:05:55 +05:30
Ankush Menat
abeed35461
fix: throw exception if backup failed (#18230) 2022-09-28 14:29:38 +05:30
Ankush Menat
0642708f01
perf: use modified instead of creation in scheduler (#18234)
creation doesn't have index and does full table scan. On large site with
~3M activity logs it takes ~1.5 seconds just to begin scheduler.


[skip ci]
2022-09-27 19:21:02 +05:30
Ankush Menat
07662ebaf3
fix: only allow verified_command on GET requests (#18235) 2022-09-27 18:17:58 +05:30
Ankush Menat
c76277f1bf fix: correctly order args and kwargs 2022-09-26 11:26:03 +05:30
Ankush Menat
9c84d078fa fix: remove mariadb specific comments from column
MariaDB has additional syntax for comments which are like python.
2022-09-26 11:09:39 +05:30
Shariq Ansari
5cfcc4a075
fix: Chart date format on x-axis is inaccurate (#18191) 2022-09-21 16:20:44 +05:30
Athul Cyriac Ajay
31a37ed671
chore: Add make_put_requests method for Server Scripts (#18128) 2022-09-14 15:54:15 +05:30
Ritwik Puri
7f4974e923
Merge branch 'develop' into sync-dashboard 2022-09-12 16:19:19 +05:30