Commit graph

71 commits

Author SHA1 Message Date
David Arnold
83bc1f09e9
refactor: clarify test record dep management in test modules (#28060) 2024-10-09 13:44:27 +00:00
David Arnold
c114e5fae8
refactor: unit vs integration treewide (#27992)
* refactor: constitute unit test case

* fix: docs and type hints

* refactor: mark presumed integration test cases explicitly

At time of writing, we now have at least two base test classes:

- frappe.tests.UnitTestCase
- frappe.tests.IntegrationTestCase

They load in their perspective priority queue during execution.

Probably more to come for more efficient queing and scheduling.

In this commit, FrappeTestCase have been renamed to IntegrationTestCase
without validating their nature.

* feat: Move test-related functions from test_runner.py to tests/utils.py

* refactor: add bare UnitTestCase to all doctype tests

This should teach LLMs in their next pass that the distinction matters
and that this is widely used framework practice
2024-10-06 09:43:36 +00:00
Ankush Menat
3f707f1ae1 test: add test for custom docperm behaviour 2024-04-18 15:44:04 +05:30
Ankush Menat
a1bb734079 fix: filter select perm in get_doctypes_with_read
closes https://github.com/frappe/frappe/issues/26015

Extracted from https://github.com/frappe/frappe/pull/26018
2024-04-18 15:15:47 +05:30
Ankush Menat
99952880cc fix!: Don't let users with write access to UP bypass UP
IDK why we truly need this, except maybe debugging sometimes. This just
causes confusion and people keep reporting this as security issue.
2024-04-05 18:55:27 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Ankush Menat
0381f836d6 fix: update correct role permission rule
Right now if you have if-owner rule on doctype then whatever you change
will only apply to last inserted rule because we don't check if-owner
value

Long term better fix: Identify with perm rule name instead of arbitrary
"primary keys" defined in code.
2023-09-18 13:45:20 +05:30
Ankush Menat
1b406edd54 feat: Desk User role 2023-08-28 22:31:23 +05:30
Gavin D'souza
340617c1e1 test: Add check to make sure select & search fields intersect 2023-04-22 15:07:14 +05:30
Gavin D'souza
c0537c74da test: Add check for permitted fields 2023-04-22 13:28:17 +05:30
Sagar Vora
481ff1b2af test: add testcases for parentfield validations 2022-12-04 20:06:26 +00:00
Sagar Vora
a9b69351e6 test: use different user 2022-08-02 05:02:48 +05:30
Sagar Vora
b66f1d44e3 test: add tests for frappe.get_doc 2022-08-02 04:46:41 +05:30
Sagar Vora
56717602b4 fix: reverse logic for failing permission check 2022-08-02 04:09:01 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
barredterra
cdc850f12e test: user permissions affecting User 2022-06-10 16:30:20 +02:00
Ankush Menat
6ac1d95584 test: fix badly written tests 2022-04-22 19:47:54 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Ankush Menat
588fbe24ef feat: testing utilities 2022-02-28 16:20:51 +05:30
ChillarAnand
89b0181a8a test: Fix flaky permission test 2022-02-25 19:08:22 +05:30
Gavin D'souza
ecb0cd4139 test: Add test for disallowing setting tandard fields
Via db008020f6
2021-12-30 10:37:12 +05:30
Gavin D'souza
272cea4940 test: Add test for owner, creation constants 2021-12-30 10:33:08 +05:30
Suraj Shetty
4e6ea8fdbd fix: Docstring of has_permission & made error title translatable
- doctype -> DocType
- fixed other typo
2021-10-28 15:25:45 +05:30
Suraj Shetty
26dfdf5c11 test: Update tests 2021-10-28 11:18:36 +05:30
Suraj Shetty
3b92971a8e test: Update test case 2021-10-27 13:53:08 +05:30
Suraj Shetty
68cf640545 test: Test child table permission 2021-10-27 13:00:16 +05:30
Sagar Vora
5c86dc80c7
fix: if_owner constraint being applied wrongly (#14471)
* fix: `if_owner` constraint being applied wrongly

* test: check if owner on `frappe.get_list`

Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com>
2021-10-19 15:03:17 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
c00a5003f4 refactor(tests): frappe.db.delete > frappe.db.sql
Use frappe.db.delete wherever possible. Get rid of all the frappe.db.sql
;)

This commit focuses on the frappe.tests module
2021-08-19 19:48:42 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Deepesh Garg
a7c8b93430 fix: Delete doc afer use 2021-04-12 22:05:09 +05:30
Deepesh Garg
14c67cb244 fix: Test to check if_owner perm on delete 2021-04-12 19:48:47 +05:30
Deepesh Garg
d3c363a8f4 fix: Do not delete blog post 2021-04-11 12:42:37 +05:30
Deepesh Garg
dce4f62ff3 fix: Do not reset blog post perm 2021-04-11 10:27:44 +05:30
Deepesh Garg
a4c973a549 fix: Update users for test 2021-04-11 10:26:07 +05:30
Deepesh Garg
7b929fa72c fix: Update blog category 2021-04-10 23:05:08 +05:30
Deepesh Garg
cb27653da1 fix: Test case for if_owner perm with getdoc 2021-04-10 22:34:12 +05:30
Saurabh
97b693c6b0
feat: Added permission to grant only Select access to document (#12063)
* feat: add permtype 'select' to DocPerm and CustomDocPerm

* feat: add 'select' perm in rights tupple

* feat: provisions to handle select permission

* feat: toggle href based on permissions

* feat: pass permission type explicitly while validating link in permission check

* fix: sider

* feat: added test cases to validate select perm

* feat: add method frappe.only_has_select_perm to explicitly check the select perm

* fix: if user only has select perm then do not show anchor tag for link fields

* fix: sider
2020-12-29 16:58:28 +05:30
Shivam Mishra
faffec0f37 feat: update name in test records 2020-08-26 11:38:29 +05:30
Shivam Mishra
dabdab5c9f fix: test_set_only_once_child_table_row_value test 2020-04-30 16:24:41 +05:30
Suraj Shetty
699e6f8d4c test: Delete contact phone and and contact email while deleting contact 2020-03-23 13:33:21 +05:30
Mangesh-Khairnar
c81fa6db3c test: validate no fetch for multiple non default user permission 2019-04-24 13:19:04 +05:30
Mangesh-Khairnar
fe007f426d fix: default user permission to handle small int values 2019-04-17 19:06:38 +05:30
Mangesh-Khairnar
ff98540857 test: validate default value fetch in multiple user permission case 2019-04-16 23:37:52 +05:30
Sagar Vora
17b20b22a3 Merge branch 'master' into develop 2019-02-12 16:31:54 +05:30
Suraj Shetty
73c67481de
test: Change total post length 2019-02-06 16:27:46 +05:30
Nabin Hait
a7a4679a09 fix: tests for user permissions 2019-02-05 18:41:19 +05:30
Nabin Hait
ff1d430af6 fix: Set field default based on user permissions 2019-02-04 13:51:38 +05:30
Sagar Vora
ef82f39f99 Merge branch 'staging' into develop 2019-01-29 18:24:11 +05:30
Aditya Hase
6b72faf44f style: Linting fixes (#6809)
* style: Remove unused imports

* style: Remove unused local variables
2019-01-23 16:39:55 +05:30