Commit graph

106 commits

Author SHA1 Message Date
Nabin Hait
76db5e11c8 feat: Section Break without border 2020-05-15 10:11:58 +05:30
Suraj Shetty
ed105eb001 fix: Clear db_tables cache whenever a table is created or dropped 2020-04-30 14:16:29 +05:30
Chinmay D. Pai
2f821f9c2d
chore: fix deepsource issues
* use set comprehension instead of generator
* remove redundant else statement

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-04-29 21:58:00 +05:30
Suraj Shetty
a73be732fd
refactor: Fix redundant cache value set 2020-04-29 16:43:01 +05:30
Suraj Shetty
bf3a80f05d fix: Directly used set comprehension
As indicated by deepsource
2020-04-29 14:39:14 +05:30
Suraj Shetty
651109bb00 fix: Translatable string 2020-04-29 14:07:51 +05:30
Suraj Shetty
031aad0d85 perf: Cache get_tables values
- To avoid redundant db calls
2020-04-29 12:28:08 +05:30
Himanshu Warekar
595979eb1f Merge branch 'develop' of https://github.com/frappe/frappe into custom_append_to 2020-03-27 11:16:41 +05:30
Suraj Shetty
1599fc0751 fix: Get latest meta while building table 2020-03-25 12:48:21 +05:30
Suraj Shetty
8f8e361766 style: Fix formatting issues 2020-03-21 17:45:39 +05:30
Suraj Shetty
c21e33b001 fix(postgres): Ignore type casting in default value
- return 'Daily' instead of "'Daily'::character varying"
2020-03-21 16:55:04 +05:30
Suraj Shetty
d495e9c3d4 fix: Use .get to fetch attribute value 2020-03-21 13:03:02 +05:30
Suraj Shetty
af7e040d1a refactor: Get doc fields directly from meta 2020-03-21 12:30:03 +05:30
prssanna
6ed6ab2907 fix: update db type map 2020-03-21 11:38:41 +05:30
prssanna
61270ba210 feat: change fieldtype in db with customize form 2020-03-21 11:38:41 +05:30
Suraj Shetty
8c9d55edca
Revert "feat: change fieldtype in db with customize form" 2020-03-19 13:25:54 +05:30
Dinuka Salwathura
e3dfb148e3
Change mysql host from localhost to 127.0.0.1
Having localhost makes mandatory to connect via mysqld.sock
changing host to 127.0.0.1 makes it to connect via tcp
2020-03-16 19:32:24 +05:30
Himanshu Warekar
bf555f8004 Merge branch 'develop' of https://github.com/frappe/frappe into custom_append_to 2020-03-13 19:37:21 +05:30
prssanna
7bb014ee9a fix: update db type map 2020-03-13 15:17:11 +05:30
prssanna
c5c9ae46e6 feat: change fieldtype in db with customize form 2020-03-13 15:17:11 +05:30
Chinmay D. Pai
ca7fc2c17d
chore: delete user on the unix socket as well
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-03-11 18:23:20 +05:30
Chinmay D. Pai
004ddacbf1
fix: do not set db_host to % and instead pass to setup_db
db_host != the hostname part after @, hmm. so instead we'll pass
no-mariadb-socket flag to setup_database where we'll drop and create
users with host set to the TCP/IP socket instead of the UNIX socket.

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-03-06 13:02:26 +05:30
Suraj Shetty
51bae0df50 fix(translations): Incorrect syntax 2020-01-29 15:35:28 +05:30
Himanshu Warekar
230073ebf2 fix: change to quotes in postgres.sql file 2020-01-19 14:54:18 +05:30
Himanshu Warekar
d9c490fa29 Merge branch 'develop' of https://github.com/frappe/frappe into custom_append_to 2020-01-06 11:16:10 +05:30
Mohammed Safwat Abu Kwaik
4ac83a0cc8 fix: allow setting custom database schema in site_config (#9182)
* Update database.py

* Update frappe/database/postgres/database.py

Co-Authored-By: Chinmay Pai <chinmaydpai@gmail.com>

Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>
2020-01-02 22:20:04 +05:30
Himanshu Warekar
9543b7d4af fix: remove status field 2019-12-27 14:48:46 +05:30
deepeshgarg007
33ec59ad53 Merge barnch develop into mandatory-depends-on 2019-12-12 20:58:27 +05:30
Himanshu Warekar
02e8e3380c Merge branch 'develop' of https://github.com/frappe/frappe into custom_append_to 2019-12-12 19:23:53 +05:30
Oshosanya Michael
8a11fb57cd feat: Allow full database config on creating site (#8874)
* Allow setting db port on install

* Allow setting db port on install

* Allow full db config on creating site

* bug fix

* bug fix

* Escape character

* Update frappe/commands/site.py

allow only integer argument

Co-Authored-By: Chinmay Pai <chinmaydpai@gmail.com>

* Update frappe/database/db_manager.py

No need to escape integer variable

Co-Authored-By: Chinmay Pai <chinmaydpai@gmail.com>

* cast port to integer to surpress pymysql error

* cast port to string to surpress pymysql error

* Removed type casting
2019-12-12 13:17:07 +05:30
Himanshu Warekar
8c9918bc96 feat: allow document creation via email 2019-12-12 12:46:21 +05:30
prssanna
1026800ee0 feat: add mandatory_depends_on and read_only_depends_on to docfield 2019-12-04 21:34:49 +05:30
Faris Ansari
488c68df96
Merge branch 'develop' into refactor-scheduler 2019-12-02 13:16:45 +05:30
Faris Ansari
2dac4f8432
fix(db.sql): Print query in debug mode (#8767) 2019-11-07 17:12:11 +05:30
Rushabh Mehta
fea34e3f6b fix(tests): test_scheduler 2019-11-07 12:14:09 +05:30
Rushabh Mehta
c583be6f33 fix(scheduler): implement queue peeking 2019-11-07 12:14:09 +05:30
Rushabh Mehta
0035772f8f fix(tests) 2019-11-07 12:14:09 +05:30
Rushabh Mehta
3e4e6d4b3f feat(doctype link): add links to doctype for link dashboard 2019-11-07 12:14:09 +05:30
Rushabh Mehta
34b4b069ba feat(scheduler): log scheduler events 2019-11-07 12:14:09 +05:30
Himanshu
bf57a1d79a Patch(Tags): Check if column exists (#8682)
* fix: tags patch

* fix: auto_commit_on_many_writes

* fix: check if tag exists

* fix: check if tag or tag link exists

* fix: check if column exists

* fix: set autocommit false

* fix: use ignore in insert query for bulk insert

* fix: add option to ignore duplicates
2019-10-29 09:52:38 +00:00
Suraj Shetty
86263e05f4 perf: Cache db columns to avoid redundant database calls (#8543)
* perf: Cache db columns to avoid redundant database calls

* fix: Move cache clearing code from doctype to schema.py

* fix: self.table_name instead of self.name

* fix: Cache columns in  "table_columns" key

`table_columns` was cached in meta but columns were also getting accessed
directly using frappe.db.get_table_columns. Now, it is cached at
`frappe.db` layer

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2019-10-07 13:39:40 +00:00
Faris Ansari
f926a2aa48
Merge pull request #8488 from hrwX/global_tags
feat(Desk): Global Tags
2019-10-07 19:05:28 +05:30
John Clarke
118bba4a83
report the name of the DocType when the associated table is missing
Reported here https://discuss.erpnext.com/t/bench-migrate-fails-with-pymysql-err-programmingerror-it-doesnt-print-what-is-the-error/53540
2019-10-06 10:34:19 -06:00
Himanshu Warekar
02cebdd7d3 fix: use frappe.tags 2019-10-03 16:43:36 +05:30
Himanshu Warekar
b7196f124c feat: use tag link for global tags 2019-09-24 23:25:04 +05:30
Himanshu Warekar
f6d1ce2194 feat: Global Tags 2019-09-24 01:03:11 +05:30
Suraj Shetty
7fe35a2d3c
fix: set default value in set_value as None to avoid error.
```
frappe.db.set_value('Call Log', log.name, {
			fieldname: doc.name,
			display_name_field: doc.get_title()
		}, update_modified=False)
```
this code should not fail if value is not pass because value is passed in the dict.
2019-09-23 15:54:46 +05:30
Faris Ansari
c8a80a2e4d fix: frappe.db.field_exists
- field_exists didn't work correctly
- The call to field_exists itself was wrong
2019-09-19 15:41:17 +05:30
Sahil Khan
a5480c8dfc feat(custom_field): update db on updating custom field 2019-09-12 18:37:13 +05:30
Himanshu Warekar
e955361610 fix: if not db host then localhost 2019-09-11 12:15:04 +05:30