Commit graph

44385 commits

Author SHA1 Message Date
KerollesFathy
615b2c5e8d fix(EmailQueue): ensure communication exists before updating delivery status 2026-04-26 12:11:25 +00:00
Ejaaz Khan
9a22cabd95
Merge pull request #38905 from iamejaaz/small-ui-ux-fix
fix(QueryReport): change toggle cursor to pointer
2026-04-26 10:33:43 +05:30
Ejaaz Khan
007328ae89 fix(QueryReport): change toggle cursor to pointer 2026-04-26 10:10:31 +05:30
Ejaaz Khan
614da3ee77
Merge pull request #38904 from iamejaaz/small-ui-ux-fix
fix(datatable): left border visibility
2026-04-26 10:09:22 +05:30
Ejaaz Khan
7c77b1c6b1 fix(datatable): left border visibility 2026-04-26 10:03:06 +05:30
Ejaaz Khan
dcdc2eeae9
Merge pull request #38899 from iamejaaz/create-new-shortcut
feat: add crtl+b to create new doc
2026-04-26 08:31:21 +05:30
Ejaaz Khan
0905493518
Merge pull request #37852 from KerollesFathy/fix-copy-doc-title
fix(form_sidebar): copy document title
2026-04-26 00:09:36 +05:30
Ejaaz Khan
5d19b1998f feat: add crtl+b to create new doc 2026-04-25 23:57:01 +05:30
Ejaaz Khan
5b4ddb2236
Merge pull request #38896 from iamejaaz/small-ui-ux-fix
fix(sidebar): notification panel and icon hover state
2026-04-25 16:27:45 +05:30
Ejaaz Khan
6216cda60e fix(sidebar): hover state of shortcut items 2026-04-25 14:48:28 +05:30
Ejaaz Khan
02e764cd4c fix: notification panel issue on close sidebar 2026-04-25 14:47:36 +05:30
Aarol D'Souza
590b47c596
Merge pull request #38892 from AarDG10/fix/db-query-self-ref-alias
fix(db_query): unique alias on self-referential Link joins
2026-04-25 13:02:25 +05:30
Shrihari Mahabal
2e0a8f19f1
Merge pull request #38891 from ShrihariMahabal/skip-http-validation-for-bg-tasks
fix: skip http validation for servers scripts in background tasks
2026-04-25 12:51:37 +05:30
AarDG10
455595f2f5 refactor(test): minor refactor and added test to check query 2026-04-25 12:42:57 +05:30
vijayanrxbb
55e342bbd5 test(db_query): assert self-referential Link joins don't collide on alias
Mirrors test_ambiguous_linked_tables but with a DocType whose Link
fields point back to itself, covering the path where pypika's '2'
auto-alias collides on the second self-join.
2026-04-25 12:42:57 +05:30
vijayanrxbb
383b24e0f9 fix(db_query): unique alias on self-referential Link joins
When a DocType has two or more Link fields pointing back to itself and
list view tries to join them, pypika auto-aliased both joins with the
same '<table>2' suffix, producing a MySQL 1066 'Not unique table/alias'
error.

Alias each self-referential join with 'tab<doctype>_<link_fieldname>'
so every join gets a unique alias, and use the same aliased table in
apply_select so SELECT references resolve correctly.
2026-04-25 12:42:57 +05:30
Shrihari Mahabal
234b0722a2 fix: skip http validation for servers scripts in background tasks 2026-04-25 12:19:18 +05:30
Ankush Menat
7a565de242
ci: Tweak coverage (again) (#38889)
* ci: Skip other dbs in coverage computation

* ci: Add accurate coverage tracking (again)
2026-04-25 11:59:22 +05:30
Ejaaz Khan
916d04ae74
Merge pull request #38885 from iamejaaz/small-ui-ux-fix
fix(ListView): content overlow in small screens
2026-04-24 22:49:04 +05:30
Ejaaz Khan
58667ec285 fix(ListView): content overlow in small screens 2026-04-24 22:45:40 +05:30
Aarol D'Souza
74f125c360
Revert "fix(client): add stronger checks in save and set_value endpoints" 2026-04-24 20:09:37 +05:30
Shrihari Mahabal
6284ad13cd
Merge pull request #38876 from ShrihariMahabal/check-perm-on-user-email-awaiting
fix: add perm check on user email awaiting
2026-04-24 18:12:59 +05:30
Shrihari Mahabal
c19dd276ba fix: add perm check on user email awaiting 2026-04-24 17:10:50 +05:30
Ankush Menat
098a0851c6
ci: Fix coverage reporting (again) (#38849)
* chore: remove _decorate_all_methods_and_functions_with_type_checker

No one understands this runtime magic anymore.

* build: Bump coverage.py to latest

* test: Skip github in coverage reporting

* test: Print traceback from all threads when test is stuck

* ci: Enable coverage in server side tests

* ci: Always enable coverage

It's cheap in recent python versions, our reasons for selectively
disabling aren't valid anymore.

* ci: Disable stderr capturing

* ci: Use default buffer behaviour in unittest runner

* ci(coverage): Set concurrency to multiprocessing

We do use multiprocessing, perhaps the patches aren't concurrectly
handled?

* ci(coverage): Try parallel run

* fix: Apply subprocess patch

* ci: Don't start web server with coverage

Causes deadlock for some reason. We don't actually report it either.

* ci: only submit UI coverage if ran

* test: remove aggresive stuck test checking

* ci: disable UI coverage

(for now)
2026-04-24 16:05:14 +05:30
Ejaaz Khan
d9d35fa4ad
Merge pull request #38866 from iamejaaz/small-ui-ux-fix
fix(ListView): Small UI & UX fixes related to navbar
2026-04-24 15:47:24 +05:30
RitvikSardana
b484cf0136
fix: pytz to filter out deprecated timezones (#38751) 2026-04-24 14:06:40 +05:30
Ejaaz Khan
f7a0be068b fix: set max-width to list title 2026-04-24 13:12:50 +05:30
Ejaaz Khan
d68a814e02 fix(ListView): hide indicator on listview 2026-04-24 13:01:31 +05:30
Ejaaz Khan
8054844193
Merge pull request #38767 from Abdeali099/delete-custom-fields-utility
feat: added a method to delete custom_fields
2026-04-24 12:48:51 +05:30
Abdeali Chharchhoda
1d571827cf chore: clear cache after deleting custom fields 2026-04-24 12:01:34 +05:30
Ankush Menat
1f9015a9c2
fix: Re-add rate limit on blog comments (#38862) 2026-04-24 05:09:14 +00:00
Kerolles Fathy
13230516b8
Merge pull request #38858 from devdiogenes/edit_section-translatable
fix: Make Edit Section title translatable in Print format Builder
2026-04-24 01:09:43 +03:00
Kerolles Fathy
3d414812c8
Merge pull request #38857 from devdiogenes/fix-condition-examples-translatable
fix: Makes Condition Examples title translatable
2026-04-24 01:08:52 +03:00
devdiogenes
984ebe5ae7 fix: Make Edit Section title translatable in Print format Builder 2026-04-23 19:47:39 +00:00
Ejaaz Khan
25c95c7f9d
Merge pull request #38831 from s-aga-r/fix-66079
fix(SMTP): config to disable EHLO after AUTH
2026-04-23 23:32:52 +05:30
Ejaaz Khan
be6e85fe9e
Merge pull request #38748 from barredterra/fix/test-runner-missing-doctype
fix(tests): skip uninstalled doctypes in test record dependency walk
2026-04-23 23:21:48 +05:30
Ejaaz Khan
778aa12feb
Merge pull request #38393 from barredterra/defer-doctype-export
fix: defer DocType exports until after save response
2026-04-23 23:19:16 +05:30
Saqib Ansari
a8c373a2f4
Merge pull request #38576 from nextchamp-saqib/concurrent_limit
feat: add `@frappe.concurrent_limit()` decorator
2026-04-23 22:55:59 +05:30
Saqib Ansari
01de388c26
Merge pull request #38800 from nextchamp-saqib/qb-json-functions
feat: add JSON functions in query builder
2026-04-23 22:50:47 +05:30
Aarol D'Souza
f10abb4e06
Merge pull request #38750 from pratikb64/fix/delete-utils
fix: add get_dynamic_linked_docs & get_linked_docs utils
2026-04-23 20:27:35 +05:30
AarDG10
1257e0db42 refactor(delete_doc): minor refactor in qb usage 2026-04-23 20:13:42 +05:30
Pratik
05532b3697 refactor: remove for loop while raising exception 2026-04-23 18:52:54 +05:30
Hussain Nagaria
1b07869248
Merge pull request #38828 from imgullu786/fix/workspace-save 2026-04-23 17:15:34 +05:30
Shrihari Mahabal
620541d97c
Merge pull request #38843 from ShrihariMahabal/event-permissions
fix: check permissions for getting and updating events
2026-04-23 15:51:00 +05:30
Shrihari Mahabal
b4c2a6c617 fix: check permissions for getting and updating events 2026-04-23 15:38:32 +05:30
Aarol D'Souza
58badf002c
Merge pull request #38815 from AarDG10/fix-client
fix(client): add stronger checks in save and set_value endpoints
2026-04-23 14:06:58 +05:30
Md Gulam Gaush
be0cf977a2 fix: Page not found error when saving public workspace with multi word name 2026-04-23 11:49:24 +05:30
Abdeali Chharchhoda
9a75ff6fd3 test: enhance delete_custom_fields test to cover multiple deletion methods 2026-04-23 11:26:47 +05:30
Saqib Ansari
588112b833
refactor: bring back collapse button (#38742) 2026-04-23 11:26:20 +05:30
s-aga-r
7f355b3f53 fix(SMTP): config to disable EHLO after AUTH 2026-04-23 11:25:54 +05:30