Commit graph

3984 commits

Author SHA1 Message Date
Jayanta
9ff6043693
fix(boilerplate): add apt dependencies section for Frappe Cloud (#38198)
* fix(boilerplate): Add apt dependencies for Frappe Cloud

Add apt dependencies section for Frappe Cloud deployment
2026-03-24 16:51:28 +05:30
Jannat Patel
97510d125c fix: redirect website user to default home after social login 2026-03-18 12:39:01 +05:30
AarDG10
3e14434f9e fix: add fallback to also check for translation w/ html tags
Adds a fallback to check for translations w/ and w/o HTML tags.
2026-03-13 11:56:48 +05:30
Akhil Narang
c5bf0d3f59
fix: prevent user from setting same password on forced reset (#37652)
Co-authored-by: UmakanthKaspa <kaspaumakanth1999@gmail.com>
2026-03-11 18:06:15 +05:30
Ankush Menat
546100ec60
fix: check return type of getattr (#37873) 2026-03-09 14:04:25 +00:00
Nikhil Kothari
733e62ba2c
feat: add support for DD-MMM-YYYY in data import (#37853) 2026-03-08 19:17:48 +00:00
Akhil Narang
3e4f139ff3
fix: use string representation of exceptions in translated strings (#37756)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-03-06 13:02:16 +05:30
Ejaaz Khan
a5d591230b
Merge pull request #37745 from kaulith/fix/print-format-builder-beta-header
fix: pass letterhead and render layout header/footer in print format
2026-03-04 22:28:58 +05:30
Akhil Narang
cacb6b65f8
Merge pull request #37747 from akhilnarang/oauth-first-name-fallback
fix(oauth): add another fallback for first name
2026-03-04 11:48:34 +05:30
Akhil Narang
1707a7cb96
fix(oauth): add another fallback for first name
Github doesn't mandate a first name, but frappe does, so fallback to username.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-03-04 11:38:40 +05:30
Kaushal Shriwas
84fb0d000c fix: pass letterhead and render layout header/footer in print format builder beta browser print 2026-03-04 02:02:01 +05:30
Ejaaz Khan
742e8407b5
Revert "feat: use chrome from system/docker file" 2026-03-03 12:03:20 +05:30
Ejaaz Khan
f86fe795b6
Merge pull request #37713 from iamejaaz/37464-default-pdf-issue 2026-03-02 20:39:06 +05:30
Ejaaz Khan
8028890137 feat: use chrome from system/docker file 2026-03-02 20:26:23 +05:30
Ejaaz Khan
c7ac52a71e
Revert "fix(pdf): removal of header and footer margins" 2026-03-02 19:29:36 +05:30
Kerolles Fathy
cfc2007f65
fix: allow dangerous HTML in link exists exception (#37677)
* fix: allow dangerous HTML in link exists exception

* fix: Allow `a` tags

* Revert "fix: allow dangerous HTML in link exists exception"

This reverts commit 9a37f5092ed6c27ff6a0c427df6494561e971ac3.

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-03-02 09:00:43 +00:00
Suraj Shetty
d518bc7307
Merge pull request #37189 from krantheman/fix-report-pdf-layout 2026-02-26 16:21:23 +05:30
Ankush Menat
85e0fdaa6c
fix: Apply full perm logic on global search (#37400)
Co-authored-by: AarDG10 <aarol.dsouza@gmail.com>
2026-02-23 17:55:27 +05:30
Ankush Menat
657b1eb50c
fix!: Restrict allowed HTML in msgprints (#37399)
Co-authored-by: AarDG10 <aarol.dsouza@gmail.com>
2026-02-23 11:49:15 +00:00
Akhil Narang
838dffd502
fix(oauth): use get_email() helper in OAuth email validation (#37373)
Co-authored-by: Kaushal Shriwas <kaushalshriwas118@gmail.com>
2026-02-23 07:42:10 +00:00
Ankush Menat
a94312b30f
fix: Handle missing default workspace (#37359) 2026-02-23 11:43:25 +05:30
Kerolles Fathy
a71134ee2b
fix(DX): Add patches folder when generating new app boilerplate (#37352)
* fix(DX): add patches folder creation when generating new app boilerplate

* test: add patches folder to paths_inside_app
2026-02-23 11:08:20 +05:30
Suraj Shetty
20952ebe00
Merge pull request #36787 from GursheenK/bulk-actions-not-disabled-with-user-settings 2026-02-23 10:37:06 +05:30
Gursheen Anand
cf1a3760bb chore: resolve conflicts 2026-02-20 15:25:46 +01:00
mergify[bot]
15d91ed419
Merge branch 'develop' into real-file-name 2026-02-20 11:49:22 +00:00
Safwan Samsudeen
cdb50bde65 fix: use actual file name for private files 2026-02-20 14:44:44 +05:30
Aarol D'Souza
08793c57f7
fix: force type check in whitelisted methods 2 (#37086)
* fix(diff): add type hints to whitelisted methods

* fix(global_search): add type hints to whitelisted methods

* fix(custom_html_block): add type hints to whitelisted methods

* fix(deleted_document): add type hints to whitelisted methods

* fix(log_settings): add type hints to whitelisted methods

* fix(role): add type hints to whitelisted methods

* fix(user_type): add type hints to whitelisted methods

* fix(rq_job): add type hints to whitelisted methods

* fix(link_preview): add type hints to whitelisted methods

* fix(email_account): add type hints to whitelisted methods

* fix(web_form): add type hints to whitelisted methods

* fix(web_page_view): add type hints to whitelisted methods

* fix(csvutils): add type hints to whitelisted methods

* fix(file_manager): add type hints to whitelisted methods

* fix(email_body): add type hints to whitelisted methods

* fix(email_queue): add type hints to whitelisted methods

* fix(email_template): add type hints to whitelisted methods

* fix(notification): add type hints to whitelisted methods

* fix(email_group): add type hints to whitelisted methods

* fix(inbox): add type hints to whitelisted methods

* fix(recorder): add type hints to whitelisted methods

* fix(sms_settings): add type hints to whitelisted methods

* fix: tighten type hints

* fix(data_import): add type hints to whitelisted methods

* fix(user_permission): add type hints to whitelisted methods

* fix(gantt): add type hints to whitelisted methods

* fix(like): add type hints to whitelisted methods

* fix(search): add type hints to whitelisted methods

* fix(onboarding_step): add type hints to whitelisted methods

* fix(system_console): add type hints to whitelisted methods

* fix(workspace_sidebar): add type hints to whitelisted methods

* fix(todo): add type hints to whitelisted methods

* fix: correct type hints

* fix(print_format): add type hints to whitelisted methods

* fix(client): add type hints to whitelisted methods
2026-02-19 14:58:16 +05:30
Hussain Nagaria
71365066d3
refactor: safer property access 2026-02-18 19:40:47 +05:30
Akash Tom
b9f659ef74 fix: apply margin for header and footer for ids header-html and footer-html 2026-02-18 15:08:39 +05:30
Suraj Shetty
c0806fabe8
Revert "fix(safe-exec): Allow WITH queries" (#37175) 2026-02-18 07:21:41 +00:00
Balamurali M
87ea953609 fix(safe-exec): Allow WITH queries
ref: https://mariadb.com/docs/server/reference/sql-statements/data-manipulation/selecting-data/common-table-expressions/with
2026-02-18 12:21:50 +05:30
Trusted Computer
caf08a8451
Merge branch 'frappe:develop' into fix-attach-print-pdf 2026-02-17 12:18:30 -08:00
Aarol D'Souza
9eef4f6dae
fix: force type check in whitelisted methods (#37044)
* fix(contact): force type check in contact whitelisted methods

* fix(google_indexing): force type check in google_indexing whitelisted methods

* fix(assignment_rule): add type checks to assignment_rule whitelisted methods

* refactor: remove unused args

* fix(queue): add type hints to whitelisted methods in queue.py

* fix(auto_email_report): add type hints to whitelisted methods

* fix(dashboard): add type hints to whitelisted methods

* fix(sidebar_item_group): add type hints to whitelisted methods

* fix(weasyprint): add type hints to whitelisted methods

* fix(backups): add type hints to whitelisted methods

* fix(document_naming_settings): add type hints to whitelisted methods

* fix(get_latest_submissions): add type hints to whitelisted methods

* fix(custom_field): add type hints to whitelisted methods

* fix(customize_form): add type hints to whitelisted methods

* fix(personal_data_deletion_request): add type hints to whitelisted functions

* fix(__init__): add type hints to whitelisted methods

* fix(prepared_report): add type hints to whitelisted methods

* fix(session_default_settings): add type hints to whitelisted methods

* fix(document_follow): add type hints to whitelisted methods

* fix(route_history): add type hints to whitelisted methods

* fix(form_tour): add type hints to whitelisted methods

* fix(dashboard_settings): add type hints to whitelisted methods

* fix(address): add type hints to whitelisted methods

* fix(contact): add type hints to whitelisted methods

* fix(discussion_reply): add type hints to whitelisted methods

* fix(auto_repeat): add type hints to whitelisted methods

* fix: add the missing type hints and misc. corrections

* fix(email): add type hints to whitelisted methods

* fix(permitted_documents_for_users): add type hints to whitelisted methods

* fix: correct the type hints

* fix: int PK types

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-17 15:16:30 +00:00
Ankush Menat
69dbd05e87
fix: rebuild tree should process nodes in *some* order (#37116)
Co-authored-by: Shrihari Mahabal <shriharimahabal08@gmail.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2026-02-17 14:33:40 +05:30
Soham Kulkarni
79a3e181f4
Merge pull request #37101 from sokumon/delete-icons
fix(desktop_icon): use app_name instead of app_title
2026-02-17 11:28:36 +05:30
Raffael Meyer
f00b1b44ba
fix: round negative and positive values the same way (#36242) 2026-02-17 11:23:37 +05:30
sokumon
c6338799e3 fix(desktop_icon): use app_name instead of app_title 2026-02-17 03:25:02 +05:30
Harsh Patadia
af628d70c8
fix: Unpacking of NoneType returned from frappe.get_cached_value() and parenthesized multiple exception syntax (#37008)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2026-02-16 10:19:15 +00:00
Ankush Menat
4d87562641
fix: Allow untyped self/cls (#37053) 2026-02-16 06:57:38 +00:00
trustedcomputer
d97fdfe20a fix: exclude print_format_builder print formats from weasyprint processing in email-attached PDFs 2026-02-15 09:42:54 -08:00
Safwan
dd6bb35b1d
Merge pull request #36970 from safwansamsudeen/float-format 2026-02-11 16:20:34 +05:30
Safwan Samsudeen
759ff0e6df fix: do not round whole floats in format 2026-02-11 16:09:37 +05:30
Akhil Narang
e6ea045d06
fix: improve sanitize_column regex
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-10 21:35:54 +05:30
Rahul Agrawal
f70e578baf Merge branch 'develop' into fix/email-print-format-render 2026-02-09 18:41:51 +05:30
Ankush Menat
bfba73653f
fix(DX): Boilerplate defaults for type checks and exports (#36871)
Add sane defaults for new apps.
2026-02-09 10:10:02 +00:00
Aarol D'Souza
77af2d53d6
fix(system console): allow read-only queries in system console (#36652)
* fix(system console): allow read-only queries in system console

* fix(security): make transactions strictly read only for console and scripts

* test: remove test to reflect ban on cte's for security

* fix: Only enable read only mode for SQL query

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-05 11:39:10 +00:00
Gursheen Anand
2605114511 fix: add bulk action validation for tags 2026-02-05 17:05:35 +05:30
Ankush Menat
c9cdacb4ce
feat: Optionally force type checking on whitelisted methods (#36744) 2026-02-05 16:20:41 +05:30
Akhil Narang
48e52e152b
fix(report_to_pdf): add some restrictions (#36674)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-04 19:33:14 +05:30
Gursheen Anand
2146221bee fix: check for bulk actions enabled on user before allowing bulk actions in whitelisted methods 2026-02-04 17:44:58 +05:30