Komal-Saraf0609
161fa18660
test: Corrected selectors
2022-04-22 14:33:48 +05:30
Ankush Menat
a245cb51a2
feat: configurable auto email reports limit ( #16684 )
...
- The previous limit was 3 per user which is way too less, no known reason to
restrict this other than hogging of system with too many reports. Bumped
default limit to 20.
- site config is not easily discoverable or editable, added config in
system settings.
- Moved auto email report background job form daily queue to `daily_long` queue.
closes https://github.com/frappe/frappe/issues/16681
<img width="1049" alt="Screenshot 2022-04-20 at 12 33 06 PM" src="https://user-images.githubusercontent.com/9079960/164170117-5612d9df-da91-441b-a4f6-acd89d30336e.png ">
`no-docs` (error message is sufficient to explain to user what to do without referring docs)
ref:
ISS-21-22-10245
ISS-21-22-07742
ISS-20-21-10850
ISS-20-21-10112
and many more times. This is such a stupid validation 🤦
2022-04-22 08:02:31 +00:00
gavin
2da85fa8da
Merge pull request #16698 from gavindsouza/traceback-with-context
...
feat: Traceback with context
2022-04-22 13:04:07 +05:30
Gavin D'souza
ffc2b9427f
Merge branch 'develop' of github.com:frappe/frappe into bg-rename_doc
2022-04-22 12:14:21 +05:30
Gavin D'souza
e6e01627f8
refactor: rename_document_title
...
* Remove extra reload_doc that caused extra onload
* Refactor variable naming, DRY-er
* Simplify flow
2022-04-22 12:09:26 +05:30
chillaranand
7d9695a0d2
chore: Bump wrapt to 1.14.0
2022-04-22 11:10:54 +05:30
Ankush Menat
eb6ec33df2
Merge pull request #16704 from gavindsouza/safe_exec-updates
...
feat(safe_exec): Allow more APIs
2022-04-21 18:21:34 +05:30
Gavin D'souza
ab1f893e41
feat: Add get_mapped_doc in safe_exec under frappe
2022-04-21 16:52:06 +05:30
gavin
03d02ae11c
Merge branch 'develop' into safe_exec-updates
2022-04-21 16:11:54 +05:30
Gavin D'souza
b6683db57e
refactor: frappe.rename_doc definition
...
Use explicit naming of args, kwargs and don't accept cmd and
ignore_permissions explicitly
2022-04-21 16:09:08 +05:30
KrutikaBhatt
e565deb88e
fix(UI): Duration Filter overlapping issue ( #16599 )
2022-04-21 16:00:56 +05:30
Gavin D'souza
9823e51512
feat(safe_exec): Allow new_doc, get_last_doc, rename_doc, delte_doc
...
* rename_doc points to the unwhitelisted method which supports
ignore_permissions check
* Allowed other safe utils for better DX
2022-04-21 16:00:24 +05:30
Ankush Menat
dfef7192da
refactor: remove duplicate code from db.get_descendants ( #16699 )
2022-04-21 15:27:59 +05:30
Gavin D'souza
418dcdd2f4
fix!: Use event as a differentiator for frappe.utils.log
2022-04-21 13:33:40 +05:30
Gavin D'souza
c691537e61
chore: Add typing for ease of development
2022-04-21 13:32:13 +05:30
Gavin D'souza
5ecc9fe4ff
refactor(log_error): de-clutter & log context with traceback
2022-04-21 13:27:01 +05:30
Gavin D'souza
4e533682ba
feat: get_traceback with context
2022-04-21 13:26:12 +05:30
Suraj Shetty
c1e477ce5d
Merge pull request #16697 from surajshetty3416/fix-field-group
...
fix: Do not use `set_value` for default to avoid change event
2022-04-21 12:52:56 +05:30
Suraj Shetty
b5c3ff16ee
fix: Do not use set_value for default to avoid change event
2022-04-21 12:43:46 +05:30
mergify[bot]
cc8d096bd1
Merge pull request #16582 from alyf-de/fix-open-count-no-data
...
fix: handle no data in set_open_count
2022-04-21 06:15:56 +00:00
Suraj Shetty
acbbeb1de5
Merge pull request #16693 from surajshetty3416/fix-rtl-table
2022-04-21 10:16:06 +05:30
Suraj Shetty
56bb11dc17
fix: Do not change direction of text if already in RTL mode
2022-04-21 08:49:48 +05:30
Vladislav
340995f55d
Update ru.csv
2022-04-21 01:44:40 +03:00
phot0n
6405b0510a
chore: fix linter
2022-04-20 17:56:48 +05:30
phot0n
c516357027
test(get_value): test for multiple order bys
2022-04-20 17:56:48 +05:30
phot0n
da191390a5
fix: support for multiple order by in add_conditions
2022-04-20 17:56:48 +05:30
gavin
5e707d3527
Merge pull request #16689 from gavindsouza/bulk_insert-fix
...
fix(bulk_insert): Cast values as list before subscripting
2022-04-20 16:59:28 +05:30
Gavin D'souza
35c606707e
fix(bulk_insert): Cast values as list before subscripting
2022-04-20 16:43:19 +05:30
Gavin D'souza
6cdd33f26b
fix: Generate hash of length 8 for save point
2022-04-20 16:41:25 +05:30
Gavin D'souza
892e05fdc1
Merge branch 'develop' of github.com:frappe/frappe into bg-rename_doc
2022-04-20 16:04:27 +05:30
Rushabh Mehta
78bddb4127
Merge pull request #16653 from rmehta/error-log-ref
...
feat(minor): Add document reference to Error Log and doc.log_error
2022-04-20 15:54:59 +05:30
Ankush Menat
296a6bd02f
test: show locals on test failure ( #16687 )
...
- Show locals always in CI
- Show locals locally when running in verbose mode
2022-04-20 15:37:54 +05:30
Rushabh Mehta
248c3555e3
fix(minor): add error_log for failed webhooks and web pages
2022-04-20 15:16:44 +05:30
Ankush Menat
dcee40046a
perf!: simpler frappe.get_system_setting ( #16685 )
...
Not sure why this needs to be "cached" in locals again when db object
already caches it in value_cache.
2022-04-20 15:16:04 +05:30
Faris Ansari
620a944104
Merge pull request #16622 from netchampfaris/less-flaky-date-test
...
test: less flaky date control test
2022-04-20 14:10:55 +05:30
Shariq Ansari
11360c5fd8
fix: Check mandatory_depends_on also while checking mandatory on save ( #16515 )
2022-04-20 13:02:42 +05:30
gavin
0a1b75c452
Merge pull request #16680 from gavindsouza/migrate-fix
...
fix: Check for required services running after frappe init
2022-04-20 12:05:59 +05:30
Gavin D'souza
91e0cac029
fix: Check for required services running after frappe init
...
Each site on a single app server can run on separate DBMS' on separate
servers. This site specific config resides in each site's
site_config.json file. Thereby, we need to load site's config before
checking for service's availability.
2022-04-20 11:25:38 +05:30
Pruthvi Patel
8b010e1732
refactor: make frappe.db.bulk_insert work as expected ( #16527 )
...
## Issue
`frappe.db.bulk_insert` is not working as expected:
- It will not insert any row if there are less than 3 values
- It will not add 1st row at all. e.g if I'm adding 5 values, it will only add 4.
- It will add values one by one after 2 values, instead it should have inserted items (in db) in chunk of 10000 (as per the code written before).
## Changes Made
- Solved above issues
- use better way to chunk list
- Added Postgres support for bulk_insert API
And now `bulk_insert` will only do **1 db call for each 10000** values.
Note: For testing purpose I made `Test Bulk Insert` doctype and keep chunk size of 100.
## Before
## After
nodocs
2022-04-19 14:47:22 +00:00
gavin
d3e7090688
Merge pull request #16675 from gavindsouza/invalid-git-version
...
fix(version): Handle unable to read commit errors in version command
2022-04-19 20:07:41 +05:30
Gavin D'souza
aef0c0f66e
fix: Handle unable to read commit errors
2022-04-19 19:21:25 +05:30
gavin
d1f8c87364
Merge pull request #16666 from phot0n/remove-tag-link-patch
...
chore: remove tag link patch
2022-04-19 18:52:56 +05:30
Ritwik Puri
586dd3ff02
Merge pull request #16612 from phot0n/customize-form-xss
...
feat(minor): add ignore_xss_filter to customize form field
2022-04-19 17:50:51 +05:30
Deepesh Garg
b59619f764
chore: Update creds to allow updates on protected branch ( #16672 )
2022-04-19 17:29:09 +05:30
Faris Ansari
fc4e2780bd
chore: pretty logging for dialog command
2022-04-19 16:49:34 +05:30
Faris Ansari
d1978d8e62
fix: check dates in frappe realm
...
new Date in Cypress context and new Date in frappe context differs sometimes in CI
2022-04-19 16:49:08 +05:30
Suraj Shetty
8f94cb655f
Merge branch 'develop' into phone_field_control
2022-04-19 16:28:18 +05:30
Shariq Ansari
ea463d1387
Merge branch 'develop' into customize-form-xss
2022-04-19 16:04:48 +05:30
Shariq Ansari
ef6bb79f65
test: Typing on focused input issue ( #16669 )
2022-04-19 15:51:03 +05:30
phot0n
317ff3b9e2
chore: remove tag link patch
2022-04-19 13:50:45 +05:30
