Commit graph

1219 commits

Author SHA1 Message Date
kamaljohnson
cb25d894b4 refactor: code cleanup 2022-02-08 12:54:51 +05:30
Suraj Shetty
b978b5a70b test: Fix mocked method and formatting issues 2022-02-08 12:01:11 +05:30
kamaljohnson
84501c663e fix: use new mocked_inbound_mail in test_email
- remove in_test block from production code
2022-02-08 08:33:09 +05:30
kamaljohnson
0e63c9c33e fix: test fail issue for some email tests
- test_threading
- test_threading_by_message_id
- test_threading_by_subject
2022-02-08 08:11:43 +05:30
kamaljohnson
d318675522 feat: add coverage for some more email tests
- test_incoming
- test_incoming_with_attach
- test_incoming_attached_email_from_outlook_plain_text_only
- test_incoming_attached_email_from_outlook_layers
2022-02-08 01:27:26 +05:30
kamaljohnson
7b0e646e10 fix: none type issue in email test, add more coverage to test_auto_reply 2022-02-08 01:04:44 +05:30
kamaljohnson
e109c6b039 Merge branch 'develop' into fix-imap-folder-append-to-not-working-issue 2022-02-07 18:26:04 +05:30
kamaljohnson
7c51c6a9ea fix: add in_test parameter from frappe.local.flags.in_test mock 2022-02-07 18:25:36 +05:30
kamaljohnson
caab903edb fix: add back in_test override for imap_folders test
Since a lot of tests still uses the old way i.e, use `in_test` and execute custome (non-production) code to get results. Kept the same code for now else as a major test refactor needs to be done.
2022-02-07 15:49:59 +05:30
phot0n
b31f3c24f6 refactor: remove parent, parenttype, parentfield, idx columns from non-child table doctypes
* feat: add parent, parenttype, idx, parentfield columns to doctypes when transitioning from normal -> child table

* fix: remove parent, parenttype, parentfield, idx from DocType DocType
2022-02-07 15:12:37 +05:30
Suraj Shetty
ae2dd3f6b8 fix: Remove in_test flag inside get_inbound_mails
- Use mocked data instead for testing
2022-02-07 11:59:06 +05:30
kamaljohnson
c80c81ed32 fix: messages and test_mail not passed issue while running test 2022-02-04 18:20:07 +05:30
kamaljohnson
6881e58194 Merge branch 'develop' into fix-imap-folder-append-to-not-working-issue 2022-02-04 16:58:49 +05:30
kamaljohnson
1cc0f88d0b fix: issue when test_mails are passed while testing 2022-02-04 15:47:27 +05:30
kamaljohnson
8f8bafbdde fix: sider styling issue 2022-02-04 15:29:12 +05:30
kamaljohnson
8cc26af272 fix: remove messages-1.raw 2022-02-04 15:28:16 +05:30
kamaljohnson
3734dc7927 feat: add tests for imap folders email syncing with multiple folders 2022-02-04 15:07:18 +05:30
Raffael Meyer
89922bae90
feat: utility methods for docstatus (#15515)
* feat: utility methods for docstatus

* refactor: use utility method for doctsatus

* refactor: enum for docstatus

* refactor: docstatus as property

* fix: set docstatus

* feat: docstatus extends int class

* test: docstatus of BaseDocument

* refactor: occurrences of docstatus

* fix: typo

* refactor: move docstatus to a separate file

* test: docstatus

* fix: sider
2022-02-04 07:41:25 +00:00
kamaljohnson
ffbf215070 fix: communication if is_first and no append_to issue 2022-02-02 11:29:43 +05:30
kamaljohnson
12442726c6 fix: reply emails get_reference_doc from communication issue 2022-02-02 11:00:39 +05:30
kamaljohnson
f960fb70dc fix: append_to in case of not passed issue 2022-02-02 10:29:09 +05:30
kamaljohnson
18820bf44e feat: add test 2022-02-02 09:08:03 +05:30
kamaljohnson
58db376509 fix: email syncing with "seen" emails even if email_sync filter set to "unseen" issue 2022-02-01 20:06:26 +05:30
kamaljohnson
43ac81be5d refactor: remove debug logs 2022-02-01 19:04:18 +05:30
kamaljohnson
eb574ca9f1 feat: add filter for append_to wrt imap_folder 2022-02-01 19:01:41 +05:30
kamaljohnson
57a6ee392a fix: append_to parameter order in InboundMail 2022-02-01 11:00:50 +05:30
kamaljohnson
7829de9862 fix: auto creation of append to doctype ref while receiving mail 2022-02-01 06:22:39 +05:30
Gavin D'souza
6b6e10f7c5 fix: Log errors correctly
Prior to this, no tracebacks were logged and the body of the log only
had what was supposed to be the title
2022-01-27 18:29:57 +05:30
Gavin D'souza
de2bcb08b4 fix!: Drop six PY2 compatibility package 2022-01-27 18:28:04 +05:30
Gavin D'souza
5503e18817 chore(typing): Add typing, style fixes
This was going to be a fix at first. Until I realised it couldn't...so I
removed the changes and kept the things back that helped me debug the
issue
2022-01-27 18:27:35 +05:30
Summayya Hashmani
645fde2e67
fix: email fetch error for imaplib (#15581)
* fix: remove maxline for imaplib

* refactor: remove redundant line

Co-authored-by: Summayya <frappe@Summayyas-MacBook-Air.local>
2022-01-11 08:11:38 +00:00
Gavin D'souza
981564e544 Merge branch 'develop' into frappe-postgres-changes 2022-01-07 11:37:28 +05:30
Conor
40ba1ac9ba fix: Postgres Compatibility
* Handle inconsistencies in type handling in DatabaseQuery & Database
  APIs
* Update incompatible queries with frappe.qb notation
* Fixed use cases discovered by failing ERPNext CI tests

fix: db independent syntax for user_type

fix: handle postgres datetime values

feat: add ability to auto commit on db inserts

feat: add ability to escape underscore in postgres

fix: handle missing data in test runner bootstrapping

fix: db independent syntax for queries

fix: refactor to use qb

fix: update cache for language

fix: use pluck in email_queue

Co-authored-by: gavin <gavin18d@gmail.com>

fix: don't auto insert on tests for make_property_setter

fix: remove auto_commit in custom_field insertion

fix: remove auto_commit functionality

fix: review comments

fix: revert link validation

fix: style suggestion for readability

Co-authored-by: gavin <gavin18d@gmail.com>

fix: revert .lower() in link validation

fix: add rollback for setup_wizard

Revert "fix: add rollback for setup_wizard"

This reverts commit 83b3b0913db17718ccd5edae01858cff15603829.

Revert "feat: add ability to escape underscore in postgres"

This reverts commit 8ed9c2aa3306438e94bb813f60e65b416d0b947b.

fix: more concise representation of order fields

Co-authored-by: gavin <gavin18d@gmail.com>
2022-01-07 10:44:57 +05:30
shadrak gurupnor
1832df06ad fix: replace owner with allocated_to 2022-01-04 13:39:33 +05:30
Gavin D'souza
bb004fc33b fix: Remove redundant owner fields in Email Template, Help Article 2022-01-04 13:32:44 +05:30
kamaljohnson
bf9ef972c8 refactor: remove debug statement 2021-12-16 13:08:47 +05:30
kamaljohnson
7744924797 fix: syntax error in frappe.qb set in email_account.py 2021-12-16 13:01:16 +05:30
Rutwik Hiwalkar
1ec54c87c8
feat: patched frappe email to work with frappecloud mail app (#15248)
* feat: patched EmailQueue.send and frappe.utils.get_formatted_email

* chore: renamed hooks and handled an edge case

* fix: if the get_sender_details hook is defined but it returns invalid input
2021-12-12 21:09:31 +05:30
Faris Ansari
4bb79161be style: missing semicolon 2021-12-07 17:57:18 +05:30
Faris Ansari
d760e25b63 tests: fix newsletter tests 2021-12-07 17:43:57 +05:30
Faris Ansari
606a0d3809 fix: various fixes
- show published newsletters in list view
- show published newsletter as web page
- show status section after newsletter is sent
- add email_sent_at and total_recipients field
2021-12-07 15:52:25 +05:30
Faris Ansari
de7d0337a6 fix: various newsletter form ux fixes
- Cancel Scheduling button
- Show dashboard message if newsletter is scheduled
2021-12-07 15:48:35 +05:30
Faris Ansari
330677bb0a fix: better sending status
- show email sending progress in form dashboard
2021-12-07 15:40:55 +05:30
Faris Ansari
9bdb5f2eb2 fix: Explicit attachments table
The newsletter content may contain images that get "attached" to the
newsletter document. If this is the case, you can't selectively include
attachments in the newsletter as it attaches all the attachments.
An explicit attachments table solves this problem.
2021-12-06 17:04:24 +05:30
Faris Ansari
0d3bac5528 fix(ux): Show broken links as dashboard message 2021-12-06 15:38:59 +05:30
Faris Ansari
da4160e2dd fix: Newsletter enhancements and fixes
- Organize fields into sections
- Buttons for Send now and Scheduled sending
- Buttons to Send test email and to Check broken links
- Remove Test section
2021-12-06 15:38:58 +05:30
Suraj Shetty
e4ad02f7e7
Merge branch 'develop' into newsletter-markdown 2021-12-03 13:29:59 +05:30
Faris Ansari
51c4738a04 fix(newsletter): use md_to_html instead of markdown
because valid html is valid markdown and markdown method
doesn't convert markdown if it encounters some html tags
2021-12-02 18:01:43 +05:30
Manuel
3a34bfc520
Fix: copy_email_data patch #15106 (#15115)
Reload DocType `Email Account` in patch.
Changed `modified` in json files.

Removed linking of `imap_folder` in `Email Flag Queue` this connection
seems not necessary at this point. Also removed all parts that create
this connection.
2021-12-01 12:41:27 +00:00
Manuel
d57fe8f799
Update frappe/email/doctype/email_account/email_account.py
Co-authored-by: Abhishek Saxena <33656173+saxenabhishek@users.noreply.github.com>
2021-11-26 08:08:18 +01:00