Commit graph

9 commits

Author SHA1 Message Date
ChillarAnand
b2fc959307 refactor: Clean up whitespace & add CI check 2022-02-25 20:01:29 +05:30
Ankush Menat
614423e41c
chore: change repo name 2021-10-22 22:37:06 +05:30
Ankush Menat
488cb31265 ci: move semgrep rules out of repo 2021-10-22 21:46:50 +05:30
Ankush Menat
144880bfb1
ci: make semgrep check diff-aware 2021-07-16 12:00:30 +05:30
Ankush Menat
4d7f5a8f8d
ci: fix semgrep false positives (#13161)
* ci: fix false positive rule for split js translate

- limit regex to must match end of line.
- expand previous check to take care of other ways to split multi-line
  calls.

* ci: update tests for rules, ignore rules in sider

* ci: enable semgrep on v13 branches

* ci: fix false positive for python split strings
2021-05-12 20:22:48 +05:30
Ankush Menat
5881c5dbec
ci(semgrep): add more rules, r/python.correctness (#12876)
* ci(semgrep): add more rules, r/python.correctness

- Added file for defining rules as per frappe data model:
frappe_correctness.yml
- Add rule for SQLi, with WARNING only for now
- Add rule file for UX
- WARNING | INFO do not fail the build now

* ci(semgrep): on_cancel, on_submit correctness rule

* ci(semgrep): split workflow in steps

* ci(semgrep): catch line breaks in _()

* chore: fix sider issue
2021-04-23 09:04:34 +05:30
Ankush Menat
d7bc848a52
test(semgrep): python and javascript translation
- Move rules to .github folder to reduce clutter in root folder
- separate out rules
- add tests for rules
- docs for writing more rules
2021-03-13 18:22:48 +05:30
Ankush Menat
6c2d377e74
fix: use semgrep cli instead of docker image (#12566)
CLI is more flexible at present. Until github action catches up,
switch to CLI version.

This also fixes failure from forks which don't contain semgrep config
yet.
2021-03-11 10:42:42 +05:30
Ankush Menat
a74b7b04ac
chore: add semgrep linting (#12524) 2021-03-09 12:04:09 +05:30