Commit graph

6255 commits

Author SHA1 Message Date
AarDG10
0bff72ed17 test(postgres): fix mariadb specific identifiers for postgres queries 2025-11-05 13:53:32 +05:30
AarDG10
6481d2aeba test(postgres): fix test_decimal_field_configuration for Postgres 2025-11-04 23:37:10 +05:30
Ankush Menat
6d2ca3913c
Merge pull request #34413 from AarDG10/feat-cancellable-data-import
feat: Cancel Button Added for Data Import
2025-10-30 10:42:20 +05:30
Sanket Shah
3914891ebe
fix: increase label field length to 255 chars (#34394)
* fix: increase label field length to 255 chars

Some doc field labels were getting truncated when exceeding 140 characters.

This caused issues during customization of complex forms where descriptive labels were required.

* fix: increase label field length to 255 chars

Some customize form field labels were getting truncated when exceeding 140 characters.

This caused issues during customization of complex forms where descriptive labels were required.
2025-10-28 17:06:24 +05:30
Hussain Nagaria
289391bfd3 fix: deduplicate timeline links for system-to-system emails 2025-10-27 22:48:44 +05:30
AarDG10
f750728bae feat: Cancel Button Added for Prepared Report 2025-10-24 14:46:38 +05:30
AarDG10
9f053ce5ee feat: Cancel Button Added for Data Import 2025-10-17 18:42:09 +05:30
Ankush Menat
727775f820
Merge pull request #33088 from ankush/computed_child_table
feat: Computed/virtual child-tables
2025-10-15 18:32:16 +05:30
Ankush Menat
761bcadbbe fix(UX): Hide empty session table
You can't see sessions of other users
2025-10-15 18:11:46 +05:30
Akhil Narang
79a2457f84
Merge pull request #34331 from akhilnarang/fix-2fa-toggle
fix(system_settings): don't change 2fa settings for roles unless the value actually changed
2025-10-15 11:07:34 +05:30
Sagar Vora
a93530e221 Merge branch 'develop' into computed_child_table 2025-10-14 12:53:32 +05:30
Aarol D'Souza
4ecb9bc57d
fix: clear cache and prevent data access after DocType deletion (#34307)
* fix: clear cache and prevent data access after DocType deletion

* fix: Handle potential DB failures during migrate

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2025-10-10 08:00:51 +00:00
Akhil Narang
d5648b2548
fix(system_settings): don't change 2fa settings for roles unless the value actually changed
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-10-10 11:57:30 +05:30
Sagar Vora
7307d99227 chore: fix linter issue 2025-10-09 17:30:10 +05:30
Sagar Vora
f51506d19e fix: restore NotImplemented methods 2025-10-09 17:25:52 +05:30
Dhinesh
123a7a0136
fix: check Submission Queue already exists for the record (#34094)
* fix: check Submission Queue already exists for the record

* chore: clean up msgprint statments
2025-10-09 15:32:57 +05:30
Ejaaz Khan
e7832bfd4b
Merge pull request #32684 from iamejaaz/32489-role-perm-based-masking
feat: show mask data in form, list and report view
2025-10-09 10:55:50 +05:30
Akhil Narang
3dfa9f35dc
fix: escape HTML in filename before display (#34289)
* Revert "fix: sanitize HTML in file names before saving (#34192)"

This reverts commit 0120410593.

* feat: escape file name before display

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-10-07 11:50:09 +05:30
Akhil Narang
5252d5ad47
fix(doctype): restrict length to 61 characters (#34225)
Default is 140 here, but we restrict it to 61 in the backend
(tab+name should be 64 characters max)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-10-01 06:26:40 +00:00
mergify[bot]
16058b92af
Merge branch 'develop' into 32489-role-perm-based-masking 2025-09-30 09:00:48 +00:00
Akhil Narang
0120410593
fix: sanitize HTML in file names before saving (#34192)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-29 15:55:23 +05:30
Charles-Henri Decultot
72b20fa52b
fix: HTML sanitation for XSS mitigation (#34168)
* fix: several XSS attack opportunities

* fix: linter
2025-09-29 10:39:04 +05:30
Akhil Narang
355d218f8e
Merge pull request #34162 from akhilnarang/bump-ruff
refactor(treewide): bump ruff
2025-09-26 17:44:11 +05:30
Akhil Narang
6ca4d4d167
refactor(treewide): ruff format
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-26 13:16:43 +05:30
Ejaaz Khan
80307c731b
Merge pull request #34101 from Abdeali099/grid-fixes
refactor: Enhance grid configuration
2025-09-25 11:30:12 +05:30
Corentin Forler
7743c90783
feat: Optionally show a warning when opening an external link 2025-09-24 16:53:01 +02:00
Akhil Narang
dc2422ebde
fix: don't call file.check_content() twice
This first call was sometimes done when `_content` wasn't set, resulting in:

```
  File "apps/frappe/frappe/core/doctype/file/file.py", line 138, in validate
    self.check_content()
  File "apps/frappe/frappe/core/doctype/file/file.py", line 381, in check_content
    if self.file_type == "PDF" and self._content and pdf_contains_js(self._content):
                                   ^^^^^^^^^^^^^
AttributeError: 'File' object has no attribute '_content'
```

Just calling it in `write_file()` seems good enough

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-24 18:20:09 +05:30
Abdeali Chharchhoda
0b2d0d6458 refactor: update default value for rows_threshold_for_grid_search to 20 2025-09-23 16:23:27 +05:30
Ejaaz Khan
ca67a12e0f
refactor: remove debugging statement 2025-09-22 15:05:27 +05:30
anwarpatelnoori
42c104fa76 fix: mange specific roles without saving the user doc 2025-09-21 11:43:37 +00:00
Hussain Nagaria
7dcc670ca8
Merge pull request #33899 from frappe/feat/control-decimal-width 2025-09-20 18:38:10 +05:30
Hussain Nagaria
5c280c1596 refactor: move to inline comment 2025-09-18 12:26:14 +05:30
Hussain Nagaria
7373d90691 fix: no semgrep on PIL monkey patch 2025-09-18 12:22:37 +05:30
Hussain Nagaria
e21560d237 refactor: remove unnecessary precision setting 2025-09-18 12:18:56 +05:30
Hussain Nagaria
f74c665cc2 test: precision exceeds length 2025-09-18 00:18:32 +05:30
Hussain Nagaria
de6195e12f test: length and precision for decimal based fields 2025-09-18 00:15:42 +05:30
Ejaaz Khan
54b34c9535
Merge branch 'develop' into 32489-role-perm-based-masking 2025-09-17 16:17:30 +05:30
Hussain Nagaria
c230e86e2c fix: handle length more robustly 2025-09-17 13:27:13 +05:30
Akhil Narang
36ccf32ab3
fix: don't try to scan encrypted PDFs
Also fix reversed logic of JS check

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-10 15:44:09 +05:30
barredterra
d93c177f45 chore(User Session Display): remove old boilerplate 2025-09-10 11:46:25 +02:00
barredterra
dc4c8feff5 refactor(User): rename current to is_current 2025-09-10 11:45:10 +02:00
barredterra
396114fe00 fix(User): hide Sign Out button for current session 2025-09-10 11:39:04 +02:00
Raffael Meyer
ee93a01106
Merge branch 'develop' into computed_child_table 2025-09-10 08:34:36 +02:00
Corentin Forler
64aa4787be
fix: Don't check PDF content if not defined (#33914) 2025-09-09 15:29:57 +05:30
Rahul Agrawal
c52e5157b4
feat: allow users to export report in background (#33861)
* feat: allow users to email prepared report

* fix: add export in background checkbox in export dialog

* chore: use a common function to send report email

* feat: delete generated files from system after user defined duration

* feat: add exported reports in a folder and periodically clean it

* test: add test for export via report

* fix: add exported folder path as constant

* chore: un-edit report.json

* refactor: for readability

* chore: type hint

* refactor: let the BG job fail if email fails

* refactor: consistent `report_name`

* it reads better now, e.g. attached_to_name=report_name instead of attached_to_name=title

* refactor: `return_file` to its inverse `populate_response`

* chore: more specific error message

---------

Co-authored-by: Rahul Agrawal <deathstarconsole@Rahuls-MacBook-Air.local>
Co-authored-by: Hussain Nagaria <hussainbhaitech@gmail.com>
2025-09-05 14:34:55 +00:00
Akhil Narang
60b2d92af8
fix(data_import): set payload count from existing importer
Don't create a new one, especially one that doesn't have all parameters (main issue here: console=False)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-03 17:56:41 +05:30
Akhil Narang
7ad1378d00
Merge pull request #33772 from erjeve/fix-data-import-payload-count
fix: initialize payload_count in import_file function
2025-09-03 17:10:10 +05:30
Hussain Nagaria
8f83dedbba feat: allow length change for decimal columns 2025-09-03 15:28:10 +05:30
Hussain Nagaria
dcbc397400
fix: comparison accuracy 2025-09-03 11:33:53 +05:30
Rahul Agrawal
de1249ecec refactor: extract expression into separate variable 2025-09-03 11:28:46 +05:30