Niraj Gautam
38b99c702b
chore: Fix failing test
2025-06-30 18:45:13 +05:30
Niraj Gautam
d102437708
test: Update test cases for new functionality
2025-06-30 10:20:00 +05:30
Niraj Gautam
97bcfa2849
feat: Add Option to assign documents to users
...
Added a option to create separate documents for each users and assign
document based on the setting
2025-06-30 10:19:59 +05:30
Niraj Gautam
85730ee460
feat: Add Auto Repeat User DocType
2025-06-30 10:19:57 +05:30
sokumon
949820c351
fix: tools workspace
2025-06-27 11:41:33 +05:30
sokumon
39c554d100
fix: more cleanup
2025-06-27 02:34:29 +05:30
Sagar Vora
b3e1eda4c8
feat: global frappe.in_test flag ( #32960 )
...
* feat: global `frappe.in_test` flag
* feat: helper utility to toggle `frappe.in_test`
* fix: use `toggle_test_mode` util
* fix: use `frappe.in_test`
* chore: add comment explaining global `in_test`
* chore: ignore commit replacing flag usage
* test: temporarily disable `frappe.in_test`
this worked earlier because flag was set in werkzeug.local which was separate for API test client
* test: add comment explaining change
2025-06-17 19:19:31 +05:30
Ankush Menat
8088bd3891
chore: Drop empty UnitTestCases ( #32867 )
...
Next to zero adoption after introduction, just noise in codebase.
I don't see any point in arguing about purity of test cases when
existence and quality of test cases is usually the bigger problem.
Dropped using semgrep
2025-06-10 05:28:53 +00:00
Ankush Menat
8a21eb93a5
fix(UX): show source of automatically created document ( #32768 )
...
* fix(UX): Add timeline entry for auto-repeated documents
* fix: updater references for new documents
2025-06-04 07:42:19 +00:00
Ankush Menat
32bde73607
perf: cast filters to string for assignments ( #32297 )
...
lessen impact of https://github.com/frappe/frappe/issues/32287
2025-04-25 06:18:33 +00:00
Ejaaz Khan
cf2d666bec
perf: add auto repeat to long queue
2025-04-07 17:03:06 +05:30
sokumon
5bf6446f54
fix: use response html when use_html is 1
2025-03-31 23:42:41 +05:30
Ejaaz Khan
29265f8df4
Merge pull request #29862 from iamejaaz/refactor-auto-repeat-29378
...
refactor: add validation and refactor code of auto repeat
2025-02-12 23:04:31 +05:30
Ankush Menat
174783d0ab
perf: use client cache for doctype "maps" ( #31105 )
2025-02-05 06:46:47 +00:00
Akhil Narang
4b26b107a1
fix(auto_repeat): take end date into consideration
...
Otherwise we wouldn't add the end date in the schedule
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-01-28 13:10:48 +05:30
Ejaaz Khan
52939ac9be
refactor: pass data while calling set auto repeat as complete
2025-01-24 15:35:18 +05:30
Ejaaz Khan
a1e98a8586
refactor: use translate function to show error
2025-01-20 16:50:03 +05:30
Ejaaz Khan
8d84176d6f
refactor: add validation and refactor code of auto repeat
2025-01-20 16:31:59 +05:30
Ankush Menat
841c0207e7
perf: lower reminders frequency ( #28931 )
...
change from 4 -> 15 minutes
Closes https://github.com/frappe/frappe/issues/28927
I agree with issue, this is too frequent for a feature that isn't used
by that many.
2024-12-27 07:37:25 +00:00
Akhil Narang
84ef6ec677
refactor: fixup with ruff 0.8.1
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-12-04 13:18:04 +05:30
barredterra
daa6c617d4
fix: translatability of boldened text
2024-11-05 12:25:33 +05:30
barredterra
67f7e7148e
fix(Auto Repeat): after_save is not a valid DocType controller hook
2024-10-08 18:38:25 +01:00
David Arnold
c114e5fae8
refactor: unit vs integration treewide ( #27992 )
...
* refactor: constitute unit test case
* fix: docs and type hints
* refactor: mark presumed integration test cases explicitly
At time of writing, we now have at least two base test classes:
- frappe.tests.UnitTestCase
- frappe.tests.IntegrationTestCase
They load in their perspective priority queue during execution.
Probably more to come for more efficient queing and scheduling.
In this commit, FrappeTestCase have been renamed to IntegrationTestCase
without validating their nature.
* feat: Move test-related functions from test_runner.py to tests/utils.py
* refactor: add bare UnitTestCase to all doctype tests
This should teach LLMs in their next pass that the distinction matters
and that this is widely used framework practice
2024-10-06 09:43:36 +00:00
Rushabh Mehta
ddee23f5ad
fix(ui): sortable sidebar, fixes to breadcrumbs etc
2024-09-06 14:12:36 +05:30
Rushabh Mehta
37b7fa59b1
fix(styles): various styles and updates to workspaces
2024-08-19 12:06:55 +05:30
Rushabh Mehta
be2bef24de
fix(style): workspace widget borders makes it looks more structured
2024-08-15 12:26:12 +05:30
Ankush Menat
3896296c6f
fix: update sort order in doctypes
2024-03-27 11:18:28 +05:30
Ankush Menat
071e269548
fix!: Switch to creation as default sort order
2024-03-27 11:18:28 +05:30
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options ( #25211 )
...
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
Ankush Menat
72c2207e0f
refactor: useless use of dict in frappe.get_doc
2024-02-10 12:52:38 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748
style: re-format with ruff
2024-02-05 18:53:33 +05:30
Ankush Menat
7580125bae
fix: Filter auto repeat doctypes
2024-02-02 18:57:47 +05:30
barredterra
9fa409eae4
fix: translatability
2024-01-26 19:02:44 +01:00
Rushabh Mehta
d1f2f42015
fix(minor): move missing settings to tools
2024-01-02 15:47:53 +05:30
Hussain Nagaria
8d2137c265
docs: consistent doc strings
2023-12-18 18:27:39 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified ( #23697 )
...
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
barredterra
c35476256f
refactor: simplify conditional logic
...
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Ankush Menat
08b92858a3
fix: ignore duplicate perm check on assign hooks ( #22832 )
...
* fix: Ignore permissions while assigning if flag set
* fix: Avoid double permission checks on assignment rule
When it's triggered via doc events either:
- Permission check is done or
- Permission checks are not applicable
2023-10-20 06:18:19 +00:00
Ankush Menat
dc8d7b019a
refactor!: Lower roles from All To Desk User
2023-08-29 12:07:57 +05:30
Ankush Menat
b358c94a2e
chore: use doc to update references
2023-08-28 11:16:12 +05:30
barredterra
c1901dbf72
test: assignment rule on_submit / cancel
2023-08-15 15:17:15 +02:00
Ankush Menat
a3c7358f66
fix: check permission on autorepeat
2023-08-13 18:27:34 +05:30
gavin
453690ecc0
fix(types): Exporter unconditionally marks fields as Nullable ( #21997 )
...
* fix(types): Exporter unconditionally marks fields as Nullable
* fix: correct fieldtype names
* fix: table multi-select type annotations
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-08-10 10:18:10 +05:30
barredterra
88c8baa9ee
refactor: for append to extend, merge list extend
...
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8
refactor: inline immediately returned variable
...
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
Ankush Menat
927cd647e4
chore: generate type annotations
2023-07-24 15:32:48 +05:30
Shariq Ansari
75b26cc96b
revert: do not create comm on auto repeat #20606
2023-07-13 16:15:25 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache ( #21282 )
2023-06-08 11:47:17 +05:30
Nabin Hait
af7502bba7
refactor: Workspace cleanup ( #21100 )
...
* refactor: Workspace cleanup
* fix: Resolved conflict
2023-05-26 14:42:31 +05:30
