Commit graph

211 commits

Author SHA1 Message Date
Ankush Menat
bea2df6dcc
perf: drop country_info from boot (#17431)
* fix: unknown function call

* perf: drop country_info from boot

This is ~50kb of data that is sent with every boot.
2022-07-07 14:41:13 +05:30
Ankush Menat
b5128a35fd
refactor: simplify fetching of readable records (#17417)
- remove encoding, use cstr directly
- remove falsy values by default None, empty string.
2022-07-07 14:40:59 +05:30
Ankush Menat
faf0d15c51 refactor: load country and currency info in boot
Previously this was done in ERPNext but all currency formatting
functionality depends on this, hence moved to framework. Largely
rewritten from scratch.
2022-07-04 20:29:38 +05:30
gavin
e92ead1257 refactor: Re-write queries using SubQuery 2022-05-27 17:32:37 +05:30
Himanshu
70409a3c7b
fix: set translated text to link field (#15451)
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324)
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.

Todo:

- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour

### Behaviour

- Link field loses focus: show the translated name.
- Link field is focused
    - If old value is present
        - If options **are** one of [Role, DocType]: show the translated name
        - Else: show the name (untranslated) to enable search in untranslated values
    - Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus

## Demo

### Link to UOM in a custom Item DocType

The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.

#### Before

https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov

#### After

https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov

### Link to DocType in Customize Form

The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.

#### Before

https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov

#### After

https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov

https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
2022-05-16 13:21:42 +00:00
Noah Jacob
1637e3af08 fix: linting 2022-04-12 21:06:59 +05:30
Noah Jacob
c2f2fc10e7 Merge branch develop into phone_field_control 2022-04-12 20:40:29 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Abhishek Saxena
5c8856d66e
refactor: db.sql calls to frappe.qb (#16107)
# Changes

- Introduces `subqry` class to use in where clause when there is a non-column condition. eg.
> .where(subqry(no_of_roles) == 0)
- Convert SQL queries to frappe.qb 

# Testing

Functions with query refactors
- frappe.boot.get_user_pages_or_reports() -> Same output of `get_bootinfo()` as develop
- frappe.boot.get_unseen_notes() -> Forms the same query as develop 
```sql
SELECT `name`,`title`,`content`,`notify_on_every_login`
FROM `tabNote` WHERE `notify_on_every_login`=1
AND `expire_notification_on`>'2022-03-30 01:10:53.393874'
AND (SELECT `nsb`.`user` FROM `tabNote Seen By` `nsb` WHERE `nsb`.`parent`=`tabNote`.`name`) NOT IN ('Administrator')
```
- frappe.installer._delete_doctypes() -> installed and uninsalled a dummy app to drop tables

### Not tested
- frappe.make_property_setter()
- frappe.realtime.get_pending_tasks_for_doc() [whitelist method]
- frappe.sessions.Session.start()
- frappe.twofactor.cache_2fa_data()
2022-04-12 05:07:25 +00:00
Noah Jacob
579d0643c4 Merge branch 'develop' into phone_field_control 2022-03-22 15:05:45 +05:30
Jannat Patel
55eb8eed1a fix: calling function directly from boot file 2022-03-15 09:03:37 +05:30
Suraj Shetty
5e57a9004d fix: Set value as string for property setter 2022-02-15 10:21:40 +05:30
Saqib Ansari
e2c968e255 fix: customized doctypes to show_title_field_in_link 2022-02-09 11:54:44 +05:30
Saqib Ansari
b42cc400b9 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-02-01 15:08:57 +05:30
phot0n
e716a55932 refactor(minor): move frequently_visited_links from (now deleted) post to route_history 2022-01-28 20:55:24 +05:30
Suraj Shetty
b180854766
Merge branch 'develop' into phone_field_control 2022-01-14 20:11:11 +05:30
Shariq Ansari
2efc917087
Merge branch 'develop' into wspace-new-design 2022-01-14 18:17:45 +05:30
Saqib Ansari
30ba577c0a Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-01-14 15:20:56 +05:30
Saqib Ansari
b4212ad05f refactor: setting input value for link fields 2022-01-13 18:34:41 +05:30
Rushabh Mehta
853287f49d fix: load user_info on-demand 2022-01-13 16:39:24 +05:30
Shariq Ansari
b85d5bd483 chore: renamed wspace to workspace 2022-01-12 16:21:14 +05:30
Noah Jacob
e86378f26f
Merge branch 'develop' into phone_field_control 2022-01-07 13:12:33 +05:30
Noah Jacob
eb314f2e95 chore: updated country_info.json with iso codes 2022-01-04 12:58:41 +05:30
Noah Jacob
d08a332a85 feat: Phone Field Control Type 2022-01-04 12:58:36 +05:30
Suraj Shetty
2bde93f1a1
Merge branch 'develop' into link_title_refactor 2021-12-20 11:07:10 +05:30
Saqib Ansari
ab9700d947 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2021-12-15 19:32:16 +05:30
hrwx
1f70c27e9f chore: rename timezone keys 2021-11-15 14:33:28 +00:00
hrwx
87b1e9af00 Merge branch 'develop' of github.com:frappe/frappe into multi_timezone_support 2021-11-15 14:24:59 +00:00
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
hrwx
d056beb0ef feat: show title links in Link Fields 2021-08-03 15:55:32 +05:30
shariquerik
4a05697cfe fix: Role based access to workspace 2021-07-19 11:04:12 +05:30
shariquerik
afe1dbe0f8 fix: Workspace 2.0 2021-07-06 22:05:37 +05:30
hrwx
1952920add feat: Convert datetime field values to system timezone
Co-authored-by: Sahil Khan <sahilkhan28297@gmail.com>
2021-06-15 23:28:24 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Suraj Shetty
d8c777e98c refactor: Remove unnecessary code 2021-04-30 10:43:07 +05:30
Suraj Shetty
a1190a0c4a feat: Add option to mention a group of users 2021-04-12 16:35:11 +05:30
Suraj Shetty
603018ef53
perf: Load workspace faster (#12364) 2021-02-12 19:10:44 +05:30
Rushabh Mehta
1341988530 fix(minor): homepage and tests 2021-01-01 16:54:06 +05:30
Rushabh Mehta
b2686e0623 fix(routing): removed /space from routing 2021-01-01 12:30:35 +05:30
Suraj Shetty
768586a5d6 fix: Only show system users in mentions 2020-12-18 19:06:21 +05:30
Shivam Mishra
583b506461 feat: rename workspace to space 2020-12-16 14:28:24 +05:30
Shivam Mishra
8b77346066 Merge branch 'rebrand-ui' of https://github.com/frappe/frappe into desk-enhancements 2020-12-16 13:18:48 +05:30
Rushabh Mehta
b460de8202 fix(various): route cleanups, added debounce to frappe.call and dont validate links when they are default 2020-12-10 15:15:08 +05:30
Rushabh Mehta
87cdf5334c fix(routing): even cleaner routing 2020-12-10 15:15:03 +05:30
Shivam Mishra
bd7690a9fa feat: rename desk page to workspace 2020-12-04 14:16:26 +05:30
Shivam Mishra
9d57eb4f4b chore: remove moduleview code 2020-12-04 14:16:26 +05:30
Rushabh Mehta
742860f56e
Merge pull request #11917 from rmehta/unified-desk
feat(routing): New routing style, not using hashes, also /desk -> /app
2020-11-11 17:48:55 +05:30
Rushabh Mehta
d38d9ac98e fix(patch): patch existing roles with desk_settings 2020-11-11 17:44:14 +05:30
Suraj Shetty
f608fc9516 feat: Enable desk for Website User 2020-11-11 08:50:54 +05:30
prssanna
cfceef6a5e feat: new redesign print style 2020-11-10 14:10:48 +05:30