Commit graph

2121 commits

Author SHA1 Message Date
Shariq Ansari
a8f86abbd8
refactor: Replaced blog's feedback with comment's comment_type='Like' (#17479) 2022-07-14 14:09:00 +05:30
phot0n
31c5f260d7 chore: use f-strings 2022-07-13 12:29:25 +05:30
phot0n
8b38fcb438 chore: move getting site address to GoogleOAuth 2022-07-13 12:05:46 +05:30
phot0n
484758d6e0 chore: remove additional/unnecessary set_value calls 2022-07-13 12:05:46 +05:30
phot0n
6848c93770 chore: remove GET method whitelisting from google integrations 2022-07-13 12:05:46 +05:30
phot0n
07a577af86 feat: google oauth for google emails
* used unique constraint on email_id in Email Account Doctype
2022-07-13 12:05:46 +05:30
phot0n
26dd606831 refactor: GoogleOAuth
* refactor: single callback method for google oauth
2022-07-13 12:05:46 +05:30
Suraj Shetty
3e724cd2f2 fix: Use "html.parser" to avoid additional parser dependency
- result from html.parser is fine for further processing
2022-07-06 08:31:18 +05:30
Ankush Menat
261fbfcd11
Revert "fix(doc)!: Always cast datetime, date and time fields"
Revert "fix(doc)!: Always cast datetime, date and time fields (#15891)"

This reverts commit d7789ab6ff.
2022-07-05 13:43:32 +05:30
Himanshu
d7789ab6ff
fix(doc)!: Always cast datetime, date and time fields (#15891)
### BREAKING CHANGE
#### Datetime, Date and Time fields will always be cast to respective objects in `setattr`, this will ensure uniformity while accessing the values, no more `getdate`, `get_datetime`, `to_timedelta` wrapper.
- While importing data, the framework does check for `set_only_once`.
- In normal case scenarios, this will work flawlessly since most date fields might not be set_only_once.
- But in Subscription, the date field is set to `set_only_once` and in `after_insert`, `document.save` is called, and while doing so, `set_only_once` is checked [here](1944a547f9/frappe/model/document.py (L566)).
-This works fine if the data imported is in the correct format.
- If the date's data is not in the correct format, the framework throws an error.
- for eg `06-02-2022 00:00:00 != 06-02-2022`
- fixes [Issue/#15370](https://github.com/frappe/frappe/issues/15370)

> no-docs
2022-07-05 07:07:16 +00:00
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Suraj Shetty
b0d53d93ad
Merge pull request #17264 from netchampfaris/page-builder-section-ids 2022-06-22 12:48:36 +05:30
Faris Ansari
8814041b33 fix: set web-template attr in script and style tags from web templates
Also, deduplication of styles and scripts when web_blocks jinja method is used
2022-06-21 20:42:14 +05:30
Faris Ansari
891a2c7d5b feat(PageBuilder): Section IDs
Set IDs on sections so that you can link to them using anchor tags
2022-06-21 20:03:00 +05:30
Suraj Shetty
64cc07227e refactor: Replace usage of deprecated attribute 2022-06-21 08:00:49 +05:30
Gavin D'souza
a1691784a8 chore: Drop duplicate get_frontmatter definition 2022-06-13 18:39:56 +05:30
gavin
9ce74fb6c4
Merge branch 'develop' into request-cache 2022-06-09 12:32:03 +05:30
Suraj Shetty
27b49743e3 fix: Comment tag extractor code 2022-06-09 09:22:07 +05:30
gavin
6f6ded256f
Merge pull request #17111 from gavindsouza/refactor-re
perf: Pre-compile and re-use regexp pattern
2022-06-08 15:05:59 +05:30
Jannat Patel
d9f9ef28de
fix: translatable web templates (#17086) 2022-06-08 14:48:56 +05:30
Gavin D'souza
b696fa6da5 perf: Pre-compile and re-use regexp pattern
Converted all possible usages of re.* that weren't compiling the regex
separately and re-using it. Separated out the compiled patterns as
global variables. Repetitive patterns could be made DRY-er.

Would be nicer to have all regexes in a single module so that we could
re-use better, keep track of outdated, and keep checks for possible
reDos' etc
2022-06-08 14:07:38 +05:30
gavin
44dba28159
Merge branch 'develop' into refactor-file 2022-06-08 12:43:35 +05:30
Gavin D'souza
958745fbc0 refactor(minor): Website Settings 2022-06-07 15:56:26 +05:30
Ernesto Ruiz
e925600b70
fix: link to Google Settings in Website Settings (#17083) 2022-06-06 20:13:48 +05:30
Gavin D'souza
5ec2690160 Merge branch 'develop' into refactor-file 2022-06-01 15:47:55 +05:30
Suraj Shetty
1431cb26d3 fix: Catch any expection and show proper error page
- Also, show title & message if it is defined in the exception class
2022-06-01 08:08:52 +05:30
Gavin D'souza
9bc85402f6 fix: Add splash_image to context if exists 2022-05-30 18:56:17 +05:30
gavin
f416e2a1d2 feat(website-settings): Configurable Splash Image
Configurable Splash Image option which will override app's splash_image
hook set.
2022-05-27 16:36:37 +05:30
Ankush Menat
f7610ba423
test: flaky test due to stale translation cache (#16985) 2022-05-25 15:22:30 +05:30
Rushabh Mehta
1c864159f2 fix(minor): remove top margins for headings on standard templates 2022-05-25 12:38:29 +05:30
Faris Ansari
4b13d6d7e4
fix(webform): only title on the page should be h1 (#16880)
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
2022-05-16 13:33:29 +05:30
Faris Ansari
6994cc684f fix(metatags): check if value is set for key 2022-05-11 13:28:38 +05:30
Suraj Shetty
d23b293e1e fix(webform): Only show published web forms 2022-05-09 19:22:13 +05:30
Gavin D'souza
6d96f11dd9 fix: Use BlogPosting schema for Article
Fixes https://github.com/frappe/frappe/issues/1730
2022-04-29 14:38:35 +05:30
Ankush Menat
6ac1d95584 test: fix badly written tests 2022-04-22 19:47:54 +05:30
Gavin D'souza
1d84483289 Merge branch 'develop' of github.com:frappe/frappe into refactor-file 2022-04-21 11:45:50 +05:30
Rushabh Mehta
248c3555e3 fix(minor): add error_log for failed webhooks and web pages 2022-04-20 15:16:44 +05:30
Rushabh Mehta
57a55e4225 feat(minor): Add document reference to Error Log and doc.log_error 2022-04-18 17:29:03 +05:30
Gavin D'souza
4b51b72119 Merge branch 'develop' of github.com:frappe/frappe into refactor-file 2022-04-18 17:28:56 +05:30
Suraj Shetty
3c1175ea15 fix: Directly pass link_title_doctypes instead of calling it
To avoid permission error
2022-04-15 18:41:07 +05:30
Gavin D'souza
97e911e069 Merge branch 'develop' of github.com:frappe/frappe into refactor-file 2022-04-13 10:49:26 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Rushabh Mehta
a682516f71 fix(style): minor style fixes 2022-04-08 10:38:03 +05:30
Rushabh Mehta
4c350f41a2 fix(style): minor style fixes 2022-04-08 06:37:44 +05:30
Rushabh Mehta
7ceb8fd747 fix(style): minor style fixes 2022-04-08 05:35:55 +05:30
Faris Ansari
ae335f5e1c test: spam links shouldn't render on blog post 2022-04-06 16:29:22 +05:30
Jannat Patel
7da95d4f2e fix: markdown support for section with features 2022-04-01 09:40:50 +05:30
Suraj Shetty
be3d2a9732
Merge pull request #16186 from pateljannat/discussions-component-redesign
feat: discussions component redesign
2022-03-31 16:48:29 +05:30
Jannat Patel
f571691afb fix: issue with collapsible section 2022-03-30 16:40:41 +05:30
Jannat Patel
653bb909d4
Merge branch 'develop' into discussions-component-redesign 2022-03-28 10:21:19 +05:30