Commit graph

111 commits

Author SHA1 Message Date
Suraj Shetty
3e724cd2f2 fix: Use "html.parser" to avoid additional parser dependency
- result from html.parser is fine for further processing
2022-07-06 08:31:18 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Suraj Shetty
27b49743e3 fix: Comment tag extractor code 2022-06-09 09:22:07 +05:30
Gavin D'souza
b696fa6da5 perf: Pre-compile and re-use regexp pattern
Converted all possible usages of re.* that weren't compiling the regex
separately and re-using it. Separated out the compiled patterns as
global variables. Repetitive patterns could be made DRY-er.

Would be nicer to have all regexes in a single module so that we could
re-use better, keep track of outdated, and keep checks for possible
reDos' etc
2022-06-08 14:07:38 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
barredterra
745297a49d refactor: a not in b
Search: if not ([\w\d]*?) in ([\w\d]*?)
Replace: if $1 not in $2
2022-02-21 19:54:34 +01:00
Gavin D'souza
001075f88a fix: Use lru_cache instead of cache
* Mainly because it was introduced in PY39
* Making this change beacuse I'd like to evict cold caches too
2022-02-02 13:03:38 +05:30
Ankush Menat
5c17f9ad79
Merge pull request #15661 from gavindsouza/thumbnail-for-images
fix: Thumbnail for external images (from URL)
2022-02-02 12:21:06 +05:30
Gavin D'souza
c56b5a4899 Merge branch 'develop' of github.com:frappe/frappe into thumbnail-for-images 2022-01-31 11:26:31 +05:30
Gavin D'souza
5b6ceb5543 Merge branch 'develop' of github.com:frappe/frappe into set_value-refactor 2022-01-28 18:39:12 +05:30
Gavin D'souza
51fa09c4ab Merge branch 'develop' of github.com:frappe/frappe into thumbnail-for-images 2022-01-27 18:56:58 +05:30
Gavin D'souza
de2bcb08b4 fix!: Drop six PY2 compatibility package 2022-01-27 18:28:04 +05:30
Gavin D'souza
5503e18817 chore(typing): Add typing, style fixes
This was going to be a fix at first. Until I realised it couldn't...so I
removed the changes and kept the things back that helped me debug the
issue
2022-01-27 18:27:35 +05:30
Gavin D'souza
9dbaf252f0 fix: Check if binary file in Page Renderers
* Check if binary before rendering using StaticPage resolver
* Check if not binary before rendering using TemplatePage resolver
2022-01-19 19:30:45 +05:30
barredterra
b1383df15a refactor: use is None instead of == None 2022-01-17 10:37:51 +01:00
Gavin D'souza
3052808048 fix: Don't cast to str if None or Falsy
* refactor: use get_single_value instead of set_value(blah, None, blah1)
* User.reload in test_home_page to combat what happens locally
2022-01-10 15:05:57 +05:30
Paweł Wojciechowski
a956571d41
fix: Website URL parsing function parses absolute telephone/phone tel: URLs as relative (#14568)
* Update utils.py

Fix: #14567 

tel: URLs should be parsed as absolute path

* fix: Parsing telephone/phone tel: URLs as absolute
2021-10-26 05:34:23 +00:00
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Mohammad Hasnain Mohsin Rajan
e87d22b244
perf: strain html before passing to bs4 (#13785) 2021-08-02 16:34:51 +05:30
Suraj Shetty
9ad276767f test: Reset no_cache flag 2021-06-24 13:30:11 +05:30
Suraj Shetty
468b8fbd99 fix: Remove unnecessary import 2021-06-03 11:48:49 +05:30
Suraj Shetty
2d8c6c1710 Merge branch 'develop' of https://github.com/frappe/frappe into refactor-website 2021-06-03 11:43:28 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Gavin D'souza
e8cf96d1d3 fix: Replace cmp with different logic
cmp was being used from past.builtins library since it was deprecated in
PY2. It's hard to understand behaviour of their usages, so this is an
attempt to replicate behaviour with simpler logic, making this more
readable.

Also, removed usages of iteritems and string_types, compatibility
imports
2021-05-26 13:25:01 +05:30
Suraj Shetty
ca56b21290 test: Check all cases of setting homepage 2021-05-25 15:01:20 +05:30
Suraj Shetty
86897c1808 refactor: Remove render.py and move all utility functions to utils.py
- Replace or remove all render imports
2021-05-25 10:53:35 +05:30
Suraj Shetty
5bd8010681 style: Translate string 2021-05-20 13:24:44 +05:30
Suraj Shetty
862b5320b6 refactor: Move code to appropriate files
- Delete unused resolve_route method
- move resolve_path & resolve_redirect to path_resolver
- Remove redirect.py
2021-05-20 01:29:02 +05:30
Suraj Shetty
132434cc94 refactor: Delete unused code 2021-05-20 01:23:54 +05:30
Suraj Shetty
6375818c10 fix: 404 caching 2021-05-18 21:57:20 +05:30
Suraj Shetty
c217b32fa9 fix: Add cache_html decorator to cache HTML 2021-05-18 15:41:23 +05:30
Suraj Shetty
d6a539362d style: Fix formatting issue 2021-05-18 09:13:13 +05:30
Suraj Shetty
c8d588819f refactor: Move get_sidebar_data method to utils
- Also, rename get_sidebar_data to get_sidebar_items & delete context.py
- Remove commented text
2021-05-18 09:05:02 +05:30
Suraj Shetty
c964217106 style: Fix import issues 2021-05-14 21:40:44 +05:30
Suraj Shetty
20bab0f631 refactor: Move code to appropriate places 2021-05-14 18:58:04 +05:30
Suraj Shetty
56ee6e449c refactor: Remove render method
- also, move clear cache to utils.py
2021-05-14 14:17:52 +05:30
Prssanna Desai
ff44523b04
Merge pull request #12278 from hasnain2808/fix-auto-login-redirect 2021-02-02 14:30:25 +05:30
Faris Ansari
4ffd3c1743 fix: Dont cache homepage in development 2021-01-28 23:41:18 +05:30
hasnain2808@gmail.com
7d2227dc1c fix: auto login redirect 2021-01-28 21:47:02 +05:30
Faris Ansari
ab80058d85 fix: Set og:type to website for web page 2020-09-10 15:33:50 +05:30
Rushabh Mehta
137df8290b fix(sider): fix sider issues 2020-08-17 09:41:54 +05:30
Rushabh Mehta
b0f2af0ac5 fix(tests): add tests for home page 2020-08-17 09:41:54 +05:30
Rushabh Mehta
77018fc9d6 fix(cleanup): cleanup layout of doctype, user, role, add home_page to Portal Settings, Role 2020-08-17 09:41:54 +05:30
Faris Ansari
3b09087c5b fix: Markdown content in Blog Post
`markdown` checks if the content is html, if not, converts to markdown.
This breaks when there are html tags in markdown. Instead we can
use `md_to_html` directly.
2020-07-15 14:46:39 +05:30
prafful1234
737ecae59d
feat(website): fetch email comments in issue portal (#9657)
* feat(website): fetch email comments in issue portal

* fix: deepsource issues

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>

* chore: remove unnecessary import

not sure how i missed it

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>

Co-authored-by: prafful1234 <prafful@mntechnique.com>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-03-30 12:53:21 +05:30
Faris Ansari
6b282db8a0 fix: Web View Rendering
- Extract title from h1 if it doesn't contain jinja
- Add _context_dict to context to be able to inspect it in templates
- Add inspect macro to inspect any variable
- Better defaults for controller_row template

Co-Authored-By: Suraj Shetty <surajshetty3416@gmail.com>
2020-03-24 15:12:24 +05:30
Victor Munene
06f3b7a35f return empty string if title arg is falsey 2020-03-17 08:09:50 +03:00
Faris Ansari
766e26ac5f
feat: Index all web pages for search (#7322)
* feat: Index Web Pages for search

- Walks and indexes all webpages in global_search

* test: Web Page Indexing
2019-04-26 12:41:17 +05:30
Rushabh Mehta
ae097e5139 fix: tests, check for spam comments 2019-02-07 16:35:50 +05:30
Rushabh Mehta
41d90fa6d1 BREAKING CHANGE: Comments are now handled separately from Communication and Version 2019-02-07 16:35:50 +05:30