Commit graph

226 commits

Author SHA1 Message Date
Ankush Menat
b63b00da34
fix: Commit before starting a patch (#33133)
Closes https://github.com/frappe/frappe/issues/33092
2025-06-27 11:21:28 +05:30
Sagar Vora
7660f59c31 perf(import_file): use orjson.loads 2025-06-26 17:38:16 +05:30
Sagar Vora
56c7295b8c
perf: commit only if file is imported (#33114) 2025-06-26 15:51:03 +05:30
Ejaaz Khan
cae7759df6 refactor: pass app as an argument to avoid duplicte function call 2025-04-25 14:55:07 +05:30
Hicham Dachir
381ee5682c
fix: add newline to JSON exports
Add empty line in the end of auto generate/update doctype files, in order to follow the python code style
2025-03-10 06:44:25 +00:00
Akhil Narang
1e7e83124d
fix(export_file): check paths before writing
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-01-09 14:56:10 +05:30
Akhil Narang
84ef6ec677
refactor: fixup with ruff 0.8.1
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-12-04 13:18:04 +05:30
El-Shafei H.
6c210dc9d1
fix: Replace "<br>" with "\n" (#27854) 2024-09-23 11:59:20 +05:30
Jeroen Peperkamp
806d13dbb9
fix!: sort exported customizations by name for better diffs (#26927)
* fix: sort exported customizations by name for better diffs

* fix formatting

---------

Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
2024-07-17 21:14:58 +05:30
Ankush Menat
51d41ea6df fix: Sync customization on first install if not sync_on_migrate
If not sync_on_migrate right now this code isn't doing anything :hanky:
2024-04-11 18:29:43 +05:30
Ankush Menat
9245062ed9 test: prop setter syncing 2024-04-11 18:14:56 +05:30
Ankush Menat
526ff3b576 fix!: Sync property setter instead of overriding them 2024-04-11 18:04:30 +05:30
Ankush Menat
f7c0dd66fd refactor: migrate virtual doctypes to new API 2024-03-11 18:25:05 +05:30
Ankush Menat
d6137a805c fix: better default virtual doctype template 2024-03-11 15:20:35 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
Ankush Menat
1e20820846
refactor: Indicate that weak hash functions are not usedforsecurity (#23540)
[skip ci]
2023-12-01 16:04:37 +05:30
barredterra
41b0308951 refactor: use higher level get_app_path
It's just nicer to read; less mental load.
2023-08-21 17:15:45 +02:00
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8 refactor: inline immediately returned variable
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
Sagar Vora
54be05c18e
fix(Workspace): ignore is_hidden when importing standard workspaces (#21470) 2023-06-23 21:01:22 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Gursheen Kaur Anand
49fe6e0c98
feat: patches.txt template added by default for new apps #21046 (#21070)
* Added patches.txt template in boilerplate

* test: new app patches.txt

* style: formatting

---------

Co-authored-by: Gursheen Anand <gursheen@frappe.io>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-05-24 14:47:06 +05:30
Ritwik Puri
da5f642d4c
chore: make skipped and traceback fields read_only in patch log & newline after traceback for better readability while skipping failing patches (#20961) 2023-05-10 19:36:58 +05:30
Shadrak Gurupnor
d9b2d23ec3
feat: track skipped patch with traceback (#20931)
* feat: track skipped patch with traceback

* fix: dump all the patches in patch log

* fix: check non-skipped patches

* fix: print traceback if failed && reload patch_log before migrate

* chore: dont force patch log reload

* chore: remove unnecessary checks

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-05-10 18:44:40 +05:30
Rucha Mahabal
e5b26b77db
fix(minor): typo in fixture syncing message (#20768) 2023-04-19 12:14:18 +05:30
Ankush Menat
c36dabbc63 chore: add removed message
Not sure why this was removed
2023-04-11 11:26:47 +05:30
Saurabh
26e73208d5
fix: validate if doctype exists before syncing customisations (#20598)
* fix: validate if doctype exists before syncing customisations

* refactor: rename and add default

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-04-11 11:24:03 +05:30
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
Ankush Menat
bbcc365a24
fix: use monotonic clock for timing code (#19138)
* fix: use monotonic time for timing code

`time.time()` depends on system clock which can drift away and get corrected
over time. If you're unlucky it will get corrected in your timing code
and give absurd results.

* test: dont check for status

can refresh and give wrong output

[skip ci]
2022-12-06 15:42:37 +05:30
Mohammad Hussain Nagaria
a534e7a66a
fix: Pass *args and **kwargs in db_insert boilerplate for Virtual DocType (#19018)
[skip ci]
2022-11-28 11:14:24 +05:30
Ankush Menat
1d186db6a6
fix: disable autocommit before each patch (#18307) 2022-10-06 16:08:39 +05:30
Ankush Menat
b9e757782f
fix: correct boilerplate for virtual doctypes (#18248) 2022-09-28 15:49:15 +05:30
Ankush Menat
e1253e8299 fix: remove ad-hoc maintenance mode implementation 2022-09-09 17:34:46 +05:30
Shariq Ansari
d274b56817 chore: code cleanup 2022-08-19 15:56:44 +05:30
Shariq Ansari
521102b589 fix: update public workspace name with json file 2022-08-16 18:23:23 +05:30
Gavin D'souza
598359c684 test: Reset requirements for export_doc 2022-08-09 15:57:26 +05:30
Gavin D'souza
ca1291f924 refactor: modules.utils
* indent de-indented is_virtual code block
* add typing, revert previous breaking changes
2022-08-09 13:39:23 +05:30
Gavin D'souza
624c308659 Merge branch 'develop' of github.com:frappe/frappe into modules-refactor 2022-08-08 12:27:11 +05:30
Ankush Menat
e8efd64dbc refactor!: better API contracts for virtual doctype
Current APIs implement class methods as instance method, which is
problamamtic while implementing methods. E.g. If load_from_db doesn't
like empty docname then all class method will stop working.

This change while breaking is essential for usability of virtual
doctype.
2022-07-22 14:26:02 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Ankush Menat
1e64abe9a5 fix!: meaningful error messages over KeyError 2022-05-29 13:46:48 +05:30
chillaranand
d2b63d0935 feat: Added force flag to install-app command 2022-05-11 16:18:14 +05:30
Gavin D'souza
f463d45a61 Revert "perf: Glob filesystem instead of DB reads etc"
This reverts commit c9fa6931ff.
2022-04-21 15:24:40 +05:30
Gavin D'souza
c9fa6931ff perf: Glob filesystem instead of DB reads etc
Why speak more word when less word do trick
2022-04-14 13:30:35 +05:30
Gavin D'souza
6538419e5d fix: Add return values to enable better testing ;) 2022-04-14 13:29:20 +05:30
Gavin D'souza
d7abbe0e10 refactor: frappe.modules.utils
* Simplified logic and got rid of multi-level indents
* Better error & debug messages
* Better code readability
* Optimized conditions
* Added type hints
* Refactored raw query to QB
2022-04-14 09:05:19 +05:30
Gavin D'souza
3cd047becf fix: Obey force kwarg frappe.reload_doc 2022-04-13 19:22:46 +05:30