Akhil Narang
5e5d7568fd
fix(web_form): convert title to string
...
I had a doctype where title was float so this broke
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-08-29 16:29:52 +05:30
Akhil Narang
cffcc3cf34
fix(web_form): allow deletion of an item if you have permission
...
Bulk delete via list doesn't work if you have access to only "some" documents as we don't pass docname when checking
Seems inefficient to check there, so implemented it here
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-08-29 16:29:52 +05:30
Ejaaz Khan
77dcacffc6
Merge pull request #33823 from Z4nzu/fix/webform-button-label-context
...
fix: remove context leakage from web form button labels
2025-08-29 10:09:53 +05:30
Hardik Zinzuvadiya
a49d9b2190
fix: correct translation strings in web form buttons by using double colon for context
2025-08-28 12:27:40 +00:00
Raizaaa
aa3bb0e4d7
fix: remove trailing spaces in translatable strings
2025-08-27 13:23:17 +03:00
Samar Raj
6907856ddc
feat: added wildcard support in webform_include_js hook ( #33751 )
2025-08-22 10:31:41 +00:00
Ejaaz Khan
5ff2089592
Merge pull request #33022 from maasanto/web_template_enhancement
...
fix: remove Jinja placeholder for title on web template when it is not defined
2025-07-29 12:43:29 +05:30
Soham Kulkarni
64db88228f
refactor: seperate blogs into a seperate app ( #32737 )
...
* fix: remove doctypes,workspace blocks, files
* fix: minor python tests and UI tests
* fix: remove blog post from tests
* fix: remove blogger as role for tests
* fix: add check for if doctype exists
* fix: ui test
* fix: more cleanup
* fix: cleanup comments and fix test_query
* fix: resolve conflicts
* fix: add warning and handle comments
2025-07-28 14:35:02 +05:30
mahsem
3efc476da9
fix: web_form_context_title_translation ( #33173 )
2025-07-23 18:14:33 +05:30
Venkatesh M
96e0f49df4
fix: handle None session.data in maintenance mode ( fixes #33258 )
...
- Add null check for session.data in safe_exec.py
- Add null check for session.data in base_template_page.py
- Prevents AttributeError when session.data is None during maintenance mode
2025-07-19 16:02:57 +00:00
zeel-codder
74ef86e94f
fix: replace get_last_doc with get_lazy_doc in Web Form fetch for edit
2025-07-15 00:37:53 +05:30
Soham Kulkarni
439215b91e
Merge branch 'develop' into fix/add-missing-messages-to-load-translations
2025-07-11 15:42:05 +05:30
avc
caf1065863
fix: add translatable strings for file upload dialog on webform ( #33156 )
...
* fix: add webform translatable strings
* fix: linters
2025-06-30 10:15:31 +05:30
Soham Kulkarni
e1aa789acf
Merge pull request #32971 from sokumon/newsletter-removal
...
refactor: seperate newsletter into app
2025-06-27 11:59:02 +05:30
Sagar Vora
2e5c8bea03
feat: frappe.utils.orjson_dumps
2025-06-26 17:37:51 +05:30
flaviacastro
0d58394db0
fix: add missing messages to load_translations in web form list file
2025-06-25 12:27:03 +00:00
sokumon
ec79747fa7
fix: keep utm doctypes
2025-06-20 19:01:18 +05:30
Antoine Maas
52d686f7e2
fix: hide jinja placeholder for title when no value-section with small cta
2025-06-20 09:34:02 +00:00
Antoine Maas
1daad6f7f0
fix: hide jinja placeholder for title when no value-section with image grid
2025-06-20 09:33:50 +00:00
Antoine Maas
277286ff18
fix: hide jinja placeholder for title when no value-section with image
2025-06-20 09:32:33 +00:00
Antoine Maas
2b20e93fe7
fix: hide jinja placeholder for title when no value-section with embed
2025-06-20 09:31:46 +00:00
Antoine Maas
e9c302ac0d
fix: hide jinja placeholder for title when no value-section with right image
2025-06-20 09:31:33 +00:00
Antoine Maas
a2bca73ac3
fix: hide jinja placeholder for title when no value set-hero
2025-06-20 09:27:49 +00:00
Antoine Maas
ed14fafe32
fix: hide jinja placeholder for title when no value set-section with cta
2025-06-20 09:26:58 +00:00
Antoine Maas
a96f3dc6cf
fix: hide jinja placeholder for title when no value set
2025-06-20 09:25:43 +00:00
sokumon
6be013804d
fix: remove tests utils and workspace card
2025-06-18 16:23:36 +05:30
sokumon
32a87f53d6
fix: delete newsletter related files
2025-06-18 16:23:36 +05:30
Sagar Vora
b3e1eda4c8
feat: global frappe.in_test flag ( #32960 )
...
* feat: global `frappe.in_test` flag
* feat: helper utility to toggle `frappe.in_test`
* fix: use `toggle_test_mode` util
* fix: use `frappe.in_test`
* chore: add comment explaining global `in_test`
* chore: ignore commit replacing flag usage
* test: temporarily disable `frappe.in_test`
this worked earlier because flag was set in werkzeug.local which was separate for API test client
* test: add comment explaining change
2025-06-17 19:19:31 +05:30
Sagar Vora
cb0d06455b
chore: use frappe._dev_server instead of local.dev_server
2025-06-17 12:03:08 +05:30
Ankush Menat
c02f1aa5f1
perf: Always defer web page view logs
...
Unnecessary continuous load on DB.
2025-06-13 11:25:50 +05:30
Ankush Menat
49f582ae57
perf: Use lazy doc in a lot more places
2025-06-11 09:55:45 +05:30
Ankush Menat
8088bd3891
chore: Drop empty UnitTestCases ( #32867 )
...
Next to zero adoption after introduction, just noise in codebase.
I don't see any point in arguing about purity of test cases when
existence and quality of test cases is usually the bigger problem.
Dropped using semgrep
2025-06-10 05:28:53 +00:00
Ankush Menat
f9ff807e4c
refactor: Rename get_settings -> get_single_value ( #32840 )
...
Not all single doctypes are settings, so this is better. Implicit
caching is fine, same is done for `db` APIs on singles. We *should* aim
for 100% correctness of caching implementation, especially for singles.
Thanks to @netchampfaris for the suggestion.
2025-06-09 04:20:29 +00:00
Ankush Menat
caf415f13e
feat: get_settings ( #32821 )
...
* feat: get_settings
get_cached_value doesn't work well with singles because you either need
to pass `None` or repeat doctype name... both are awekward and easy to
shoot yourself in foot with.
* refactor: Use cached settings
2025-06-06 18:34:17 +05:30
Ankush Menat
47a47a9b5d
refactor!: Change internal datastructure of db.value_cache
...
It's now a defaultdictionary of `[doctype][name/filters][fieldname]`
This allows us to implement granular clearing and improve usage of this cache.
2025-06-05 14:46:03 +05:30
Saad Chaudhary
57bb1abdeb
fix(web_form): row number column in child tables were showing the wrong title
...
* fix:Web Form Child Table: Incorrect title showing for 'row number' column #32331
* fix : code alignment with develop branch
* fix : code alignment with develop branch
---------
Co-authored-by: saadchaudhaary <saad@zirrusone.com>
2025-06-04 13:53:48 +05:30
mahsem
6e0f9b743c
fix: state_translatability ( #32533 )
2025-05-15 18:19:58 +05:30
flaviacastro
1bf0aaf8ee
chore: add webform list empty state messages to load_translations
2025-04-28 19:44:38 -03:00
Marica
2a75c27d17
fix: Show authorized private attachments in web forms ( #32177 )
2025-04-25 14:21:41 +02:00
Corentin Forler
c0d332a9b0
fix(blog): Strip tags before truncating content for intro
2025-04-22 11:01:54 +02:00
Sagar Vora
83b6231f95
chore: add type hints to whitelisted endpoints
2025-04-21 15:25:55 +05:30
Sagar Vora
4729b9dbb2
Merge pull request #32213 from sagarvora/remove-clear-sitemap
...
chore: remove method that does nothing
2025-04-19 20:32:11 +05:30
Sagar Vora
b4e0914afe
chore: remove method that does nothing
2025-04-19 20:22:02 +05:30
Sagar Vora
e08efc8a64
perf: use cached user and compile regex
2025-04-18 17:41:42 +05:30
sokumon
da1caec4a3
fix: add title if web form title is missing
2025-04-02 16:33:40 +05:30
Gavin D'souza
e9691a1b08
perf: Google Calendar
...
* Check if sync is enabled before refreshing token & shit - reduce
deletion of event times like a 1000x
* Use cached settings to avoid reading the same thing while operating
on Events or Google Calendar syncs
2025-03-17 19:11:06 +01:00
Suhail
666f8da3dc
fix: return 1 or 0 instead of boolean for is_fc_site boot data ( #31753 )
2025-03-17 06:23:29 +00:00
Rucha Mahabal
85bcc372e7
fix: skip preloading bundled assets if http_status_code is 404
...
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2025-03-15 15:27:03 +05:30
Marica
68f6f39a9e
Merge pull request #31633 from marination/web-form-translate-link-field
...
fix: Translate link fields in Webform
2025-03-13 15:46:37 +05:30
Ankush Menat
ba84768ba8
perf: Use cached redirects ( #31698 )
2025-03-13 13:50:26 +05:30
