Commit graph

2858 commits

Author SHA1 Message Date
Suraj Shetty
cefac6851e
Merge pull request #36621 from frappe/fix-empty-list-in-operator-behavior
fix!: Enhance IN/NOT IN operator handling for empty lists
2026-02-09 15:17:54 +05:30
barredterra
251189a1e2 fix: skip db changes while renaming virtual doctype 2026-02-08 17:44:04 +01:00
Safwan
1307ae33eb
fix: use system number format for currency precision (#36648)
* fix: use system number format for currency precision

* fix: remove default format
2026-02-07 06:30:00 +00:00
Sumit Jain
1d9eb802fc
feat: Enhance autoname functionality (#36827)
* feat: Enhance autoname functionality to support expression naming rules with and without dots before dashes

* style: Fix formatting issues

---------

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2026-02-07 06:22:28 +00:00
Sumit Jain
c6868b11c6 feat: Enhance IN/NOT IN operator handling for empty lists
Added logic to return appropriate criteria for empty lists in IN and NOT IN operators. An empty list with IN now returns 0 results (1=0), while NOT IN returns all results (1=1). Updated tests to verify this behavior.
2026-02-03 12:31:29 +05:30
Sagar Vora
f2a608c08d fix: allow default fields for users with select perms 2026-02-02 15:19:23 +05:30
sokumon
aeb53b3401 fix: change condition for Workspace 2026-01-28 15:41:30 +05:30
Hussain Nagaria
d5dc81cf50 Revert "fix(BaseDocument): reset name when __islocal is set"
This reverts commit 8f3710cdec19da5918e3bf25cef38be693fdc5c2.
2026-01-26 15:59:56 +05:30
Ejaaz Khan
d124305323
Merge pull request #35278 from stephenBDT/fix-virtual-childtable-fields-not-in-pdf-2
fix: virtual childtable docfields value not in pdf childtable
2026-01-24 02:01:28 +05:30
Ankush Menat
ee56afade5
refactor!: Remove UUID Utils library (#36216)
potentially minor breaking change - removal of a default dependency.

Use inbuilt `uuid` library instead of relying on third party lib.

py3.14 adds support for uuidv7, so we no longer need third party lib.
2026-01-22 11:40:11 +00:00
sokumon
1357924b05 fix: cleanup desktop icons in migrate 2026-01-21 16:51:47 +05:30
Rahul Agrawal
2df6e92c2f
fix: remove read-only field validation map_doc (#35757) 2026-01-20 22:17:12 +05:30
Hussain Nagaria
0080ee6aae
fix(BaseDocument): reset name when __islocal is set (#36080) 2026-01-19 13:42:25 +00:00
sokumon
04972a8619 fix: remove sync_user_settings from hooks 2026-01-17 19:16:06 +05:30
sokumon
8c9aa18ab5 feat: create icons when user settings are synced 2026-01-17 19:16:06 +05:30
Akhil Narang
8c5b5ecec3
Merge pull request #35775 from akhilnarang/multisql-wildcard
feat(multisql): support passing a wildcard query
2026-01-12 12:23:31 +05:30
sokumon
5c81a34cbb fix: remove orphan workspace sidebars 2026-01-12 10:35:50 +05:30
Sagar Vora
6327f4ca8a fix: specify valid rights for share query 2026-01-09 12:44:48 +05:30
Akhil Narang
8657690ef5
refactor: use wildcard to avoid duplicating some queries
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-08 18:56:05 +05:30
rohitwaghchaure
4e51d71c0b
Merge pull request #35674 from rohitwaghchaure/fixed-parse-data-too-long-error
fix: better validation message for data too long error
2026-01-06 15:11:13 +05:30
Rohit Waghchaure
f30e1e9a1c fix: better validation message for data too long error 2026-01-06 11:49:08 +05:30
Mihir Kandoi
922c1b812d
fix(document naming): customer parser should be checked before anything else (#35586) 2026-01-05 13:44:32 +05:30
Raizaaa
0a2ab6364c
fix: added 'autoname' to reserved keywords (#35473)
* fix: added 'autoname' to reserved keywords

* fix: prevent using autoname as DocField name

- Add validation for autoname in check_invalid_fieldnames()
- Treat Python keywords as reserved fieldnames

* fix: move autoname out of reserved keywords

* fix: move python keywords out of reserved keywords

* fix: skip reserved docfield name check for 'DocType'

---------

Co-authored-by: Raiza Safeel <raizasafeel@Raizas-MacBook-Air.local>
2025-12-31 12:00:49 +05:30
Soham Kulkarni
c145726f5f
Merge pull request #35539 from sokumon/cancel 2025-12-30 16:53:29 +05:30
sokumon
a235fc110b chore: add correct docs url 2025-12-30 16:43:34 +05:30
UmakanthKaspa
6bb584f725
feat: Support dynamic expressions in workflow update_value field (#34354)
* feat: add dynamic value support for workflow update_value field

* feat: add evaluate as expression checkbox to workflow states

* test: add tests for dynamic workflow update_value expression

* fix: use description field instead of sender in workflow
  tests

* chore: fix typo

---------

Co-authored-by: UmakanthKaspa <kaspaumakanth1999@gmail.com>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2025-12-30 15:58:43 +05:30
Sagar Vora
fd7aa0969b
Merge pull request #35501 from sagarvora/stricter-link-assert 2025-12-29 17:00:29 +05:30
Sagar Vora
49d33a7b3a fix: stricter link field assertion 2025-12-29 16:35:51 +05:30
Sagar Vora
fc3a85b93a fix: check perms before validating links 2025-12-29 16:08:27 +05:30
artykbasar
2739385184
fix(estimate_count): scope to site db (#35481)
* Fix large-table heuristics: scope estimate_count and guard recency

* fix(estimate_count): scope to site database

Incase some setups don't have per-db-users

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: artykbasar <artykbasar@users.noreply.github.com>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2025-12-29 14:11:34 +05:30
Tai Cai
12efd72cc9 fix(model): fix postgres compatibility in update_user_settings
In Postgres, double quotes denote identifiers. The previous LIKE clause format caused "UndefinedColumn" errors during field renaming (e.g., during HRMS installation) because the pattern was interpreted as a column name.

This change parameterizes the LIKE pattern and passes the wildcarded value as a bound parameter, ensuring compatibility with both MySQL and Postgres.
2025-12-24 11:33:42 +07:00
Akhil Narang
e859b1d312
fix: disable UP040, revert some instances to TypeAlias
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-23 13:12:04 +05:30
Akhil Narang
f7feeea0a0
fix: ruff "unsafe" fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-22 21:06:48 +05:30
Akhil Narang
8723a2b6ee
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-22 21:06:48 +05:30
Akhil Narang
3a2dcaa2de
fix(with_comment_count): handle string values
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-18 18:11:02 +05:30
Akhil Narang
c0ebc96597
feat(qb_query): expose fields like db_query
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-18 17:26:52 +05:30
sokumon
709169a538 chore: clean desktop icon controller 2025-12-18 14:20:00 +05:30
Akhil Narang
42d8cae26e
fix(meta): use raw SQL to avoid recursively querying meta in some cases
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-17 11:21:22 +05:30
Steffen Brennscheidt
d7f6f1f65c fix: virtual childtable docfields value not in pdf childtable 2025-12-16 10:10:04 +00:00
Akhil Narang
c7f5ea837a
feat: implement field masking for query builder (#35230)
* feat: implement field masking for query builder

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* fix: add series and sessions to "core doctypes" list

This is so that we don't try to query their meta
This should also resolve #35030

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-16 12:08:13 +05:30
Soham Kulkarni
c22a1937b5
Merge pull request #35067 from sokumon/remove-orphans 2025-12-10 18:01:14 +05:30
Akhil Narang
ef6a0bffc2
fix: update overloaded get_doc() signature
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-10 16:52:37 +05:30
Akhil Narang
2dcfe07ca8
refactor: make use of check_permission parameter for get_lazy_doc
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-10 16:52:26 +05:30
Akhil Narang
75b91f44ce
feat(get_lazy_doc): add in check_permission parameter
So as to avoid manually calling doc.check_permission() often

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-10 15:40:58 +05:30
Akhil Narang
bb5a94ac20
Merge pull request #35135 from akhilnarang/fix-run-doc-method
feat(get_doc): add in `check_permission` parameter
2025-12-10 15:36:27 +05:30
Akhil Narang
40ebe6b97a
feat(get_doc): add in check_permissions parameter
If a string, we'll try to check for that permission
Otherwise, we'll just check for `read`
2025-12-09 19:31:14 +05:30
sokumon
dfd5d6982d fix: create and use a file map to remove orphans 2025-12-09 17:31:20 +05:30
Akhil Narang
269471729c
feat(qb_query)!: return query object if requested
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-09 11:39:48 +05:30
sokumon
ea6a9cd76e fix: print more information in error 2025-12-08 00:43:03 +05:30
sokumon
7b32b96cfc fix: handle names with parenthesis 2025-12-07 23:09:44 +05:30