vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
44260 commits 1 branch 0 tags 587 MiB
Commit graph

3167 commits

Author SHA1 Message Date
Ankush Menat
62529f3d74
chore(telemetry): track logged errors (#23390) 
Also includes unhandled errors
 2023-11-24 04:55:12 +00:00
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup 
Drop redundant bool conversion

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-23 13:57:51 +05:30
Ankush Menat
f526054ae2
refactor: Remove usage of utcnow (#23369) 2023-11-23 13:21:27 +05:30
Ankush Menat
d715b0ad31
Merge pull request #22804 from akhilnarang/non-nullable-fields 
feat: allow setting fields as not nullable
 2023-11-20 12:46:02 +05:30
Akhil Narang
eb45da3913
feat: Allow usage of print() within safe_exec() (#23084) 
* feat(safe_exec): allow usage of `print()`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* refactor(system_console): update description to mention `print()` instead of `log()`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* feat: unconditionally add debug logs to response if present

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* chore(safe_exec): add in a test for running `print()` within safe_exec

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* fix(safe_exec): ignore warning

RestrictedPython warns us if we call `print()` don't use their `printed` variable

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* feat: store debug logs from scheduled jobs

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* fix: avoid ignoring warnings, disabled in prod anyway

* chore: remove unnecessary logging

This can be moved to level 2 when required

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-11-20 12:45:41 +05:30
Shariq Ansari
a14966c980
Merge pull request #22595 from blaggacao/fix/non-html-notifications-rendered-from-files 2023-11-18 21:06:12 +05:30
David Arnold
9228cd70f8
fix: code style 2023-11-17 09:30:53 +01:00
David Arnold
5b33608fe3
fix: shell escaping in execute_in_shell helper 2023-11-16 10:52:11 +01:00
Akhil Narang
75709eede7
feat: set a non-null value if docfield isn't set as nullable 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
David Arnold
fb6171ae34
Merge remote-tracking branch 'upstream/develop' into refactor/centralize-python-shell-interface-for-database-binaries 2023-11-13 10:01:54 +01:00
David Arnold
77b1d58428
Merge remote-tracking branch 'upstream/develop' into fix/non-html-notifications-rendered-from-files 2023-11-13 10:00:49 +01:00
Ankush Menat
c69b043527
fix: send correct username in userinfo (#23177) 2023-11-11 08:08:39 +00:00
Akhil Narang
659cbcb88f
refactor(scheduler): drop unused parameter (#23174) 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-11 11:29:12 +05:30
David Arnold
40a2daf84c
chore: give cli invocations of dbtools a dedicated interface 2023-11-09 12:14:41 +01:00
David Arnold
fe8cc7a5c2
fix: non-html notifications from files 2023-11-09 09:51:39 +01:00
Ankush Menat
0aa3b51faa fix: single global search sync 
closes https://github.com/frappe/frappe/issues/23106
 2023-11-06 20:29:16 +05:30
Ankush Menat
089985e53b feat: frappe.job local for reading job info 2023-11-04 14:06:31 +05:30
mergify[bot]
6ad2e762d3
Merge pull request #23064 from frappe/bulk-insert-search-sync 
perf(GlobalSearch): bulk insert queued items
 2023-11-03 05:10:31 +00:00
Ankush Menat
8c74d542d5 perf: don't check len before popping 
rpop is atomic and yields None when nothing is found. No need to check length.
 2023-11-03 10:20:31 +05:30
Ankush Menat
eba499a9ba refactor: misc changes 
- make internal function explicit
- dont delete keys which is immediately being replaced.
- deprecate `sync_value`
 2023-11-03 10:15:52 +05:30
18alantom
3d7ba41583 fix(sync_values): use EXCLUDED for postgres 
removing the second arg from `do_update` causes
EXCLUDE to be auto added
 2023-11-02 18:57:51 +05:30
18alantom
aa690553cf refactor: undo use of count in redis pop 
count param in rpop and lpop was introduced in 6.20
at the time of this commit we are using an older
version that does not include it
 2023-11-02 18:22:50 +05:30
18alantom
ee3776f38f refactor: move inner for to function 2023-11-02 17:02:49 +05:30
18alantom
64adf49706 refactor: use rpop count to pop in batches 
- fix: dedupe items in a batch
- fix: reassign `query` cause it does not hold state

_fkn ORMs man 🙄_
 2023-11-02 16:58:10 +05:30
18alantom
b56136ba66 refactor: add count to cache pop 2023-11-02 15:52:29 +05:30
18alantom
2742746ced perf(GlobalSearch): bulk insert queued items 
Fixes #14660
 2023-11-02 13:30:56 +05:30
Ankush Menat
db01c05eb8 fix: enforce perms on global search 2023-10-31 21:37:30 +05:30
Akhil Narang
03c88d145e
chore: print full path to backup (#22984) 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-10-30 18:04:33 +05:30
Ankush Menat
daca4dd31c chore: keep deprecated function slated for removal in future 
This is used in ERPNext.
 2023-10-30 17:31:25 +05:30
Ankush Menat
d3225a6df9
refactor: Writing multi-pdf (#22981) 
- rename variables, output -> pdf_writer
- write to in memory stream instead of disk


[skip ci]
 2023-10-30 17:26:01 +05:30
Akhil Narang
1119919971
refactor: use gzip library's compress() and decompress() methods directly 
The util methods were added for python2.7 compat, mark them as deprecated

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-10-20 21:17:35 +05:30
Ankush Menat
d1111fb189
refactor: DB dump executable logic (#22799) 2023-10-18 08:54:40 +00:00
Ankush Menat
5de126aea9
Merge pull request #22757 from frappe/fix-ci-boilerplate 
fix: add mariadb-client install step in workflow boilerplate
 2023-10-17 11:57:05 +05:30
Hussain Nagaria
f1ba76f5f7 fix: add mariadb-client install step in workflow boilerplate 2023-10-16 19:40:09 +05:30
Ankush Menat
e2714c3e1c feat: v2 error and debug log structure 2023-10-16 18:13:50 +05:30
Ankush Menat
018ed845bd refactor: defer unnecessary json-dumping of messages 
Also avoid accessing locals where interface is present like for popping last message.
 2023-10-16 18:13:50 +05:30
Ankush Menat
411819ef81 feat: v2 for message response strucutre 2023-10-16 18:13:50 +05:30
Ankush Menat
3cc2ca8fc7 test: old API messages 2023-10-16 18:13:50 +05:30
Ankush Menat
d5a21a2676 fix: rename type validation 
`None` can be passed which is acceptable here.

TODO: Make slackdict accept none as bool and convert to False
 2023-10-16 18:12:53 +05:30
Ankush Menat
e1f2f4bb54 fix: Let social login key control signups 
There are cases where certain social login keys

- Should not allow signups at all and only allow logins. E.g. social media login keys.
- Should allow signups even if global sign ups are disabled. e.g. internal SSO like setups.
 2023-10-14 12:43:48 +05:30
Akhil Narang
0be3b61aec
chore: drop usage of the deprecated distutils.version.LooseVersion 
Use `packaging.version.Version` instead

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-10-11 20:13:59 +05:30
Ankush Menat
fc16af2ac9 fix: fallback to mysqldump if mariadb-dump isn't available 2023-10-11 19:30:36 +05:30
Sambasiva Suda
7165f94148
fix: validate_email_addr should return email id as it is if it is valid (#22613) 2023-10-11 12:37:48 +05:30
Akhil Narang
091ebdd8dc
refactor(treewide): use mariadb commands directly instead of mysql (#22620) 
This has been done because the mysql command issues a deprecation warning now

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-10-10 12:49:16 +05:30
Ankush Menat
5d31667157 fix: Correct exit code for failed compressed file backup 
addresses https://github.com/frappe/press/issues/1052

Similar to https://github.com/frappe/frappe/pull/18230
 2023-09-25 23:15:11 +05:30
Ankush Menat
e9a6c4ab13 fix: user info error when name case mismatches 2023-09-23 15:26:31 +05:30
Corentin Flr
41d30e7213
feat: Add custom icons with the app_include_icons hook (#22254) 
* feat: Add custom icons with the `app_include_icons` hook

These custom icons are available on the desk only. They can be picked in the `ControlIcon` picker.

Co-authored-by: Abraham Kalungi <85731451+kalungia@users.noreply.github.com>

* fix: skip conf for including icons

* test: Fix test_include_icons

---------

Co-authored-by: Abraham Kalungi <85731451+kalungia@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
 2023-09-20 20:23:17 +05:30
Bernd Oliver Sünderhauf
67376e26d4
fix: Set system timezone for Administrator and Guest users. (#22440) 
* fix: Set system timezone for Administrator and Guest users.

* refactor: use constant instead of duplicating

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-09-20 15:26:00 +05:30
Ankush Menat
e152ebc0a3 chore: typo 2023-09-18 20:16:27 +05:30
Ankush Menat
d20e436e0f perf: fetch user info in one query 2023-09-18 11:16:20 +05:30