Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup
...
Drop redundant bool conversion
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 13:57:51 +05:30
Shariq Ansari
be4e0bbc8a
Merge pull request #23207 from rtdany10/workflow-status
...
feat: workflow state wise status override
2023-11-20 21:06:59 +05:30
Shariq Ansari
da5b723939
Merge pull request #23217 from rtdany10/workflow-docstatus-validation
...
fix(workflow): avoid implicit docstatus altering
2023-11-19 10:55:51 +05:30
Dany Robert
ee4f74913c
fix: test docstatus change from workflow
2023-11-19 03:02:30 +00:00
Shariq Ansari
d9691c579e
Merge branch 'develop' into workflow-status
2023-11-18 21:39:58 +05:30
Dany Robert
b4c0b10bff
fix(workflow): avoid implicit docstatus altering
2023-11-17 14:01:54 +00:00
Shariq Ansari
45aba69a06
fix: set default state as 0
2023-11-16 12:39:31 +05:30
Dany Robert
3f70cebf65
feat: workflow state wise status override
2023-11-13 13:00:14 +00:00
Shariq Ansari
ff5c6e3394
chore: updated workflow builder banner
2023-10-19 11:34:47 +05:30
Sambasiva Suda
53c795f4b8
fix: Workflow Builder not updating diagram with added states/transitions in table ( #22429 )
...
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
2023-10-03 17:13:51 +05:30
Ankush Menat
dc8d7b019a
refactor!: Lower roles from All To Desk User
2023-08-29 12:07:57 +05:30
Ankush Menat
2e9f779a98
fix: check workflow state field to avoid error
2023-08-28 11:02:53 +05:30
Ankush Menat
89c0c1b07b
fix: don't enqueue sendmail jobs
...
- sendmail just creates email queue, it should be done on the fly.
- if OutgoingEmailError occurs then skip all future ones.
2023-08-22 15:25:32 +05:30
gavin
453690ecc0
fix(types): Exporter unconditionally marks fields as Nullable ( #21997 )
...
* fix(types): Exporter unconditionally marks fields as Nullable
* fix: correct fieldtype names
* fix: table multi-select type annotations
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-08-10 10:18:10 +05:30
barredterra
88c8baa9ee
refactor: for append to extend, merge list extend
...
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8
refactor: inline immediately returned variable
...
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
Ankush Menat
927cd647e4
chore: generate type annotations
2023-07-24 15:32:48 +05:30
Ankush Menat
892c5e30a2
refactor: Simpler workflow caching
...
Entire document is cached, so no need to create another layer of cache.
2023-07-19 16:45:44 +05:30
Ankush Menat
d68e46d2cc
fix: disable workflow emails by default
...
make it opt-in instead.
2023-07-19 16:45:44 +05:30
Ankush Menat
58cf770760
fix: All ESLint errors
2023-07-14 15:25:48 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache ( #21282 )
2023-06-08 11:47:17 +05:30
Shariq Ansari
3736aaa26f
chore: linter fix
2023-05-10 17:36:57 +05:30
Shariq Ansari
ecc431875e
chore: updated banner text
2023-05-10 17:21:39 +05:30
Shariq Ansari
ab5570f447
chore: removed try new workflow builder button
2023-05-10 14:42:35 +05:30
Shariq Ansari
35f1c0213d
fix: dont save if state or transition is empty and is_active is set
2023-05-10 14:41:15 +05:30
Shariq Ansari
f5310e1d03
fix: wrong workflow_builder_url in existing doc's banner
2023-05-04 18:06:54 +05:30
Shariq Ansari
997f2f64fa
fix: added button on list view to open workflow builder
2023-05-03 16:22:06 +05:30
Shariq Ansari
5ad8079086
fix: added banner on workflow doc to try new workflow builder with gif
2023-05-03 16:06:27 +05:30
Shariq Ansari
9ab905c46c
fix: show state/transition data on sidebar on click
2023-05-02 20:09:47 +05:30
Shariq Ansari
f258ca09ac
fix: render states & transition by fetching workflow data
2023-05-02 17:55:46 +05:30
Shariq Ansari
96057eb632
fix: try workflow builder button in workflow doc
2023-05-01 13:31:53 +05:30
Shariq Ansari
289c774b1a
fix: workflow creating/editing dialog
2023-05-01 13:25:39 +05:30
Shariq Ansari
aa3b6d3ecc
feat: workflow builder
...
created page with vue setup
2023-05-01 13:13:27 +05:30
Sagar Vora
53c9869ce3
style: use set.isdisjoint when comparing roles (+ minor refactor)
2023-04-27 17:39:33 +05:30
Wolfram Schmidt
4a7e039b87
fix: allow renaming workflow action master ( #20698 )
...
allow to rename work flow action masters will help to consolidate and make sure that typos can be corrected at ease
2023-04-14 14:53:04 +05:30
Ankush Menat
0cab0b830d
refactor: replace imghdr with filetype ( #20680 )
...
* refactor: replace `imaghdr` with `filetype`
```
11:52:06 worker.1 | /home/ankush/benches/develop/apps/frappe/frappe/core/doctype/file/utils.py:2: DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13
```
* feat: improved extension guessing using filecontent
2023-04-13 12:19:08 +05:30
Ankush Menat
d5a9f198ec
refactor: set docfield options without method ( #20653 )
2023-04-11 18:08:19 +05:30
Andrew McLeod
b898029894
fix(workflow): add whitelisted functions permissions checks ( #20575 )
...
Add permissions checks to workflow.py whitelisted functions.
2023-04-11 14:45:35 +05:30
Raffael Meyer
d48a1c9e7c
feat: make workflow state translatable ( #20326 )
2023-03-20 21:55:08 +05:30
Leonard Goertz
6cba6753bc
fix: raise_exception=False for has_permission in filter_allowed_users ( #20113 )
...
* raise_exception=False for has_permission for workflow users
* style: format
[skip ci]
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-02-22 11:18:00 +05:30
Ahmed Hasanin
57bc2ebf57
fix(workflow): Remove docstatus field from get_workflow_state_count ( #19332 )
...
remove docstatus from get_workflow_state_count as it is not being used
and causes error with postgresql as it requires the selected column
to either appear in the group by clause or an aggregat function
[skip ci]
2022-12-19 11:50:58 +05:30
Ankush Menat
0896873c8a
test: add test role to user
2022-09-10 12:48:33 +05:30
Aradhya Tripathi
e73ae6f039
Merge branch 'develop' into get-all-mod
2022-08-19 15:42:35 +05:30
Ankush Menat
3e2d2a703a
test: Use FrappeTestCase everywhere
2022-08-17 16:39:42 +05:30
Aradhya Tripathi
0656ea9b07
Merge branch 'develop' into get-all-mod
2022-08-14 11:39:30 +05:30
Ankush Menat
40f27f908a
style: format JS files with prettier
2022-08-04 14:51:01 +05:30
Gavin D'souza
85e3ee9403
chore: Minified DocType JSON notation from old verbose notation
2022-08-03 12:22:03 +05:30
Aradhya
69089d3fd5
refactor: removed unnecesary pseudocolumns
2022-07-24 14:47:51 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features ( #17367 )
...
refactor: clean up code to py39+ supported syntax
- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes
Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
chillaranand
25f82e966c
refactor: Remove unused imports & code
2022-05-19 15:34:35 +05:30