Commit graph

5693 commits

Author SHA1 Message Date
Rutwik Hiwalkar
7b39a9bbd3
feat: add vim and emacs mode for ace-editor (#25936) 2024-04-16 11:35:58 +05:30
David Arnold
a99c4ff2b0
fix: don't sanitize defaults and options (#25939) 2024-04-15 17:39:48 +05:30
Ankush Menat
f6d003963c
fix: show warning for pending migrations (#25908)
* Revert "fix: limit title length on form (#25880)"

This reverts commit 28177c8574.

* fix: show warning for pending migrations
2024-04-11 11:51:40 +05:30
Ankush Menat
caf7aec286
feat(APIv2): Add comment via REST API (#25889)
```
POST /document/Sales Order/S0-123/add_comment
{
    text: "Comment"
}
```
2024-04-10 10:53:22 +00:00
Ankush Menat
c1bf152b89
fix: handle interface error during report timeout (#25893) 2024-04-10 06:57:36 +00:00
Ankush Menat
bef9bdc5ee
fix: log out reliability (#25865)
* fix: Avoid possible cache eviction issue

Clear cache after removing data from DB, so a concurrent request can't put stale data in cache.

* fix: explicitly login as guest after logging out

Avoids problem with some other code potentially re-adding current
session in cache or DB.

* test: avoid hard coded admin pw

* test: reset user after running tests

* fix: only login as guest if in request

Background jobs, some other user disabling someone else etc
2024-04-09 18:56:52 +05:30
Ankush Menat
9dad8b1d55
Merge pull request #21014 from BreadGenie/whats-new
feat: `What's New`
2024-04-08 19:05:30 +05:30
Ankush Menat
618c2e60a1 test: fix failing tests 2024-04-08 18:55:05 +05:30
Sanket322
9ee221bc41
fix: add before_print in doctype event (#25858) 2024-04-08 18:05:16 +05:30
Ankush Menat
c817c7f769 perf: extend scheduler jitter to weekly/monthly jobs too 2024-04-08 17:04:00 +05:30
Ankush Menat
9524413eff
fix: limit select user to desk users by default (#25843) 2024-04-08 12:20:34 +05:30
Ankush Menat
30f00fd5f3 fix: invlaid integer validations for biging
closes https://github.com/frappe/frappe/issues/25566
2024-04-06 11:04:55 +05:30
Ankush Menat
d1210f7edc
Merge pull request #25507 from GursheenK/announcement-widget-navbar
feat: navbar announcement widget
2024-04-02 22:38:52 +05:30
Ankush Menat
561617d5db
fix: allow disabling logging on CRON jobs (#25742)
Some crons are very very small duration and don't require logging
either. We should let users decide if they want to disable logging.
2024-03-30 06:21:56 +00:00
Ankush Menat
6c79a13641 feat: UUID naming support 2024-03-29 19:02:28 +05:30
Gursheen Anand
2c0498cbdd fix: use boot to store announcement 2024-03-29 16:24:41 +05:30
Ankush Menat
87d121f47a
Merge pull request #25660 from uhrjun/develop
fix: incorrect status on data import
2024-03-28 17:17:41 +05:30
Ankush Menat
9f7c385b11 fix: erase logs in case of complete failure 2024-03-28 16:59:36 +05:30
Akhil Narang
2710c28870
fix(importer): set Pending status as a fallback
Will match scenarios like success == failed == 0

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-28 15:14:56 +05:30
Ankush Menat
f22120190d fix: Correct logic for comlete success 2024-03-28 14:48:10 +05:30
Ankush Menat
7220a7d898 fix: recorder sorting with multi-col 2024-03-28 13:26:34 +05:30
Ankush Menat
0cbd7c825b
Merge pull request #25650 from akhilnarang/fix-replyto-communication-reply
fix: set correct Reply-To header for replies
2024-03-28 10:03:57 +05:30
barredterra
7426805425 fix: make ads translatable 2024-03-27 19:47:42 +01:00
Ankush Menat
2238f02cb7 Merge branch 'develop' into announcement-widget-navbar 2024-03-27 16:53:56 +05:30
Ankush Menat
432c8cf48c
Merge pull request #25624 from ankush/creation
fix!: Switch to `creation` as default sort order
2024-03-27 13:25:53 +05:30
Ankush Menat
c91ea8ccd5 fix: switch default sort for new doctypes 2024-03-27 13:15:46 +05:30
Ankush Menat
672f3b2258 refactor!: sort by creation for clearing old logs 2024-03-27 13:04:01 +05:30
Ankush Menat
3896296c6f fix: update sort order in doctypes 2024-03-27 11:18:28 +05:30
Ankush Menat
071e269548 fix!: Switch to creation as default sort order 2024-03-27 11:18:28 +05:30
barredterra
0e573fc77e feat: move languages to CSV file, add enabled property
Only enable supported laguages.
2024-03-27 00:18:36 +01:00
barredterra
9fe11241ee chore: remove old patch
No longer needed, has been there since v8. Removed so we don't have to maintain it.
2024-03-26 23:53:25 +01:00
barredterra
12fdc277f8 chore: drop unused method 2024-03-26 23:09:29 +01:00
Arjun Choudhary
f75dd9d1eb fix: incorrect status on data import
- Used to show the status as "Not Started" if a prior import session was partially successful
- `data_import_list.js` needs some rethinking just displaying the past few logs isn't super helpful
  the import logs aren't individually identifiable on that screen
- could start deleting the logs of a previously failed imported record, if it's successful on a subsequent run
  or atleast flag it to not display it

Refer to internal ticket 9486 and 12166 for further information
2024-03-26 16:54:17 +00:00
Akhil Narang
bf2472d650
fix: set sender of communication as reply-to if its a reply
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-26 18:40:43 +05:30
Ankush Menat
7f4bcf37ce
fix: check object instead of DB for amended_from field (#25645) 2024-03-26 13:11:17 +05:30
Akhil Narang
7c126f0555
Merge pull request #25610 from akhilnarang/fix-sentry-background-job
feat: drop sentry's RQ integration
2024-03-26 11:08:36 +05:30
Akhil Narang
baa5b1cb5f
fix(test): update RQ serialization test
The job name will now be the module + qualname instead of just the method name

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-26 10:53:42 +05:30
Ankush Menat
c75242cce4
Revert "fix: ensure that prepared report is set even on timeout (#25565)" (#25637)
This reverts commit 6613ed76fe.
2024-03-25 05:24:10 +00:00
Ankush Menat
54776f796b
perf: dont set defaults unless required (#25626)
On site with many signups this causes cache trashing because every
signup clears cache.
2024-03-23 14:35:56 +00:00
Akhil Narang
766d2ae778
feat: allow setting a custom rate limit for login via email link feature
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-22 15:50:45 +05:30
Nihantra C. Patel
f2561c46ef
fix: depend on condition in "Allow in Quick Entry" (#25579)
* fix: depend on condition in "Allow in Quick Entry"

* remove section break and column break from the condition
2024-03-21 23:48:55 +05:30
Ankush Menat
6613ed76fe
fix: ensure that prepared report is set even on timeout (#25565)
* fix: ensure that prepared report is set even on timeout

Under following condition prepared report is never enabled:
- Process takes too much time and is killed
- HTTP timeout

Fix:
- We spawn a thread and ask it to wait till prepared report threshold
  time is elapsed and set prepared report on it.
- Condvar is used to immdiately wake up and end the thread if report
  finsihed early.

* refactor: use threading.Timer

No need to implement it ourselves
2024-03-21 11:18:29 +00:00
Shariq Ansari
d7dbf774e7
Merge pull request #25257 from cogk/feat-default-workspace
feat(workspace): Allow user to choose a default workspace
2024-03-20 17:56:20 +05:30
Shariq Ansari
61cac70b3e chore: moved workspaces section inside settings tab 2024-03-20 17:16:33 +05:30
Corentin Flr
e3d00e9117
fix(workspace): Don't allow Welcome as default workspace
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2024-03-19 16:24:13 +01:00
Gursheen Anand
351151b0ff fix: reset announcements after saving settings 2024-03-18 14:54:36 +05:30
Gursheen Anand
88d8b6ce6c feat: announcement widget in navbar settings 2024-03-18 14:45:08 +05:30
Ankush Menat
2f87a09ad9
test: fix timeout decorator (#25489) 2024-03-16 15:59:04 +05:30
Ankush Menat
d4bb72b74f
Merge pull request #25419 from frappe/cust_form_text
fix: allow transitioning to long text
2024-03-15 18:14:10 +05:30
Ankush Menat
48c24c7c5b test: fixup timeouts
The tests were failing because they weren't able to complete in 20
seconds. Ugh!
2024-03-15 17:58:57 +05:30