Commit graph

3534 commits

Author SHA1 Message Date
Ankush Menat
a61b0f6ffe fix(UX): show title instead of name 2024-04-08 18:45:34 +05:30
Ankush Menat
6873eab7b4 refactor: move to boot
- Remove API call
- Remove notification setting, don't think we need this
2024-04-08 18:40:03 +05:30
Ankush Menat
491c995313 fix: cold start 2024-04-08 18:24:38 +05:30
Ankush Menat
82f377b6ab refactor: default changelog API 2024-04-08 18:24:38 +05:30
Ankush Menat
bd2dc42b94 perf: speed up changelog fetching
- implicit limit
- bench level cache for each app
2024-04-08 18:24:38 +05:30
Ankush Menat
d2b38666f6 refactor: fetch changelog in background once a week 2024-04-08 18:24:38 +05:30
Ankush Menat
465efe8ea6 refactor: rename variable for last date of feed 2024-04-08 18:24:35 +05:30
Ankush Menat
6a831224a1 refactor: dumb, fast changelog feed in UI 2024-04-08 17:00:46 +05:30
Ankush Menat
000f062580 refactor: better fieldname for posting_timestamp
Also index the field
2024-04-08 16:56:11 +05:30
Ankush Menat
a5eb5aa236 chore: compat changes with latest version
- change sort field
2024-04-08 16:45:51 +05:30
Ankush Menat
8d9304abbe Merge branch 'develop' into whats-new 2024-04-08 16:32:15 +05:30
Richard Case
551c8d5ef4
fix: log report errors to aid debugging (#25738) 2024-04-08 12:21:41 +05:30
Akhil Narang
c2d8ee2bbb
fix: ensure we don't try to add int and NoneType
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-03 13:58:23 +05:30
Akhil Narang
61dfbe2f9f
fix(dashboard_chart): use dict.get() to avoid a KeyError
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-03 12:44:19 +05:30
Akhil Narang
da563ef0e4
fix(event): clear message after handling exception
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-01 21:46:15 +05:30
Akhil Narang
bf931598a2
Revert "Merge pull request #25755 from akhilnarang/optional-skip-msgprint"
This reverts commit f8121b99df, reversing
changes made to 14e2d95947.
2024-04-01 21:42:12 +05:30
Akhil Narang
ca83ad580c
feat: allow skipping msgprint
If we're handling the exception on our own, we don't need to show the user anything
Example: https://github.com/frappe/frappe/blob/version-15/frappe/desk/doctype/event/event.py#L398

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-01 14:21:47 +05:30
Ankush Menat
b7bc5d3236
fix(round 3): switch to creation sorting (#25669) 2024-03-27 08:59:04 +00:00
Ankush Menat
672f3b2258 refactor!: sort by creation for clearing old logs 2024-03-27 13:04:01 +05:30
Ankush Menat
dbcf7ad30c refactor: update usage of modified everywhere 2024-03-27 11:23:13 +05:30
Ankush Menat
3896296c6f fix: update sort order in doctypes 2024-03-27 11:18:28 +05:30
Ankush Menat
071e269548 fix!: Switch to creation as default sort order 2024-03-27 11:18:28 +05:30
Ankush Menat
4f205e2942
fix: only add title field in search if it exists (#25634) 2024-03-25 05:18:07 +00:00
Ankush Menat
571ca34eca
fix: redirect after login, todo filters (#25521)
* Revert "fix: default filter setup on todo list (#25455)"

This reverts commit 396bc4102e.

* Revert "Revert "fix: default filter setup on todo list (#25455)""

This reverts commit 5e6b6997d526446760c42e7e812ceef5fe416492.

* test: wait longer for filters to apply

* fix: route redirects after login

* test: use clear_filters

* fix: don't set default filters on ToDo

This messes with previous filters logic.
2024-03-20 17:02:24 +05:30
Ankush Menat
f642b1881f fix: invalid select star expansions 2024-03-20 16:31:02 +05:30
Ankush Menat
5eca52b2c7 fix: only trim tab if it starts with tab 2024-03-20 12:29:58 +05:30
Ankush Menat
cc4e628edf fix: remove unnecessary dummy column 2024-03-20 12:29:58 +05:30
Ankush Menat
3facad0a25 fix: avoid parsing reserved keywords and simple strings 2024-03-20 12:29:58 +05:30
Ankush Menat
414b1beffd Revert "Revert "perf: cache fieldname extraction""
This reverts commit ffe84c9f9d.
2024-03-20 12:29:58 +05:30
Ankush Menat
ea193ecd48 Revert "Revert "fix: search_link fails when txt contains parentheses (#22892)""
This reverts commit c0cf13b8e8.
2024-03-20 12:29:57 +05:30
David Arnold
56f1ed4fb3
fix: exclude irrelevant regional links (#25510) 2024-03-18 18:37:43 +05:30
Kevin Shenk
396bc4102e
fix: default filter setup on todo list (#25455)
* fix: default filter setup on todo list

Since `frappe.route_options` is an empty object by default, the condition needs updated from `!frappe.route_options` to `!Object.keys(frappe.route_options).length`.

Also, `allocated_to` is a better default filter for the To Do list compared to the previous `owner` filter.

Further, this contained the only use of `page.add_sidebar_item()` in all of the current Frappe and ERPNext codebase, and that function neither makes sense or works anymore, so it should be removed.

* refactor: remove deprecated add_sidebar_item

* style: format files

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-15 09:20:54 +00:00
Ankush Menat
dbe55d4ace
perf: Avoid ordering in count query (#25451)
Order doesn't matter for count. This PR now actually makes https://github.com/frappe/frappe/pull/25348 effective
2024-03-14 15:03:27 +00:00
Ankush Menat
8e3175f3e8
fix: show attachments on notifications too (#25443) 2024-03-14 13:01:10 +00:00
Ankush Menat
f6a626c156
Merge pull request #25406 from ankush/workspace_rename
fix: handle parent rename in child workspace
2024-03-13 20:51:44 +05:30
Ankush Menat
b25fd31ba7 fix: handle parent rename in child workspace 2024-03-13 20:38:47 +05:30
Ankush Menat
65fb8dce01 fix: dont render very large reports, offer export instead 2024-03-13 18:20:21 +05:30
Sabu Siyad
f3a472b76e
fix(ux): translate onboarding step description 2024-03-13 12:08:43 +05:30
Ankush Menat
8f5fcfe406
Merge pull request #25369 from ankush/no_delete_console_log
fix!: console logs can't be deleted
2024-03-12 20:50:37 +05:30
Ankush Menat
54a2b08278 fix!: console logs can't be deleted 2024-03-12 20:38:23 +05:30
Rushabh Mehta
4963a7e2b2
Merge pull request #25357 from rmehta/fix-minor-style
fix(minor): fixed style for read-only tables and form comments
2024-03-12 15:45:16 +05:30
Rushabh Mehta
6d3af51aab fix(minor): fixed style for read-only tables and form comments 2024-03-12 15:31:08 +05:30
Ankush Menat
1fa7cc7816 fix: support child tables in count with limit 2024-03-12 13:17:31 +05:30
Ankush Menat
7e88c53aa4 perf: show estimated count on list view 2024-03-12 13:17:31 +05:30
Ankush Menat
a49fafbf8e feat: support countig till a limit
In InnoDB counting is essentially O(n) operation, it can be pretty fast
on indexes but when filters don't use any index it usually means doing a
full table scan.

Adding a limit will stop the scan as soon as that many records are
matched.
2024-03-12 13:17:28 +05:30
Ankush Menat
ae649aadf0 fix: dont add useless distinct clause
confuses query planner in some cases
2024-03-12 09:18:07 +05:30
Ankush Menat
8a3dd85503
Merge pull request #25295 from ankush/virtual-doctype-dx
fix(DX)!: virtual doctype APIs
2024-03-11 18:37:20 +05:30
Ankush Menat
4ab2ccd01f fix!: get_count accepts splatted arguments 2024-03-11 18:15:27 +05:30
Ankush Menat
a28921750d fix(DX): Avoid use of args in virtual doctype 2024-03-11 15:20:35 +05:30
Ankush Menat
bdae769c74 fix: export dashboard_chart_source only if not programatically save 2024-03-11 14:27:24 +05:30