vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
46163 commits 1 branch 0 tags 587 MiB
Commit graph

165 commits

Author SHA1 Message Date
Ankush Menat
8e3175f3e8
fix: show attachments on notifications too (#25443) 2024-03-14 13:01:10 +00:00
barredterra
10bd9a7efd fix: use communication date in timeline 
Before, we used the database creation date, which coincidentally corresponds to the real communication date in many cases.
 2024-02-13 15:36:53 +01:00
Akhil Narang
26ae0f3460
fix: ruff fixes 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
barredterra
c35476256f refactor: simplify conditional logic 
Command: `sourcery review --fix --enable de-morgan .`
 2023-12-05 11:14:41 +01:00
Ankush Menat
d20e436e0f perf: fetch user info in one query 2023-09-18 11:16:20 +05:30
Ankush Menat
8f34d6fc3e perf: docinfo 
- Dont query versions if disabled
 2023-09-17 14:16:47 +05:30
barredterra
7c38dac8ee Merge remote-tracking branch 'upstream/develop' into close-assignment-from-sidebar 2023-08-15 18:45:17 +02:00
barredterra
88c8baa9ee refactor: for append to extend, merge list extend 
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
 2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8 refactor: inline immediately returned variable 
Inline a variable to a return in the case when the
variable being declared is immediately returned
 2023-08-08 18:09:49 +02:00
Ankush Menat
201be85d88 chore: remove dead code 
https://sourcegraph.com/search?q=context:global+get_badge_info+repo:%5Egithub%5C.com/frappe/.*&patternType=standard&sm=0&groupBy=repo
 2023-08-05 11:20:27 +05:30
Raffael Meyer
011d21b4a3
refactor: docshare get_users (#21924) 2023-08-05 09:41:22 +05:30
barredterra
fbbb453138 feat: close assignment from sidebar 2023-08-04 11:47:32 +02:00
Ankush Menat
f989b83d33 perf: drop total_comments 
Can be done client side, also not used anywhere.
 2023-07-22 15:09:11 +05:30
Ankush Menat
740fe1fc91 perf: reduce 1 query in getdoc 2023-07-22 14:16:08 +05:30
Shariq Ansari
76cc712f35 fix: load 21 communications to verify load more button is required or not. 2023-07-04 12:36:53 +05:30
Shariq Ansari
9e0ed9d2a2 fix: convert string to int 2023-06-13 16:23:39 +05:30
Shariq Ansari
0e962078fe revert: temp fix to load communications 2023-06-13 16:20:07 +05:30
Ankush Menat
22149b5bff chore: increase communication limit 
This needs better fix, added temporarily
 2023-06-13 12:12:21 +05:30
Ankush Menat
8a30667a97
fix: Fetch non-cached version of Meta on Customize Form. (#21269) 
* fix: Replace meta cache when uncached meta is requested

* fix: use meta from DB on customize form

* refactor: make cached kw only, use _dev_server
 2023-06-12 14:59:42 +05:30
Ritwik Puri
47edc63170
fix: support for different delimiter for timeline email linking (#19751) 2023-02-03 11:47:38 +05:30
Raffael Meyer
e82046ef00
ci: bump isort to 5.12.0 (#19836) 
* ci: bump isort to 5.12.0

* style: remove trailing whitespace
 2023-01-30 15:11:55 +05:30
morehardik
d3d76865f7
fix: check permission before running onload hook #11774 (#19823) 
Added fix for issue wherein Document is loaded post permission check
 2023-01-29 03:01:29 +05:30
Sagar Vora
fc3ee12baf
perf: cache FormMeta directly (#18165) 
* perf: cache `FormMeta` directly

* perf: check if `dt` is table, use `db.get_value` instead of `get_all`
 2022-09-19 16:10:32 +05:30
Sagar Vora
627302d851
fix: set doctype and name in docinfo (#18088) 2022-09-12 14:18:20 +05:30
Ankush Menat
62d65aa843 perf: drop useless indexes from view log 2022-09-09 17:34:46 +05:30
Ankush Menat
7b3cc322f1
Merge pull request #17891 from ankush/misc_fixes 
perf: ~45% faster Desk first response
 2022-08-22 11:45:20 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all 
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
 2022-08-22 11:35:14 +05:30
Ankush Menat
48869d506f perf: dont order by for uniq searches 2022-08-21 17:37:40 +05:30
Ankush Menat
615f0dbcb8 Revert "refactor: desk missing doc handling" 
This reverts commit d11fdc3ca4.
 2022-07-22 19:24:34 +05:30
Ankush Menat
d11fdc3ca4 refactor: desk missing doc handling 
- reduce 1 query
- make normal and virtual doc behave in same manner
 2022-07-22 18:50:06 +05:30
Shridhar Patil
0285d4f686
fix: frappe.db.exists will always return error for virtual doctype (#17595) 
So first check whether the doctype is virutal
 2022-07-22 18:49:38 +05:30
Ankush Menat
e88bc35cae refactor: move is_virtual_doctype to relevant file 2022-07-22 14:25:48 +05:30
Ankush Menat
10da1622f4 fix: form view broken for virtual doctype 2022-07-22 14:25:48 +05:30
Ankush Menat
06ce1f33ec refactor: remove unnecessary exception handling 2022-07-04 11:59:54 +05:30
Ankush Menat
e9a9496ebc fix: duplicate tracebacks in console 2022-07-04 11:25:47 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367) 
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
 2022-07-01 11:51:05 +05:30
chillaranand
25f82e966c refactor: Remove unused imports & code 2022-05-19 15:34:35 +05:30
Ankush Menat
2fbf8c905f
fix: dont override local proxies (#16611) 2022-04-13 20:44:10 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453) 
Co-authored-by: Frappe Bot <developers@frappe.io>
 2022-04-12 10:59:25 +05:30
Nabin Hait
762aeb32f0 fix: Show assignments based on allocated todo only 2022-03-23 13:13:31 +05:30
Rushabh Mehta
dd02496dad
Merge pull request #15964 from phot0n/integer-primary-keys 
feat: integer primary keys
 2022-03-16 17:07:20 +05:30
Ankush Menat
db0925d446 fix: dont return docinfo as message 
The return was added for testability but it also becomes part of
response so response size doubles. :)
 2022-03-15 12:46:36 +05:30
phot0n
bebc8058b6 feat: integer primary keys 2022-03-11 23:46:00 +05:30
ChillarAnand
2b48c08340 fix: Fix flaky tests 2022-02-28 12:44:06 +05:30
Saqib Ansari
f63b02191d perf: cache db.get_value 2022-02-14 15:11:14 +05:30
Saqib Ansari
422e0d4461 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-02-01 22:57:22 +05:30
Ankush Menat
300031aa36 revert "refactor: get_docinfo without side effects" 
This reverts commit 79f5a6b640.
 2022-02-01 19:39:02 +05:30
Saqib Ansari
b42cc400b9 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-02-01 15:08:57 +05:30