Commit graph

36 commits

Author SHA1 Message Date
Raffael Meyer
5fce1a57c0
fix: validate fieldname in get_group_by_count (#21932)
* fix: validate fieldname in get_group_by_count

* test: call get_group_by_count with invalid field

* test: is_default_field
2023-08-06 17:33:34 +05:30
Sagar Vora
9f5a994f70 fix!: improved filter validation in Engine.get_query 2023-05-31 14:16:52 +05:30
Faris Ansari
99160cbe17 fix: refactor usage 2022-12-31 22:17:54 +05:30
Faris Ansari
726fcfdb79 refactor: qb.engine
- simplify
- qb.engine.get_query -> qb.get_query
- qb.engine.build_conditions -> qb.get_query
2022-12-25 23:19:11 +05:30
Aradhya Tripathi
ebd1d5b48c
Merge branch 'develop' into get-all-mod 2022-07-01 13:25:32 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Ankush Menat
813dcc1848
Revert "feat: Adding support to Query engine" 2022-06-29 23:30:23 +05:30
Aradhya
4af2e1e886 refactor: replaced frappe.db.query with frappe.qb.engine 2022-06-28 19:43:50 +05:30
phot0n
d018da1819 fix: use desc ordering when fetching Assigned To data 2022-06-06 22:40:58 +05:30
Gavin D'souza
91f9d61a6c refactor: Use SubQuery term instead of subqry 2022-05-30 18:47:05 +05:30
gavin
f355034e7c refactor: get_group_by_count
Refactored raw query and partial get_all building with db.query + qb
notation equivalent. Added type hints & f-strings.

Intent: This particular API (for field "assigned_to") was taking
a while to run so decided to refactor this in hopes of perf improvemnts.

Result: 50% reduction in response times :D
2022-05-27 17:31:31 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
shadrak gurupnor
6c6ff2c16d fix: overriding of owner of doc
feat: Fixed the dilemma of owner field in ToDo document
2022-01-04 13:39:16 +05:30
Aradhya-Tripathi
672ae5cd87 fix: replaced return_query with run 2021-10-23 15:36:32 +05:30
Sagar Vora
c560d67a57 fix: remove/update older whitelist calls 2021-10-18 16:47:11 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Rushabh Mehta
30a041646c feat(guest-access): Allow Guest to view, edit allowed forms, making way remove web forms 2020-12-10 15:13:51 +05:30
Prssanna Desai
5f119b33ea fix: fetch todos with status not equal to cancelled in assigned to sidebar filter (#10714)
(cherry picked from commit d682a64ebd3d2cd3d307ff06ceca7a729412dda7)
2020-06-17 09:40:19 +00:00
Himanshu Warekar
729cada2fd Merge branch 'develop' of https://github.com/frappe/frappe into force_listview_columns 2020-01-04 10:55:36 +05:30
Rucha Mahabal
86ff0a6354 fix: list view group by filter ambiguous column name 2019-11-27 14:12:44 +05:30
Himanshu Warekar
3b9e1ab6a7 Merge branch 'develop' of https://github.com/frappe/frappe into force_listview_columns 2019-11-14 10:39:57 +05:30
Shivam Mishra
47abe300c4
style: removed print statements 2019-10-27 17:32:30 +05:30
Shivam Mishra
c0d69a04c4 feat: added tests 2019-10-24 19:47:53 +05:30
Himanshu Warekar
97ae23c2a1 fix: allow overriding columns from settings 2019-10-23 15:42:24 +05:30
Rushabh Mehta
8e088cb990 fix(minor): count fix 2019-09-30 11:40:40 +05:30
Prssanna Desai
7fef3e3a4f fix: refactor by separating html from business logic 2019-07-04 16:42:12 +05:30
Prssanna Desai
20e5e6c151 fiix: add search to dropdowns and move tags to dropdown 2019-07-04 16:42:12 +05:30
Prssanna Desai
c12f4bc099 feat(Sidebar): Add group by to list sidebar 2019-07-04 16:42:12 +05:30
Prssanna Desai
85fb946392 fix(Assigned To): fix "Assigned To" query for postgres (#7154) 2019-03-28 18:29:12 +05:30
Prssanna Desai
3725ebf7c3 fix: Wrap quotes around columns and column names in query 2019-03-27 22:41:02 +05:30
Prssanna Desai
8a4bfb1429 Improve query for assignment count and add test 2019-03-27 22:41:02 +05:30
Prssanna Desai
7a81f26780 fix: Improve query for assignment count 2019-03-27 22:41:02 +05:30
Prssanna Desai
a43d89db82 fix: Improvements to "Assigned To" dropdown 2019-03-27 22:41:02 +05:30
Prssanna Desai
e5eade2fa1 feat(Sidebar): Add "Assigned To" Dropdown 2019-03-13 11:59:47 +05:30
Aditya Hase
ad65471d06 feat(desk): List View Settings 2019-03-06 19:30:39 +05:30