Ankush Menat
1ff7b84140
fix: wrap read_only functions correctly ( #25018 )
...
`functools.wraps` preserves signature useful for introspection.
2024-02-22 11:16:15 +00:00
Akhil Narang
aa38d9e2f4
refactor: pipeline wherever possible, optimize calls
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-19 14:28:35 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748
style: re-format with ruff
2024-02-05 18:53:33 +05:30
Ankush Menat
7487df22c9
refactor: use frappe.get_system_settings
...
because it's cached and doesn't hit frappe.db at all.
2024-02-02 18:43:43 +05:30
Anand Baburajan
5004374ecc
chore: handle invalid connections conf for internal links ( #22486 )
...
* chore: handle invalid connections conf for internal links
* chore: remove unnecessary None
2023-09-20 11:14:51 +00:00
anandbaburajan
1dc7a3705b
fix: separate internal_and_external_links from internal_links
2023-09-05 21:41:43 +05:30
Ankush Menat
58568115a9
Merge pull request #21955 from barredterra/refactor-with-sourcery
...
refactor: run sourcery on all files
2023-08-10 10:11:20 +05:30
barredterra
b553ed98d8
refactor: inline immediately returned variable
...
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
anandbaburajan
480ef5076d
chore: rename links_count_data to count, and update docstring of get_open_count
...
(cherry picked from commit 97a57966116a7ef9bd542d34e63448edab8befda)
2023-08-02 03:21:39 +00:00
anandbaburajan
2f2524fa4e
chore: add missing get
...
(cherry picked from commit e0137fdb79de4e07897ae0b1a04e48e0aafa96d2)
2023-08-02 03:21:39 +00:00
anandbaburajan
61e0b6c00e
test: remove ui tests and add server tests, and turn dev mode off
...
(cherry picked from commit 82390164c99e7d0d4615ab2ea8d726f96d65f02d)
2023-08-02 03:21:38 +00:00
anandbaburajan
d0b07ff314
refactor: dashboard.js and get_open_count
...
(cherry picked from commit eff4800cc303c73a4d6ae0d26186e00598c4618c)
2023-08-02 03:21:38 +00:00
anandbaburajan
2af1a8f65c
fix: allow cross child table links in dashboard
...
(cherry picked from commit d29b151fcdf77bb8d45518c027d6d49b2eb0f9ad)
2023-08-02 03:21:35 +00:00
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache ( #21282 )
2023-06-08 11:47:17 +05:30
Gavin D'souza
01fdb6a241
chore: Remove unused realtime updates
...
These events were added for supporting listeners in desk. The listeners
have thus been removed and these are now unnecessary messages published
to anyone landing on Frappe pages or on Desk.
2022-11-15 13:12:51 +05:30
Nabin Hait
53c22b0493
feat: Enable mentions and notify users from any text field
2022-07-22 15:26:37 +05:30
Gavin D'souza
c16bec3407
chore: Simplify get_open_count doc usage
2022-05-10 15:00:52 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black ( #16453 )
...
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Ankush Menat
af4ce8156d
fix: remove mutable defaults ( #14597 )
...
* fix: mutable defaults
* fix: missing defaults
2021-10-28 09:36:31 +00:00
Gavin D'souza
3446026555
chore: Update header: license.txt => LICENSE
...
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
e407b78506
chore: Drop dead and deprecated code
...
* Remove six for PY2 compatability since our dependencies are not, PY2
is legacy.
* Removed usages of utils from future/past libraries since they are
deprecated. This includes 'from __future__ ...' and 'from past...'
statements.
* Removed compatibility imports for PY2, switched from six imports to
standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
SDLyu
cd4ae61220
Fix bug dict has no attribute of fieldname
2020-06-06 09:42:17 +08:00
prssanna
dae9eb5a2a
fix: don't get filters if string type
2020-05-14 19:32:01 +05:30
Suraj Shetty
c3519b5a12
fix: Do not check for module for custom doctypes ( #10081 )
2020-04-24 10:31:08 +05:30
Suraj Shetty
e3dfbf4562
fix: Get guest's config if session.user is None
2019-12-23 07:49:16 +05:30
Suraj Shetty
6b91ed22e4
fix: Remove unwanted print statement
2019-12-23 07:48:15 +05:30
Suraj Shetty
da09ef5fe5
fix: Return empty dict if session is not created
2019-12-23 07:48:15 +05:30
Rushabh Mehta
0c77540ed4
fix(ux): added dropdown in print layout to avoid linebreak and fix for login
2019-11-07 15:07:56 +05:30
Rushabh Mehta
8d4610504a
fix(notifications): login, logout notifications
2019-11-07 12:14:09 +05:30
Aditya Hase
2fd835803a
perf(notifications): Let database do the counting
2019-10-23 23:00:03 +05:30
Faris Ansari
4e8b9d1e21
fix: pass method without calling
2019-10-21 13:25:13 +05:30
Faris Ansari
3ceb0ea4d7
fix: cleanup
2019-10-21 13:15:55 +05:30
prssanna
75b624e7a2
fix: move notifications to desk, refactor notifications.js
2019-10-09 16:23:26 +05:30
prssanna
4833c04609
fix: email notifications sent only if notifications enabled and remove unused imports
2019-10-09 16:22:57 +05:30
prssanna
fc38664fe7
fix: formatting
2019-10-09 16:22:57 +05:30
prssanna
730d9d91cf
fix: remove unused imports
2019-10-09 16:22:57 +05:30
prssanna
f44cec60b4
fix: remove unused notifications code from toolbar.js
2019-10-09 16:22:57 +05:30
prssanna
2073fd1f91
fix: remove notifications code
2019-10-09 16:22:57 +05:30
prssanna
bae5049683
feat(Notifications): Add integrated notifications
2019-10-09 16:22:57 +05:30
Himanshu Warekar
a5e327216a
fix: could not find row fix
2019-09-07 11:32:00 +05:30
Sagar Vora
17b20b22a3
Merge branch 'master' into develop
2019-02-12 16:31:54 +05:30
Faris Ansari
850e9e6d0b
fix: Skip get_open_count during migrate or install
2019-02-11 18:41:11 +05:30
Sagar Vora
ef82f39f99
Merge branch 'staging' into develop
2019-01-29 18:24:11 +05:30
Chinmay Pai
3250553738
fix(notifications): ignore mysql internal error 1684 for concurrent ddl statements ( #6826 )
...
apparently this occurs when get_notifcations is called, and at the same time, a table is being modified. to fix this, we just skip the table that is currently being modified.
Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
2019-01-25 11:19:17 +05:30
Saurabh
97152b5a1e
fix: return empty dict if setup wizard is not completed ( #6830 )
2019-01-25 10:22:13 +05:30
Saurabh
14911900c8
fix: return empty dict if site is in installation state or setup wiz not completed
2019-01-24 19:56:03 +05:30
Faris Ansari
75f8847ad4
fix: Skip get_notifications before setup_complete ( #6828 )
2019-01-24 19:15:49 +05:30
Saurabh
2de5dfdbb3
Merge branch 'staging' into develop
2018-12-18 10:20:24 +05:30
Saurabh
52073a2b59
[minor][fix] get_notifications_for_doctypes ( #6634 )
2018-12-17 16:06:56 +05:30