Commit graph

206 commits

Author SHA1 Message Date
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Rucha Mahabal
04de8b2271 fix(setup wizard): skip user creation if email is not provided
- user setup slide is not shown if developer mode is enabled
2024-01-23 12:26:43 +05:30
Rucha Mahabal
53c5383f52 chore: silence semgrep warnings for overusing args 2024-01-15 16:02:15 +05:30
Rucha Mahabal
49bbd0d1d7 fix(setup wizard): allow setting user password for an existing user 2024-01-11 14:42:38 +05:30
Ankush Menat
9620a3c596 Merge branch 'develop' into po-translation 2024-01-10 16:17:47 +05:30
Ankush Menat
8a7707e3fa
fix(DX): store tracebacks with context (#24059) 2024-01-01 07:16:47 +00:00
Ankush Menat
1ae79badf7 fix: only set change listener if available 2023-12-28 19:11:12 +05:30
barredterra
3a76fb2253 feat: support CSV and gettext at the same time 2023-12-26 19:13:10 +01:00
barredterra
d384bb4506 Merge remote-tracking branch 'upstream/develop' into po-translation 2023-12-26 16:45:05 +01:00
Shariq Ansari
fc13ff5f29 chore: minor fix 2023-12-23 11:39:39 +05:30
mahsem
551aaafefc
fix: update setup_wizard.py translation (#23583)
* Update setup_wizard.py translation

Import frappe _  and translate some untranslated strings

* style: format

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-04 18:23:09 +05:30
Ankush Menat
91cebdace8 Merge branch 'develop' into po-translation 2023-12-02 19:43:32 +05:30
Ankush Menat
1d5d06e924
Merge pull request #23418 from akhilnarang/return-traceback-for-setupwizard-failure
fix(setup_wizard): don't suppress original exception
2023-11-27 11:51:40 +05:30
Akhil Narang
db3ffaf658
refactor: check for last response error
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 18:25:31 +05:30
Akhil Narang
d48c3f5f60
refactor: return message in response as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 18:25:07 +05:30
Akhil Narang
461f479b45
feat(setup_wizard): store error in error log as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:43:44 +05:30
Akhil Narang
9aec553b89
fix(setup_wizard): sync password character limit with other places (#23419)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:26:34 +05:30
Akhil Narang
838a49ebc2
fix(setup_wizard): don't suppress original exception
Raise it so that the user can know what went wrong

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:13:34 +05:30
barredterra
67404e0cd0 Merge branch 'develop' into po-translation 2023-11-06 19:40:25 +01:00
Ankush Menat
86e4a3a6e1 fix: Respect "Do Not Track" settings
Don't offer telemetry as option if DNT is set in browser.

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/doNotTrack
2023-11-01 15:07:27 +05:30
barredterra
c38ff0e83f feat: optionally use gettext for translation 2023-10-29 15:32:01 +01:00
Bernd Oliver Sünderhauf
67376e26d4
fix: Set system timezone for Administrator and Guest users. (#22440)
* fix: Set system timezone for Administrator and Guest users.

* refactor: use constant instead of duplicating

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 15:26:00 +05:30
Ankush Menat
1b406edd54 feat: Desk User role 2023-08-28 22:31:23 +05:30
Ankush Menat
3c991d86fc chore: remove whitelisting
not required
2023-08-24 19:10:03 +05:30
Ankush Menat
a9d7b99429
feat(telemetry): allow users to send session recording (#22170) 2023-08-23 20:58:07 +05:30
Ankush Menat
66ea947ae6 fix: clear system settings cache explicitly 2023-08-18 17:48:22 +05:30
Ankush Menat
8ec5a8e84b refactor: Add all roles while creating new user 2023-08-18 17:48:14 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
Maharshi Patel
6b7f815a75
fix: guess_country backward timezone issue for india. (#21849)
* fix: guess_country backward timezone issue for india.

In some cases ( mac ) where Asia/Calcutta is used as timezone. guessing didn't work.

* refactor: make tz backward compatbility extensible

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-07-28 18:13:22 +05:30
Ankush Menat
58cf770760 fix: All ESLint errors 2023-07-14 15:25:48 +05:30
Corentin Flr
e8a57c63ce
fix(setup_wizard): Don't send headers when exception happens on command line (#21641)
Co-authored-by: Corentin Forler <8860073-cforler_dokos@users.noreply.gitlab.com>
2023-07-11 18:41:13 +05:30
Ankush Menat
1a7cb47826 fix: setup wizard auto completes when clickin on autocomplete fields
closes https://github.com/frappe/frappe/issues/15693
2023-07-02 12:50:43 +05:30
Ankush Menat
ee4c66ecf1 feat(UX): Guess country from system_timezone
This is accurate enough for vast majority of countries.
Alternate is using GeoIP and making network calls.
2023-07-02 12:31:18 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Ankush Menat
4ab98b998d
fix: setup wizard recursion in routing (#21101)
- setup wizard shows slide from index in route
- if you visit `/app/setup-wizard` then index in route is `undefined`
- because of hacky code we do `id + ''` so `undefined` becomes `"undefined"` a truthy value

The recursion of undefined > 0 > undefined > 0 continues until browser
intervenes and stops further routing.
2023-05-24 17:43:51 +05:30
Ankush Menat
c643d4a33c chore: capitalization 2023-05-22 16:15:53 +05:30
Ankush Menat
9f83ead7a2 fix: remove setup_complete events
This can trigger along side actual setup complete event causing two
parallel requests.
2023-05-22 14:48:19 +05:30
Ankush Menat
97959d7b88
fix: validate email on setup wizard (#20979)
* chore: remove unused gravatar code

* fix: Check invalid field in setup wizard

* chore: typo

---------

Co-authored-by: Michelle Alva <50285544+michellealva@users.noreply.github.com>
2023-05-14 19:16:31 +05:30
Ankush Menat
93c326b971 feat: let user opt out of telemetry from setup 2023-04-25 14:46:53 +05:30
Ankush Menat
f63c420798 feat: add python posthog library 2023-04-25 13:10:14 +05:30
Ankush Menat
6c3f29efe7 feat: setup wizard progress telemetry 2023-04-25 11:54:56 +05:30
Ankush Menat
709edf1f55 fix: Make corrected bankers rounding default method 2023-03-13 13:10:51 +05:30
Deepesh Garg
0f5d17663d
fix: Remove setup wizard user image (#19601) 2023-01-16 16:44:04 +05:30
Ankush Menat
e00023deb1 refactor: replace bad usage of db.set_value 2023-01-04 11:13:53 +05:30
Ankush Menat
56920e409a
perf: send all translations for setup wizard (#18226)
Computing all translations is far slower than just sending everything.
This is how boot works too.
2022-09-26 17:50:49 +05:30
Ankush Menat
40f27f908a style: format JS files with prettier 2022-08-04 14:51:01 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Ankush Menat
eac73f6765
fix: better error logging for setup exceptions (#17096)
fix: better error loggin for setup failure
2022-06-07 19:05:30 +05:30
Ankush Menat
359c7768f5 fix: multiple postgres transaction abort issues
- wrap setup fixtures in savepoint
- wrap scheduled_job_type in savepoint
- ignore duplicates where it's ignored by exc
- dont attempt to delete from deleted table
- delete custom field and commit - stale meta causes future inserts to
  insert unknown field.
2022-06-05 00:26:15 +05:30
chillaranand
25f82e966c refactor: Remove unused imports & code 2022-05-19 15:34:35 +05:30