Commit graph

287 commits

Author SHA1 Message Date
Richard Case
551c8d5ef4
fix: log report errors to aid debugging (#25738) 2024-04-08 12:21:41 +05:30
Ankush Menat
65fb8dce01 fix: dont render very large reports, offer export instead 2024-03-13 18:20:21 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Ankush Menat
12bbfd24e6
fix: Show proper error message for prepared report failure (#24733) 2024-02-05 05:49:23 +00:00
Ankush Menat
0fd6f5eed7
Merge pull request #23827 from frappe/api-docs
docs: add Python API missing docstrings / type hints
2023-12-21 12:13:05 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
Gursheen Anand
806708650c chore: linter issue 2023-12-18 12:15:51 +05:30
Gursheen Anand
4a7c60fb5a refactor: use simple condition for filter values 2023-12-15 17:02:09 +05:30
Gursheen Anand
54d3679b9d fix: format filters with multiple values 2023-12-01 13:07:39 +05:30
Gursheen Anand
8a4d85a5ad fix: parse applied filter json before building data 2023-11-30 15:07:30 +05:30
Gursheen Anand
a52d1870dc feat: add filter values while building report xlsx data 2023-11-09 12:09:42 +05:30
ruthra kumar
f6d9069fb1 fix: keyerror on reports with subtotal 2023-10-08 17:22:29 +05:30
Shariq Ansari
9bafe1f558
Merge pull request #22408 from RitvikSardana/develop-ritvik-add-column-fix 2023-09-26 12:30:10 +05:30
RitvikSardana
7ae5ffca19 chore: code cleanup 2023-09-18 18:24:43 +05:30
Shariq Ansari
afd323ef23 fix: return report if not custom report 2023-09-15 15:18:23 +05:30
RitvikSardana
4bbed3287e chore: code cleanup 2023-09-15 12:19:21 +05:30
RitvikSardana
d3178527b3 fix: works for multiple rows now after saving 2023-09-14 13:23:00 +05:30
RitvikSardana
985b9a4ac4 fix: fixed the conflict between fieldname in General Ledger Report 2023-09-14 11:32:31 +05:30
Shariq Ansari
ac0e2a29c2 fix: nested custom reports filter not rendering 2023-09-12 20:08:38 +05:30
ruthra kumar
9cdb56ee5e fix: key error on link_field 2023-09-06 13:47:59 +05:30
ruthra kumar
8605cd2129
fix: attribute error on old custom reports (#22286) 2023-09-02 09:54:14 +05:30
ruthra kumar
2249751e43
fix: attribute error on custom reports (#22281) 2023-09-01 20:50:34 +05:30
Ankush Menat
487d9fb61f
chore: use isinstance 2023-08-29 22:02:52 +05:30
ruthra kumar
cf24c46128 refactor: filter on names while fetching custom fields
post https://github.com/frappe/frappe/pull/22133, `link_field` should
be a dict to facilitate passing primary key `name` for filtering

query_report.py has been modified to be backward compatible with old
`str` type link_field as well
2023-08-29 20:49:09 +05:30
ruthra kumar
b0ed1735c2 fix: typerror on custom reports 2023-08-29 15:48:39 +05:30
ruthra kumar
08d5b59778
refactor: filter on name while fetching custom column (#22133) 2023-08-21 15:05:10 +05:30
Deepesh Garg
112836dcd7
chore: Provision to ignore prepared report via route options (#22077) 2023-08-16 20:18:57 +05:30
barredterra
b553ed98d8 refactor: inline immediately returned variable
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
Ankush Menat
ae0edd85fe perf: Faster report exporting logic (#21415)
* perf: Faster report exports to Excel

Try exporting report with 100K rows, most likely it fails or takes a really long time.

Root causes:
- visible_idx was a list, lookups are SLOW AF when lists grow to 100k+
- visible_idx check is not required when I am exporting entire report.

Test with 85,000 rows.

|         | Before | After | Improvement |
| ---     | ---    | ---   | ---         |
| Export  | 25.99  | 0.77  | ~33x faster |
2023-06-17 21:07:59 +05:30
Shariq Ansari
428eaf6a16
chore: linter fix 2023-06-08 16:52:24 +05:30
Vimal Patel
48b9128904 fix: remove redundant prepare_filter method 2023-06-08 11:26:22 +01:00
Vimal Patel
0d729e5e47 fix: New Dashboard Chart throws TypeError: format requires a mapping
closes #21250

backport version-14-hotfix
2023-06-08 11:18:44 +01:00
Vimal Patel
70944cabb3 fix: New Dashboard Chart throws TypeError: format requires a mapping
closes #21250
2023-06-08 11:11:33 +01:00
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
anandbaburajan
348f852792 fix: custom filters while exporting and creating new auto email reports 2023-05-10 19:08:01 +05:30
Anand Baburajan
b62bb8b0ec
fix: allow filter values to be saved in custom report (#20623) 2023-04-13 17:42:21 +05:30
Smit Vora
08732e50db
fix: better permission error for query_report (#20643) 2023-04-11 11:42:18 +05:30
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
ruthra kumar
90a4c93bf9
fix: attribute error on export of reports with additional columns (#19105) 2022-12-05 15:03:10 +05:30
phot0n
a69c82e06c feat(minor): option to show charts, total_row with prepared reports 2022-11-29 13:46:11 +05:30
phot0n
bf132ab2a8 fix: use doc.get to check if columns field exists or not 2022-11-29 13:46:11 +05:30
phot0n
18d48ddeb8 refactor: cleanup peprared result render and old logs cleanup
* directly fetch columns from result file rather than storing it in db
* remove prepared report settings from system settings
* remove disable_prepared_report from report doctype
2022-11-29 13:46:11 +05:30
phot0n
4fe8eadf5e refactor: remove unnecessary fields from prepared report
* removed ref_report_doctype
* changed title_field from ref_report_doctype to report_name (both are same)
* changed report_name field to link type
* changed autonaming to hash based
* added status in list view via document states
2022-11-29 13:46:11 +05:30
phot0n
9bfc43c148 fix: use after_insert hook for enqueuing report generation
this removes the need of additionally calling enqueue_report method

* enqueue report in long queue
* reduce the timeout from 100 mins to 30 mins
2022-11-29 13:46:11 +05:30
barredterra
d70e5e73e2 refactor: extract common methods 2022-11-26 20:00:58 +01:00
Raffael Meyer
cca25174ab
Merge branch 'develop' into csv-params 2022-11-14 12:38:51 +01:00
Raffael Meyer
09d35c74eb
fix: remove redundant translation (#18775) 2022-11-06 17:27:02 +05:30
barredterra
62d68a8be6 refactor: reuse functions from reportview 2022-10-29 18:07:51 +02:00