barredterra
a28c5cd724
refactor: receive email
2024-04-05 17:43:16 +02:00
barredterra
e854b7ba5d
Merge remote-tracking branch 'upstream/develop' into filter-email-recipients
2024-03-31 00:01:09 +01:00
Ankush Menat
0cbd7c825b
Merge pull request #25650 from akhilnarang/fix-replyto-communication-reply
...
fix: set correct Reply-To header for replies
2024-03-28 10:03:57 +05:30
Ankush Menat
67bcda333e
fix: auto add modified index when sort_field is set to it ( #25686 )
...
This is 2nd most common sort order, so we should support adding index
for it automatically.
Not quite sure on generalizing this behaviour *YET*
2024-03-27 14:40:26 +00:00
Ankush Menat
85f66c083e
fix: preserve original error message ( #25682 )
2024-03-27 13:13:49 +00:00
Ankush Menat
59b95a4d19
fix: invalid filter on email acccount ( #25674 )
2024-03-27 11:09:59 +00:00
Ankush Menat
672f3b2258
refactor!: sort by creation for clearing old logs
2024-03-27 13:04:01 +05:30
Ankush Menat
3896296c6f
fix: update sort order in doctypes
2024-03-27 11:18:28 +05:30
Akhil Narang
19fcaff098
fix: miscellaneous cleanup
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-26 18:40:43 +05:30
barredterra
3730dfa44e
feat: add option to filter email recipients
2024-03-20 00:44:22 +01:00
Ankush Menat
fdd74e3ac1
fix: set sane default timeout on SMTP
2024-03-18 19:19:32 +05:30
Ankush Menat
e76c29fcec
feat: Store printed PDF attachments on communication ( #25439 )
2024-03-14 11:45:03 +00:00
Akhil Narang
c441c844f9
fix(auto_email_report): check if column (docfield) parent is a child table ( #25335 )
...
This code tried to fetch the child doctype with the parent's ID otherwise
Support ticket 11145
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-11 19:34:53 +05:30
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options ( #25211 )
...
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
David Arnold
c66d35fe5b
fix(notification): ensure outgoing mail is set on comms ( #24814 )
2024-02-27 16:47:46 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
Ankush Menat
59f8e361a5
fix: lower socket timeout for validating email domain ( #24915 )
2024-02-18 14:21:29 +00:00
Raffael Meyer
fc64e8a0fb
feat: pass doctype as context when translating label ( #24903 )
2024-02-18 19:42:15 +05:30
Ankush Menat
72c2207e0f
refactor: useless use of dict in frappe.get_doc
2024-02-10 12:52:38 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748
style: re-format with ruff
2024-02-05 18:53:33 +05:30
bhavesh95863
dc6d71e84b
fix: no of rows displayed based on report type
...
(cherry picked from commit db4d36f527ace8f4a678ebe39daceaa9f9579a73)
2024-02-05 05:57:20 +00:00
mergify[bot]
21d7cbca41
Merge pull request #24570 from Govind-Jangid/feat/auto-email-report-get-first-day
...
feat: use_first_day_of_period
2024-02-03 06:17:59 +00:00
Govind Jangid
492584db93
fix: date format & pre commit test
2024-02-03 06:36:19 +05:30
Ankush Menat
7487df22c9
refactor: use frappe.get_system_settings
...
because it's cached and doesn't hit frappe.db at all.
2024-02-02 18:43:43 +05:30
Ankush Menat
dae99eb53c
fix: Fetch SMTP server inside context
...
Currently if smtp server creation fails email queue is endlessly
retried. It should just fail if there's no outgoing account.
2024-02-01 11:10:57 +05:30
Ankush Menat
78665d98b2
fix: Bail if no SMTP acccount can be found
...
Currently we give this weird error instead of just saying no outgoing email account is configured.
```
AttributeError: 'NoneType' object has no attribute 'get_smtp_server'
File "frappe/email/queue.py", line 154, in flush
email_queue.send()
File "frappe/email/doctype/email_queue/email_queue.py", line 160, in send
with SendMailContext(self, smtp_server_instance) as ctx:
File "frappe/email/doctype/email_queue/email_queue.py", line 236, in __init__
self.smtp_server: SMTPServer = smtp_server_instance or self.email_account_doc.get_smtp_server()
```
2024-02-01 11:10:57 +05:30
Rucha Mahabal
53d6d156ec
chore: cleanup doctype descriptions ( #24609 )
2024-01-31 12:00:39 +05:30
Ankush Menat
dedadbb0d9
perf: optional faster perm check for files
2024-01-31 10:49:18 +05:30
Govind Jangid
cb841bde6d
fix: depends on
2024-01-29 14:47:42 +05:30
Govind Jangid
39d3a5e8f4
fix: suggestion
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2024-01-29 14:39:58 +05:30
Govind Jangid
9e74bfbb8c
fix: description
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2024-01-29 14:35:54 +05:30
Govind Jangid
bb746d5e9c
fix: formatting
2024-01-29 12:31:54 +05:30
Govind Jangid
503222391b
fix: formatting
2024-01-29 12:30:35 +05:30
Govind Jangid
0c6c0c5f50
feat: use_first_day_of_period
2024-01-29 12:17:58 +05:30
Ankush Menat
d5d9b12472
test: flaky server tests ( #24301 )
...
* Revert "fix(test_recorder): get the correct request (#24143 )"
This reverts commit 745080c56e
2024-01-15 08:09:46 +00:00
Akhil Narang
1147c8bbed
refactor: read email body with policy=SMTP
...
`policy=SMTPUTF8` seems to break without specifying SMTPUTF8 in mail_options when actually sending the mail
(can't validate this because no server I tried seems to support that)
The `default` or `SMTP` policy work fine. Stuck to `SMTP` for CRLF line endings - default only does LF
Can get away with just changing this for SendMailContext().get_message_object(), but seemed better to standardize it
Non ASCII characters in the subject break completely, for example hindi characters get replaced by `?`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-10 16:21:36 +05:30
Akhil Narang
e29b39f7df
refactor: use receiver's language for some notifications
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-10 16:21:36 +05:30
Shariq Ansari
2fe507c58c
chore: linter fix
2024-01-09 15:55:04 +05:30
Shariq Ansari
724fd1a291
chore: linter fix
2024-01-09 15:08:45 +05:30
Kevin Shenk
4ec4594c62
fix: notification.py should ignore permissions on fetching on mobile_no receiver list
...
Similar to fetching the email list in `get_list_of_recipients()`, the `get_info_based_on_role` call to fetch `mobile_no` in `get_receiver_list()` should set `ignore_permissions` in order to allow sms notifications to send based on actions of limited and anonymous users (e.g. web form submissions).
2024-01-05 04:49:33 -05:00
Ankush Menat
cc2bb85484
fix: correct arg type
...
assign_to expects a list of strings of users not a single string.
2024-01-04 18:39:15 +05:30
Ankush Menat
3836d942ac
fix: logic to disable broken account
...
This doesn't work because when email is broken we still continue and
down the line changes get rolled back.
2024-01-04 17:39:25 +05:30
Ankush Menat
71908f1e00
refactor: respect multi-tenancy
...
redis set/get don't consider site
2024-01-04 17:39:25 +05:30
Ankush Menat
807cfd66f1
fix: Reset failed attempts ONLY if succesful connection is made
2024-01-04 17:39:25 +05:30
Ankush Menat
8a7707e3fa
fix(DX): store tracebacks with context ( #24059 )
2024-01-01 07:16:47 +00:00
Ankush Menat
19e0fe65f5
fix: allow guests to view published Newsletters
2023-12-29 18:04:29 +05:30
Ankush Menat
c7e5afee6a
refactor: Use arr.includes(item) instead of in_list(arr, item)
2023-12-27 19:33:13 +05:30
Akhil Narang
25ba2822be
Merge pull request #23431 from barredterra/newsletter-welcome-url
...
feat(Newsletter): redirect to welcome URL
2023-12-21 17:10:06 +05:30
Ankush Menat
0fd6f5eed7
Merge pull request #23827 from frappe/api-docs
...
docs: add Python API missing docstrings / type hints
2023-12-21 12:13:05 +05:30
