Commit graph

854 commits

Author SHA1 Message Date
Ankush Menat
535bc10340
fix: make letterhead attachments public by default (#25925)
Also does it for web page.

Note: This is just default config, users can change while uploading.
2024-04-12 05:14:18 +00:00
Ankush Menat
672f3b2258 refactor!: sort by creation for clearing old logs 2024-03-27 13:04:01 +05:30
Ankush Menat
3896296c6f fix: update sort order in doctypes 2024-03-27 11:18:28 +05:30
Akhil Narang
2af42f5501
fix(webhook): r is referenced here before its initialized
Broke in #21064

Sentry: FRAPPE-2SH

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-22 18:59:02 +05:30
Ankush Menat
e47e76897a
fix: notify on failed s3 backup upload (#25544) 2024-03-19 15:50:37 +00:00
Ankush Menat
0a81407304
perf: Skip running webhook code if method is not supported (#25498)
E.g. `doc.run_method("autoname")` triggers webhook code for no reason.
2024-03-18 10:01:15 +05:30
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options (#25211)
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
Rucha Mahabal
82179f908d
Merge pull request #24114 from tanmoysrt/integrate_frappe_notification
feat: add frappe push notification client
2024-02-28 11:27:57 +05:30
Rucha Mahabal
8305affddd chore: Add Push Notification Settings to Integrations workspace 2024-02-28 11:07:22 +05:30
Rucha Mahabal
2e79f6acb4 feat: add descriptions to Push Notification Settings
- mark it as beta

- validate relay server url key
2024-02-28 01:09:46 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
prafful1234
d66fe5a037
feat: Queue selection for webhooks (#24876)
* feat: Queue selection for webhooks

* fix: code refactor

* fix: Add authorization check for get_all_queues

* fix(UX): move field to relevant section

* refactor: rename field for queue

* refactor: simpler autocomplete

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-02-19 06:31:30 +00:00
Raffael Meyer
fc64e8a0fb
feat: pass doctype as context when translating label (#24903) 2024-02-18 19:42:15 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
8a71054c0c
Merge pull request #24765 from ankush/black_to_ruff
ci: switch to ruff-format
2024-02-05 19:20:51 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Ankush Menat
063e30964d fix: Use TEXT type for Webhook URLs to support large URLs 2024-02-05 17:50:04 +05:30
Ankush Menat
7487df22c9 refactor: use frappe.get_system_settings
because it's cached and doesn't hit frappe.db at all.
2024-02-02 18:43:43 +05:30
Raffael Meyer
4cc89ae42b
Merge pull request #24500 from barredterra/fix-typos 2024-01-24 03:01:50 +01:00
barredterra
9d6cbd0c15 fix: typos 2024-01-24 02:41:03 +01:00
barredterra
bb7bb41621 fix: Google Drive translatability 2024-01-23 20:13:34 +01:00
barredterra
c17f014ef4 refactor: remove redundant API Key from Google Picker 2024-01-16 13:26:03 +01:00
Tanmoy Sarkar
a084f91e18
Merge branch 'frappe:develop' into integrate_frappe_notification 2024-01-08 16:52:27 +05:30
Ankush Menat
4e188ec531
fix: webhook error logging fails (#24172)
These variables can be unset if webhook fails while creating them.
2024-01-08 15:37:04 +05:30
Tanmoy Sarkar
896da0afb3 fix: fix issues 2024-01-04 18:36:54 +05:30
Tanmoy Sarkar
30726d364f chore: keep push notification relay disable by default 2024-01-04 12:16:07 +05:30
Tanmoy Sarkar
853a0c1f58 feat: add frappe notification client 2024-01-04 11:38:19 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified (#23697)
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
Ankush Menat
f0aaeadd49 fix: Correct fallback for social login key 2023-12-11 12:48:47 +05:30
Ankush Menat
e4a9431c9c
fix: change webhook header types to small text (#23722)
closes https://github.com/frappe/frappe/issues/18650
2023-12-11 06:30:01 +00:00
barredterra
c35476256f refactor: simplify conditional logic
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Ankush Menat
6cb425baae Revert "refactor: OAuth flow without breaking routing convention"
This reverts commit e96ecab00e.
2023-12-02 20:02:24 +05:30
ruthra kumar
0a7c0593da refactor: execute the last instance of a webhook in a request 2023-12-01 15:15:43 +05:30
Sagar Vora
1490fc1ba6
perf: avoid double local caching webhooks (#23426)
### Changes Made

- remove cache in `frappe.flags` (and related comment)
- use cache generator
- ⚠️ micro optimisation: use a variable for `frappe.flags`
2023-11-29 03:10:04 +00:00
Ankush Menat
f526054ae2
refactor: Remove usage of utcnow (#23369) 2023-11-23 13:21:27 +05:30
Ankush Menat
31e3b3f981
fix: social key signup without signup conf (#23359) 2023-11-22 11:32:45 +00:00
David Arnold
ec4bc971c5
fix(integration): preserver data json formatting on update 2023-11-07 16:43:13 +01:00
Ankush Menat
563639235e
Merge pull request #22300 from ankush/api_v2
feat!: API versioning and API v2 (beta)
2023-10-17 11:34:26 +05:30
Corentin Flr
2b542d87e1
fix: Fix scopes for Google Calendar (#22614)
https://developers.google.com/identity/protocols/oauth2/scopes
2023-10-17 08:07:38 +05:30
Ankush Menat
e96ecab00e refactor: OAuth flow without breaking routing convention
Appending `/connected-app` after method breaks routing.
2023-10-16 18:12:53 +05:30
Ankush Menat
275f16060a fix: route ambiguitities and / in name
v1 and v2:
- Use path convertor to consume entire document which MIGHT contain `/`
- Drop string convertor, as it's the default
- Dont merge slashes - avoid consuming something that's part of name

v2:
- `SI/BLAH/BLAH/submit` is not simple to parse without ambiguitity
- `SI/BLAH/BLAH/method/submit` removes ambiguitity for 99.99% cases.
2023-10-16 18:12:53 +05:30
Sagar Vora
258c175982 perf: defer db query when saving Event 2023-10-16 12:59:30 +05:30
Anand Chitipothu
aff3f66366
fix: work-around to fix issue with syncing Google Contacts (#22649)
Issue #22648
2023-10-16 12:29:49 +05:30
Ankush Menat
e1f2f4bb54 fix: Let social login key control signups
There are cases where certain social login keys

- Should not allow signups at all and only allow logins. E.g. social media login keys.
- Should allow signups even if global sign ups are disabled. e.g. internal SSO like setups.
2023-10-14 12:43:48 +05:30
Sagar Vora
6043909fe6 fix: allow larger URLs in Integration Request 2023-10-09 19:13:10 +05:30
Corentin Flr
8882679357
fix: Ensure Google Calendar scopes is a List (#22333) 2023-09-11 18:04:22 +05:30
Ankush Menat
2f4c5c63aa test: fix ldap test 2023-08-29 12:07:58 +05:30
Ankush Menat
dc8d7b019a refactor!: Lower roles from All To Desk User 2023-08-29 12:07:57 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00