Commit graph

46163 commits

Author SHA1 Message Date
Revant Nandgaonkar
37803a00d4
fix: strip exc from json response if traceback not allowed (#23989)
* fix: strip exc from json response if traceback not allowed

* fix: use pop instead of del to avoid key error

* fix: Avoid showing exc when traceback is disabled

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-28 10:45:06 +05:30
Ankush Menat
0162d3bda0
Merge pull request #23982 from ankush/new_js_child_table
fix!: initialize child tables correctly
2023-12-27 19:51:18 +05:30
Ankush Menat
e814af0aeb fix!: Init child tables as empty array on client side 2023-12-27 19:35:55 +05:30
Ankush Menat
c7e5afee6a refactor: Use arr.includes(item) instead of in_list(arr, item) 2023-12-27 19:33:13 +05:30
Akhil Narang
70bb2f45bb
Merge pull request #23590 from GursheenK/treeview-filters 2023-12-27 19:03:05 +05:30
Akhil Narang
d5d35704d8
feat(sentry): skip validation errors
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 18:43:33 +05:30
Gursheen Kaur Anand
0fadb6d9fc
fix: use sbool for better typecasting
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 18:40:44 +05:30
Akhil Narang
34f03a2de2
fix(data_import): respect the value of show_failed_logs checkbox
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 16:58:04 +05:30
Ankush Menat
6e914dfdf6
test: use doctype that supports prompt naming (#23980) 2023-12-27 11:15:42 +00:00
Jannat Patel
32469b5a81
fix: roles editor (#23976) 2023-12-27 16:17:31 +05:30
Ankush Menat
4996b8ac7b refactor: postgres version check 2023-12-27 16:12:40 +05:30
hhharsha36
445da4319b
fix: error - permission denied for schema public from Postgres >= 15 during initial DB setup (#23799)
Error from Postgres:
ERROR:  permission denied for schema public at character 14

Error from Frappe:
psql:/home/frappe/frappe-bench/apps/frappe/frappe/database/postgres/framework_postgres.sql:72: ERROR:  permission denied for schema public

Error Causer:
Starting Postgres version >= 15, all users will have the `CREATE` permission revoked by default.

Fix:
Grant relevant privileges to the database in question for the user. In this case, DB owner privilege.

Note: the below two permission attempts were unsuccessful and still caused the same public schema permission error

GRANT USAGE, CREATE ON SCHEMA public TO {frappe.conf.db_name};
GRANT ALL ON SCHEMA public TO {frappe.conf.db_name}

References:
https://stackoverflow.com/questions/74110708/postgres-15-permission-denied-for-schema-public
https://stackoverflow.com/questions/67276391/why-am-i-getting-a-permission-denied-error-for-schema-public-on-pgadmin-4
2023-12-27 16:04:21 +05:30
Corentin Flr
91405493e5
fix(text_editor): Fix bubble's link tooltip clipping (#23911)
* fix(text_editor): Use body as bounds to avoid bubble's tooltip clipping

* fix(text_editor): Allow overflow for link tooltip
2023-12-27 16:03:18 +05:30
14987
2e730d7056
fix(Data Import): show failed import logs 2023-12-27 15:06:24 +05:30
Ankush Menat
6367194620
perf: skip network call if no doc (#23967)
If link field has no value then its title will always be undefined.
2023-12-27 14:15:20 +05:30
Maharshi Patel
c3cc310496
Merge pull request #23287 from fadilsiddique/numbercard_fix
fix: number card layout
only align flex-start for shortcut-widget-box instead of all widget-head
2023-12-27 13:46:41 +05:30
Maharshi Patel
53ab3c6491 Merge branch 'develop' into numbercard_fix 2023-12-27 13:39:00 +05:30
Maharshi Patel
39136b01b6 fix: shortcut-widget-box should have flex-start
As we changed align-items to space-between for widget head,
we need to override .shortcut-widget-box to flex-start
2023-12-27 13:32:04 +05:30
Maharshi Patel
547523c7b4
fix(minor): mobile menu class (#23970)
removed `.collapse.show` class as it is removed during opening animation of menu.
2023-12-27 13:16:02 +05:30
Maharshi Patel
fe906966d4
fix(minor): Onboarding check if element available (#23947)
only try to find parent_element_selector if element exists
2023-12-27 12:02:37 +05:30
Akhil Narang
64b63d5969
fix(sentry): don't set context if not enabled
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 11:38:01 +05:30
Ankush Menat
a16db1be32
fix: show relative path in loaded JS (#23964)
[skip ci]
2023-12-27 10:46:30 +05:30
barredterra
7d4bdbebb9 feat: apps can provide custom message extractors
- custom extractors take precedence
- default extractors are used as a fallback
2023-12-27 01:44:48 +01:00
barredterra
e1140a22b8 fix: don't presume english as source language
Note: If we DO want this, it should happen at a higher level.
2023-12-26 23:18:07 +01:00
barredterra
483fa15c8f fix: clear translation cache
- Cache was not getting cleared, since it's user-specific
- Remove unused implementation from gettext
2023-12-26 23:17:31 +01:00
barredterra
3a76fb2253 feat: support CSV and gettext at the same time 2023-12-26 19:13:10 +01:00
barredterra
d384bb4506 Merge remote-tracking branch 'upstream/develop' into po-translation 2023-12-26 16:45:05 +01:00
barredterra
8867e1ec4e Merge remote-tracking branch 'upstream/develop' into copy-config-to-new-app 2023-12-26 16:37:31 +01:00
barredterra
9845777170 test: create app
- add `branch_name` to `default_hooks`; use `default_hooks` in tests
- convert `default_user_input` to list, add `branch_name`
2023-12-26 16:36:49 +01:00
Akhil Narang
ba01eb99cb
Merge pull request #23892 from jjaycaneza/fix-childTable-skip_dirty_trigger-param
fix: add skip_dirty_trigger param for child_table
2023-12-26 17:54:22 +05:30
Fierflame
3ee00cf1e4 fix: Solve the problem that the filter conditions are regarded as the same when the filter values are equivalent arrays in the filter 2023-12-26 20:17:58 +08:00
Sagar Vora
f54e0c94b7
Merge pull request #23948 from frappe-tianjy/fix/frappe.ui.Capture.prototype.setup_remove_action 2023-12-26 17:35:14 +05:30
Fierflame
c5990938fd fix: Solve the problem that there is no forEach instance method in HTMLCollection in some environments, which leads to the failure of camera-related functions. 2023-12-26 19:50:33 +08:00
猛火
854cebd5b1
fix: Solve the problem that the document editor will report an error when the type name includes multiple spaces (#23940) 2023-12-26 14:34:48 +05:30
Ankush Menat
4b5658a507
Merge pull request #23926 from cogk/fix-child-doc-defaults
fix(document): Pass parent_doc and parentfield for child in _set_defaults
2023-12-26 13:27:05 +05:30
Akhil Narang
067104ca9c
refactor(sentry): sync up with FC implementation
Co-authored-by: Aditya Hase <aditya@adityahase.com>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 12:30:10 +05:30
Ankush Menat
bedf270bc4
Merge pull request #23935 from barredterra/print-font
fix: use system font for printing
2023-12-26 12:21:15 +05:30
Ankush Menat
2dfef73ae8
Merge pull request #22915 from akhilnarang/dont-extract-backup-unconditionally
perf: don't extract gzipped backups
2023-12-26 12:19:10 +05:30
Xiaoguang Sun
68d4a5ad82
Do not call begin in updatedb after syncing (#23934)
Do not call begin in updatedb after syncing as commit does it already.

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
2023-12-26 12:12:19 +05:30
Akhil Narang
43021911ff
fix: simplify parsing version for older backups
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
6e8f32af58
chore: don't pipe output through pv
No point if we're using `execute_in_shell()`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
3fe840fb31
fix(postgres): make use of common helper
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
76c9fbd0cd
fix: use source before changing its contents
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
b010dc584f
chore(installer): fix output when prompting user about downgrade
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
9bf818eb4a
chore: add in some tests for backup
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
7f433b84af
feat: allow creating a backup with the older metadata style
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
998f2c10d6
fix: handle older gzipped backups as well
Also fix the actual comparison

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
a06e402f38
refactor: use a function with context manager for backup decryption
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
2e382040cd
fix: simplify version detection logic
Our version detection code is relatively simple, so we shouldn't have any exceptions arising there
Just check for a None return value to decide whether we should use the older logic

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
148efbc3ed
refactor(restore): adjust downgrade check
First actually check whether its a downgrade, then check for the force flag

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30