Maharshi Patel
53cdd6d1bf
fix: relink attachments before saving doc
...
Certain people add attachment, before filling mandatory fields
which will raise Missing Fields error.
Or any other kind of errors raised by different validators due to which
file is uploaded but doc is not saved.
This will lead to orphaned/mislinked files. ex. new-purchase-receipt-1
This fix changes name of new docs to new-<doctype>-<no>-<10digithash>
after saving the document we can use this new name to find any mislinked
files created in past hour and relink them to the new doc on save.
2023-10-10 23:49:16 +05:30
Maharshi Patel
8550e7bded
chore: deprecated get_filter_as_json
...
Instead of removing get_filter_as_json add console warn.
2023-10-10 21:18:20 +05:30
Shariq Ansari
009d9e010b
Merge pull request #22679 from shariquerik/conditional-webform-list-view
2023-10-10 15:47:27 +05:30
Gursheen Kaur Anand
9f11e399e4
Merge branch 'develop' into audit-trail-filters
2023-10-10 15:44:05 +05:30
Akhil Narang
b601131d8f
fix: don't allow setting an invalid rating ( #22633 )
...
* feat: don't allow setting an invalid rating
Convert anything <0 to 0, and anything >1 to 1
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* chore: add in tests for rating
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 15:38:58 +05:30
Gursheen Anand
3c4fa8415e
fix: set date fields in test
2023-10-10 15:33:13 +05:30
Gursheen Anand
22e138de9e
fix: filter docs in controller
2023-10-10 15:32:03 +05:30
Gursheen Anand
796c2608b3
fix: validate date fields explicitly
2023-10-10 15:25:02 +05:30
Gursheen Anand
56d1bf2732
fix: filter document field using date
2023-10-10 15:21:43 +05:30
Gursheen Anand
8707fbf248
fix: make date filters mandatory
2023-10-10 15:21:04 +05:30
dependabot[bot]
d24d4f52c3
build(deps): bump postcss from 8.4.24 to 8.4.31 ( #22615 )
...
Bumps [postcss](https://github.com/postcss/postcss ) from 8.4.24 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.4.24...8.4.31 )
---
updated-dependencies:
- dependency-name: postcss
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-10 14:17:12 +05:30
Suraj Shetty
3d8461a7af
Merge pull request #22674 from surajshetty3416/fix-reportview-filter
2023-10-10 14:12:44 +05:30
Suraj Shetty
d6fc9be930
Merge pull request #22619 from GursheenK/audit-trail-write-permission
2023-10-10 13:35:30 +05:30
Suraj Shetty
c8f3389ba7
Merge pull request #22439 from dhiashalabi/fix-child-table-select-search-link-permission
2023-10-10 13:32:45 +05:30
Suraj Shetty
3a5f8ecaa5
Merge pull request #22555 from cogk/fix-notpermittedpage-redirect-if-startwith-app
2023-10-10 13:29:04 +05:30
Gursheen Anand
6758be3e24
feat: start and end date filters
2023-10-10 13:05:18 +05:30
Gursheen Anand
53712ed556
fix: only show amended docs in dropdown
2023-10-10 13:02:05 +05:30
Shariq Ansari
46f3b5b12d
fix: changed table style to match grid style
...
updated description and some minor fixes
2023-10-10 12:53:21 +05:30
Akhil Narang
091ebdd8dc
refactor(treewide): use mariadb commands directly instead of mysql ( #22620 )
...
This has been done because the mysql command issues a deprecation warning now
mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 12:49:16 +05:30
Maharshi Patel
7752136081
fix: strip html and show text ( #22656 )
...
* fix: strip html and show text
Quill editor adds html which is useless for user so strip html using html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description).
* fix: remove placeholder text
[skip ci]
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-10-10 12:29:36 +05:30
Suraj Shetty
fbaefddaa1
fix: Use same filter in report view and list view
2023-10-10 11:47:49 +05:30
Shariq Ansari
fb9c111ed2
fix: conditional webform with list view enabled
2023-10-10 11:47:03 +05:30
Sagar Vora
58fa1c93c5
Merge pull request #22667 from resilient-tech/black-compatible-export
2023-10-09 19:31:36 +05:30
Sagar Vora
eb8bc998e2
Merge pull request #22666 from resilient-tech/allow-larger-urls
2023-10-09 19:23:28 +05:30
Sagar Vora
b6b7fafe72
chore: export black-compatible types
2023-10-09 19:20:20 +05:30
Sagar Vora
6043909fe6
fix: allow larger URLs in Integration Request
2023-10-09 19:13:10 +05:30
Ankush Menat
9073874b50
Merge pull request #22636 from akhilnarang/awesomeplete-tab-autocomplete
...
feat: enable `tabSelect` for awesomplete
2023-10-09 18:42:25 +05:30
Ankush Menat
b24d91c52f
Merge pull request #22657 from ruthra-kumar/keyerror_on_reports_with_subtotal
...
fix: keyerror on reports with subtotal
2023-10-09 17:18:30 +05:30
rohitwaghchaure
34fe6661c0
fix: e-commerece test cases ( #22663 )
2023-10-09 11:49:41 +05:30
barredterra
ff0e3c73ad
refactor: redundant CSS/classes
2023-10-08 16:16:39 +02:00
barredterra
681364815d
fix(listview): assigned to
...
- don't show "-" if assignments are empty
- vertically center avatars in row
- remove unused avatar-empty class
2023-10-08 16:03:17 +02:00
barredterra
ca2e04d35d
feat(listview): move likes to the right
2023-10-08 16:00:44 +02:00
ruthra kumar
f6d9069fb1
fix: keyerror on reports with subtotal
2023-10-08 17:22:29 +05:30
Maharshi Patel
27e4901e0b
fix: workspace don't strip filter info on save.
...
currently on save of filter ( get_filter_as_json ) is used
to convert it to object with following structure:
```
{
priority: (2) ['=', 'Medium'],
status: (2) ['=', 'Open']
}
```
Doing this we lose information of parent doctype.
Missing parent doctype causes field not permitted error.
To fix this, I saved filter as it is and converted it to object when required.
2023-10-08 16:42:17 +05:30
Suraj Shetty
0c9db5060b
Merge pull request #22602 from resilient-tech/fix-long-title
2023-10-08 06:37:33 +05:30
Suraj Shetty
ecca2fcc7a
Merge pull request #22562 from FHenry/dev_translation_context_for_edit_grid_row_button
2023-10-08 06:27:35 +05:30
Florian HENRY
d05e0b8d4c
Merge branch 'develop' of https://github.com/frappe/frappe into dev_translation_context_for_edit_grid_row_button
2023-10-07 16:30:52 +02:00
mergify[bot]
eee418a4c6
Merge pull request #22330 from blaggacao/feat/improve-openid-connect-devx
...
feat: improve openid connect devx
2023-10-07 13:43:36 +00:00
barredterra
ed2290d1d6
Merge branch 'develop' into feat/improve-openid-connect-devx
2023-10-07 15:22:59 +02:00
barredterra
b8677d8d56
fix: vertically center icon and count
2023-10-07 11:46:49 +02:00
barredterra
5f5bfd0086
fix: change outline of like icon to gray-800
...
For consistency with other icons
2023-10-07 11:24:57 +02:00
barredterra
344a725d45
fix: list view formatting logic
2023-10-06 16:15:19 +02:00
DaizyModi
1cd51644a2
fix: set css for max width 412px
2023-10-06 15:10:58 +05:30
Akhil Narang
5553a84e00
feat: enable tabSelect for awesomplete
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-05 16:34:58 +05:30
Maharshi Patel
d83b6758dd
Merge pull request #22626 from maharshivpatel/fix-workspace-style
...
fix: workspace style
2023-10-05 10:28:24 +05:30
Maharshi Patel
60b3f34691
Merge pull request #22628 from maharshivpatel/fix-kanban-memory-issue
...
fix: kanban remove unnecessary get_docfield
2023-10-05 00:45:14 +05:30
Maharshi Patel
6c5856f6fc
Merge pull request #22627 from maharshivpatel/hide-sidebar-on-new-doc
...
fix(minor): hide side section on new doc form.
2023-10-05 00:43:29 +05:30
Maharshi Patel
84adb3f68e
Merge pull request #22617 from maharshivpatel/fix-sidebar-and-multiselect
...
fix: sidebar, multi-select, body tag letter spacing
2023-10-05 00:24:38 +05:30
Maharshi Patel
68221f4d9e
fix: kanban remove unnecessary get_docfield
...
* Label will be same for all documents so there is no need to call get_docfield.
* As it internally calls docfield_copy and makes "deep copy" for each document.
which causes massive memory usage as number of document increases.
* Instead get meta from docfield_map and use it.
2023-10-04 23:36:53 +05:30
Maharshi Patel
658f58d1e0
fix(minor): hide side section on new doc.
...
* on new doc, hide sidebar is hidden. however, layout-side-section is still visible.
* added hide-sidebar class to layout-side-section when doc is new.
2023-10-04 23:30:48 +05:30