Commit graph

46163 commits

Author SHA1 Message Date
mergify[bot]
0dbdb7847a
Merge branch 'develop' into update-cy-new 2023-09-23 10:04:21 +00:00
Ankush Menat
bf037acb5b chore: deprecate get_js
Pointless function for loading public JS files
2023-09-23 15:30:23 +05:30
Ankush Menat
e9a6c4ab13 fix: user info error when name case mismatches 2023-09-23 15:26:31 +05:30
Ankush Menat
428d78a491 chore: move svg icons to end and correct version 2023-09-23 15:17:05 +05:30
Ankush Menat
8621e196d1
Merge pull request #22113 from gavindsouza/assets-fetch-no-get_js
perf: frappe.require
2023-09-23 15:14:05 +05:30
Ankush Menat
d7a9d0111c
perf: lazy load SVG icons (#22517)
| Metric                             | Before | After | Change    |
| ---                                | ---    | ---   | ---       |
| app.html first response size       | 421kb  | 106kb | -75% (!)  |
| First response duration            | 60ms   | 40ms  | -33%      |

huge thanks to @cogk for doing most of the work for this PR on this issue: https://github.com/frappe/frappe/issues/17449#issuecomment-1728328726

Co-authored-by: Corentin Flr <10946971+cogk@users.noreply.github.com>
2023-09-23 15:13:43 +05:30
Ankush Menat
b5d0169ca7 refactor: fetch logic
- Use _version_number which indicates when assets.json was generated.
  Files are evicted roughly at same time. metadata_version changes with
  other changes too.
- use `includes` instead of index check
- camelCase -> snake_case
- dont force caching. doesn't seem to be required. Caches without this
  header too.
2023-09-23 15:07:35 +05:30
Ankush Menat
1e19a2e4f1 Merge branch 'develop' into assets-fetch-no-get_js 2023-09-23 14:58:06 +05:30
Faris Ansari
18c4f653f4 chore: unskip restore test 2023-09-23 13:01:40 +05:30
Ankush Menat
8635daf425
fix: duplicate icons (#22516) 2023-09-23 12:51:20 +05:30
Ankush Menat
908ddad962
Merge pull request #22515 from ankush/email_rec
fix: handle poorly encoded from emails
2023-09-23 12:13:57 +05:30
Ankush Menat
f974fcabac fix: ignore poorly encoded email parts 2023-09-23 11:53:05 +05:30
Ankush Menat
59d1eefa61 refactor: move unhandled email to log settings 2023-09-23 11:23:53 +05:30
Faris Ansari
fa88f1a628 fix: resolve path instead of absolute path
#22142 made the change to absolute path but it affected file backups.
Resolve path should probably be enough in most cases.
2023-09-23 11:05:49 +05:30
David Arnold
e57dc10631
fix: rss rendering of blog entries (#22511) 2023-09-22 20:31:51 +05:30
Ankush Menat
aa413e8c9f
fix: link notification messages with communication (#22507) 2023-09-22 17:06:47 +05:30
Suraj Shetty
f374771361
Merge pull request #22191 from maharshivpatel/feat-desk-refresh 2023-09-22 12:56:11 +05:30
Suraj Shetty
66f8c0b37f chore: Fix cypress configuration to support cy13 2023-09-22 12:02:19 +05:30
Suraj Shetty
a496f6b5e1 build: Update cypress 2023-09-22 11:19:41 +05:30
Maharshi Patel
a4fdc0ff80 fix(minor): change comment box color to control bg 2023-09-21 22:38:25 +05:30
Daizy Modi
3b8aca1a43
feat: provision to set_route for Custom Number Card (#21806) 2023-09-21 18:38:43 +05:30
barredterra
262bda5c91 feat: check write perms on attached to doc(type) 2023-09-21 14:53:45 +02:00
barredterra
ae77f92821 fix: render count on image capture
Immediately render total_count as "No Images", instead of displaying the
name of the HTML field (total_count).
2023-09-21 14:48:17 +02:00
barredterra
41f38f5bc6 fix: stop media stream on hide
When the image capture dialog is hidden, stop the media stream.
Didn't work becasue function was executed during setup.
2023-09-21 14:46:43 +02:00
Ankush Menat
4888e85df1
fix: Add more usable fieldtypes to group by (#22497)
- Autocomplete is same as select
- Dynamic link is same as link
- Date is useful too

Possible improvement `group by date(datetime)` (not part of this PR)
2023-09-21 17:49:07 +05:30
Maharshi Patel
73601cbc2a chore: remove form builder not important and flaky ui test. 2023-09-21 16:39:33 +05:30
Maharshi Patel
83c2f6e53a chore: fix linters 2023-09-21 14:56:52 +05:30
Maharshi Patel
32da8cb530 fix(minor): datatable header cell bg color 2023-09-21 13:49:24 +05:30
Maharshi Patel
8837e24d5c fix: sidebar tags as per espresso
changed frappe.ui.Tags to sidebar button to match espresso style.
2023-09-21 13:22:56 +05:30
Maharshi Patel
88329d73c7 fix: datepicker style as per espresso 2023-09-21 12:34:33 +05:30
Maharshi Patel
880030864e fix(minor): form tour driver dark theme background color. 2023-09-21 12:12:08 +05:30
Maharshi Patel
e99f07c8a3 fix(minor): dark mode checkbox disabled state. 2023-09-21 11:30:01 +05:30
Maharshi Patel
37f03069bf
Merge branch 'develop' into feat-desk-refresh 2023-09-20 22:24:33 +05:30
Maharshi Patel
9b6d6267dd fix: awesome_bar & sidebar cypress test as per espresso. 2023-09-20 22:22:44 +05:30
Corentin Flr
41d30e7213
feat: Add custom icons with the app_include_icons hook (#22254)
* feat: Add custom icons with the `app_include_icons` hook

These custom icons are available on the desk only. They can be picked in the `ControlIcon` picker.

Co-authored-by: Abraham Kalungi <85731451+kalungia@users.noreply.github.com>

* fix: skip conf for including icons

* test: Fix test_include_icons

---------

Co-authored-by: Abraham Kalungi <85731451+kalungia@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-20 20:23:17 +05:30
HENRY Florian
42ee7f9b2d
feat: bulk update fields select sorted by translated labels (#22318)
* feat: bulk update fields sorted translated alpha sort

* chore: implement review from @barredterra

* chore: fix linter/prettier

* fix: convert to string

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 18:52:21 +05:30
Ankush Menat
ff26528ab0 style: format 2023-09-20 18:16:10 +05:30
Psyi Rius
36c182e72c
chore(js): improved cryptic looking sanitise regex with info (#22357) 2023-09-20 17:39:33 +05:30
Gavin D'souza
13e04999d2
fix: Add version tag for non-bundled assets 2023-09-20 17:02:55 +05:30
Anand Baburajan
5004374ecc
chore: handle invalid connections conf for internal links (#22486)
* chore: handle invalid connections conf for internal links

* chore: remove unnecessary None
2023-09-20 11:14:51 +00:00
Maharshi Patel
2cb6076b59 fix: cypress, dark mode, grid search, timeline
fixes for Espresso
* due to have fixed height of the grid heading, the search bar was not visible now
  added class that will double the height of the grid heading row if filter row is present.
* dark mode fixes: button active state, Awesomeplete dropdown, Quill editor.
* timeline style fixes
2023-09-20 16:35:30 +05:30
Bernd Oliver Sünderhauf
67376e26d4
fix: Set system timezone for Administrator and Guest users. (#22440)
* fix: Set system timezone for Administrator and Guest users.

* refactor: use constant instead of duplicating

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 15:26:00 +05:30
Saif Ur Rehman
b5ff562142
fix(base_list): setup_filter_area error handling 2023-09-20 14:49:56 +05:00
Saif Ur Rehman
d38913714c
fix(xcall): optional error message 2023-09-20 14:42:02 +05:00
mergify[bot]
69b0fcf06e
Merge pull request #22316 from cogk/fix-email-subject-decode
fix: Fix email subject decoding
2023-09-20 09:41:59 +00:00
Saif Ur Rehman
f086e03df0
fix(ajax): error handling 2023-09-20 13:39:33 +05:00
Corentin Flr
15010cf8a9
fix: Fix typo in form_tour (#22474) 2023-09-20 13:22:09 +05:30
David Arnold
086435c004
feat: add upstream json argument to integrations make_request (#22462)
* feat: add upstream json argument to integrations make_request

* style: format

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 13:15:22 +05:30
Ankush Menat
3a0522f0ba
Merge pull request #22480 from ankush/reportview
fix: reportview where fields dont have label
2023-09-20 12:53:21 +05:30
Ankush Menat
9a36a09bee fix: remove unnecessary conditional
both code branches exactly same, so why bother
2023-09-20 12:30:44 +05:30