Commit graph

46163 commits

Author SHA1 Message Date
Ankush Menat
9e2a0384e0
build: bump gitpython (#22290) 2023-09-02 15:29:14 +05:30
Ankush Menat
8f48fbcde2 fix: escape title in link preview 2023-09-02 15:14:42 +05:30
Ankush Menat
9e87c97822
Merge pull request from GHSA-j2w9-8xrr-7g98
* fix: Prevent HTML injection in list_view

* fix: Prevent HTML injection in link_preview

* fix: Prevent HTML injection in breadcrumbs

* fix: Prevent HTML injection in readonly Link field

* refactor: rename breadcrumb util

---------

Co-authored-by: Corentin Forler <10946971+cogk@users.noreply.github.com>
2023-09-02 13:10:49 +05:30
Michaël Terceno
bc080531ee
Merge branch 'frappe:develop' into fix-missing-keyboard-shortcut-on-document---Duplicate 2023-09-02 08:23:04 +02:00
Michaël Terceno
de85c844ea
fix: Replace the shortcut initially proposed
Ctrl+D by Shift+D
2023-09-02 08:22:40 +02:00
Raffael Meyer
744b383e9a
fix: don't attach web view link if disabled (#22276)
* fix: don't attach web view link if disabled

* feat: improve label

old: "Send document Web View link in email"
new: "Include Web View Link in Email"
2023-09-02 11:43:28 +05:30
Ankush Menat
5215cc3c74
Merge pull request #22266 from Xieyt/fix/new-app-email-validation
fix: add Email Validation in boilerplate creation
2023-09-02 11:39:18 +05:30
Ankush Menat
1ad5c0ea86 refactor: Avoid regex for email validation
[skip ci]
2023-09-02 11:38:56 +05:30
David Arnold
ed5da35b1a
fix: align to socketio port default 9000 (#22277)
* fix: align the frontent to socketio port default 3000

* Revert "fix: align the frontent to socketio port default 3000"

This reverts commit 85df5bfbf9f87c954a3d25169c344ea43c9b8fff.

* fix: change default socketio port

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-02 11:28:10 +05:30
Corentin Flr
1380241609
chore: Switch to pydantic.ConfigDict in typing_validations.py (#22268)
> PydanticDeprecatedSince20: Support for class-based `config` is deprecated, use ConfigDict instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.0/migration/
2023-09-02 11:23:50 +05:30
Corentin Flr
f88df82820
chore(rq): Pass rq.Callback objects to enqueue_call (#22271)
> DeprecationWarning: Passing a string or function for `on_failure` is deprecated, pass `Callback` instead
2023-09-02 11:22:33 +05:30
ruthra kumar
8605cd2129
fix: attribute error on old custom reports (#22286) 2023-09-02 09:54:14 +05:30
ruthra kumar
2249751e43
fix: attribute error on custom reports (#22281) 2023-09-01 20:50:34 +05:30
Michaël Terceno
3e895f0e35
fix: missing keyboard shortcut on document - Duplicate 2023-09-01 14:36:07 +02:00
RitvikSardana
6fc2cc7fa3
fix: when tree doctype is created ignore_user_permissions is set to 1 by default (#22235) 2023-09-01 14:29:50 +05:30
Maharshi Patel
f207c28f6f fix: contrast issue on major/prominent parts of design
changed light text to muted from gray-600  to gray-700.
misc: fixed grid-heading alignment issue caused by line-height
2023-09-01 13:44:38 +05:30
barredterra
8084d938e6 style: add space 2023-08-31 15:49:29 +02:00
barredterra
45822067dc refactor: use for..of loop in address list 2023-08-31 15:35:36 +02:00
barredterra
740f416572 refactor: use frappe.utils.get_form_link 2023-08-31 15:32:30 +02:00
barredterra
9511b5a6c5 fix: spacing in address and contact list 2023-08-31 12:56:00 +02:00
barredterra
3ca1bb0ea0 feat: edit icon instead of text 2023-08-31 12:43:18 +02:00
barredterra
b312629b4b fix: responsiveness of address and contact list 2023-08-31 12:04:04 +02:00
Xieyt
98fce7d633
Fix:add Email Validation 2023-08-31 14:04:54 +05:30
Ankush Menat
9436c14265 chore: treat background submit as beta feature 2023-08-31 11:59:40 +05:30
Raffael Meyer
b070c06f53
fix: show progress in doc, if given (#22256)
If doc is given, show progress in doc only.
Else, show progress to the current user (in all tabs).
2023-08-31 11:33:48 +05:30
gavin
ddc4e4813a
Merge pull request #22253 from gavindsouza/trim_database-fix
fix(trim-db): Dont show confirm dialog on dry run
2023-08-31 11:26:38 +05:30
Ankush Menat
470e46ed2a
Merge pull request #22258 from ankush/update_rp
build(deps): update RestrictedPython to latest version
2023-08-31 11:20:53 +05:30
Ankush Menat
e9585e9ce6 fix: remove validation on text code
These can overvalidate e.g. "Frappe information technology" contains "format".

Restricted python anyways validates these attr access at runtime, so no
need to validate this on code.
2023-08-31 11:03:28 +05:30
Ankush Menat
cef0399fa3 build(deps): update RestrictedPython to latest version 2023-08-31 10:51:06 +05:30
Gavin D'souza
d4fe4c7e02 fix(trim-db): Dont show confirm dialog on dry run 2023-08-30 13:04:33 +00:00
dependabot[bot]
dd8f314bf4
chore(deps): bump @adobe/css-tools from 4.2.0 to 4.3.1 (#22247)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-30 16:50:40 +05:30
mergify[bot]
fe3f6fe0c9
fix: The Geolocation Map Field in RTL languages in System (backport #22248) (#22250)
(cherry picked from commit 30dd229032cb77b41e7dda16dbdc3e6b28456ee9)

Co-authored-by: Alaa Alsalehi <alaadiaa@gmail.com>
2023-08-30 15:27:57 +05:30
Ankush Menat
d4255eb8b2
Merge pull request #22231 from ruthra-kumar/typeerror_on_custom_reports
fix: `typeerror` on custom reports
2023-08-30 12:03:12 +05:30
Raffael Meyer
1dcf1d1f4b
Merge pull request #21874 from blaggacao/fix-website-asset-discovery 2023-08-29 19:23:55 +02:00
Ankush Menat
487d9fb61f
chore: use isinstance 2023-08-29 22:02:52 +05:30
ruthra kumar
cf24c46128 refactor: filter on names while fetching custom fields
post https://github.com/frappe/frappe/pull/22133, `link_field` should
be a dict to facilitate passing primary key `name` for filtering

query_report.py has been modified to be backward compatible with old
`str` type link_field as well
2023-08-29 20:49:09 +05:30
Ankush Menat
e88cdb6e70
Merge pull request #22224 from ankush/desk_user
feat: `Desk User` role
2023-08-29 20:27:21 +05:30
Ankush Menat
04b2c42778
Merge pull request #22239 from ankush/reveal_missing_perm
fix(UX): Highlight which permission is missing
2023-08-29 20:25:12 +05:30
Ankush Menat
edfeb0d932 fix(UX): Highlight which permission is missing 2023-08-29 19:11:58 +05:30
Ankush Menat
fd44142893
Merge pull request #22233 from ankush/rename_merge_prevent
fix: dont allow rename+merge for case changes
2023-08-29 18:20:58 +05:30
Ankush Menat
5fd0dfb163 fix: dont allow rename+merge for case changes 2023-08-29 18:03:16 +05:30
Ankush Menat
92d11d9f1f fix: revert communication doctype default
This breaks for users who dont have "inbox" which is a lot of users.
2023-08-29 17:21:18 +05:30
ruthra kumar
b0ed1735c2 fix: typerror on custom reports 2023-08-29 15:48:39 +05:30
Ankush Menat
8176b86b25 fix: notification_settings has_permission hooks 2023-08-29 13:26:48 +05:30
niraj gautam
dff426a267
fix: Do not allow newsletter scheduling with past date (#22204)
* fix: newsletter scheduling

* fix: Add required prop on schedule dialog

* refactor: Add validation in newsletter.py

* test: fix scheduled newsletter test

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-08-29 06:49:52 +00:00
Ankush Menat
85956ed0c1 test: switch user before modifying other user 2023-08-29 12:07:58 +05:30
Ankush Menat
2f4c5c63aa test: fix ldap test 2023-08-29 12:07:58 +05:30
Ankush Menat
dc8d7b019a refactor!: Lower roles from All To Desk User 2023-08-29 12:07:57 +05:30
Maharshi Patel
7e89b73c84 fix: updated sidebar
- fixed attachment button
- made button text ellipsis
- fixed margin and padding for shared and assigned avatars
2023-08-28 23:56:35 +05:30
Maharshi Patel
b042f4c71e fix: change datatable styles to match new design 2023-08-28 23:55:25 +05:30