Commit graph

4717 commits

Author SHA1 Message Date
phot0n
cb796a4e64 refactor(minor): better notification
* changed completed_at fieldname to ended_at (in submission queue doctype)
* added rollback on exception in queue_in_background method
2022-10-06 13:06:03 +05:30
Aradhya
ae24f17e42 refactor: changed field order & added depends on 2022-10-05 22:40:59 +05:30
Aradhya
d4a0ad436c feat: Added completed_at field and better naming 2022-10-05 16:11:11 +05:30
Aradhya
b15e07dd79 refactor: better locking and unlocking 2022-10-05 15:58:49 +05:30
Aradhya
1230b78337 fix: locking the correct doctype 2022-10-05 15:50:48 +05:30
Aradhya
4bdffe73dd refactor: moved background submit to Submission Queue DocType
Co-authored-by: phot0n ritwikpuri5678@gmail.com
2022-10-04 23:06:46 +05:30
Aradhya
33acaf7efd fix: unlock document when action is executed 2022-10-04 17:24:27 +05:30
Aradhya
198bc39085 refactor: moved submission from document class 2022-10-04 17:20:14 +05:30
Aradhya
9cc826541f fix: fixed functionality 2022-10-04 02:41:14 +05:30
Aradhya
eae73ae5d4 feat: log reports for queued submits 2022-10-03 17:36:33 +05:30
Aradhya
1df308e5b7 Merge branch 'develop' of https://github.com/frappe/frappe into bg-submissions 2022-10-03 15:11:14 +05:30
Raffael Meyer
513321810d
fix(Data Import): don't validate empty values (#17923)
* refactor: exclude header from column values earlier

* fix: don't validate empty columns

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-10-03 10:57:42 +05:30
Cleo Menezes Jr
af24bbff1b
fix: Show Report button should appear only if the doc is saved (#18268) 2022-10-01 00:10:55 +05:30
Aradhya
8b1a01e4b7 refactor: changed field name & removed queueing from save 2022-09-30 19:25:06 +05:30
Aradhya
7ed111aff7 Merge branch 'bg-submissions' of https://github.com/Aradhya-Tripathi/frappe into bg-submissions 2022-09-28 19:00:47 +05:30
Ankush Menat
967cc26fab feat: capture custom values in frappe monitor
lets monitor add extra info for:
- Save/Submit by doctype
- Report generation time by standard report name
2022-09-25 15:07:30 +05:30
Aradhya
f62d1540cf feat: Background submissions for submittable doctypes 2022-09-24 14:00:55 +05:30
Ankush Menat
3203dc8c1f
fix: filter out inactive workers (#18200)
[skip ci]
2022-09-21 12:15:03 +05:30
Ankush Menat
1c06b331ef
Merge pull request #18178 from phot0n/restrict-ip-text
fix: change fieldtype of restrict_ip from data to small text
2022-09-19 18:56:26 +05:30
Sagar Vora
6c6a969d3a perf: simpler, faster meta cache 2022-09-19 16:21:11 +05:30
phot0n
359f0c3dcb fix: change fieldtype of restrict_ip from data to small text 2022-09-19 16:07:38 +05:30
Rucha Mahabal
da5a6d3f24
fix: show Roles child table for custom reports (#18139) 2022-09-15 19:54:07 +05:30
Ankush Menat
7453e8e3a1 perf: drop all old parent indexes
- re-add parent index on custom_docperm
2022-09-14 14:28:47 +05:30
Ankush Menat
3a5a45d8af perf: drop many unused indexes
- reference owner - only used for activity page which is unusable
  *anyway*
- same for timeline and link doctypes

perf: drop unused index from Commment

Can't find a single  query that uses this index

perf: drop pointless "Is home folder" index

just why? It's checkbox index with 1 entry which has unique name already

Most pointless index I've seen no far.

perf: Drop "attached to doctype" separate index

There is already a composite index for this.

perf: drop indexes from web page view log

BOTH are totally unused in any of the queries related to this doctype.

Only "website analytics" report uses this which doesn't even show this
data lmao.

perf: drop unused index from EPS log

We never filter by doctype or type. pointless indexing.

perf: fix up notification log indexes

- drop unused index
- add "for user" index
2022-09-14 14:28:47 +05:30
Ankush Menat
4120d5a8e3
fix: RQ job name when func object is passed (#18112)
[skip ci]
2022-09-13 19:10:21 +05:30
Ankush Menat
1a60049af0
refactor: simpler job queued checking (#18091) 2022-09-12 12:59:00 +05:30
Ankush Menat
11936a76df feat: kill a running background job -f
Also refactor permission checks
2022-09-12 11:49:25 +05:30
Ankush Menat
2267d40420 test: add tests for bg job monitoring code 2022-09-12 11:49:25 +05:30
Ankush Menat
fc048ae5e3 refactor!: remove background jobs page 2022-09-12 11:49:25 +05:30
Ankush Menat
4ae85b20db feat: auto refresh RQ job page 2022-09-12 11:49:25 +05:30
Ankush Menat
46df97c3f2 feat: show scheduler status on RQ job page 2022-09-12 11:49:25 +05:30
Ankush Menat
c021b07255 fix: disable count and stats 2022-09-12 11:49:25 +05:30
Ankush Menat
dca6592b7e feat: delete background jobs from form views 2022-09-12 11:49:19 +05:30
Ankush Menat
fc0ff7bd2e feat: RQ job doctype 2022-09-12 11:49:05 +05:30
Ankush Menat
330bd08210 feat: RQ worker virtual doctype
Enuff manual JS and HTML crap, lets reuse list and form views!
2022-09-11 11:44:12 +05:30
Ankush Menat
f5a45a7e78 fix: erase default before adding new series-es 2022-09-10 13:14:23 +05:30
Ankush Menat
62d65aa843 perf: drop useless indexes from view log 2022-09-09 17:34:46 +05:30
Ankush Menat
55617b9e86 fix: defer logging during read only mode
Deferred:
- Error log
- view log
- web page view

Disable:
- "_seen" tracking used on list view to highlight unseen docs.
- "seen" on error log.
- dashboard chart last ts caching
2022-09-09 17:34:46 +05:30
Nikhil Kothari
89b2e5133f
feat: option to disable user pass based login (#18000)
* Added checkbox to disable pass login in settings

* Added user_pass disable option in Login page context

* Hide user-pass fields when option disabled

* Added check for social login key and LDAP

* feat: Disable API based usr-pwd login

* style: format with black

* refactor: simpify auth validation

No need for else clause

* refactor: fixup sys setting json and move field

* refactor: sys settings validation

* refactor: simpler imports

* chore: undo unintional changes

* test: add test for disabled user pass

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-06 13:48:00 +05:30
Ankush Menat
8541fa4cd3 refactor: dont fetch whole doc for 1 value. 2022-09-02 17:47:30 +05:30
HENRY Florian
df9e8c62dd
feat: review Custom and Build workspace, move background Job to Build Workspace (#17981)
* feat: review link for Custom, build and NavBar

* feat: review link for Custom, build and NavBar

* feat: review link for Custom, build and NavBar

* feat: review link for Custom, build and NavBar

* feat: review link for Custom, build and NavBar

* feat: review link for Custom, build and NavBar

* chore: linter json

* fix: replace Block Module By Module Profile

* chore: cypress test

* chore: reset package.json to develop

* refactor: workspace link, system logs section

- removed workspace listview link, visiting list view isn't required for
  practically all the tasks
- Frappe Logs -> System Logs

[skip ci]

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-02 11:20:59 +05:30
Aradhya Tripathi
befc1b9db8
Merge branch 'develop' into get-all-mod 2022-08-31 15:45:50 +05:30
Ankush Menat
d91e8260b0 chore: add route history to default log clean up 2022-08-30 17:34:18 +05:30
Aradhya Tripathi
d2b11deb41
Merge branch 'develop' into get-all-mod 2022-08-27 20:46:44 +05:30
Ankush Menat
e8af6b2c16 feat: make attachments public on doctypes
When this checkbox is checked, while uploading docs using fileuploader
the default visibility will be set to "public".

At present all uploaded attachments are private, however in following
cases it makes sense to set default as public:

1. Blog post
2. Item catalog
3. Website item

Considering this we decided to add this configurtion so developers can
specify sane default while user still has control over it using
"Customize form"

Enabled this for "blog post" doctype

Unrelatd change: consistent "form settings" section on DocType and customize
form
2022-08-26 12:42:26 +05:30
Suraj Shetty
81fa146330
fix: Do not show "Not Saved" on loading System Settings (#17967) 2022-08-26 10:44:51 +05:30
Aradhya Tripathi
80e64c7143
Merge branch 'develop' into get-all-mod 2022-08-24 19:46:46 +05:30
Raffael Meyer
63a60c6457
fix: translate import warnings (#17924) 2022-08-24 11:37:41 +05:30
Sagar Vora
2866721a78 test: clear lang_full_dict from local cache 2022-08-22 19:04:18 +05:30
Aradhya Tripathi
caf171b363
Merge branch 'develop' into get-all-mod 2022-08-22 14:53:35 +05:30