Commit graph

713 commits

Author SHA1 Message Date
Kunhi
2596fb7a2f
fix: Unable to save JSON field type in the customize form. (#27472)
* fix: Unable to save JSON field type in the customize form

* fix: run pre-commit

* precommit, fix

* precommit, linter issue
2024-08-22 12:49:01 +05:30
Nabin Hait
e54274f290
chore: Deleted all the form tours (#27403) 2024-08-20 10:39:40 +05:30
Rushabh Mehta
37b7fa59b1 fix(styles): various styles and updates to workspaces 2024-08-19 12:06:55 +05:30
mergify[bot]
65ce529a04
fix: front-end bug in 'customize_form.js', triggered by delete actions on child-tables (#26344) (#26644)
* fix: Doctype Links not updating #26041
https://github.com/frappe/frappe/issues/26041

In refresh_field(fieldname, txt) function of grid_row.js, added the comments :-
    // the below if statement is added to factor in the exception when this.doc is undefined -
    // - after row removals via customize_form.js on links, actions and states child-tables
    if (this.doc)
            field.docname = this.doc.name;

* fix: Doctype Links not updating frappe#26041

In customize_form.js :-
defined parent and parenttype as local variables in the event functions for child tables links, actions and states

* Revert "In customize_form.js :-"

This reverts commit 6732f0aec4733490da46d7bd5cbedf239d13ec89.

* fix: Doctype Links not updating #26041

* style: amended spacing as per 'prettier' in precommit

* style: added comma after last event definitions in child doctype, as per 'prettier' in precommit

(cherry picked from commit b9f48455be10b40ab53375d7aef9fbaac644aea6)

Co-authored-by: Karan Wilson <48678570+karanwilson@users.noreply.github.com>
2024-06-03 12:25:14 +05:30
David Arnold
a99c4ff2b0
fix: don't sanitize defaults and options (#25939) 2024-04-15 17:39:48 +05:30
Ankush Menat
a0268f126f fix: Dry run and confirm before trimming tables 2024-04-12 10:55:47 +05:30
barredterra
9238f4649f feat(Customize Form): add "Trim Table" action 2024-04-11 19:07:32 +02:00
Ankush Menat
12a8e9e666 fix(DX): Warn about custom docperm behaviour 2024-04-11 18:26:30 +05:30
Akhil Narang
2bf0ab079a
feat(customize_form): allow setting creation as a default sort field (#25760)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-01 19:08:11 +05:30
Ankush Menat
dbcf7ad30c refactor: update usage of modified everywhere 2024-03-27 11:23:13 +05:30
Ankush Menat
3896296c6f fix: update sort order in doctypes 2024-03-27 11:18:28 +05:30
Ankush Menat
02fd017204 fix: allow transitioning to long text 2024-03-15 15:00:07 +05:30
Ankush Menat
166d28a4d3 fix: handle invalid fetch from split
Some users have manged to write fetch expr with 2 dots 🤷
2024-03-12 22:30:00 +05:30
Raffael Meyer
eecb31e8e8
Merge pull request #25285 from barredterra/custom-field-translatable-default 2024-03-11 11:39:50 +01:00
Ankush Menat
4f4a387b7e
fix(patch): Remove obviously invalid fetch from expressions (#25284) 2024-03-10 07:36:12 +00:00
barredterra
b26dcdc14f fix: do not mark custom field as translatable by default
This is a special feature that should be enabled explicitly. In DocField, it's already disabled by default.
2024-03-07 17:37:40 +01:00
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options (#25211)
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
Ankush Menat
af69dab130
fix(UX): reload form after renaming field (#25159) 2024-02-29 04:26:52 +00:00
Ankush Menat
dab06f33b1
fix: add show_dashboard field on custom fields (#24984)
closes https://github.com/frappe/frappe/issues/23637
2024-02-21 12:58:34 +00:00
Raffael Meyer
fc64e8a0fb
feat: pass doctype as context when translating label (#24903) 2024-02-18 19:42:15 +05:30
Ankush Menat
72c2207e0f refactor: useless use of dict in frappe.get_doc 2024-02-10 12:52:38 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Indrajith.vs
0314502742
fix(Custom Field): Button Rename Fieldname visible before saving (#24712) 2024-02-03 12:40:50 +05:30
Ankush Menat
4553de8ba0
fix: never show virtual fields in list view (#24666)
* fix: never render virtual fields in list view

* fix: Hide "in list view" for virtual columns
2024-02-01 16:22:07 +05:30
Indrajith.vs
754ac4abeb
fix(Custom Field): default fieldname in rename fieldname prompt (#24492) 2024-01-24 16:32:50 +05:30
Ankush Menat
f6388f6357
fix: Skip no-value fields for rename (#24163) 2024-01-08 12:50:34 +05:30
Ankush Menat
c7e5afee6a refactor: Use arr.includes(item) instead of in_list(arr, item) 2023-12-27 19:33:13 +05:30
Akhil Narang
178b699466
Merge pull request #23432 from marination/doc-connections
fix: Treat Document Links entries as all non-std fields
2023-12-19 16:05:58 +05:30
Akhil Narang
e38b5e04f8
fix(test_customize_form): drop checking of flags.update_db
The value changed is being checked directly
Checking the flag breaks if this or a similar test is run multiple times on the same database

Also extract 255 into a separate variable

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-19 15:50:13 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified (#23697)
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
Ankush Menat
7edb80bf5c
fix: correct error message (#23746)
[skip ci]
2023-12-12 14:49:37 +05:30
barredterra
35d6e70382 feat: add sender_name_field 2023-12-01 18:39:39 +01:00
Raffael Meyer
7e08f003b3
fix: translate customize form (german) (#23497)
* fix: show translated doctype names

* fix: german translations for customize form
2023-11-30 00:18:52 +05:30
Corentin Flr
82623e5977
chore(translations): Remove extra space at end of line
When editing translation CSV manually in a text editor, one does not always disable the "trim trailing whitespace" feature. This can lead to mis-translations and duplications (when using `bench get-untranslated`).
2023-11-27 12:17:27 +01:00
Shariq Ansari
584d43aea5 fix: change tab to form if doctype is set in customize form 2023-11-16 11:40:40 +05:30
Shariq Ansari
3341333a3a fix: combined details and settings tab in customize form 2023-11-16 11:40:04 +05:30
RitvikSardana
0c4245634f
feat: Apply Filters to Link Fields Via Form Builder (#22844)
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-11-15 11:34:19 +05:30
Shariq Ansari
bce95096f6 chore: show fields table in customize form 2023-11-07 19:28:00 +05:30
Shariq Ansari
441e115493 chore: hide fields table in customize form 2023-10-31 02:05:55 +05:30
Sagar Vora
f08f128b1c fix: improve label and description for fetch_if_empty 2023-10-26 15:02:03 +05:30
Maharshi Patel
bbf91b8afc
fix: sync doctype layout on update standard field (#22699)
* fix: sync doctype layout on update standard field

When standard field is deleted & it is not updated in the doctype layout,
Error occurs as it will try to render fields that doesn't exist
and layout won't render.

to fix this, sync doctype layout on update standard field

* refactor: use savepoint decorator

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-10-16 12:19:17 +05:30
Ankush Menat
0d5f28d569 feat: rename custom field 2023-09-25 12:25:28 +05:30
Ankush Menat
9436c14265 chore: treat background submit as beta feature 2023-08-31 11:59:40 +05:30
Ankush Menat
dc8d7b019a refactor!: Lower roles from All To Desk User 2023-08-29 12:07:57 +05:30
Shariq Ansari
ac775c0e68 fix: removed duplicate doctype_properties from customize form 2023-08-16 13:46:52 +05:30
mergify[bot]
fd10ab25cc
Merge pull request #22003 from gavindsouza/refactor-doc-bits
refactor: Use single query to delete child rows on doc.save
2023-08-11 06:45:07 +00:00
Gavin D'souza
84f134a683
fix: Add "better" typing hints 2023-08-11 11:45:47 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
Ankush Menat
927cd647e4 chore: generate type annotations 2023-07-24 15:32:48 +05:30