Commit graph

196 commits

Author SHA1 Message Date
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
Ankush Menat
bbcc365a24
fix: use monotonic clock for timing code (#19138)
* fix: use monotonic time for timing code

`time.time()` depends on system clock which can drift away and get corrected
over time. If you're unlucky it will get corrected in your timing code
and give absurd results.

* test: dont check for status

can refresh and give wrong output

[skip ci]
2022-12-06 15:42:37 +05:30
Mohammad Hussain Nagaria
a534e7a66a
fix: Pass *args and **kwargs in db_insert boilerplate for Virtual DocType (#19018)
[skip ci]
2022-11-28 11:14:24 +05:30
Ankush Menat
1d186db6a6
fix: disable autocommit before each patch (#18307) 2022-10-06 16:08:39 +05:30
Ankush Menat
b9e757782f
fix: correct boilerplate for virtual doctypes (#18248) 2022-09-28 15:49:15 +05:30
Ankush Menat
e1253e8299 fix: remove ad-hoc maintenance mode implementation 2022-09-09 17:34:46 +05:30
Shariq Ansari
d274b56817 chore: code cleanup 2022-08-19 15:56:44 +05:30
Shariq Ansari
521102b589 fix: update public workspace name with json file 2022-08-16 18:23:23 +05:30
Gavin D'souza
598359c684 test: Reset requirements for export_doc 2022-08-09 15:57:26 +05:30
Gavin D'souza
ca1291f924 refactor: modules.utils
* indent de-indented is_virtual code block
* add typing, revert previous breaking changes
2022-08-09 13:39:23 +05:30
Gavin D'souza
624c308659 Merge branch 'develop' of github.com:frappe/frappe into modules-refactor 2022-08-08 12:27:11 +05:30
Ankush Menat
e8efd64dbc refactor!: better API contracts for virtual doctype
Current APIs implement class methods as instance method, which is
problamamtic while implementing methods. E.g. If load_from_db doesn't
like empty docname then all class method will stop working.

This change while breaking is essential for usability of virtual
doctype.
2022-07-22 14:26:02 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Ankush Menat
1e64abe9a5 fix!: meaningful error messages over KeyError 2022-05-29 13:46:48 +05:30
chillaranand
d2b63d0935 feat: Added force flag to install-app command 2022-05-11 16:18:14 +05:30
Gavin D'souza
f463d45a61 Revert "perf: Glob filesystem instead of DB reads etc"
This reverts commit c9fa6931ff.
2022-04-21 15:24:40 +05:30
Gavin D'souza
c9fa6931ff perf: Glob filesystem instead of DB reads etc
Why speak more word when less word do trick
2022-04-14 13:30:35 +05:30
Gavin D'souza
6538419e5d fix: Add return values to enable better testing ;) 2022-04-14 13:29:20 +05:30
Gavin D'souza
d7abbe0e10 refactor: frappe.modules.utils
* Simplified logic and got rid of multi-level indents
* Better error & debug messages
* Better code readability
* Optimized conditions
* Added type hints
* Refactored raw query to QB
2022-04-14 09:05:19 +05:30
Gavin D'souza
3cd047becf fix: Obey force kwarg frappe.reload_doc 2022-04-13 19:22:46 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Mohammed Redah
60814c4e3f
fix: Export Links in Customize Form (#16333)
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2022-04-10 07:46:43 +05:30
Sagar Vora
833eeff1c4
fix: remove hyphen from class name while creating boilerplate (#16391) 2022-03-24 17:55:09 +05:30
mergify[bot]
c3e350f2c6
chore: typo mistake (#16275) (#16285)
(cherry picked from commit e997d82da3d5fa74f90fdd878bb0bd8a80bbbc06)

Co-authored-by: Bhavesh Maheshwari <34086262+bhavesh95863@users.noreply.github.com>
2022-03-15 15:02:44 +05:30
Gavin D'souza
96d298abf4 feat(minor): Add patch docstring if available in patch runner 2022-02-28 17:41:31 +05:30
Ankush Menat
01dc744aed fix: only check migration_hash on doctype
other documents dont have this field, hash based migration is only for
doctypes.
2022-02-23 14:11:30 +05:30
phot0n
b31f3c24f6 refactor: remove parent, parenttype, parentfield, idx columns from non-child table doctypes
* feat: add parent, parenttype, idx, parentfield columns to doctypes when transitioning from normal -> child table

* fix: remove parent, parenttype, parentfield, idx from DocType DocType
2022-02-07 15:12:37 +05:30
mergify[bot]
028bb9eb06
Merge pull request #15722 from hrwX/virtual_dt
feat: get_count, get_stats for virtual doctype
2022-01-27 04:39:57 +00:00
Ankush Menat
8b30b61c3e fix: allow empty patches.txt 2022-01-27 09:34:41 +05:30
Ankush Menat
fd227d38f4
feat: post model-sync patches (#15351)
Ability to run a few patches after the doctype model schema is synced.

Read module-level docstring of patch_handler.py for more info.
2022-01-26 11:21:30 +05:30
hrwx
26a70e3cf1 feat: get_count, get_stats for virtual doctype 2022-01-25 10:16:28 +00:00
barredterra
c92e6ab85d fix: import doc / fixtures 2021-12-13 19:02:51 +01:00
barredterra
2ab030c4d8 fix: update modified of Singles 2021-12-10 12:26:32 +01:00
Gavin D'souza
46a8e20ac2 fix: Don't export migration_hash column in std json
Fixes https://github.com/frappe/frappe/issues/14563
2021-10-25 14:45:03 +05:30
abhishek
ba78852c73 docs: add docstring for import_file_by_path 2021-10-12 17:15:12 +05:30
abhishek
86f29aeaa3 fix: missing logical cases
- handle first time imports
- update hash and timestamps
2021-10-12 03:21:08 +05:30
Gavin D'souza
2622f3398e style: Black-ish queries
* feat(minor): Added DocType to frappe.query_builder namespace
2021-10-11 19:00:52 +05:30
abhishek
547111841a refactor: sql in update_modified() to frappe.qb 2021-10-11 18:58:15 +05:30
abhishek
3ac65adb94 style: misc changes 2021-10-11 18:57:46 +05:30
abhishek
822fdce4d6 fix: doctype doc hash creation 2021-10-11 17:23:17 +05:30
abhishek
278883edb0 fix: missing migration hash column 2021-10-11 17:23:17 +05:30
abhishek
b2b391e90a style: misc 2021-10-11 17:23:17 +05:30
Gavin D'souza
db6fc6a5fb feat: Hash based comparison migration 2021-10-11 17:23:17 +05:30
Rushabh Mehta
5befc80cd4 fix(minor): linting 2021-09-05 22:30:09 +05:30
Rushabh Mehta
20dea90670 feat(minor): Packages! also cleanup of DocField and other minor fixes 2021-09-05 22:01:55 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
32c6cf1c44 refactor(misc): frappe.db.delete > frappe.db.sql
Use frappe.db.delete wherever possible. Get rid of all the frappe.db.sql ;)

This commit focuses on the pending modules that had relatively easier
DELETE statements.
2021-08-19 19:53:16 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
barredterra
3632a32272 fix: print warning and add comments 2021-05-13 15:59:39 +02:00
Raffael Meyer
aa06b63eb6
refactor: getattr
Co-authored-by: gavin <gavin18d@gmail.com>
2021-05-12 20:54:06 +02:00