Commit graph

43715 commits

Author SHA1 Message Date
Nabin Hait
04c2944886 fix: Delete from cache after deleting a server script 2023-10-15 19:16:13 +05:30
Ankush Menat
e9629bc04e
Merge pull request #22700 from akhilnarang/failed-email-notification
fix(UX): send out a system notification when email sending + retries fail
2023-10-14 13:15:39 +05:30
Ankush Menat
fb34d49703
Merge pull request #22724 from ankush/oauth_signups_exc
feat: let social login keys control signups
2023-10-14 13:07:10 +05:30
Ankush Menat
e1f2f4bb54 fix: Let social login key control signups
There are cases where certain social login keys

- Should not allow signups at all and only allow logins. E.g. social media login keys.
- Should allow signups even if global sign ups are disabled. e.g. internal SSO like setups.
2023-10-14 12:43:48 +05:30
Ankush Menat
65455ffa89 fix(DX): Add simple cron explanation next to cron fields
closes https://github.com/frappe/frappe/issues/21166
2023-10-14 11:27:18 +05:30
Akhil Narang
41d524c9a0
chore: add in a test for failed email notification
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-13 18:16:32 +05:30
Ankush Menat
c6f7c1f709
Merge pull request #22720 from cogk/fix-dont-mutate-df-in-frappe-format
fix: Don't mutate `df` object in frappe.format
2023-10-13 17:56:28 +05:30
Corentin Forler
7c9954e724
fix: Don't mutate df object in frappe.format
When customizing the **Communication** DocType by setting the property `in_list_view` for the field `_user_tags` to `1`, the *fieldtype* of the `_user_tags` docfield can be mutated to `"Tag"` by the `frappe.format` function called during the list view rendering. Then, when opening a Communication form view, the layout tries to render the `_user_tags` field which has the invalid fieldtype `"Tag"`, which crashes the rendering of the form.
2023-10-13 12:16:57 +02:00
Ankush Menat
083aa8a11c
Merge pull request #22659 from barredterra/like-in-list
feat(listview): move likes to the right
2023-10-13 15:40:34 +05:30
Ankush Menat
29544fb971
Merge pull request #22650 from barredterra/form-sidebar-stats
fix: like/comment icons and count
2023-10-13 15:39:30 +05:30
Ankush Menat
52d6bd67e4 fix: Always return document from doc.insert 2023-10-13 15:34:03 +05:30
Ankush Menat
e72b03adaf refactor: handle notification failure 2023-10-13 14:59:00 +05:30
Ankush Menat
497807cbbc
Merge pull request #22713 from akhilnarang/fix-docstring
fix(model/document): add missing parameters to docstring and fix return type annotation
2023-10-13 14:53:42 +05:30
Akhil Narang
1482ad68c9 fix(model/document): add missing parameters to docstring
[skip ci]

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-13 14:51:39 +05:30
Ankush Menat
ce0c2fc41b
Merge pull request #22716 from akhilnarang/hide-image-upload-if-no-permission
fix: hide `sidebar-image-actions` if the user doesn't have write permission
2023-10-13 14:47:28 +05:30
mergify[bot]
0934f05cb6
Merge pull request #22714 from akhilnarang/type-exporter-cleanup
fix: method name typo and return type annotation
2023-10-13 04:25:50 +00:00
Akhil Narang
8b3359520a
fix: hide sidebar-image-actions if the user doesn't have write permission
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-12 18:50:01 +05:30
Akhil Narang
85c3be814d
fix(exporter): some methods had the wrong return types
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-12 13:57:48 +05:30
Akhil Narang
92218e443b
chore(exporter): fix typo in method name
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-12 13:57:48 +05:30
Akhil Narang
65d6c20d9e
feat: send out a system notification when email sending + retries fail
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-12 13:34:50 +05:30
mergify[bot]
c9bba3c1b2
Merge pull request #22705 from akhilnarang/drop-deprecated-method
chore: drop usage of the deprecated `distutils.version.LooseVersion`
2023-10-11 15:04:34 +00:00
Akhil Narang
0be3b61aec
chore: drop usage of the deprecated distutils.version.LooseVersion
Use `packaging.version.Version` instead

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-11 20:13:59 +05:30
Ankush Menat
fc16af2ac9 fix: fallback to mysqldump if mariadb-dump isn't available 2023-10-11 19:30:36 +05:30
Ankush Menat
e47492b4db
Merge pull request #22703 from ankush/restore
fix: backward compatible get_site_path
2023-10-11 19:00:54 +05:30
Ankush Menat
404f3fbeec test: add better test for backup restoration
Before restore:
- Wipe DB, files.

After restore:
- Actually check if things got restored.
2023-10-11 18:39:12 +05:30
Ankush Menat
9983bf82e6 fix: backward compatible get_site_path
Before: `./sitename`
After:  `sitename`

This used to return `.` before, even though these are paths identical
they aren't REALLY. Tar command strips 2 subpaths so this ended up
breaking file restores.
2023-10-11 17:30:13 +05:30
Shariq Ansari
bad161ad89
Merge pull request #22655 from maharshivpatel/fix-workspace-filters 2023-10-11 15:57:57 +05:30
Shariq Ansari
7d4de5675c
chore: remove deprecated message 2023-10-11 15:35:53 +05:30
Shariq Ansari
0c4021a1a5
Merge pull request #22701 from shariquerik/permission-table-getting-empty 2023-10-11 15:33:12 +05:30
Shariq Ansari
f8c090ffa8 fix: load doctype model instead of using frappe.model.with_doctype 2023-10-11 15:01:26 +05:30
Suraj Shetty
9d21848c60
Merge pull request #22484 from frappe/SaiFi0102-patch-2 2023-10-11 13:50:40 +05:30
Suraj Shetty
dfed8f353e
Merge pull request #22485 from frappe/SaiFi0102-patch-3 2023-10-11 13:49:20 +05:30
Saif Ur Rehman
24206de0d0
fix(Email Inline Embed): Unescape embed path (#22291) 2023-10-11 13:47:27 +05:30
Sambasiva Suda
7165f94148
fix: validate_email_addr should return email id as it is if it is valid (#22613) 2023-10-11 12:37:48 +05:30
Ankush Menat
05d7646ab2 chore: disable beta releases 2023-10-11 12:21:29 +05:30
Ankush Menat
2118fcd257
Merge pull request #22696 from ankush/addr_perm
fix: Apply address all perm only if owner
2023-10-11 11:52:00 +05:30
Ankush Menat
bac5f76247 fix: Apply address all perm only if owner 2023-10-11 11:48:51 +05:30
Ankush Menat
6a78e064fe chore: fix translations 2023-10-11 11:38:11 +05:30
Akhil Narang
7474397ee4
feat: enable tabSelect for awesomplete (#22687)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 23:59:25 +05:30
Maharshi Patel
8550e7bded chore: deprecated get_filter_as_json
Instead of removing get_filter_as_json add console warn.
2023-10-10 21:18:20 +05:30
Shariq Ansari
009d9e010b
Merge pull request #22679 from shariquerik/conditional-webform-list-view 2023-10-10 15:47:27 +05:30
Akhil Narang
b601131d8f
fix: don't allow setting an invalid rating (#22633)
* feat: don't allow setting an invalid rating

Convert anything <0 to 0, and anything >1 to 1

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* chore: add in tests for rating

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 15:38:58 +05:30
dependabot[bot]
d24d4f52c3
build(deps): bump postcss from 8.4.24 to 8.4.31 (#22615)
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.24 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.4.24...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-10 14:17:12 +05:30
Suraj Shetty
3d8461a7af
Merge pull request #22674 from surajshetty3416/fix-reportview-filter 2023-10-10 14:12:44 +05:30
Suraj Shetty
d6fc9be930
Merge pull request #22619 from GursheenK/audit-trail-write-permission 2023-10-10 13:35:30 +05:30
Suraj Shetty
c8f3389ba7
Merge pull request #22439 from dhiashalabi/fix-child-table-select-search-link-permission 2023-10-10 13:32:45 +05:30
Suraj Shetty
3a5f8ecaa5
Merge pull request #22555 from cogk/fix-notpermittedpage-redirect-if-startwith-app 2023-10-10 13:29:04 +05:30
Shariq Ansari
46f3b5b12d fix: changed table style to match grid style
updated description and some minor fixes
2023-10-10 12:53:21 +05:30
Akhil Narang
091ebdd8dc
refactor(treewide): use mariadb commands directly instead of mysql (#22620)
This has been done because the mysql command issues a deprecation warning now

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 12:49:16 +05:30
Maharshi Patel
7752136081
fix: strip html and show text (#22656)
* fix: strip html and show text

Quill editor adds html which is useless for user so strip html using  html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description).

* fix: remove placeholder text

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-10-10 12:29:36 +05:30