Commit graph

2618 commits

Author SHA1 Message Date
AarDG10
a9d98723b4 test: add test to check if reply is restricted to owner 2026-04-28 15:51:47 +05:30
AarDG10
befd7f313c fix(discussion_topic): add perm. check to submit_discussion method
Users should not be able to edit someone else's replies. Forbidding it w/ this check.
2026-04-28 11:19:10 +05:30
Soham Kulkarni
57a94ca566
Merge pull request #38726 from sokumon/default-workspace 2026-04-20 14:28:25 +05:30
sokumon
767099268a fix: consider default workspace after login 2026-04-20 01:29:22 +05:30
Kaushal Shriwas
87b0824031 fix: skip hidden and mandatory check when allow_incomplete is set 2026-04-19 16:49:38 +05:30
Hussain Nagaria
b354a30aed
refactor: more readable conditional 2026-04-13 12:56:25 +05:30
Kaushal Shriwas
334d4d971f fix: validate hidden and mandatory fields without default in web form 2026-04-11 16:57:02 +05:30
Kaushal Shriwas
57854698ce fix: prevent portal list pages from being cached 2026-03-28 00:33:55 +05:30
Sagar Vora
7be05130c7
refactor: remove repetitive use of frappe.get_hooks() (#38197)
* refactor: remove repetitive use of frappe.get_hooks()

* refactor: update variable name

---------

Co-authored-by: harsh patadia <harshpatadia4114@gmail.com>
2026-03-26 12:11:20 +00:00
Ejaaz Khan
a5d65c1b3f
Merge pull request #37026 from UmakanthKaspa/feat/web-form-dynamic-filters
feat: add dynamic filters to Web Form list view
2026-03-20 22:55:01 +05:30
Suraj Shetty
1c6050bf9f
fix(view-log): Accept int for version parameter (#37984) 2026-03-13 06:26:28 +00:00
Felix Ruby
56b574a3bc
fix: merge fieldtype select options to include all form builder elements (#37287) 2026-03-11 08:48:31 +00:00
Kerolles Fathy
26dddcb9d8
fix(webform): respect context banner_image (#37688) 2026-03-02 11:05:40 +05:30
Suraj Shetty
6e974833f5
Merge pull request #37524 from TITANiumRox/dialog-primary-button-spinner 2026-02-26 15:08:47 +05:30
Suraj Shetty
d15a6d6da0 fix: Only show "Edit Values" button if template has something to edit
Closes: https://github.com/frappe/frappe/issues/18612
2026-02-26 11:20:50 +05:30
Aditya Patil
332cad5b18 refactor: added return to pass the thenable back to primary_action in all the dialogs with async calls 2026-02-25 14:01:26 +05:30
Saqib Ansari
9d3dd2a12a chore: merge develop 2026-02-25 12:43:02 +05:30
Suraj Shetty
e1e65238f4
Merge pull request #37013 from stravo1/fix-cached-404-website-permission 2026-02-25 11:38:41 +05:30
Saqib Ansari
6d37b4b8d6 fix: use lucide close icon 2026-02-24 17:21:27 +05:30
Gursheen Anand
24eec8cf44 fix: only check for valid child table fields to compare doctypes 2026-02-24 09:49:20 +05:30
Suraj Shetty
fc2b61e5aa
fix(Web Form): child table link fields break for guest submissions (#37208) 2026-02-23 14:41:48 +05:30
Suraj Shetty
5648e8d430
Merge pull request #36917 from KerollesFathy/fix-remove-duplicated-more-articles-on 2026-02-22 10:57:19 +05:30
Elnegren
df78027f41
fix: deprecated initHighlighting (#36938)
* fix: remove read_only decorator from get_desktop_page
get_desktop_page leads to a call to check_completions which calls save and thus with the read_only decorator calls save on the read replica

* fix: Move write operation out of read only request

* fix: deprecated initHighlighting

Deprecated as of 10.6.0. initHighlighting() is deprecated.  Use highlightAll() instead.

---------

Co-authored-by: Apile Tyumre <apiletyumre@iridescentsun.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2026-02-20 19:47:32 +00:00
Gursheen Anand
0650293a18 chore: merge develop 2026-02-20 07:43:16 +05:30
Aarol D'Souza
08793c57f7
fix: force type check in whitelisted methods 2 (#37086)
* fix(diff): add type hints to whitelisted methods

* fix(global_search): add type hints to whitelisted methods

* fix(custom_html_block): add type hints to whitelisted methods

* fix(deleted_document): add type hints to whitelisted methods

* fix(log_settings): add type hints to whitelisted methods

* fix(role): add type hints to whitelisted methods

* fix(user_type): add type hints to whitelisted methods

* fix(rq_job): add type hints to whitelisted methods

* fix(link_preview): add type hints to whitelisted methods

* fix(email_account): add type hints to whitelisted methods

* fix(web_form): add type hints to whitelisted methods

* fix(web_page_view): add type hints to whitelisted methods

* fix(csvutils): add type hints to whitelisted methods

* fix(file_manager): add type hints to whitelisted methods

* fix(email_body): add type hints to whitelisted methods

* fix(email_queue): add type hints to whitelisted methods

* fix(email_template): add type hints to whitelisted methods

* fix(notification): add type hints to whitelisted methods

* fix(email_group): add type hints to whitelisted methods

* fix(inbox): add type hints to whitelisted methods

* fix(recorder): add type hints to whitelisted methods

* fix(sms_settings): add type hints to whitelisted methods

* fix: tighten type hints

* fix(data_import): add type hints to whitelisted methods

* fix(user_permission): add type hints to whitelisted methods

* fix(gantt): add type hints to whitelisted methods

* fix(like): add type hints to whitelisted methods

* fix(search): add type hints to whitelisted methods

* fix(onboarding_step): add type hints to whitelisted methods

* fix(system_console): add type hints to whitelisted methods

* fix(workspace_sidebar): add type hints to whitelisted methods

* fix(todo): add type hints to whitelisted methods

* fix: correct type hints

* fix(print_format): add type hints to whitelisted methods

* fix(client): add type hints to whitelisted methods
2026-02-19 14:58:16 +05:30
Gursheen Anand
c97cc1a471 chore: remove unused whitelist decorator 2026-02-19 13:03:21 +05:30
Gursheen Anand
3d4a14f7b1 refactor: cleanup process link field 2026-02-18 20:03:38 +05:30
Gursheen Anand
3de1ed26a4 fix: use autocomplete for showing child table links in web form 2026-02-18 14:54:52 +05:30
Soham Kulkarni
739eae4a4e
Merge pull request #36983 from KerollesFathy/fix-kb-layout
fix: adjust padding and layout for knowledge base
2026-02-18 12:51:48 +05:30
Sayantan Ghosh
84bfc8aa91
fix: frappe.call for website now handles 417 errors (#32362)
this is to bring parity between the two `frappe.call` methods: one for the website and one for the framework.
2026-02-18 06:00:27 +00:00
Aarol D'Souza
9eef4f6dae
fix: force type check in whitelisted methods (#37044)
* fix(contact): force type check in contact whitelisted methods

* fix(google_indexing): force type check in google_indexing whitelisted methods

* fix(assignment_rule): add type checks to assignment_rule whitelisted methods

* refactor: remove unused args

* fix(queue): add type hints to whitelisted methods in queue.py

* fix(auto_email_report): add type hints to whitelisted methods

* fix(dashboard): add type hints to whitelisted methods

* fix(sidebar_item_group): add type hints to whitelisted methods

* fix(weasyprint): add type hints to whitelisted methods

* fix(backups): add type hints to whitelisted methods

* fix(document_naming_settings): add type hints to whitelisted methods

* fix(get_latest_submissions): add type hints to whitelisted methods

* fix(custom_field): add type hints to whitelisted methods

* fix(customize_form): add type hints to whitelisted methods

* fix(personal_data_deletion_request): add type hints to whitelisted functions

* fix(__init__): add type hints to whitelisted methods

* fix(prepared_report): add type hints to whitelisted methods

* fix(session_default_settings): add type hints to whitelisted methods

* fix(document_follow): add type hints to whitelisted methods

* fix(route_history): add type hints to whitelisted methods

* fix(form_tour): add type hints to whitelisted methods

* fix(dashboard_settings): add type hints to whitelisted methods

* fix(address): add type hints to whitelisted methods

* fix(contact): add type hints to whitelisted methods

* fix(discussion_reply): add type hints to whitelisted methods

* fix(auto_repeat): add type hints to whitelisted methods

* fix: add the missing type hints and misc. corrections

* fix(email): add type hints to whitelisted methods

* fix(permitted_documents_for_users): add type hints to whitelisted methods

* fix: correct the type hints

* fix: int PK types

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-17 15:16:30 +00:00
stravo1@mac
9dcaab96ee fix(website_404): skip caching 404 for pages with permission checks 2026-02-16 23:41:32 +05:30
stravo1@mac
a534936726 Revert "fix(website_404): cache website 404 results wrt to users"
This reverts commit 697978c8f3.
2026-02-16 22:15:01 +05:30
mergify[bot]
2538873150
Merge branch 'develop' into feat/web-form-dynamic-filters 2026-02-16 07:25:15 +00:00
UmakanthKaspa
740104b88d fix: pre-populate existing values in Web Form dynamic filters dialog 2026-02-15 12:59:45 +05:30
UmakanthKaspa
6dd4539002 feat: evaluate Web Form dynamic filters server-side 2026-02-15 11:03:16 +05:30
stravo1@mac
697978c8f3 fix(website_404): cache website 404 results wrt to users
fixes #37007
2026-02-13 21:37:57 +05:30
UmakanthKaspa
d0d7ef8ae6 feat: add dynamic filters to Web Form list view 2026-02-13 21:17:18 +05:30
KerollesFathy
b6a6fa709c fix(webform): hide navbar/footer settings 2026-02-12 14:40:17 +00:00
KerollesFathy
1820817c95 fix: adjust padding and layout for knowledge base article list 2026-02-11 18:01:03 +00:00
KerollesFathy
ddbda86d45 fix: remove duplicate "More articles on category" link 2026-02-09 21:35:32 +00:00
Shrihari Mahabal
193cb67e9c
fix: bypass size limit check for requesting personal information (#36584)
* fix: bypass size limit check for requesting personal information

* refactor: make size check skip generalized using flags and fix email sending test

* fix: test for large file request

* fix: update file size check flag name

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* fix: Update flag name to skip_file_size_check

---------

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2026-02-09 01:59:06 +00:00
Sagar Vora
ba74006ad8 fix: swap email with self.anon first 2026-01-26 15:39:01 +05:30
sokumon
1c50e3d73d fix: cleanup workspace for website 2026-01-11 23:43:11 +05:30
barredterra
30379b71cb fix: lowercase "row" 2025-12-31 16:11:31 +01:00
sokumon
1a3585a2d0 fix(portal): reroute to /logout from 2025-12-29 10:39:30 +05:30
Akhil Narang
8723a2b6ee
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-22 21:06:48 +05:30
sokumon
0ea047a776 fix: reroute portal users correctly 2025-12-19 20:34:28 +05:30
sokumon
dd2dc053ca chore: more renames to /desk 2025-12-18 20:45:04 +05:30
Sagar Vora
e51ca57097 fix: reduce query and improve logic 2025-12-16 19:20:27 +05:30