Commit graph

1423 commits

Author SHA1 Message Date
Ankush Menat
b8ed8d624c fix: ignore child tables when init-ing parent doc 2022-10-04 14:27:25 +05:30
Ankush Menat
abeed35461
fix: throw exception if backup failed (#18230) 2022-09-28 14:29:38 +05:30
Ankush Menat
0642708f01
perf: use modified instead of creation in scheduler (#18234)
creation doesn't have index and does full table scan. On large site with
~3M activity logs it takes ~1.5 seconds just to begin scheduler.


[skip ci]
2022-09-27 19:21:02 +05:30
Ankush Menat
6ba28061f6
test: flaky API tests due to autherror (#18221) 2022-09-26 12:33:20 +05:30
mergify[bot]
002b27dbdd
fix: pypika does not parse datetime.time (backport #18184) (#18205)
* fix: pypika does not parse datetime.time

(cherry picked from commit b8f5a4304cccda954822cfe69d4805a18d9f07a7)

* fix: style - imports sort order fixed

(cherry picked from commit c3562c643ab9bff38d230202675d8ce1ae190912)

* test: add test for query builder parsing datetime.time

(cherry picked from commit 99889c270199da4b26b0d3858ae0f0a416d49d90)

* fix: format_time instead of format_datetime, test was failing!

(cherry picked from commit 5d697a22ac8cb98c8f8f44b3f99c57b932c5223c)

* fix(style): linter issues

(cherry picked from commit e231e1b0eadf63e84c9f81cfed9e2926e086fc44)

* test: add test for postgres

(cherry picked from commit 695591c43af9672cb83ce856a46c97e0bddfa9c3)

* fix: converting datepart and timepart to strings for Combinedatetime

(cherry picked from commit 1ebda943a607688bfb3db9fb42c80723a9050973)

* fix: style, linter issues

(cherry picked from commit c01262ad02b8831fdb0c5332b6973499e8adf6ad)

Co-authored-by: Anoop Kurungadam <anoop@earthianslive.com>
Co-authored-by: Aradhya <aradhyatripathi51@gmail.com>
2022-09-23 15:46:31 +05:30
Ankush Menat
656f6df257
fix: drop Meta cache during update (#18182) 2022-09-19 19:24:17 +05:30
Ankush Menat
1c06b331ef
Merge pull request #18178 from phot0n/restrict-ip-text
fix: change fieldtype of restrict_ip from data to small text
2022-09-19 18:56:26 +05:30
phot0n
82d0faf3d2 test: use middle_name instead of restrict_ip in test_index_and_unique_constraints 2022-09-19 18:38:47 +05:30
Ankush Menat
c28ddcc3e6 test: basic perf test for rps on get_list 2022-09-19 16:21:20 +05:30
Shariq Ansari
235171796d
fix: coalesce not in queries (#18099)
* fix: get workspaces with empty module fields

* Revert "fix: get workspaces with empty module fields"

This reverts commit 1f194be2c3642e31ebe2165e461b2f24be8cda4c.

* fix: always coalesce `not in` queries

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-13 12:08:07 +05:30
Ankush Menat
fc048ae5e3 refactor!: remove background jobs page 2022-09-12 11:49:25 +05:30
Ankush Menat
0896873c8a test: add test role to user 2022-09-10 12:48:33 +05:30
Ankush Menat
a6b341bd59 test: fix tests using admin account 2022-09-10 12:48:33 +05:30
Ankush Menat
f07bc3b369 test(UI): use non-admin user for tests 2022-09-10 12:48:33 +05:30
Ankush Menat
7f316fa427 test: add api tests for read only mode 2022-09-09 17:34:46 +05:30
Ankush Menat
f96505fae0 feat: wrap read only mode SQL errors 2022-09-09 17:34:44 +05:30
Nikhil Kothari
89b2e5133f
feat: option to disable user pass based login (#18000)
* Added checkbox to disable pass login in settings

* Added user_pass disable option in Login page context

* Hide user-pass fields when option disabled

* Added check for social login key and LDAP

* feat: Disable API based usr-pwd login

* style: format with black

* refactor: simpify auth validation

No need for else clause

* refactor: fixup sys setting json and move field

* refactor: sys settings validation

* refactor: simpler imports

* chore: undo unintional changes

* test: add test for disabled user pass

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-06 13:48:00 +05:30
Sagar Vora
5db5396b49 test: ensure that Vary header is specified 2022-09-05 15:51:41 +05:30
Sagar Vora
5cb440c27f test: use OPTIONS method for CORS tests 2022-09-04 20:20:08 +00:00
phot0n
9a897620fc test: test for root deletion with/out allow_root_deletion 2022-09-02 23:32:00 +05:30
Ankush Menat
e397b27d29 test: upgrade cypress from v6 to v10
chore: run cypress migrator

fix: specPattern should be an array

test: correct intercept URL

This is breaking change in cypress 7.0

test: make list view test rerunnable

test: redo undo tests and add compare doc

test: scroll to action button

chore: drop flaky tests

fix: remove scroll behaviour

fix: clear filters before running count test

test: input delay causes flake
2022-09-02 17:47:30 +05:30
Aradhya Tripathi
9be4daa295
Merge branch 'develop' into get-all-mod 2022-08-30 16:43:04 +05:30
Ankush Menat
f5b8e5f015
perf: short-circuit guest connection and basic perf tests (#17988)
* perf: reorder condition to avoid redis call

* test: basic perf tests
2022-08-30 16:30:25 +05:30
Aradhya Tripathi
d2b11deb41
Merge branch 'develop' into get-all-mod 2022-08-27 20:46:44 +05:30
Ankush Menat
e8af6b2c16 feat: make attachments public on doctypes
When this checkbox is checked, while uploading docs using fileuploader
the default visibility will be set to "public".

At present all uploaded attachments are private, however in following
cases it makes sense to set default as public:

1. Blog post
2. Item catalog
3. Website item

Considering this we decided to add this configurtion so developers can
specify sane default while user still has control over it using
"Customize form"

Enabled this for "blog post" doctype

Unrelatd change: consistent "form settings" section on DocType and customize
form
2022-08-26 12:42:26 +05:30
Raffael Meyer
d05ed27a01
feat: remove subtree (#17647)
* feat: remove subtree

* test: remove_subtree
2022-08-25 11:34:05 +05:30
Aradhya Tripathi
80e64c7143
Merge branch 'develop' into get-all-mod 2022-08-24 19:46:46 +05:30
Ankush Menat
6ec5c05e4e test: simplify user addition test 2022-08-24 14:50:22 +05:30
Alaa Alsalehi
40f54d04b7 feat(bench): add new bench command for add user 2022-08-24 14:29:50 +05:30
Ankush Menat
2623b7e63c test: top bar for website 2022-08-24 11:03:53 +05:30
Ankush Menat
cdb0732646
perf: avoid coalescing wherever possible (#17920) 2022-08-24 10:30:51 +05:30
Sagar Vora
2866721a78 test: clear lang_full_dict from local cache 2022-08-22 19:04:18 +05:30
Aradhya Tripathi
caf171b363
Merge branch 'develop' into get-all-mod 2022-08-22 14:53:35 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Aradhya Tripathi
e73ae6f039
Merge branch 'develop' into get-all-mod 2022-08-19 15:42:35 +05:30
Faris Ansari
82fef72ce1
fix(db-query): parenttype condition on child table left join (#17865)
joining only on name is incorrect because parent primary keys are not unique across tables

How was this working all this time? 🥲
2022-08-18 09:04:40 +00:00
Aradhya
d690bbe7f1 Merge branch 'get-all-mod' of github.com:Aradhya-Tripathi/frappe into get-all-mod 2022-08-17 19:54:55 +05:30
Aradhya
0addffafb9 refactor: minor changes 2022-08-17 19:52:51 +05:30
mergify[bot]
615b27b675
Merge pull request #17854 from netchampfaris/text-editor-has-content
fix: has_content check for fieldtype TextEditor
2022-08-17 11:57:36 +00:00
Ankush Menat
3e2d2a703a test: Use FrappeTestCase everywhere 2022-08-17 16:39:42 +05:30
Ankush Menat
41af9621cd test: undo custom field creation 2022-08-17 16:39:42 +05:30
Faris Ansari
10e49a19b8 test: Text Editor only image content 2022-08-17 15:45:11 +05:30
Suraj Shetty
ae61df8273
Merge branch 'develop' into get-all-mod 2022-08-16 17:07:47 +05:30
Ankush Menat
3ec4a618e3
test: FrappeClient tests not skipped (#17843) 2022-08-16 14:10:12 +05:30
Ankush Menat
53af10a064 refactor!: python pretty_date consistent with JS
Python pretty date was ceiling month and week instead of flooring them,
this is incorrect AND inconsistent with popular JS library pretty date
that we use on client side
2022-08-16 10:53:28 +05:30
Ankush Menat
9de31d03c1 refactor!: timespan utils consistent output
BREAKING CHANGE:

- `get_year_ending` returns datetime.date instead of str
- `get_timespan_date_range` will always return datetime.date ranges
2022-08-16 10:53:28 +05:30
Ankush Menat
3fa4ec1bd6 refactor: container utils and misc tests 2022-08-16 10:53:28 +05:30
Ankush Menat
ad4cb710f2 refactor: duplication in gravatar code 2022-08-16 10:53:28 +05:30
Ankush Menat
9bf9256049 test: validate name 2022-08-16 10:53:28 +05:30
Ankush Menat
26bf65b87c test: phone number validation 2022-08-16 10:53:28 +05:30