Commit graph

2180 commits

Author SHA1 Message Date
Ankush Menat
3a5a45d8af perf: drop many unused indexes
- reference owner - only used for activity page which is unusable
  *anyway*
- same for timeline and link doctypes

perf: drop unused index from Commment

Can't find a single  query that uses this index

perf: drop pointless "Is home folder" index

just why? It's checkbox index with 1 entry which has unique name already

Most pointless index I've seen no far.

perf: Drop "attached to doctype" separate index

There is already a composite index for this.

perf: drop indexes from web page view log

BOTH are totally unused in any of the queries related to this doctype.

Only "website analytics" report uses this which doesn't even show this
data lmao.

perf: drop unused index from EPS log

We never filter by doctype or type. pointless indexing.

perf: fix up notification log indexes

- drop unused index
- add "for user" index
2022-09-14 14:28:47 +05:30
Ankush Menat
06d888126b fix(UX): show read only mode warning on web pages 2022-09-09 17:34:46 +05:30
Ankush Menat
55617b9e86 fix: defer logging during read only mode
Deferred:
- Error log
- view log
- web page view

Disable:
- "_seen" tracking used on list view to highlight unseen docs.
- "seen" on error log.
- dashboard chart last ts caching
2022-09-09 17:34:46 +05:30
Ankush Menat
e8af6b2c16 feat: make attachments public on doctypes
When this checkbox is checked, while uploading docs using fileuploader
the default visibility will be set to "public".

At present all uploaded attachments are private, however in following
cases it makes sense to set default as public:

1. Blog post
2. Item catalog
3. Website item

Considering this we decided to add this configurtion so developers can
specify sane default while user still has control over it using
"Customize form"

Enabled this for "blog post" doctype

Unrelatd change: consistent "form settings" section on DocType and customize
form
2022-08-26 12:42:26 +05:30
Ankush Menat
7e34da6bec build(deps): bump werkzeug
Werkzeug has faster router now
2022-08-26 10:23:09 +05:30
Ankush Menat
2623b7e63c test: top bar for website 2022-08-24 11:03:53 +05:30
Faris Ansari
9358655ae2
fix: 'TopBarItem' object does not support item assignment #17926
TypeError: 'TopBarItem' object does not support item assignment
2022-08-24 10:39:20 +05:30
Shariq Ansari
d17fd03958 chore: moved include script from html to web_form.bundle.js 2022-08-23 17:00:27 +05:30
Shariq Ansari
78ab3d8429 chore: removed unused code 2022-08-23 16:39:14 +05:30
Shariq Ansari
5ca89e0dad revert: use meta fields in standard webforms 2022-08-23 16:33:14 +05:30
Suraj Shetty
3d84a748b7
Merge pull request #17863 from shariquerik/web-form-misc-fixes 2022-08-23 09:54:23 +05:30
Shariq Ansari
2b57e77f29 feat: added not saved indicator if form is dirty 2022-08-22 19:40:51 +05:30
Shariq Ansari
fb8ba3d881 fix: include Color field in Web Form fieldtypes 2022-08-22 18:21:48 +05:30
Shariq Ansari
4b4d66d2a3 fix: title should never be empty 2022-08-22 16:47:15 +05:30
Shariq Ansari
309b42f1a3 fix: show webform name and webform doc name on header 2022-08-22 15:57:46 +05:30
Shariq Ansari
66389932d1 fix: show introduction in edit mode 2022-08-22 13:19:03 +05:30
Ankush Menat
7b3cc322f1
Merge pull request #17891 from ankush/misc_fixes
perf: ~45% faster Desk first response
2022-08-22 11:45:20 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Ankush Menat
4241f8c8c0 perf: simpler/faster preload header computation
We parse entire response to find preload headers, instead just use
include_style and include_script to include assets directly into preload
headers. This shaves off ~13% overhead in response.
2022-08-21 18:46:58 +05:30
Ankush Menat
48869d506f perf: dont order by for uniq searches 2022-08-21 17:37:40 +05:30
Ankush Menat
786df3fbeb perf: ~33% faster Desk response
- hardcode `/app` resolution
- use cached website settings everywhere. It was mixing cache and DB
  everywhere and re-quering same thing (why ?)
2022-08-21 17:35:07 +05:30
Shariq Ansari
5cdf21d8ee fix: minor success page css changes 2022-08-18 16:39:21 +05:30
Shariq Ansari
9288d0cebf fix: replaced clear button with discard button 2022-08-18 13:18:55 +05:30
Shariq Ansari
6ed42f5213 test: fixed failing unit test 2022-08-17 21:37:20 +05:30
Shariq Ansari
7ae2202b75 fix(minor): success page button css (responsive) 2022-08-17 21:00:55 +05:30
Shariq Ansari
05b1a99e53 chore: sider fixes 2022-08-17 20:34:48 +05:30
Shariq Ansari
eb7dccaae2 fix: made web form skeleton responsive 2022-08-17 20:15:22 +05:30
Shariq Ansari
0889d9137f fix: made web form and web list responsive 2022-08-17 20:12:46 +05:30
Shariq Ansari
3c9bc6f1ec fix: moved banner image in to page header section 2022-08-17 20:01:21 +05:30
Shariq Ansari
f03e5e2d1e chore: minor fixes 2022-08-17 19:46:55 +05:30
Shariq Ansari
68318aacd3 fix: added cancel button in clear form dialog 2022-08-17 19:39:42 +05:30
Shariq Ansari
ce67ee1bc6 fix: make clear button link which trigger warning dialog 2022-08-17 19:32:59 +05:30
Shariq Ansari
df3eff1a8d fix: show clear button only if form is dirty and
move previous button on right side if clear button is visible
2022-08-17 19:27:08 +05:30
Shariq Ansari
029bea6774 fix: formatted Section,Column,Page Breaks in webform field table and more
Show fields label in Field column both in web form fields table and web form list column table. Also enabled mandatory field in grid view
2022-08-17 19:14:53 +05:30
Shariq Ansari
0c897e4d22 fix: only allow 9 page breaks in web form 2022-08-17 19:06:23 +05:30
Shariq Ansari
2eb70c381a chore: rearranged web form tabs and fields 2022-08-17 19:02:40 +05:30
Shariq Ansari
fec57546ee fix: show empty fields in web form's view mode 2022-08-17 18:33:59 +05:30
Shariq Ansari
7cd528084e fix: added in_view_mode flag 2022-08-17 18:21:14 +05:30
Shariq Ansari
b0adf07790 chore: renamed is_form_editable to in_edit_mode 2022-08-17 18:14:46 +05:30
Shariq Ansari
f7942a4a8b fix: Keep action button size consistent 2022-08-17 18:11:18 +05:30
Ankush Menat
1c9ea57279 fix: dont use sendmail with now=True 2022-08-17 16:39:42 +05:30
Ankush Menat
3e2d2a703a test: Use FrappeTestCase everywhere 2022-08-17 16:39:42 +05:30
Shariq Ansari
14bcd977b5
feat: Webform Success Page and some customization options (#17790) 2022-08-11 21:18:51 +05:30
Shariq Ansari
cfb56688e9
refactor: Multi Step Web Form (#17783) 2022-08-10 18:05:20 +05:30
Ankush Menat
5d4e1e66b8 refactor!: drop lazy loading utility
Browsers now natively support this with `lazy` attribute.
2022-08-09 18:15:14 +05:30
Ankush Menat
ce164d59e3 fix: limit allowed attributes for lazy images
Co-Authored-by: Sagar Vora <sagar@resilient.tech>
2022-08-09 17:59:45 +05:30
Shariq Ansari
0ce7f44d45
fix: Webform Misc Fix (#17642) 2022-08-07 15:24:50 +05:30
Ankush Menat
40f27f908a style: format JS files with prettier 2022-08-04 14:51:01 +05:30
Gavin D'souza
85e3ee9403 chore: Minified DocType JSON notation from old verbose notation 2022-08-03 12:22:03 +05:30
phot0n
ed39d2c6ed chore: remove payments params from webform's whitelisted accept fuction 2022-07-27 11:00:02 +05:30