Commit graph

1004 commits

Author SHA1 Message Date
Ameya Shenoy
f513739d1a
Merge branch 'master' into staging-fixes 2018-11-28 07:53:35 +00:00
Saurabh
4738a9711a fix: tighten protection against sql injection (#6546) 2018-11-28 10:22:30 +05:30
Ameya Shenoy
3669203acf fix(get_version): from hooks.py instaed of git (#6534) 2018-11-26 12:16:12 +01:00
Nabin Hait
e50e6deed3
fix(fetch from): Always set value based on fetch_from if new doc (#6536) 2018-11-26 16:14:58 +05:30
Ameya Shenoy
d1d0edc636
Merge branch 'master' into staging-fixes 2018-11-23 08:07:36 +00:00
Rohit Waghchaure
d8277d0f98 [Fix] Fetch from works after submission of document 2018-11-22 20:10:08 +05:30
rohitwaghchaure
c247ec17ea fix: child table access using get_list function (#6511)
User was able to fetch child table data without having access from client side using frappe.db.get_list function
2018-11-22 12:44:32 +05:30
rohitwaghchaure
df6687f9c0 fix: After rename, user still able to search document using old name (#6515) 2018-11-22 11:33:29 +05:30
Ameya Shenoy
5a791cd099
Merge branch 'master' into staging-fixes 2018-11-05 06:37:49 +00:00
Saurabh
856a721073 [fix] sql injection fix (#6390) 2018-11-05 10:51:57 +05:30
Suraj Shetty
15d3f4660e fix(security): pop ignore_permissions arg from whitelisted method 2018-11-05 10:29:50 +05:30
Suraj Shetty
0aee7afb87 Fix permission error while import (#6385)
Custom permission should apply while import
or else import of doctype with custom roles fails
2018-11-02 12:19:25 +05:30
Ameya Shenoy
55fbf7ad99
Merge branch 'master' into staging-fixes 2018-10-31 10:40:55 +00:00
Saurabh
a1e68b6fd5 [fix] potential sql injection by sanitizing fields parameter 2018-10-31 14:26:22 +05:30
Shreya
a4f0316119 fix(series): Revert series count after doc deletion 2018-10-25 14:43:31 +05:30
Suraj Shetty
e85589f46c HTML Editor control (#6237)
* Add HTML editor

* Add HTML editor map to db_schema.py

* Revert permission change
- ref #6218

* Fix typo

* Add HTML Editor entry to customize form field

* Update customize_form_field.json

* Update permissions.py

* Debounce preview generation

* Translate strings
2018-10-11 14:07:16 +05:30
Ameya Shenoy
66073c360a
Merge branch 'master' into staging-fixes 2018-10-03 14:51:32 +00:00
rohitwaghchaure
1c8db8fee3 [Fix] Permlevel 1 with read permission fields are not disaplying in the form (#6160) 2018-10-02 10:08:59 +05:30
Suraj Shetty
a380db49a8 Validation fix (#6138)
* Validate set_only_once only on doc update

* Remove redundant error message
2018-09-27 09:16:36 +05:30
Prateeksha Singh
eb5b7a77c9 [Feature] Format Autoname (#6017)
* [Feature] Format Autoname

- Generate autoname by replacing all instances of braced params
- Independent of remaining string or separators.
- Remove autoname Concatenate option

* [autoname] add test for format autoname
2018-09-03 10:58:56 +05:30
Prateeksha Singh
eaafc4d7f5 [child-records] set name in new child records before setting password (#6048) 2018-09-03 10:56:41 +05:30
Rushabh Mehta
624703d1b9 minor: mapping now takes optional args 2018-08-30 18:23:06 +05:30
Rushabh Mehta
00fc9c9b1c fix(fetch): fetch_from will always update after save 2018-08-30 12:16:10 +05:30
Himanshu Mishra
10361383c1 [fix]: use is_async in background jobs instead of async (#5986) 2018-08-20 10:36:26 +05:30
sivankar
a48b76b940 refactored code to add support in filters to get descendant or ancest… (#5847)
* refactored code to add support in filters to get descendant or ancestor for tree type documents

* added semicolon and comments to imporve code quality

* refactored code to add not ancestor and not descendants of filters

* added test cases for ancestors of and descendants of

* Translate labels
2018-08-14 12:19:18 +05:30
Nabin Hait
39e9e306f2 Cached some queries (#5951) 2018-08-09 11:25:07 +05:30
Rushabh Mehta
b1857a5132
optimize(meta): meta is now cached in redis (#5948)
* optimize(meta): meta is now cached in redis

* fix(meta): test fixes

* fix(meta): codacy

* fix(meta): allow nulls to be serialized

* fix(form_meta): fix form meta caches

* fix(form_meta): fix form meta caches

* fix(form_meta): don't cache for developer_mode'
2018-08-09 11:24:42 +05:30
Nabin Hait
7f2a14bdf1 feat(document): frappe.get_cached_doc 2018-08-08 13:04:23 +05:30
Dominik Ottenbreit
feee6cc07e Create more clear docstring for trim_tables (#5863)
* Create more clear docstring for trim_tables

Current DocString was not clear enough. I updated the description to give background information on why this function may be needed.

* Update meta.py
2018-07-24 16:30:00 +05:30
Mohamed_Alsum
803f6b0c7b allow null when time field is not required (#5832)
* allow null when time field is not required

* Update base_document.py
2018-07-23 10:36:42 +05:30
Sushant Nadkar
f8dc45c3c1 Convert doc field value to string type before using (#5795) 2018-07-11 11:11:55 +05:30
Saurabh
a135c6c431 resolved merge conflicts 2018-07-06 13:37:51 +05:30
Ameya Shenoy
5c6b02515a regex fix (#5765)
courtesy: @netchanpfaris
initally the regex used to allow only digits 0-9, not it considers the
entire number range
2018-07-03 14:55:21 +05:30
Suraj Shetty
6ff6a98f8c Return if no link fields found (#5764) 2018-07-02 21:49:07 +05:30
Shridhar Patil
6ec17cc37d ignore save password based on fieldname (#5749)
* ignore save password based on fieldname

* ignore save password if flag is True

* if ignore_password is set  then check for field
2018-06-29 15:52:29 +05:30
Saurabh
e2b1ebe84c [Security][fix] To avoid possible sql injection via filters and or_filters parameters and tighten the field level checks (#5721)
* [fix] sanitize filters and or_filters to avoid sql injection

* add test cases for filter sanitizer

* codacy fix

* added test cases to test valid scenarios
2018-06-27 09:15:42 +05:30
Suraj Shetty
8ef543fdcc Update doctype names in skip_for_doctype field on doctype rename (#5719) 2018-06-26 10:13:37 +05:30
Suraj Shetty
26c6e2928c Move allow self approval check to transisition for more control (#5691)
* Move allow self approval check to transisition for more control

* Disable email alert from workflow test

* Add allow_self_approval to each transition of test workflow

* Remove print statement

* Remove extra blank lines
2018-06-21 09:08:27 +05:30
Shreya Shah
3135f38716 Check if hasattr track_views (#5685) 2018-06-15 11:07:20 +05:30
Shridhar Patil
3f731e904a [feature] Document View logs (#5627)
* Added track view checkbox in doctype

* Add comment to communication whenever user views a document

* typo fixed

* add view log after permission check

* doctype for view logs

* client side changes

* view log doctype updated

* add to view_log whenever a user views a document

* view log changed fields to set only once

* get and retun view logs if available

* add view logs to time line

* doctype view_log: update

* removed print statement

* View log: changed column data to link

* created joint index on reference_doctype and reserence_name

* codacy issues fixed

* changed for loop to es6

* removed frappe.db.commit

check if a doctype has track_views and then get view logs

* view logs made translatable

* set commit flag to true

* Add track views for Event doctype to run test

* test for view log

* test for view log
2018-06-15 09:08:59 +05:30
Nabin Hait
003df19442 update cached link_fields as per new 2018-06-13 17:51:38 +05:30
Suraj Shetty
9e402ec3b5 Clear cache on workflow update (#5677) 2018-06-12 21:50:36 +05:30
Charles-Henri Decultot
c2b49ce572 Slack integration (#5640)
* Slack notifications

* Codacy corrections

* Slack notifications

* Codacy corrections

* Rename Email Alert to Notification

* Migration Patch

* Refactor of notification.py

* Dev cleanup

* Test correction
2018-06-11 15:11:00 +05:30
Suraj Shetty
6b77c10cc9 [Workflow] Added a check to enable/disable workflow action emails and test fix (#5668)
* Fix build and make py3 compatible

* Remove unused test since state edit check was removed

* Add toggle to enable or disable workflow action emails
2018-06-11 15:09:42 +05:30
Suraj Shetty
944626ed5e [Minor][Fix] Workflow action (#5665)
* Fix incorrect this reference

* Fix verify request for python 3

* Fix workflow validation
2018-06-08 16:33:39 +05:30
Rushabh Mehta
dd189d4c99 [fix] set default naming_series in naming.py if not set 2018-06-06 12:00:27 +05:30
Rushabh Mehta
c32bcca4e8 [fix] set default naming_series in naming.py if not set 2018-06-06 11:24:20 +05:30
Nabin Hait
786db7de12 minor fix 2018-06-04 12:26:53 +05:30
Nabin Hait
6e00608556 import sync_user_settings in rename_field 2018-06-04 12:24:58 +05:30
Manas Solanki
a91da5f706 Update user settings (#5634)
* update the user settings on the rename of any records.

* also update the renamed fields in the user settings

* fix codacy
2018-06-04 11:53:03 +05:30