Commit graph

946 commits

Author SHA1 Message Date
Suraj Shetty
77b4880893 refactor: Remove darkgrey class
- Replace darkgray with gray
2020-08-27 18:54:24 +05:30
prssanna
b33471c35a fix: replace darkgrey with darkgray 2020-08-27 15:44:37 +05:30
Suraj Shetty
b39bc162bd
Merge branch 'develop' into email-append-fix 2020-08-20 14:38:59 +05:30
Mangesh-Khairnar
b83e0b9abd
fix: add an explicit check for schedule sending (#11291) 2020-08-18 17:54:27 +05:30
Shivam Mishra
3de0c18ab2
Merge pull request #10723 from scmmishra/feat-search-api-changes
feat: Search API changes
2020-08-14 14:00:56 +00:00
Shivam Mishra
88d28d7757 chore(revert): show traceback on smtp error
This reverts commit beaaf16758.
2020-08-14 18:47:10 +05:30
Shivam Mishra
beaaf16758 test: show traceback on smtp error 2020-08-14 18:30:27 +05:30
Suraj Shetty
d4aab476a2
Merge branch 'develop' into email-append-fix 2020-08-13 18:03:36 +05:30
Mangesh-Khairnar
b49571f9b3
feat(notification): Add WhatsApp/SMS channels (#9623)
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2020-08-13 17:53:09 +05:30
Suraj Shetty
b1365b52ee
Merge branch 'develop' into email-append-fix 2020-08-12 16:50:16 +05:30
Shivam Mishra
f7d923396b
Merge branch 'develop' into feat-search-api-changes 2020-08-10 06:17:38 +00:00
Suraj Shetty
7d8695c7d3 fix: Provide fallback array for test_mails to avoid unexpected trace in travis 2020-08-08 23:46:45 +05:30
Shivam Mishra
02ddaa5ee7 feat: mark web search indexing check 2020-08-06 19:47:46 +05:30
Saurabh
b23e2cc311 fix: handle encoding exceptions while appending email to sent email folder 2020-08-06 19:09:35 +05:30
Suraj Shetty
21a0cafe62
fix: Validate and sanitise whitelisted search methods using decorator (#11197)
* fix: Validate and sanitize whitelisted search methods using decorator

Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>

* refactor: Replace decorator name

Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>

Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>
2020-08-05 19:42:19 +05:30
Prssanna Desai
645331799a
fix: whitelist functions called through search widget (#11153) 2020-08-04 12:17:33 +05:30
Suraj Shetty
d3e4a97b6f
test: Make email account is email account test (#11139) 2020-07-29 17:17:53 +05:30
Mangesh-Khairnar
33e0b78576 fix: validate recipients before sending newsletter 2020-07-23 15:06:46 +05:30
Chinmay Pai
02fa765dcc
Merge pull request #11041 from abhishekbalam/prevent_autoreply_inital_sync 2020-07-21 16:58:54 +05:30
Abhishek Balam
2083224609
fix: add a confirmation dialog on enabling auto reply
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-21 12:37:33 +05:30
prssanna
a4239c4f1f fix: don't set header if empty 2020-07-18 19:40:10 +05:30
Chinmay D. Pai
42591f2828
chore: replace rfc-compatible newline with \n
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-18 19:08:29 +05:30
Chinmay D. Pai
8a6cb7db3d
chore: replace rfc-compatible newlines with \n
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-18 18:52:55 +05:30
Chinmay D. Pai
c45864eac0
fix: specify SMTPUTF8 policy everywhere
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-18 18:27:44 +05:30
prssanna
cac8a8c4a0 fix: set policy to SMTPUTF8 2020-07-18 14:16:16 +05:30
Chinmay D. Pai
39ec64f1e3
fix: add default email policy to mail body
the default policy encodes special characters correctly, and is not set
by _default_ unless python3.8 is used. so we'll explicitly define the
policy to be used for the email body

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-17 18:36:53 +05:30
Chinmay D. Pai
ff39b6ae5f
fix: email encoding issue inside email queue
email addresses get formatted incorrectly inside the email queue,
causing emails to be sent with encoded-words addresses instead of
proper, human readable email addresses. this particularly happens when
the address has special and accented characters. an example of
encoded-words address looks like:

=?utf-8?q?=C3=A1dministr=C3=A1tor?= <admin@example.com>

instead of something like:

ádministrátor <admin@example.com>

another issue that causes this is validations that strip html tags from
field when ignore_xss_filter is not set in a docfield. setting
ignore_xss_filter for the email field inside email queue fixes
this issue.

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-17 16:24:31 +05:30
Suraj Shetty
a323506424
Merge branch 'develop' into email-reply-threading 2020-07-01 10:45:27 +05:30
Suraj Shetty
a6c68f7dc0
fix: Initialize email_sent_to_any_recipient outsite try block (#10866)
to avoid UnboundLocalError: local variable
'email_sent_to_any_recipient' referenced before assignment
2020-06-30 17:38:27 +05:30
Rushabh Mehta
14006d4163 fix: check for badly formed messages and no "Re" prefix required for first email 2020-06-28 09:34:31 +05:30
Rushabh Mehta
f9e9a6cdb9 fix: add limit to like queries while searching for threads 2020-06-28 09:34:31 +05:30
Rushabh Mehta
6dbf7a90a1 fix: threading of email replies where message-id is not returned 2020-06-28 09:34:31 +05:30
Saurabh
ad206edb20 feat: do not send notification for existing emails 2020-06-26 16:33:55 +05:30
mergify[bot]
2275f8bc1d
Merge pull request #10790 from Mangesh-Khairnar/send-emails-now
fix: send confirmation email instantly
2020-06-24 04:19:34 +00:00
Mangesh-Khairnar
c590bf009d fix: send confirmation email instantly 2020-06-23 19:06:12 +05:30
Mangesh-Khairnar
46b371af4d fix(notification): show alert fields after setting document type 2020-06-23 14:03:25 +05:30
Rucha Mahabal
e37cc9809d fix: attribute error while handling email exception 2020-06-13 11:43:50 +05:30
Shivam Mishra
7aa02b9ad4
fix: remove stray frappe.throw 2020-06-11 19:01:47 +05:30
Shivam Mishra
68c0450ac7
fix: better error title
Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>
2020-06-11 13:30:39 +00:00
Shivam Mishra
6cbd5b6adc fix: catch exceptions when sending notification 2020-06-10 16:46:28 +05:30
Suraj Shetty
4461bde3d6 fix: Send other auto email report if one fails 2020-06-03 12:38:47 +05:30
mergify[bot]
90cd0b786b
Merge pull request #10292 from prssanna/notification-in-notifications
feat: Show Notification in notifications dropdown
2020-06-01 05:35:20 +00:00
prssanna
b8a3f53c3c fix: fix translation syntax 2020-05-31 22:48:35 +05:30
prssanna
73d3d1f409 fix: pass attached_doc to doc 2020-05-31 22:43:14 +05:30
prssanna
6b2efc5f5d fix: fix translation syntax 2020-05-30 14:51:48 +05:30
prssanna
12f9e9f4c1 fix: separate channel for system notifications 2020-05-29 16:35:50 +05:30
Himanshu Warekar
400ada1a46 Merge branch 'dont_create_contacts' of https://github.com/hrwx/frappe into dont_create_contacts 2020-05-18 14:22:13 +05:30
Himanshu Warekar
cdad543a02 Merge branch 'develop' of https://github.com/frappe/frappe into dont_create_contacts 2020-05-18 13:11:18 +05:30
Suraj Shetty
d53b88a72f
perf: Make tests faster (#10307)
* feat: Ignore versions for test

* test: Do not ignore version where needed

* perf: Use frappe.db.get_single_value to leverage caching

- frappe.get_cached_value does not support single value caching

* style: Fix sider issue
2020-05-12 22:34:10 +05:30
prssanna
77b59a1493 fix: hide channel field if disabled 2020-05-12 19:21:29 +05:30