Himanshu Mishra
1bf90d18ee
perf-fix: Remove meta from pickling overhead
2021-06-15 17:17:08 +05:30
Gavin D'souza
c489846547
Merge branch 'develop' into unnecessary_comprehensions
2021-06-11 19:30:23 +05:30
Gavin D'souza
e407b78506
chore: Drop dead and deprecated code
...
* Remove six for PY2 compatability since our dependencies are not, PY2
is legacy.
* Removed usages of utils from future/past libraries since they are
deprecated. This includes 'from __future__ ...' and 'from past...'
statements.
* Removed compatibility imports for PY2, switched from six imports to
standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Prssanna Desai
4b0e627c94
Merge pull request #13203 from prssanna/custom-print-format-fix
...
fix: check if df exists in get_formatted
2021-05-13 12:14:37 +05:30
Ankush Menat
4754ab71d1
perf(minor): remove unnecessary comprehensions
...
- remove several unnecessary comprehensions from functions that accept a generator.
- Using `[x for x in iter]` causes a list to be built first then passed to the outer function.
- `any` and `all` can take generator instead. This makes memory usage O(1) and actually makes these functions short-circuiting. E.g. if the first condition fails then `all` will immediately return false instead of evaluating all the entries.
- `sum`, `min`, `max` => memory usage become O(1)
- `list`, `set`, `.join()` => roughly halves memory usage, as list is not required to be built.
- lastly, it's two fewer characters to read/think about.
2021-05-12 20:38:18 +05:30
prssanna
103fa1e31a
fix: check if df exists in get_formatted
2021-05-12 16:40:56 +05:30
Gavin D'souza
87ed7796de
fix: Use older logic to set module_name and custom vars
2021-05-06 16:56:50 +05:30
Gavin D'souza
877f9d08df
fix: Use fallback values if doctype values unset
2021-05-06 16:56:50 +05:30
Gavin D'souza
05712abc60
fix: Check for db value if cache doesn't exist
...
in get_controller, if cached value doesn't exist for a DocType in the
frappe.db.value_cache, then query the db as fallback before the final
fallback of assuming module as Core and non custom
2021-05-06 16:56:49 +05:30
Hussain Nagaria
3e229e931a
test: Email and URL validate functions
2021-04-30 15:37:55 +05:30
Hussain Nagaria
82b98330fd
feat: Add URL option for data type fields
2021-04-14 20:16:44 +05:30
Suraj Shetty
cf607148a0
Merge pull request #12121 from zerodha/virtual_doctype
2021-04-02 12:43:43 +05:30
Faris Ansari
bcb01f6491
fix: Remove encrypted password when it is unset
2021-04-01 17:48:20 +05:30
Chinmay Pai
043a6c0804
Merge branch 'develop' into virtual_doctype
2021-03-17 20:18:44 +05:30
Shariq Ansari
71bb522e95
fix: Multi currency in print view shows same currency symbol ( #12569 )
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-03-16 10:07:23 +05:30
mergify[bot]
465404f66e
Merge pull request #12447 from adityahase/perf-cli
...
perf: Faster CLI
2021-02-25 01:44:36 +00:00
mergify[bot]
3e76842765
Merge pull request #12347 from hasnain2808/better-way-to-extract-fieldname
...
fix: better way to extract fieldname from key_name
2021-02-24 10:08:04 +00:00
Aditya Hase
3f0409a2af
perf: Remove frappe.utils.password from import tree
2021-02-21 09:41:28 +05:30
Aditya Hase
637aa059b9
perf: Remove BeautifulSoup from import tree
2021-02-19 21:01:55 +05:30
hasnain2808@gmail.com
a1970efba3
chore: use dict instead of index
2021-02-19 00:15:02 +05:30
Mohammad Hasnain Mohsin Rajan
938230ae9e
chore: better commands
...
Co-authored-by: Rohan <Alchez@users.noreply.github.com>
2021-02-19 00:10:02 +05:30
Ankush Menat
523112fd8b
docs: update docs of some most used functions
...
Update following function/methods:
BaseDocument.update
BaseDocument.append
utils.cint
utils.flt
utils.getdate
[skip travis]
2021-02-15 17:41:29 +05:30
hasnain2808@gmail.com
ae4e39480e
fix: better way to extract fieldname from key_name
2021-02-08 21:23:35 +05:30
Shridhar
d48e470b86
fix: renamed label and field name
2021-01-11 13:13:39 +05:30
Shridhar
092d32be33
fix: fixed commenting and sharing for virtual doctypes
2021-01-11 13:13:38 +05:30
Shridhar
156cc9805f
fix: link validation fetch from get doc
2021-01-11 13:13:38 +05:30
Sagar Vora
34ad0cf331
fix: introduce frappe.controllers; clear global if cache is cleared; replace old references
2021-01-07 10:57:08 +05:30
Sagar Vora
c8ef51a8ec
perf: revert to using _classes global instead of frappe.cache
2021-01-06 16:33:41 +05:30
Saqib Ansari
3296097df6
feat: show absolute value in print format
2020-11-30 15:46:29 +05:30
Deepesh Garg
7b404a835b
fix: Ignore hash collosion count limit in tests
2020-10-06 12:55:09 +05:30
Faris Ansari
45e461a10a
Merge pull request #11527 from netchampfaris/override-doctype-class
2020-09-24 14:11:57 +05:30
Rushabh Mehta
21419645f8
feat(document naming): [wip] rule based naming of documents
2020-09-21 10:28:11 +05:30
Faris Ansari
8461275f5a
fix: Store classes in cache per site
2020-09-17 17:58:37 +05:30
Faris Ansari
78e1310471
feat: Ability to override doctype classes from hooks
2020-09-17 17:30:36 +05:30
Rushabh Mehta
5d2a1ea47a
fix(minor): handle importing of doctype when links are missing
2020-08-25 14:29:08 +05:30
Rushabh Mehta
ebc961cf84
fix(debug): print error before it breaks
2020-08-25 14:12:30 +05:30
Sahil Khan
8ce340046e
fix: do not sanitize code field
...
Co-authored-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-28 19:33:44 +05:30
prssanna
742d79cd5f
style: fix indent
2020-07-18 14:16:32 +05:30
Chinmay D. Pai
3678435d4a
fix: remove redundant condition for field sanitization
...
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-17 18:38:57 +05:30
marination
c2c6d9fa7f
fix: Duplicate Name Error Message on saving document
2020-07-03 14:10:44 +05:30
Prssanna Desai
0cc5e2522a
fix: use frappe.bold
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2020-06-10 11:46:13 +05:30
Prssanna Desai
695826ac49
fix: use in to check value
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2020-06-10 11:41:00 +05:30
prssanna
8455d93e5b
fix: better validation message if fetch from field doesn't exist
2020-06-05 11:28:13 +05:30
Prssanna Desai
b6011e752b
fix(Email): include Text in fieldtypes to sanitize ( #10525 )
2020-05-29 09:12:24 +05:30
mergify[bot]
4e3706763a
Merge pull request #10040 from Thunderbottom/data-validation-fix
...
fix: skip validation if oldfieldtype is not set to data
2020-04-24 17:26:11 +00:00
Suraj Shetty
9122866c62
fix: Consider __unsaved flag while getting doc as_dict ( #10067 )
...
Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Prssanna Desai <prssud@gmail.com>
2020-04-23 20:38:33 +05:30
mergify[bot]
7fb8dac072
Merge pull request #10030 from Thunderbottom/validate-name-data-options
...
feat: Add name validation to data fieldtype
2020-04-22 07:43:25 +00:00
Chinmay D. Pai
27b5819e34
fix: skip validation if oldfieldtype is not set to data
...
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-04-22 11:55:46 +05:30
Chinmay D. Pai
108fa0f42e
fix: sanitize all html input
...
use beautifulsoup to parse if string contains html and then sanitize the
input html
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-04-21 17:22:44 +05:30
Chinmay D. Pai
1dfa8ccbc4
feat: add name validation to data fieldtype
...
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-04-21 15:49:55 +05:30