Commit graph

141 commits

Author SHA1 Message Date
Faris Ansari
7b9ee521ee fix: Use get_all instead of get_list 2019-09-11 15:58:36 +05:30
Faris Ansari
1eecc3dadb Revert "fix(pg test): get_list to get_all"
This reverts commit ef665c4c87.
2019-09-10 13:34:48 +05:30
Faris Ansari
ef665c4c87 fix(pg test): get_list to get_all 2019-09-10 11:45:45 +05:30
Suraj Shetty
10e20adcf3 fix: Allow user to export if user has permission to export own documents (#8172) 2019-08-19 11:55:29 +05:30
Mangesh-Khairnar
cc0ea13ec5
fix: has permission decorator 2019-05-23 13:04:59 +05:30
Suraj Shetty
1bcdc0b7cb fix(report): Allow report export only if user has export permission on ref doctype (#7458)
* fix: Allow export only if user has export permission on reference doctype

* fix: Show only custom "no permission" error

* fix: while saving employee user getting user permissions error
2019-05-15 11:59:13 +05:30
Mangesh-Khairnar
c23876198d fix: filter default docs from allowed docs 2019-04-22 13:54:05 +05:30
Mangesh-Khairnar
8d8ef7ad3c fix: return allowed docs along with default doc 2019-04-22 13:53:43 +05:30
Mangesh-Khairnar
fe007f426d fix: default user permission to handle small int values 2019-04-17 19:06:38 +05:30
Mangesh-Khairnar
9079e7965e feat: pass default value to add user permission 2019-04-16 23:37:52 +05:30
Mangesh-Khairnar
b53ff42bcd feat: assign default value to link field based on the user permission 2019-04-16 23:37:52 +05:30
Suraj Shetty
1c8fd3169e fix(permission): use .get to avoid key error (#7187)
Port of https://github.com/frappe/frappe/pull/7184
2019-04-01 18:22:17 +05:30
Suraj Shetty
72d82538a8
fix: typo 2019-03-14 20:34:12 +05:30
Rushabh Mehta
ce76b51ff1
fix(messages): make messages translatable 2019-03-14 10:51:33 +05:30
Faris Ansari
8f86c15d9d fix: More verbose User permission message 2019-03-13 11:22:36 +00:00
Sagar Vora
17b20b22a3 Merge branch 'master' into develop 2019-02-12 16:31:54 +05:30
Suraj Shetty
66179ab862
fix: Use .get() to avoid key error 2019-02-10 12:54:37 +05:30
Suraj Shetty
06892149a9 Show permission failure message based on passed user
- only if user passed is equal to session user or if no user is passed
2019-02-07 17:48:05 +05:30
Frappe Bot
1197271700 Fixed merge conflict 2019-01-05 09:06:05 +00:00
Suraj Shetty
9adbbd44c8 fix(permission): Role permission check with if_owner enabled (#6726)
* Allow user to access list even if there is only a docperm with if owner enabled

* Add test to check if user gets access to the list

- User should be able to access list even if the user has only
 role for which docperm is created with if_owner check

* Remove commented code
2019-01-05 14:31:40 +05:30
Saurabh
3aef483538 Merge branch 'staging' into develop 2018-12-26 21:59:52 +05:30
Suraj Shetty
2a315b154e
fix(permission): KeyError 2018-12-26 21:16:41 +05:30
Frappe Bot
0499b4a845 Merge branch 'staging' into develop 2018-12-26 12:03:03 +00:00
Suraj Shetty
3213393727 Display fieldname on which restriction is applied for clarity 2018-12-25 13:16:54 +05:30
Suraj Shetty
e3b4b91655 Translate log strings 2018-12-10 14:05:59 +05:30
Suraj Shetty
1467fbe4bd Remove an unwanted argument 2018-12-02 12:13:20 +05:30
Suraj Shetty
11ec1e81a8 Add a decorator to print user permission check logs 2018-12-02 12:10:31 +05:30
Suraj Shetty
63df0ea5c7 Fix incorrect doctype check 2018-11-12 18:16:27 +05:30
Suraj Shetty
8f5126d831 Fix AttributeError 2018-11-12 16:47:35 +05:30
Suraj Shetty
5d13a5e902 Fix AttributeError 2018-11-12 16:20:11 +05:30
Suraj Shetty
82267a13e7 Fix AttributeError 2018-11-12 14:10:35 +05:30
Suraj Shetty
efbfc087d2 Fix typo 2018-11-12 13:11:15 +05:30
Suraj Shetty
e2cce998c5 Fix has_user_permission check
- Pass if there are no user_permission
applicable for the doctype of the doc
2018-11-12 12:56:12 +05:30
Suraj Shetty
7989cd054a Fix if_owner permission override 2018-11-05 08:35:01 +05:30
Suraj Shetty
5d75f95ec9 Social fixes (#6375)
* Fix post and post comment permissions

- User should be able to edit only his post/comment
- other post should and comment should be readonly

* Separate scroll to section function

* Add a test fix

* Hide activity on mobile view for now

* fix: Return early if no session user

* chore: Remove empty test files

* Add semicolon

* Return if doc.owner is not present
2018-11-02 14:45:24 +05:30
Suraj Shetty
0ffa645e10 Fixes to support new changes with user permission 2018-11-01 21:18:15 +05:30
Suraj Shetty
09a50942b7 Refactor has_permission 2018-11-01 21:18:14 +05:30
Suraj Shetty
4b3ae8f1ce wip(user_permissions) 2018-11-01 21:17:21 +05:30
Karan Sharma
943b66714d Make user permission check as case-insensitive (#6313) 2018-10-30 11:02:22 +05:30
Ameya Shenoy
aa4ef1b405
Merge branch 'staging' into develop 2018-10-23 08:04:11 +00:00
Rohit Waghchaure
63b2c14ec8 Set verbose to false 2018-10-23 11:59:18 +05:30
Ameya Shenoy
06d9385829
Merge branch 'staging' into develop 2018-10-19 12:51:40 +00:00
Rohit Waghchaure
0ab71884da [Fix] multiple user permissions messages are coming even if permissions are set 2018-10-17 18:48:51 +05:30
Ameya Shenoy
63c5613f92
Merge branch 'staging' into develop 2018-10-11 10:11:26 +00:00
Suraj Shetty
9dea3f1684 Revert permission changes (#6249) 2018-10-11 15:26:47 +05:30
Ameya Shenoy
ec18e90089
Merge branch 'staging' into develop 2018-10-11 06:56:34 +00:00
Ameya Shenoy
d3b83bd8c6
Merge branch 'master' into staging-fixes 2018-10-11 06:51:33 +00:00
rohitwaghchaure
301fcdefdc [Fix] User permissions (#6218)
* [Fix] User permissions

* Update permissions.py
2018-10-08 18:33:41 +05:30
Suraj Shetty
968791195a [Hotfix] [Permission] Fix custom docperm check in get_valid_perm (#6200)
* Fix custom docperm check in get_valid_perm

- Previously to get_valid perm we just used
to check all the custom docperms
available for the user's role and apply
standard perm for any missing doctype
But there might be some doctypes with
custom docperms which might not match
any of user's role.
Such doctype's perms should not be
replaced by standard docperm.
This PR fixes that.

* Avoids admin lock
2018-10-08 17:04:26 +05:30
Ameya Shenoy
63d7d776ca
Merge branch 'staging' into develop 2018-10-08 09:42:29 +00:00