Commit graph

20 commits

Author SHA1 Message Date
mergify[bot]
eb4c4fb7b2
fix: encode docname when routing (backport #17092) (#17374)
(cherry picked from commit c8777c59cf665ab54218cd7bf9accd1d8e22ddf9)

Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2022-09-07 21:25:51 +05:30
Ankush Menat
40f27f908a style: format JS files with prettier 2022-08-04 14:51:01 +05:30
Himanshu
70409a3c7b
fix: set translated text to link field (#15451)
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324)
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.

Todo:

- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour

### Behaviour

- Link field loses focus: show the translated name.
- Link field is focused
    - If old value is present
        - If options **are** one of [Role, DocType]: show the translated name
        - Else: show the name (untranslated) to enable search in untranslated values
    - Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus

## Demo

### Link to UOM in a custom Item DocType

The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.

#### Before

https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov

#### After

https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov

### Link to DocType in Customize Form

The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.

#### Before

https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov

#### After

https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov

https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
2022-05-16 13:21:42 +00:00
Komal-Saraf0609
a8fe3a8668
test: Adding Cypress tests for sidebar, timeline and email testing (#13729)
* test: fix get_field command

* test: Add timeline email test cases

* test: Add sidebar test cases

* test: Add timeline test cases

* test: Added new commands

* test: Added proper name for test case, added comments and removed redundancy

* test: Added proper name for test case, added comments and removed redundancy

* test: Added proper name for test case, added comments and removed redundancy

* test: Added new commands

* test: Added proper name for test case, added comments and removed redundancy

* test: Added proper name for test case, added comments and removed redundancy

* fix: Sider issues

* fix: Sider issues

* fix: Sider issues

* fix: UI Tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI test

* fix: UI tests

* fix: UI tests

* fix: Context correction

* test: fix fill_field command

* test: fixed get_field command
(removed :visible for code)

* test: Fixed fill_field command
(removed .blur())

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-06 07:52:24 +00:00
Sagar Vora
c8763859ae test: multiple cypress fixes 2021-04-18 13:22:43 +05:30
Suraj Shetty
572b5d670c
revert: "test: encoding @ since we encode each url" (#12625) 2021-03-20 07:51:28 +05:30
mergify[bot]
1448a47f62
Merge pull request #12567 from hasnain2808/fix-multiselect-dialog
test: encoding @ since we encode each url
2021-03-11 16:10:21 +00:00
hasnain2808@gmail.com
85de1a01df test: encoding @ since we encode each url 2021-03-11 20:43:44 +05:30
mergify[bot]
cbbddafc0f
Merge pull request #12268 from hasnain2808/no-assignment-rule-on-todo
fix: Do not Allow Assignment Rule on Todo
2021-02-24 11:24:12 +00:00
hasnain2808@gmail.com
a55e1a6394 fix(ToDo): cypress tests 2021-02-24 12:56:05 +05:30
Suraj Shetty
d18751db07 test: Make tests Cypress v6 compatible 2021-01-31 23:19:01 +05:30
prssanna
841c1b9852 fix: cypress tests 2020-12-29 17:00:30 +05:30
Rushabh Mehta
54cee87826 fix(minor): tests + routing 2020-12-24 14:48:40 +05:30
Faris Ansari
d719f77edb
fix(ui-tests): Pick admin password from config (#7842) 2019-07-05 12:24:07 +05:30
Suraj Shetty
3d21bba74d test: fix fill_field command for code fieldtype 2019-04-20 14:01:19 +05:30
Faris Ansari
b61a37a233 fix: Notification test in Postgres (#7044) 2019-03-08 20:47:21 +05:30
Faris Ansari
0f2b3657c8 test: Uncomment table_multiselect test 2019-03-02 15:47:00 +05:30
Rushabh Mehta
2d7b4c7782 fix: liniting and comment multiselect tests 2019-02-28 12:50:17 +05:30
Faris Ansari
f63ac68510 test: Fix Cypress tests 2019-02-19 15:24:18 +05:30
Faris Ansari
c99726a3c2
fix(TableMultiSelect): Minor bugs (#6730)
* fix(TableMultiSelect): Minor bugs

- Show dropdown immediately after selecting a value
- Selecting first value in a new Form had no effect
- Delete last value on backspace

* fix: comment

* test(Table MultiSelect): Add tests, update database file

* test: Fix database name

* test: Fill description first
2019-01-15 13:34:29 +05:30