Commit graph

1521 commits

Author SHA1 Message Date
Saurabh
a0086db9b6
fix(frappe client): validate http method for frappe.client api (#11228) 2020-09-14 12:30:30 +05:30
Suraj Shetty
0449ba0b6d
refactor: Use .pop instead of del 2020-09-08 10:58:03 +05:30
Suraj Shetty
dba454f941 fix(security): Remove ignore_permissions flag from API request 2020-09-08 10:37:25 +05:30
Faris Ansari
3f5a50d677 fix: Restrict ui test helper method to dev server mode 2020-09-06 18:37:22 +05:30
Rushabh Mehta
c83a9a142b fix(minor): mogrify 2020-08-17 09:41:54 +05:30
Rushabh Mehta
14d9c28eb7 fix(test): try with print_sql 2020-08-17 09:41:54 +05:30
Mohammad Hasnain Mohsin Rajan
14400fe1d3
style: fix typo tood to todo (#11272) 2020-08-14 17:04:09 +05:30
Suraj Shetty
7e37591c79
Merge branch 'develop' into fix-frappe-logger 2020-08-10 13:25:27 +05:30
Saurabh
435b522dbf fix: cache all apps in local and switch to enable/disable frappe logger 2020-08-10 12:31:08 +05:30
Shivam Mishra
be4d3ae434 feat: allow wide attribute in msgprint and throw 2020-08-10 12:16:16 +05:30
Suraj Shetty
130cce8840
Merge branch 'develop' into fix-test 2020-08-08 17:04:37 +05:30
Shridhar Patil
80733d4124
fix: raise incorrect site path error instead of sys.exit (#11206) 2020-08-07 21:52:04 +05:30
Suraj Shetty
cd1ab8e23c
feat: Add validate_and_sanitize_search_inputs decorator (#11194)
* feat: Add validate_and_sanitize_search_inputs decorator

Co-authored-by: Nabin Hait <nabinhait@gmail.com>
Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>

* refactor: Move validate_and_sanitize_search_inputs to init

* refactor: Move validate_and_sanitize_search_inputs to search.py

* test: validate_and_sanitize_search_inputs decorator

* chore: Add wrapt module

* refactor: Use @wrapt to define validate_and_sanitize_search_inputs decorator

* test: Add a case to make sure frappe.call works as well

Co-authored-by: Nabin Hait <nabinhait@gmail.com>
Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>
2020-08-05 19:41:41 +05:30
Suraj Shetty
c4aa9f5f2c
Merge branch 'develop' into fix-test 2020-08-04 12:57:03 +05:30
Suraj Shetty
3c3b1037ea
fix: Import frappe.permissions 2020-08-04 10:44:45 +05:30
Suraj Shetty
744a9413fd fix: Use common function to get_roles 2020-08-04 10:36:16 +05:30
Gavin D'souza
94116ae93c feat(logger): allow max_size and file_count params 2020-07-31 16:07:51 +05:30
Gavin D'souza
1345c2feb3 feat: Allow_site flag in frappe.logger 2020-07-27 17:31:12 +05:30
Gavin D'souza
ad1152f8e8 feat: override site name via _site
added filter parameter for logger
2020-07-27 17:13:18 +05:30
Gavin D'souza
476e625261 fix: Add site validation for logger 2020-07-16 16:26:20 +05:30
AminovE99
4ce70e2bcf fix(sendmail): 'frappe' not defined (#10799)
* 💄 Add frappe library

Signed-off-by: Emil <amionv99@gmail.com>

* 💄 directly import

Co-authored-by: gavin <gavin18d@gmail.com>

Co-authored-by: gavin <gavin18d@gmail.com>
(cherry picked from commit 6b9c92baf48c0671516727cb43761fc56a6dd12a)
2020-07-06 05:47:07 +00:00
Faris Ansari
5a1ce409b6 fix: Add method to import data from file
- Update import paths to use data_import module
- Data Import Beta -> Data Import
2020-06-11 18:02:25 +05:30
Faris Ansari
6f80a0b462 fix: Data Import -> Data Import Legacy 2020-06-11 18:02:25 +05:30
Gavin D'souza
079da0b645 Merge branch 'develop' of github.com:frappe/frappe into no-site-specified 2020-06-01 12:23:16 +05:30
Gavin D'souza
f71585ec74 Merge branch 'develop' of github.com:frappe/frappe into site-wise-logging 2020-05-29 14:56:29 +05:30
Gavin D'souza
746b540af8 fix: Add Form Dict information only for frappe.log 2020-05-27 19:09:18 +05:30
Gavin D'souza
c39a52d764 feat: seperate loggers into frappe, web, scheduler categories and not by
module
2020-05-27 18:33:03 +05:30
Gavin D'souza
a86ae948f7 fix(commands): raise SiteNotSpecifiedError if site not found in context 2020-05-18 13:01:33 +05:30
Suraj Shetty
d53b88a72f
perf: Make tests faster (#10307)
* feat: Ignore versions for test

* test: Do not ignore version where needed

* perf: Use frappe.db.get_single_value to leverage caching

- frappe.get_cached_value does not support single value caching

* style: Fix sider issue
2020-05-12 22:34:10 +05:30
sahil28297
aae45ed98c
fix: bump frappe develop to version 13-dev 2020-05-08 12:18:09 +05:30
Suraj Shetty
981da526f9 fix: Contextual translation key generation 2020-05-04 22:27:06 +05:30
Suraj Shetty
06ee14e433
Merge branch 'develop' into contextual-translation 2020-04-17 13:26:05 +05:30
Chinmay D. Pai
46c3bffbdc
fix: pop cmd from rename_doc
fixes issue wherein rename_doc is called through an api call and is
passed the entire unrolled frappe.form_dict, which causes the following
error:

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 60, in application
    response = frappe.api.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 58, in handle
    return frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 24, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 63, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1068, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 832, in rename_doc
    return rename_doc(*args, **kwargs)
TypeError: rename_doc() got an unexpected keyword argument 'cmd'

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-04-13 13:57:52 +05:30
Shivam Mishra
5c83ad9b97 feat: delete domain cache on frappe.clear_cache() 2020-04-06 15:20:11 +05:30
Suraj Shetty
3d6916631d Merge branch 'develop' of https://github.com/frappe/frappe into contextual-translation 2020-04-01 00:11:32 +05:30
sahil28297
c615042d25
fix: develop version as 12.0.0.dev instead of 12.1.0 (#9746)
* fix:  develop version as 12.x.x instead of 12.1.0

* fix: develop version as 12.0.0.dev

* fix: develop version as 12.0.0-dev
2020-03-20 16:10:58 +05:30
Suraj Shetty
aa854e9a54
Merge branch 'develop' into minimizable-dialog 2020-03-12 18:40:54 +05:30
Suraj Shetty
08a843db98 Merge branch 'develop' of https://github.com/frappe/frappe into contextual-translation 2020-03-09 15:26:12 +05:30
prssanna
ca815a8776 feat: add flag minimizable to msgprint and throw 2020-03-06 21:40:51 +05:30
Shivam Mishra
8f307f6123 refactor: pass raise_exception from frappe.has_permission 2020-03-02 18:49:56 +05:30
Suraj Shetty
949e8eb535 Merge branch 'develop' of https://github.com/frappe/frappe into contextual-translation 2020-02-25 13:56:23 +05:30
mergify[bot]
98ef4c1aa5
Merge pull request #9441 from marination/bulk-workflow-apply
fix: Bulk Workflow Action rollback on Error
2020-02-20 05:41:43 +00:00
Faris Ansari
494c8274af
Merge pull request #9476 from scmmishra/better-only-for-message
Better Only For message
2020-02-18 12:21:35 +05:30
Shivam Mishra
84241e5b61 feat: better only_for role message 2020-02-17 14:06:06 +05:30
marination
f2459e47b7 fix: Added consolidated feedback message
- Message dialog with errored and succesful documents.
2020-02-11 11:51:49 +05:30
Andy Zhu
209393ecbd
Fix (S3-Backup-Setting): ensure recipients and sender are corre… (#9417)
* fix: sender is not set to current user

I am not sure if I did it right:
1. import frappe
2. check if the sender is None: using frappe.session.user to fetch email address for current user

* fix: update the correct field name for S3-backup-setting

The field variable name should be updated to 'notify_email' instead of 'notification_email'.

* style: remove a trailing whitespace

* fix: Assign notify_email instead of calling frappe.db.get_value twice

* chore: remove default sender and notify_email check

* default sender already gets set in queue.py, so there's no need for a
  check inside __init__.py

* notify_email seems to be a mandatory field, so there's no need to
  check if the field has a value (assuming that it always will).

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>

Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>
2020-02-08 14:36:05 +05:30
Suraj Shetty
dee4a7336c fix(translations): Incorrect syntax 2020-01-29 15:22:35 +05:30
Suraj Shetty
09ec26efd3 feat(translation): Support context 2020-01-28 10:28:03 +05:30
Mangesh-Khairnar
a4569172e4 fix: swap message with title containing newline character 2020-01-16 15:22:17 +05:30
Mangesh-Khairnar
27a5a920d4 fix: change message content for errors without a title 2020-01-15 16:19:34 +05:30