Commit graph

1037 commits

Author SHA1 Message Date
phot0n
f49818089a feat(minor): bulk retry for email queue
* chore: add retry_sending as a email queue class method
2023-06-12 14:38:43 +05:30
phot0n
1f8598891e fix: remove infinite sending retries for certain exceptions for email queue
* chore: remove expired status & set_expiry job from email queue
2023-06-09 14:38:55 +05:30
phot0n
129fdc803a chore: fix linter 2023-06-08 16:20:10 +05:30
phot0n
4ceafe14e3 chore: remove unused is_background_task and add_to_sent_list -> update_recipient_status_to_sent
* set status to be hidden in queue doc
* don't maintain a list of sent to recipeint, a boolean is enough to set the status to partially sent
2023-06-08 16:19:37 +05:30
phot0n
aac74726ff chore: add recipient to sent list regardless of email sending method 2023-06-08 16:19:37 +05:30
phot0n
df7afa93b8 chore: log traceback directly to the queue doc 2023-06-08 16:19:37 +05:30
phot0n
742a6082ac fix: remove unnecessary statuses from email queue and only append emails to sent if imap is enabled 2023-06-08 16:19:37 +05:30
Vishal Kumar
a21412e12a
feat: allow no_smtp_authentication to be set from site config (#21274) 2023-06-08 13:15:43 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Ankush Menat
2cb2934f96
perf: query queued_recipients only once (#21277)
O(N) -> O(1) check for queued recipients

Caused by https://github.com/frappe/frappe/pull/18044

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2023-06-07 18:05:06 +05:30
ljain112
70de5d05f2 fix: don't mutate notification when getting cc and bcc 2023-05-25 19:03:23 +05:30
anandbaburajan
348f852792 fix: custom filters while exporting and creating new auto email reports 2023-05-10 19:08:01 +05:30
Smit Vora
9f35d0e894
fix: don't use default filters for auto-email report (#20876) 2023-05-10 13:12:05 +05:30
Ankush Menat
eeda161e98
fix: handle SMTPRecipientsRefused retries (#20819)
* fix: remove trailing and leading quotes from email

* chore: typo

* fix: dont retry `SMTPRecipientsRefused`

If refused once it's unlikely to work again just by retrying. There's no
mechanism to prevent infinite retry. This will still attempt for
MAX_RETRY_COUNT.

* Revert "fix: remove trailing and leading quotes from email"

This reverts commit 2676ac2c7fe76c34049da05a209554fee6b3d911.

refer https://github.com/frappe/frappe/pull/20819#discussion_r1175166987
2023-04-24 17:34:24 +05:30
Himanshu Shivhare
2cb492561a
fix(ux): correct email account setup path in error message (#20513) 2023-03-30 17:57:00 +05:30
Ritwik Puri
d9383afae6
fix: exception handling for bulk email sending (#20451) 2023-03-24 13:45:46 +05:30
Suraj Shetty
02b661bbb9 fix: Remove mandatory and save URL params to localstorage
- Saving URL params to localstorage to avoid re-entering the data.
Usually only 1 or 2 param(s) change is required to generate new link
2023-03-21 11:31:05 +05:30
Suraj Shetty
ed7d6931ca fix: Update code to update links with campaign and medium 2023-03-20 23:42:50 +05:30
Ankush Menat
7ed43e2a68
fix: Drop message_id index before migrating email queue (#20376)
[skip c]
2023-03-17 15:57:51 +05:30
Ankush Menat
f2f7d43811
fix: tolerant newsletter view logging (#20369)
* fix: tolerant newsletter view logging

* Revert "fix: tolerant newsletter view logging"

This reverts commit 5a8567a9405f336c3dc8a481c27af70860334b2b.

* fix: use raw query for updating count
2023-03-16 20:07:43 +05:30
Ankush Menat
fdcdb61a2d
fix: email linking and message_id indexing (#20356)
* fix: find communication regardless of system reply

* perf: convert and index message_id
2023-03-16 14:01:25 +05:30
Ankush Menat
9430b6a8c2
fix: Permission error while processing role based notifications (#20315) 2023-03-14 17:27:30 +05:30
Ritwik Puri
985a8ca18a
fix: proper errror translation for finding outgoing email account (#20316) 2023-03-13 21:05:48 +05:30
Shariq Ansari
a6db20fe3b fix(DX): better error message for notification from reference doctype 2023-03-02 19:35:18 +05:30
Suraj Shetty
7abdad3282 Merge branch 'develop' of https://github.com/frappe/frappe into newsletter-analytics 2023-02-28 14:31:03 +05:30
Suraj Shetty
540bf5a984 fix: Do not update modified while updating total views 2023-02-28 14:17:19 +05:30
Suraj Shetty
6c8f88b8cd refactor: Remove UTM references just set source in web page view to simplify things 2023-02-28 14:17:16 +05:30
Suraj Shetty
3eff93ea6e refactor: Only send email_read_tracker_url instead of method 2023-02-28 14:16:46 +05:30
Suraj Shetty
b9f632aa8d fix: Rename is_internal_link to is_site_link 2023-02-28 14:15:41 +05:30
Ritwik Puri
6a37c19d0e
fix: dont try to connect to server again when appending email to sent folder 2023-02-27 12:52:13 +05:30
Suraj Shetty
7d5c98c206 feat: Add UTM tracking parameters to internal links in newsletters
- Also, extend web page view to store UTM tracking data.
2023-02-23 16:19:07 +05:30
Suraj Shetty
b397ec3858 feat: Track count of views on newsletter emails 2023-02-23 13:45:53 +05:30
Ankush Menat
8446875257
refactor!: Remove "Set user permission" permtype (#20090)
This has never worked and setting user permission requires system
manager role always (because of permissions on list view)
2023-02-20 16:07:49 +05:30
Ankush Menat
3235b7a77e
fix: Notification JS relied on leaked locals (#20048)
this breaks after https://github.com/frappe/frappe/pull/19882

[skip ci]
2023-02-15 14:56:11 +05:30
Ritwik Puri
dd1cac0acc
Merge pull request #19885 from phot0n/fix-email-queue-sender
fix: use sender from formatted email body for email queue
2023-02-01 22:02:18 +05:30
phot0n
f8d7151e19 fix: use sender from formatted email body for email queue 2023-02-01 17:08:25 +05:30
Ankush Menat
479e0c1439 fix: clear cache on every update in notifications
This feels like duplicate but ensures that it gets cleared in every
case. E.g. Some class might have overridden validate or ignore_validate
might be set in which case cache doesn't get cleared.
2023-01-24 12:41:05 +05:30
Ankush Menat
e1ed1e9899
fix: rate limit newsletter subscriptions (#19690) 2023-01-20 19:05:51 +05:30
Ritwik Puri
1e6086fd75
fix(minor): only show authorization message if connected app is set (#19605) 2023-01-16 16:22:38 +05:30
Ritwik Puri
50327203ce
Merge pull request #18750 from revant/oauth-email
feat: use Connected App for OAuth based Email Account
2023-01-16 15:24:05 +05:30
phot0n
b5c81cc015 chore(patch): disable all email accounts with oauth mechanism 2023-01-16 12:56:22 +05:30
phot0n
88d4d5e10d chore: minor cleanup - removed unnecessary branches and comments 2023-01-15 21:02:21 +05:30
phot0n
481d72c0ae fix: only pull from email accoutns which have token
* removed unnecessary after_save client hook from email account
* renamed check_active_token -> has_token (no need to refresh the access token)
* removed oauthentication error from email oauth - now just a simple validation error
2023-01-06 13:07:13 +05:30
phot0n
6bed904bf7 fix: only validate oauth if tokens are set
* also brough back oauth authorization message
2023-01-03 18:05:49 +05:30
Sagar Vora
81066d7562 fix: only allow system manager to create email templates 2023-01-02 12:25:37 +00:00
phot0n
231d90cb40 chore: handle get requests via frappe.whitelist decorator 2022-12-29 18:44:53 +05:30
phot0n
b78f86a307 fix: redirect back to email account after successful oauth 2022-12-29 17:14:28 +05:30
phot0n
f0a17d7adb fix: make connected app work with email account
* removed (now) unnecessary things from oauth class
* simplified get_active_token in connected_app
* removed gmail banner from email account docs
2022-12-28 14:58:19 +05:30
Revant Nandgaonkar
a4e5df674b fix(email): oauth_access call and info message 2022-12-28 14:51:10 +05:30
Revant Nandgaonkar
f79185d79c feat: use Connected App for OAuth based Email Account 2022-12-28 14:51:10 +05:30