Notifications sent through notifications doctype are not part of
communications doctype and also not into timelines. Added these
notifications into timeline by adding docs into Communication doctype.
email addresses get formatted incorrectly inside the email queue,
causing emails to be sent with encoded-words addresses instead of
proper, human readable email addresses. this particularly happens when
the address has special and accented characters. an example of
encoded-words address looks like:
=?utf-8?q?=C3=A1dministr=C3=A1tor?= <admin@example.com>
instead of something like:
ádministrátor <admin@example.com>
another issue that causes this is validations that strip html tags from
field when ignore_xss_filter is not set in a docfield. setting
ignore_xss_filter for the email field inside email queue fixes
this issue.
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
returning empty string if parseaddr returns None shows " is not a valid Email Address"
eg: if 'email@' is passed as value, email.utils.parseaddr will return a
(None, None) tuple
formataddr[1] by default encodes non-ascii characters to `=?utf-8?q`, which needs to be decoded to a human-readable string format. using decode_header and make_header we can decode the string back to human-readable format.
before:
In [1]: formataddr(("Tèst", "notifications@erpnext.com"))
Out[1]: '=?utf-8?b?VMOoc3Q=?= <notifications@erpnext.com>'
after:
In [2]: make_header(decode_header(formataddr(("Tèst", "notifications@erpnext.com"))))
Out[2]: 'Tèst <notifications@erpnext.com>'
references:
[1]: https://docs.python.org/3/library/email.utils.html#email.utils.formataddr
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
* fix: bench run-ui-tests command
BREAKING CHANGE
This replaces the old run-ui-tests command which used selenium to run
UI tests with Cypress.
Usage:
bench --site [sitename] run-ui-tests [app]
bench --site [sitename] run-ui-tests [app] --headless
* fix: Include adminPassword from site_config
* fix: string formatting
