Commit graph

50 commits

Author SHA1 Message Date
Rushabh Mehta
3d26d2dd22 BREAKING CHANGE: remove Feedback Trigger and Feedback Rating, this was not very configurable and can now be done better with Web Forms 2019-05-13 14:18:02 +05:30
Rushabh Mehta
b66d233360 merge: staging-fixes for latest test fixes 2019-01-03 15:28:36 +05:30
Charles-Henri Decultot
06ea7499ab [Fix] Transaction log corrections (#6693)
* Transaction log corrections + improvements

* Remove unused import

* Timestamp format

* Add system manager to permissions
2019-01-02 09:10:50 +05:30
Rushabh Mehta
2e6a202652 Postgres support for Frappe (#5919)
* [start] postgres

* [wip] started refactoring db_schema

* Add psycopg2 to requirements.txt

* Add support for Postgres SQL

- Separate frameworkSQL, database, schema, setup_db file for
mariaDB and postgres
- WIP

* Remove quotes from sql to make it compatible with postgres as well

* Moved some code from db_schema to database.py

* Move code from db_schema to schema.py

Add other required refactoring

* Add schema chages

* Remove redundant code in file

* Add invalid column name exception class to exceptions.py

* Add back tick in query wherever needed and replace ifnull with coalesce

* Update get_column_description code in database.py file

* Remove a print statement

* Add keys to get on_duplicate query

* Add bactick wherever necessary

- Remove db_schema.py file

* Remove DATE_SUB as it is incompatible with postgres

- Fix prepare_filter_condition

* Add backtick and quotes wherever necessary
- Move get_database_size to frappe.db namespace
- fix some left out bugs and errors

* Add code to create key and unique index
- added mysql and posgres in their respective database.py

* Add more bacticks in queries and fix some errors
- Pass keys to on_duplicate_update method
- Replace MONTH with EXTRACT function
- Remove DATEDIFF and CURDATE usage

* Cast state value to int in toggle_two_factor_auth
- since two_factor_auth has the datatype of Int

* Refactor
- Replace Timediff with normal arithmetic operator
- Add MAX_COLUMN_LENGTH
- Remove Redundant code
- Add regexp character constant
- Move create_help_table to database.py
- Add get_full_text_search_condition method
- Inherit MariaDBTable from DBTable

* Replace Database instance with get_db method

* Move db_manager to separate file

* Refactor
- Remove some unwanted code
- Separate alter table code for postgres and mysql
- Replace data_type with column_type in database.py

* Make fulltext search changes in global_search.py

* Add empty string check

* Add root_password to site config

* Create cli command for postgres console

* Move setup of help database to setup_db.py

* Add get_database_list method

* Fix exception handling
- Replace bad_field handler with missing_column handler

* Fix tests and sql queries

* Fix import error

* Fix typo db -> database

* Fix error with make_table in help.py

* Try test for postgres

* Remove pyhton 2.7 version to try postgres travis test

* Add test fixes

* Add db_type to the config of test_site_postgres

* Enable query debug to check the reason for travis fail

* Add backticks to check if the test passes

* Update travis.yml
- Add postgres addon

* Try appending 'd_' to hash for db_name
- since postgres does not support dbname starting with a number

* Try adding db_type for global help to make travis work

* Add print statements to debug travis failure

* Enable transaction and remove debug flag

* Fix help table creation query (postgres)

* Fix import issue

* Add some checks to prevent errors
- Some doctypes used to get called even before they are created

* Try fixes

* Update travis config

* Fix create index for help table

* Remove unused code

* Fix queries and update travis config

* Fix ifnull replace logic (regex)

* Add query fixes and code cleanup

* Fix typo
- get_column_description -> get_table_columns_description

* Fix tests
- Replace double quotes in query with single quote

* Replace psycopg2 with psycopg2-binary to avoid warnings
- http://initd.org/psycopg/docs/install.html#binary-install-from-pypi

* Add multisql api

* Add few multisql queries

* Remove print statements

* Remove get_fulltext_search_condition method and replace with multi query

* Remove text slicing in create user

* Set default for 'values' argument in multisql

* Fix incorrect queries and remove few debug flags
- Fix multisql bug

* Force delete user to fix test
- Fix Import error
- Fix incorrect query

* Fix query builder bug

* Fix bad query

* Fix query (minor)

* Convert boolean text to int since is_private has datatype of int
- Some query changes like removed double quotes
and replace with interpolated string to pass multiple
value pass in one of the query

* Extend database class from an object to support python 2

* Fix query
- Add quotes around value passed to the query for variable comparision

* Try setting host_name for each test site
- To avoid "RemoteDisconnected" error while testing data migration test
- Update travis.yml to add hosts
- Remove unwanted commit in setup_help_database

* Set site hostname to data migration connector (in test file)
- To connect the same site host

* Fix duplicate entry issue
- the problem is in naming series file.
In previous commits I unknowingly changed a part of a series query
due to which series were not getting reset

* Replace few sql queries with orm methods

* Fix codacy

* Fix 'Doctype Sessions not found' issue

* Fix bugs induced during codacy fixes

* Fix Notification Test

- Use ORM instead of raw sql

* Set Date fallback value to 0001-01-01

- 0000-00-00 is invalid date in Postgres
- 0001-01-01 works in both

* Fix date filter method

* Replace double quotes with single quote for literal value

* Remove print statement

* Replace double quotes with single

* Fix tests

- Replace few raw sql with ORM

* Separate query for postgres

- update_fields_to_fetch_query

* Fix tests

- replace locate with strpos for postgres

* Fix tests

- Skip test for datediff
- convert bytes to str in escape method

* Remove TestBot

* Skip fieldname extraction

* Replace docshare raw sql with ORM

* Fix typo

* Fix ancestor query test

* Fix test data migration

* Remove hardcoded hostname

* Add default option and option list for db_type

* Remove frappe.async module

* Remove a debug flag from test

* Fix codacy

* fix import issue

* Convert classmethod to static method

* Convert few instance methods to static methods

* Remove some unused imports

* Fix codacy

- Add exception type
- Replace few instance methods with static methods
- Remove unsued import

* Fix codacy

* Remove unused code

* Remove some unused codes

- Convert some instance methods to static function

* Fix a issue with query modification

* Fix add_index query

* Fix query

* Fix update_auth patch

* Fix a issue with exception handling

* Add try catch to a reload_doc

* Add try-catch to file_manager_hook patch

* import update_gravatar to set_user_gravatar patch

* Undo all the wrong patch fixes

* Fix db_setup code 😪
- previously it was not restoring db from source SQL
which is why few old patched were breaking
(because they were getting different schema structure)

* Fix typo !

* Fix exception(is_missing_column) handling

* Add deleted code
- This code is only used in a erpnext patch.
Can be moved to that patch file

* Fix codacy

* Replace a mariadb specific function in a query used in validate_series

* Remove a debug flag

* Revert changes (rename_parent_and_child)

* Fix validate_one_root method

* Fix date format issue

* Fix codacy
- Disable a pylint for variable argument warning
- Convert an instance method to static method

* Add bandit.yml

The Codacy seems to use Bandit which generates
warning for every subprocess import and its usage during pytest
Since we have carefully used subprocess (avoided user input),
warnings needs to be avoided.
This can be removed if we have any alternative for subprocess usage.

* Skip start_process_with_partial_path check

* Fix typo

* Add python 2.7 test

* Move python versions in travis.yml

* Add python versions to jobs

* Overwrite python version inheritance for postgres in travis.yml

* Add quotes around python version in .travis.yml

* Add quotes around the name of the job

* Try a travis fix

* Try .travis.yml fix

* Import missing subprocess

* Refactor travis.yml

* Refactor travis.yml
- move install and tests commands to separate files
- Use matrix to build combination of python version and db type

* Make install.sh and run-tests.sh executable

* Add sudo required to travis.yml to allow sudo cmmands in shell files

* Load nvm

* Remove verbose flag from scripts

* Remove command-trace-print flag

* Change to build dir in before script

* Add absolute path for scripts

* Fix tests

* Fix typo

* Fix codacy
- fixes - "echo won't expand escape sequences." warning

* Append (_) underscore instead of 'd' for db_name

* Remove printf and use mysql execute flag
2018-09-21 10:20:48 +05:30
Faris Ansari
09735e9f3e Query Report: deprecated query_report_filters_by_name (#5834)
* QueryReport

- Remove set_filters_by_name
- Remove save_user_settings
- Only print visible columns

* Query Report

- Deprecate frappe.query_report_filters_by_name
- New API: get_filter_value and set_filter_value
in frappe.query_report object
- Replace instances of old API with new API

* Undo changes in query_report.py
2018-07-18 09:28:36 +05:30
shriharishastry
0a7a4988b1 added checks for if no data present 2018-06-29 15:47:20 +05:30
shriharishastry
73c38eabb2 default report for prepared 2018-06-28 19:27:35 +05:30
shriharishastry
b5e363c6c6 changes on cleaning colmn headers 2018-06-28 17:30:48 +05:30
shriharishastry
47c93b4eb1 merge issues resolved 2018-06-28 16:55:31 +05:30
shriharishastry
41f1e05a6f added check not trigger run if prepared 2018-06-28 16:47:42 +05:30
Prateeksha Singh
c2714903fe [init] add show report in prepared report 2018-06-28 15:25:48 +05:30
shriharishastry
93a2cf7a3c report changes 2018-06-26 23:25:59 +05:30
shriharishastry
fc222b7173 frappe csv utils usage 2018-06-26 23:10:06 +05:30
shriharishastry
bc7d4a73e6 removed check 2018-06-26 20:04:23 +05:30
shriharishastry
0c25bb5088 merge issues 2018-06-26 14:56:33 +05:30
shriharishastry
0e6748ac85 prepared report 2018-06-26 12:34:02 +05:30
shriharishastry
269fa44095 changes on fields and test copy 2018-06-18 15:26:09 +05:30
Suraj Shetty
a93bc87363 Permission fixes (#5530)
* Add User Permissions to Config module

* Update Permission Manager help

* Fix share button

* Remove user-permissions page

* Remove unnecessary error modals

* User Permission UI fixes
- Fix double multicheck bug on save
- Add margin above and below select all button

* Update user_permissions dict realtime on client side

- Remove user_permissions from boot

* Cast permission dict values to int
2018-05-04 19:49:11 +05:30
Charles-Henri Decultot
17855fad80 Transaction Log Report (#5207)
* Transaction Log Report

* Error correction
2018-03-19 18:25:57 +05:30
Aditya Hase
774c5fd2c6 Replaced mixed usage of tabs and spaces for indents with tabs only (#3828) 2017-08-01 11:53:58 +05:30
Rushabh Mehta
d12adda22f [minor] move todo report to correct module, desk 2017-06-22 18:21:48 +05:30
Faris Ansari
e1b243996a Added files in .eslintignore, updated globals 2017-06-02 15:00:15 +05:30
Rohit Waghchaure
b63f4400f4 added roles in the report 2017-03-06 14:42:14 +05:30
mbauskar
a29423bae2 [minor] feedback ratings document type filters 2017-02-27 10:54:16 +05:30
Makarand Bauskar
99d97530b1 [enhancement] Feedback Feature (#2683) 2017-02-09 11:30:54 +05:30
Rohit Waghchaure
82ac63e5ac [Fix] Total row not working in the report for the report builder type 2016-12-06 16:05:26 +05:30
Rushabh Mehta
303e7460c2 [feature] [wip] added Auto Email Report 2016-09-01 17:52:33 +05:30
RobertSchouten
02353e882b Update permitted_documents_for_user.py 2016-06-07 16:18:47 +08:00
RobertSchouten
cc8c5625ce Update permitted_documents_for_user.js 2016-06-07 16:16:09 +08:00
Rushabh Mehta
74919b99a0 [enhancement] remember list settings - sort, filters, paging 2016-05-30 18:19:47 +05:30
Rushabh Mehta
eb399f74bd [enhancement] desktop icons, completed modules setup and test cases 2016-03-16 11:17:29 +05:30
Anand Doshi
2995f02f3b Web Notes to Frappe, better alerts, css fixes, fixed splash 2015-03-03 15:09:34 +05:30
Nabin Hait
508c4fc64b Fixed Conflict while merging v4 to v5 2015-02-10 17:20:39 +05:30
Anand Doshi
d94a452b26 [fix] permitted documents for user - enclose fieldnames in '`' 2015-02-06 12:11:10 +05:30
Rushabh Mehta
756af9af97 [share] completes #992 2015-02-05 17:26:23 +05:30
Rushabh Mehta
456621b931 [email] implemented, tested basic in and out 2015-01-21 17:37:58 +05:30
Rushabh Mehta
5a0a9aac66 [refactor] frappe.widgets > frappe.desk 2014-09-29 12:21:12 +05:30
Nabin Hait
6e4849cc88 todo report fixes 2014-08-18 12:11:06 +05:30
Nabin Hait
bf07c86b9d Dont show single doctypes in permitted_documents_for_users_filters 2014-08-04 15:42:13 +05:30
Anand Doshi
bc4b1cefc1 Fixed report: Permitted Documents For User 2014-06-25 18:23:24 +05:30
Anand Doshi
2b2a608bab Apply User Permissions optional in script and query report, option to pass user in has_permission 2014-06-04 17:54:43 +05:30
Pratik Vyas
e5a0ede248 frappe._ to __ 2014-04-15 10:53:16 +05:30
Rushabh Mehta
4f304cfc6a frappe/frappe#478, frappe tests pass, .txt renamed to .json 2014-03-31 17:27:12 +05:30
Anand Doshi
101843e681 Changed creation, modified format #478 2014-03-28 12:46:37 +05:30
Rushabh Mehta
22ee0ef892 frappe/frappe#478 2014-03-28 11:34:59 +05:30
Nabin Hait
4442a1d8dd Fixes in todo report 2014-03-21 11:16:19 +05:30
Nabin Hait
01bb4f2002 Todo report fixed 2014-03-21 11:16:19 +05:30
Rushabh Mehta
f3810ae532 rename Profile to User frappe/frappe#470 2014-03-11 16:14:47 +05:30
Anand Doshi
f27c2260af Set Module in Report 2014-03-07 17:33:28 +05:30
Rushabh Mehta
024ddfcc5b -webnotes +frappe 💥 2014-02-14 14:55:11 +05:30