Commit graph

137 commits

Author SHA1 Message Date
Chinmay D. Pai
8383b9fc3a
fix: clear_sessions should by default include mobile
whenever password was changed, the system only logged out user for the
current device type; which is incorrect.

suppose if the user logs in through mobile and selects "logout all devices"
on password reset on desktop, the system would log the user out of all
desktop instances, leaving the mobile instance active.

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-05-06 14:21:44 +05:30
Rucha Mahabal
27245d14be feat: onboarding wizard with configurable slides 2019-11-21 20:21:13 +05:30
prssanna
fc38664fe7 fix: formatting 2019-10-09 16:22:57 +05:30
prssanna
6a81a9d7a7 fix: remove comments 2019-10-09 16:22:57 +05:30
prssanna
bae5049683 feat(Notifications): Add integrated notifications 2019-10-09 16:22:57 +05:30
Himanshu Warekar
4a70dc99fa fix: check ip restriction before resume 2019-09-19 11:08:07 +05:30
deepeshgarg007
f5a983a70d fix: Remove limits and usage info from frappe 2019-06-30 16:51:05 +05:30
Aditya Hase
71fc4cbd3a fix: Trigger notifications after updating last_login, last_ip fields
Notifications for User doctype based on Value Change in last_ip,
last_login, last_active aren't triggered because of updates performed
through frappe.db.sql. This behavior is fixed by explicitly triggering
notifications.
2019-06-20 11:16:48 +05:30
Rushabh Mehta
6d32946f64 fix(minor): removed debug 2019-05-24 12:08:22 +05:30
Rushabh Mehta
d92606cea9 fix(sessions): handle separate ways of session expiry in postgres and mariadb 2019-05-24 09:09:46 +05:30
Rushabh Mehta
7107f335f2 fix(session): session expiry not querying correctly 2019-05-24 09:08:56 +05:30
Rushabh Mehta
0a14554a15 fix(session): session expiry not querying correctly 2019-05-24 09:08:56 +05:30
Rushabh Mehta
81fa64d4bc refactor(form.js): remove very old API 2019-05-24 09:08:56 +05:30
Suraj Shetty
42b6faabe7 fix: Add quotes 2019-04-07 13:10:10 +05:30
Suraj Shetty
e3d0a84e64 Revert "fix: Update user activity using ORM"
This reverts commit b963868f61.
2019-04-07 12:53:21 +05:30
Suraj Shetty
70e569287c fix: ignore_permissions while updating user activity
- Since all users do not have access to user doctype
2019-04-03 12:50:06 +05:30
Faris Ansari
f853313a5a
fix: Update user activity using ORM (#7183) 2019-04-01 16:16:35 +05:30
Saurabh
b727233948 Merge branch 'staging' into develop 2018-12-13 10:37:25 +05:30
Prateeksha Singh
7b4a4bc5b7 [setup] startup setup dialog if setup not complete 2018-12-11 16:10:02 +05:30
Rushabh Mehta
2e6a202652 Postgres support for Frappe (#5919)
* [start] postgres

* [wip] started refactoring db_schema

* Add psycopg2 to requirements.txt

* Add support for Postgres SQL

- Separate frameworkSQL, database, schema, setup_db file for
mariaDB and postgres
- WIP

* Remove quotes from sql to make it compatible with postgres as well

* Moved some code from db_schema to database.py

* Move code from db_schema to schema.py

Add other required refactoring

* Add schema chages

* Remove redundant code in file

* Add invalid column name exception class to exceptions.py

* Add back tick in query wherever needed and replace ifnull with coalesce

* Update get_column_description code in database.py file

* Remove a print statement

* Add keys to get on_duplicate query

* Add bactick wherever necessary

- Remove db_schema.py file

* Remove DATE_SUB as it is incompatible with postgres

- Fix prepare_filter_condition

* Add backtick and quotes wherever necessary
- Move get_database_size to frappe.db namespace
- fix some left out bugs and errors

* Add code to create key and unique index
- added mysql and posgres in their respective database.py

* Add more bacticks in queries and fix some errors
- Pass keys to on_duplicate_update method
- Replace MONTH with EXTRACT function
- Remove DATEDIFF and CURDATE usage

* Cast state value to int in toggle_two_factor_auth
- since two_factor_auth has the datatype of Int

* Refactor
- Replace Timediff with normal arithmetic operator
- Add MAX_COLUMN_LENGTH
- Remove Redundant code
- Add regexp character constant
- Move create_help_table to database.py
- Add get_full_text_search_condition method
- Inherit MariaDBTable from DBTable

* Replace Database instance with get_db method

* Move db_manager to separate file

* Refactor
- Remove some unwanted code
- Separate alter table code for postgres and mysql
- Replace data_type with column_type in database.py

* Make fulltext search changes in global_search.py

* Add empty string check

* Add root_password to site config

* Create cli command for postgres console

* Move setup of help database to setup_db.py

* Add get_database_list method

* Fix exception handling
- Replace bad_field handler with missing_column handler

* Fix tests and sql queries

* Fix import error

* Fix typo db -> database

* Fix error with make_table in help.py

* Try test for postgres

* Remove pyhton 2.7 version to try postgres travis test

* Add test fixes

* Add db_type to the config of test_site_postgres

* Enable query debug to check the reason for travis fail

* Add backticks to check if the test passes

* Update travis.yml
- Add postgres addon

* Try appending 'd_' to hash for db_name
- since postgres does not support dbname starting with a number

* Try adding db_type for global help to make travis work

* Add print statements to debug travis failure

* Enable transaction and remove debug flag

* Fix help table creation query (postgres)

* Fix import issue

* Add some checks to prevent errors
- Some doctypes used to get called even before they are created

* Try fixes

* Update travis config

* Fix create index for help table

* Remove unused code

* Fix queries and update travis config

* Fix ifnull replace logic (regex)

* Add query fixes and code cleanup

* Fix typo
- get_column_description -> get_table_columns_description

* Fix tests
- Replace double quotes in query with single quote

* Replace psycopg2 with psycopg2-binary to avoid warnings
- http://initd.org/psycopg/docs/install.html#binary-install-from-pypi

* Add multisql api

* Add few multisql queries

* Remove print statements

* Remove get_fulltext_search_condition method and replace with multi query

* Remove text slicing in create user

* Set default for 'values' argument in multisql

* Fix incorrect queries and remove few debug flags
- Fix multisql bug

* Force delete user to fix test
- Fix Import error
- Fix incorrect query

* Fix query builder bug

* Fix bad query

* Fix query (minor)

* Convert boolean text to int since is_private has datatype of int
- Some query changes like removed double quotes
and replace with interpolated string to pass multiple
value pass in one of the query

* Extend database class from an object to support python 2

* Fix query
- Add quotes around value passed to the query for variable comparision

* Try setting host_name for each test site
- To avoid "RemoteDisconnected" error while testing data migration test
- Update travis.yml to add hosts
- Remove unwanted commit in setup_help_database

* Set site hostname to data migration connector (in test file)
- To connect the same site host

* Fix duplicate entry issue
- the problem is in naming series file.
In previous commits I unknowingly changed a part of a series query
due to which series were not getting reset

* Replace few sql queries with orm methods

* Fix codacy

* Fix 'Doctype Sessions not found' issue

* Fix bugs induced during codacy fixes

* Fix Notification Test

- Use ORM instead of raw sql

* Set Date fallback value to 0001-01-01

- 0000-00-00 is invalid date in Postgres
- 0001-01-01 works in both

* Fix date filter method

* Replace double quotes with single quote for literal value

* Remove print statement

* Replace double quotes with single

* Fix tests

- Replace few raw sql with ORM

* Separate query for postgres

- update_fields_to_fetch_query

* Fix tests

- replace locate with strpos for postgres

* Fix tests

- Skip test for datediff
- convert bytes to str in escape method

* Remove TestBot

* Skip fieldname extraction

* Replace docshare raw sql with ORM

* Fix typo

* Fix ancestor query test

* Fix test data migration

* Remove hardcoded hostname

* Add default option and option list for db_type

* Remove frappe.async module

* Remove a debug flag from test

* Fix codacy

* fix import issue

* Convert classmethod to static method

* Convert few instance methods to static methods

* Remove some unused imports

* Fix codacy

- Add exception type
- Replace few instance methods with static methods
- Remove unsued import

* Fix codacy

* Remove unused code

* Remove some unused codes

- Convert some instance methods to static function

* Fix a issue with query modification

* Fix add_index query

* Fix query

* Fix update_auth patch

* Fix a issue with exception handling

* Add try catch to a reload_doc

* Add try-catch to file_manager_hook patch

* import update_gravatar to set_user_gravatar patch

* Undo all the wrong patch fixes

* Fix db_setup code 😪
- previously it was not restoring db from source SQL
which is why few old patched were breaking
(because they were getting different schema structure)

* Fix typo !

* Fix exception(is_missing_column) handling

* Add deleted code
- This code is only used in a erpnext patch.
Can be moved to that patch file

* Fix codacy

* Replace a mariadb specific function in a query used in validate_series

* Remove a debug flag

* Revert changes (rename_parent_and_child)

* Fix validate_one_root method

* Fix date format issue

* Fix codacy
- Disable a pylint for variable argument warning
- Convert an instance method to static method

* Add bandit.yml

The Codacy seems to use Bandit which generates
warning for every subprocess import and its usage during pytest
Since we have carefully used subprocess (avoided user input),
warnings needs to be avoided.
This can be removed if we have any alternative for subprocess usage.

* Skip start_process_with_partial_path check

* Fix typo

* Add python 2.7 test

* Move python versions in travis.yml

* Add python versions to jobs

* Overwrite python version inheritance for postgres in travis.yml

* Add quotes around python version in .travis.yml

* Add quotes around the name of the job

* Try a travis fix

* Try .travis.yml fix

* Import missing subprocess

* Refactor travis.yml

* Refactor travis.yml
- move install and tests commands to separate files
- Use matrix to build combination of python version and db type

* Make install.sh and run-tests.sh executable

* Add sudo required to travis.yml to allow sudo cmmands in shell files

* Load nvm

* Remove verbose flag from scripts

* Remove command-trace-print flag

* Change to build dir in before script

* Add absolute path for scripts

* Fix tests

* Fix typo

* Fix codacy
- fixes - "echo won't expand escape sequences." warning

* Append (_) underscore instead of 'd' for db_name

* Remove printf and use mysql execute flag
2018-09-21 10:20:48 +05:30
Rushabh Mehta
90188a99c5
[feature] add website_redirects hook (#5692) 2018-06-20 12:10:07 +05:30
Rushabh Mehta
c4e1b9e0c1
[enhance] Add condition in transitions and move workflow to server-side (#5399)
* [workflow] move to server side

* [workflow] tests

* [workflow] tests

* [minor] remove print

* [fixes] tests and lint

* [tests] fix typo

* [fix] tests
2018-04-11 00:38:13 -08:00
Rushabh Mehta
385237b98a
[fix] missing toolbar in frappe when setup_wizard has not been officially completed (#5188) 2018-03-13 14:45:17 +05:30
Nabin Hait
7b0a7e029d Fixed merge conflict 2018-03-05 14:46:18 +05:30
Suraj Shetty
afeae4e6c7 global clear cache fix 2018-02-28 11:59:02 +05:30
Achilles Rasquinha
1b5a1a22b6 Fix ip in case None 2018-01-23 18:01:03 +05:30
Achilles Rasquinha
43d1a74c16 Python 3 compatible GeoIP fetch (#4895)
* Python 3 compatible geolite

* Updated Sessions.py
2018-01-23 15:31:18 +05:30
Shreya Shah
acdbb97ba5 Moved feed from Communication to Activity Log (#4435)
* Removed comment_type 'updated'

* New doctype activity log

* Moved feed.py to activity_log

* Updated feed gets stored in activity_log

* Activity page fetches feed from activity_log

* feed match condition change

* modified

* modified hooks.py

* modified sessions.py

* patch added

* naming in patch

* moved login, logout feed to activity_log

* changes in auth.py, hooks.py

* deleted doctype authentication_log and added test cases

* added utils.py in core

* moved some methods from communication.py to utils.py
2017-11-21 15:46:51 +05:30
Manas Solanki
3c7683e6a1 option to logout from all devices while changing password (#4419) 2017-11-10 12:11:22 +05:30
Rushabh Mehta
f0e23a5a6c [refactor] domain and domain settings (#4163)
* [refactor] domain and domain settings

* [fix] test_domain.py

* [fix] patches

* [fix] domain activation after setup

* [fix] tests and lint

* [fix] tests and lint

* [enhance] better prompt naming

* [fix] setup wizard test

* [fix] testing

* [minor] new item in quick entry from form dashboard
2017-10-17 12:29:08 +05:30
Faris Ansari
1f151ee825 [fix] webhooks cache 2017-09-22 17:23:35 +05:30
pratu16x7
70e1158c45 [fix] don't make toolbar while in setup 2017-09-22 03:07:44 +05:30
pratu16x7
7d2c96b2d4 [progress] add is_first_startup flag to show dialog 2017-08-31 14:57:14 +05:30
Rushabh Mehta
6b45f8a988 [minor] send me a copy is sticky, fixes frappe/erpnext#2367 (#3974) 2017-08-23 18:19:20 +05:30
Aditya Hase
16a9bdfd31 Replaced urllib.unquote imports with six.moves.urllib.parse.unquote (#3836) 2017-08-02 17:09:31 +05:30
Aditya Hase
e6bd1e4995 Replaced all instances of 'unicode' with 'six.text_type' (#3825) 2017-08-02 16:57:39 +05:30
Rushabh Mehta
83045eb36c [enhance] handle session expired in a graceful manner (#3022) 2017-04-10 12:44:39 +05:30
Rushabh Mehta
3076b2cc7a [fix] frappe.ready 2017-03-31 16:36:33 +05:30
Nabin Hait
d836d1367f Fixed merge conflict 2017-03-15 11:26:55 +05:30
Rushabh Mehta
9484ea1af3 [fix] clear notifications for user 2017-03-09 18:09:42 +05:30
Rohit Waghchaure
8a2c83918b changed user_roles to roles 2017-03-06 14:42:13 +05:30
Nabin Hait
985f1323ad Fixed merge conflict 2017-01-17 15:50:30 +05:30
mbauskar
c4c7d507a8 [minor] logout feed for activity logs 2017-01-16 15:26:09 +05:30
Nabin Hait
3a2642e3f7 Merge branch 'master' into develop 2017-01-10 18:00:52 +05:30
Rushabh Mehta
c711179fa6 [minor] commit update timestamp in sessions.py 2017-01-10 17:52:15 +05:30
Rushabh Mehta
0618b98c92 [minor] cleanup to comment update and maintenance mode page 2017-01-10 17:50:36 +05:30
Rushabh Mehta
b793f40259 [fix] sessions 2016-12-30 06:06:47 +05:30
Rushabh Mehta
6b637203f9 [minor] remove document_flow.py, use _sidebar.json and fix frappe/erpnext#7300 2016-12-23 09:42:15 +05:30
Rushabh Mehta
89885fe6a9 [fix] changing timezone does not reflect in system settings 2016-11-08 18:15:17 +05:30
Rushabh Mehta
1026a48a97 [refactor] code for integration service scheduled events 2016-10-13 14:59:23 +05:30